24229 2009-02-27 09:35:40 -0800 ImageQt uses SourceOver composition mode unnecessarily 2009-02-27 12:47:20 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned oldest_to_newest 111450 0 manyoso 2009-02-27 09:35:40 -0800 Hi, If an image does not have an alpha channel there is no reason to use SourceOver composition mode. 111451 1 28076 manyoso 2009-02-27 09:36:16 -0800 Created attachment 28076 Don't use SourceOver unnecessarily 111461 2 28076 eric 2009-02-27 10:12:06 -0800 Comment on attachment 28076 Don't use SourceOver unnecessarily Looks good. Also could probably be made x-platform. 111530 3 manyoso 2009-02-27 12:47:20 -0800 Fixed with r41296. 28076 2009-02-27 09:36:16 -0800 2009-02-27 10:12:06 -0800 Don't use SourceOver unnecessarily image_sourceover.patch text/plain 1664 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzFjZTYyMy4uYzVlNDBmNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMi0yNyAgQWRhbSBUcmVhdCAg PGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElmIGFuIGltYWdlIGhhcyBubyBhbHBoYSBjaGFubmVsIHRo ZXJlIGlzIG5vIHJlYXNvbiB0byB1c2UgU291cmNlT3Zlci4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQ YXR0ZXJuKToKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpkcmF3KToKKwogMjAwOS0w Mi0yNyAgWmFjayBSdXNpbiAgPHphY2tAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBO aWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ltYWdlUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZVF0LmNw cAppbmRleCBiOWFmNTdiLi5mNzcyMThiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0ltYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv SW1hZ2VRdC5jcHAKQEAgLTExMSw2ICsxMTEsOCBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVybihH cmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVjdCYgdGlsZVJlY3QsIGNvbnN0CiAg ICAgY3R4dC0+c2F2ZSgpOwogICAgIGN0eHQtPnNldENvbXBvc2l0ZU9wZXJhdGlvbihvcCk7CiAg ICAgUVBhaW50ZXIqIHAgPSBjdHh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKKyAgICBpZiAoIXBpeG1h cC5oYXNBbHBoYSgpICYmIHAtPmNvbXBvc2l0aW9uTW9kZSgpID09IFFQYWludGVyOjpDb21wb3Np dGlvbk1vZGVfU291cmNlT3ZlcikKKyAgICAgICAgcC0+c2V0Q29tcG9zaXRpb25Nb2RlKFFQYWlu dGVyOjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKICAgICBwLT5zZXRCcnVzaE9yaWdpbihwaGFz ZSk7CiAgICAgcC0+ZmlsbFJlY3QoZGVzdFJlY3QsIGIpOwogICAgIGN0eHQtPnJlc3RvcmUoKTsK QEAgLTE0OCw2ICsxNTAsOSBAQCB2b2lkIEJpdG1hcEltYWdlOjpkcmF3KEdyYXBoaWNzQ29udGV4 dCogY3R4dCwgY29uc3QgRmxvYXRSZWN0JiBkc3QsCiAKICAgICBRUGFpbnRlciogcGFpbnRlcihj dHh0LT5wbGF0Zm9ybUNvbnRleHQoKSk7CiAKKyAgICBpZiAoIWltYWdlLT5oYXNBbHBoYSgpICYm IHBhaW50ZXItPmNvbXBvc2l0aW9uTW9kZSgpID09IFFQYWludGVyOjpDb21wb3NpdGlvbk1vZGVf U291cmNlT3ZlcikKKyAgICAgICAgcGFpbnRlci0+c2V0Q29tcG9zaXRpb25Nb2RlKFFQYWludGVy OjpDb21wb3NpdGlvbk1vZGVfU291cmNlKTsKKwogICAgIC8vIFRlc3QgdXNpbmcgZXhhbXBsZSBz aXRlIGF0CiAgICAgLy8gaHR0cDovL3d3dy5tZXllcndlYi5jb20vZXJpYy9jc3MvZWRnZS9jb21w bGV4c3BpcmFsL2RlbW8uaHRtbCAgICAKICAgICBwYWludGVyLT5kcmF3UGl4bWFwKGRzdCwgKmlt YWdlLCBzcmMpOwo=