<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>242242</bug_id>
          
          <creation_ts>2022-07-01 04:53:06 -0700</creation_ts>
          <short_desc>[browserperfdash-benchmark] Fix error logging from server after 251530@main (port to python3)</short_desc>
          <delta_ts>2022-07-01 07:35:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=230098</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>aperez</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1879715</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2022-07-01 04:53:06 -0700</bug_when>
    <thetext>On 251530@main (r295525) the script browserperfdash-runner was ported to python3 and it is working fine.

However, when the browserperfdash server replies with an error (http error code: 400) the script is not longer logging what caused the error (the body of the http reply) on stderr.
Instead it is causing a generic exception that doesn&apos;t give any helpful info for debugging the problem.

Previously (with python2) the script was giving useful info. This seems to be caused because on python3 urllib.request.urlopen always rises when the http error code is not 200.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879716</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2022-07-01 05:03:00 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1989</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879746</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-07-01 07:34:51 -0700</bug_when>
    <thetext>Committed 252040@main (c0299cc3d772): &lt;https://commits.webkit.org/252040@main&gt;

Reviewed commits have been landed. Closing PR #1989 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879747</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-07-01 07:35:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/96290581&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>