24221 2009-02-27 00:52:37 -0800 [GTK] Do not emit load-finished when being disposed 2009-02-27 03:30:58 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned xan.lopez oldest_to_newest 111409 0 xan.lopez 2009-02-27 00:52:37 -0800 webkit_web_view_stop_load() is called from dispose() on WebKitWebView. This eventually calls postProgressFinishedNotification in FrameLoaderClientGtk, which emits load-finished. Add a 'disposing' flag to WebView that we can check here, so we avoid emitting signals on objects on their way to be destroyed. This fixes a bunch of critical warnings when closing a loading WebView. 111410 1 28067 xan.lopez 2009-02-27 00:55:05 -0800 Created attachment 28067 disposing.patch 111412 2 28067 ap 2009-02-27 00:57:56 -0800 Comment on attachment 28067 disposing.patch r=me > + /* > + * We can get a stopLoad() from dispose when the object is being > + * destroyed, don't emit the signal in that case. > + */ We prefer C++-style comments in C++ files. Is this check needed before other g_signal_emit_by_name() calls? 111413 3 xan.lopez 2009-02-27 01:01:11 -0800 (In reply to comment #2) > (From update of attachment 28067 [review]) > r=me > > > + /* > > + * We can get a stopLoad() from dispose when the object is being > > + * destroyed, don't emit the signal in that case. > > + */ > > We prefer C++-style comments in C++ files. OK, was just being consistent with other multi-line comments in the file :) > > Is this check needed before other g_signal_emit_by_name() calls? > Does not seem so, this is the only signal emitted during dispose AFAICT. We generally try to protect only the code paths needed on dispose, otherwise you'd need to protect every single function and signal just in case. 111428 4 jmalonzo 2009-02-27 03:30:58 -0800 Landed in r41284. Thanks! 28067 2009-02-27 00:55:05 -0800 2009-02-27 00:57:56 -0800 disposing.patch disposing.patch text/plain 4278 xan.lopez RnJvbSAxYzk5OTcyNjg1MDk3YWZmMTY4NmUwN2ZjZTgwNTk5ZGRkNDZlMDJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IEZyaSwg MjcgRmViIDIwMDkgMTA6NTQ6MDMgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAyLTI3ICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MjIxCiAgICAgICAgW0dUS10gRG8gbm90IGVtaXQgbG9hZC1maW5pc2hlZCB3aGVuIGJlaW5nIGRp c3Bvc2VkCgogICAgICAgIHdlYmtpdF93ZWJfdmlld19zdG9wX2xvYWQoKSBpcyBjYWxsZWQgZnJv bSBkaXNwb3NlKCkgb24KICAgICAgICBXZWJLaXRXZWJWaWV3LiBUaGlzIGV2ZW50dWFsbHkgY2Fs bHMgcG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24KICAgICAgICBpbiBGcmFtZUxvYWRl ckNsaWVudEd0aywgd2hpY2ggZW1pdHMgbG9hZC1maW5pc2hlZC4gQWRkCiAgICAgICAgYSAnZGlz cG9zaW5nJyBmbGFnIHRvIFdlYlZpZXcgdGhhdCB3ZSBjYW4gY2hlY2sgaGVyZSwgc28KICAgICAg ICB3ZSBhdm9pZCBlbWl0dGluZyBzaWduYWxzIG9uIG9iamVjdHMgb24gdGhlaXIgd2F5IHRvIGJl CiAgICAgICAgZGVzdHJveWVkLiAgVGhpcyBmaXhlcyBhIGJ1bmNoIG9mIGNyaXRpY2FsIHdhcm5p bmdzIHdoZW4KICAgICAgICBjbG9zaW5nIGEgbG9hZGluZyBXZWJWaWV3LgoKICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKICAgICAgICAoV2ViS2l0OjpG cmFtZUxvYWRlckNsaWVudDo6cG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24pOgogICAg ICAgICogd2Via2l0L3dlYmtpdHByaXZhdGUuaDoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcDoKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKysrKysKIFdlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3BwIHwgICAxMCArKysrKysrKy0tCiBXZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmggICAgICAgICAgICAgICAgICB8ICAgIDIgKysKIFdl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwICAgICAgICAgICAgICAgIHwgICAgMiAr KwogNCBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5k ZXggNTRmMmY0MS4uNTJjYjYwZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0wMi0yNyAgWGFu IExvcGV6ICA8eGFuQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjQyMjEKKyAgICAgICAgW0dUS10gRG8gbm90IGVtaXQgbG9hZC1maW5pc2hlZCB3aGVuIGJlaW5n IGRpc3Bvc2VkCisKKyAgICAgICAgd2Via2l0X3dlYl92aWV3X3N0b3BfbG9hZCgpIGlzIGNhbGxl ZCBmcm9tIGRpc3Bvc2UoKSBvbgorICAgICAgICBXZWJLaXRXZWJWaWV3LiBUaGlzIGV2ZW50dWFs bHkgY2FsbHMgcG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24KKyAgICAgICAgaW4gRnJh bWVMb2FkZXJDbGllbnRHdGssIHdoaWNoIGVtaXRzIGxvYWQtZmluaXNoZWQuIEFkZAorICAgICAg ICBhICdkaXNwb3NpbmcnIGZsYWcgdG8gV2ViVmlldyB0aGF0IHdlIGNhbiBjaGVjayBoZXJlLCBz bworICAgICAgICB3ZSBhdm9pZCBlbWl0dGluZyBzaWduYWxzIG9uIG9iamVjdHMgb24gdGhlaXIg d2F5IHRvIGJlCisgICAgICAgIGRlc3Ryb3llZC4gIFRoaXMgZml4ZXMgYSBidW5jaCBvZiBjcml0 aWNhbCB3YXJuaW5ncyB3aGVuCisgICAgICAgIGNsb3NpbmcgYSBsb2FkaW5nIFdlYlZpZXcuCisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50Ojpwb3N0UHJvZ3Jlc3NGaW5pc2hlZE5vdGlm aWNhdGlvbik6CisgICAgICAgICogd2Via2l0L3dlYmtpdHByaXZhdGUuaDoKKyAgICAgICAgKiB3 ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisKIDIwMDktMDItMjYgIFhhbiBMb3BleiAgPHhhbkBn bm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAg Yi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAppbmRl eCBjNGNjODYzLi5kOGU0Yzk2IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcApAQCAtMjQ3LDggKzI0NywxNCBAQCB2b2lkIEZyYW1l TG9hZGVyQ2xpZW50Ojpwb3N0UHJvZ3Jlc3NFc3RpbWF0ZUNoYW5nZWROb3RpZmljYXRpb24oKQog dm9pZCBGcmFtZUxvYWRlckNsaWVudDo6cG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24o KQogewogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBnZXRWaWV3RnJvbUZyYW1lKG1fZnJh bWUpOworICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2YXRlRGF0YSA9IFdFQktJVF9XRUJf VklFV19HRVRfUFJJVkFURSh3ZWJWaWV3KTsKIAotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZSh3 ZWJWaWV3LCAibG9hZC1maW5pc2hlZCIsIG1fZnJhbWUpOworICAgIC8qCisgICAgICogV2UgY2Fu IGdldCBhIHN0b3BMb2FkKCkgZnJvbSBkaXNwb3NlIHdoZW4gdGhlIG9iamVjdCBpcyBiZWluZwor ICAgICAqIGRlc3Ryb3llZCwgZG9uJ3QgZW1pdCB0aGUgc2lnbmFsIGluIHRoYXQgY2FzZS4KKyAg ICAgKi8KKyAgICBpZiAoIXByaXZhdGVEYXRhLT5kaXNwb3NpbmcpCisgICAgICAgIGdfc2lnbmFs X2VtaXRfYnlfbmFtZSh3ZWJWaWV3LCAibG9hZC1maW5pc2hlZCIsIG1fZnJhbWUpOwogfQogCiB2 b2lkIEZyYW1lTG9hZGVyQ2xpZW50OjpmcmFtZUxvYWRlckRlc3Ryb3llZCgpCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXRwcml2YXRlLmgKaW5kZXggNzRmMzg0My4uZjkzZTg0OSAxMDA2NDQKLS0tIGEvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5oCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHByaXZhdGUuaApAQCAtMTAyLDYgKzEwMiw4IEBAIGV4dGVybiAiQyIgewogCiAgICAgICAgIGdi b29sZWFuIHpvb21GdWxsQ29udGVudDsKICAgICAgICAgY2hhciogY3VzdG9tRW5jb2Rpbmc7CisK KyAgICAgICAgZ2Jvb2xlYW4gZGlzcG9zaW5nOwogICAgIH07CiAKICAgICAjZGVmaW5lIFdFQktJ VF9XRUJfRlJBTUVfR0VUX1BSSVZBVEUob2JqKSAgICAoR19UWVBFX0lOU1RBTkNFX0dFVF9QUklW QVRFKChvYmopLCBXRUJLSVRfVFlQRV9XRUJfRlJBTUUsIFdlYktpdFdlYkZyYW1lUHJpdmF0ZSkp CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDZjZDE4YWEuLmU3YTlmMWMgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC04MjQsNiArODI0LDggQEAgc3RhdGlj IHZvaWQgd2Via2l0X3dlYl92aWV3X2Rpc3Bvc2UoR09iamVjdCogb2JqZWN0KQogICAgIFdlYktp dFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcob2JqZWN0KTsKICAgICBXZWJLaXRX ZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CiAKKyAgICBwcml2LT5kaXNwb3Np bmcgPSBUUlVFOworCiAgICAgaWYgKHByaXYtPmNvcmVQYWdlKSB7CiAgICAgICAgIHdlYmtpdF93 ZWJfdmlld19zdG9wX2xvYWRpbmcoV0VCS0lUX1dFQl9WSUVXKG9iamVjdCkpOwogCi0tIAoxLjYu MQoK