<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>242178</bug_id>
          
          <creation_ts>2022-06-30 05:11:01 -0700</creation_ts>
          <short_desc>REGRESSION (250816@main): composite option in Element.animate() is ignored</short_desc>
          <delta_ts>2022-06-30 09:24:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Antoine Quint">graouts</assigned_to>
          <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>gsnedders</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1879323</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-06-30 05:11:01 -0700</bug_when>
    <thetext>We used to guard the `iterationComposite` property with the same runtime flag as the `composite` property. When we introduced a dedicated flag for the iterationComposite property (bug 240727) we mistakenly switched the guard in `KeyframeEffect::create()` which governed both properties from the `composite` guard to the `iterationComposite` guard, instead of adding the two guards, one for each property. As a result, the `composite` property can no longer be set via Element.animate() or the KeyframeEffect constructor.

This was found by WPT.fyi with the recent release of STP 148 which first introduced this change:

https://wpt.fyi/results/web-animations/animation-model/animation-types/accumulation-per-property-001.html?q=seq%28%28status%3Apass%7Cstatus%3Aok%29%20%28status%3Apass%7Cstatus%3Aok%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%20%28status%3A%21pass%26status%3A%21ok%26status%3A%21unknown%29%29&amp;run_id=6308426865967104&amp;run_id=5702899928662016&amp;run_id=5636710942638080&amp;run_id=5070812443836416</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879324</commentid>
    <comment_count>1</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2022-06-30 05:13:47 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1943</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879326</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-30 05:20:25 -0700</bug_when>
    <thetext>&lt;rdar://problem/96211493&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879384</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-30 09:24:22 -0700</bug_when>
    <thetext>Committed 251998@main (4fa06c18977a): &lt;https://commits.webkit.org/251998@main&gt;

Reviewed commits have been landed. Closing PR #1943 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>