24215 2009-02-26 16:52:22 -0800 Sites using gears broken in r41209, by display:none on <object> (24215) 2011-11-03 10:20:29 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mpComplete webkit-unassigned mrowe playmobil shadow2531 simon.fraser stefmanevski zwarich oldest_to_newest 111353 0 mpComplete 2009-02-26 16:52:22 -0800 This change (http://trac.webkit.org/changeset/41209) breaks sites using Gears. Such sites have a snippet of javascript that loads gears by appending an object tag into the page, with display set to "none". Now that that behavior has changed, object tags with "display=none" don't load the corresponding NPAPI plugins, and Gears no longer works. It would be nice to have a workaround for Gears until sites have time to change. 111356 1 mpComplete 2009-02-26 17:04:31 -0800 Alternatively, if the plugin were still loaded, but just not displayed, that would work for gears as well. 111358 2 simon.fraser 2009-02-26 17:06:12 -0800 Fixing display:none to work for <object> was bug 15081. 111362 3 ggaren 2009-02-26 17:15:23 -0800 visibility:hidden is the "right" way to hide gears in CSS, while still asking it to load. Do we know where these Gears sites get their code snippets from? Maybe we should evangelize the source of the snippets. 111363 4 ggaren 2009-02-26 17:15:56 -0800 Also, can you list some example sites? 111367 5 mpComplete 2009-02-26 17:37:05 -0800 The sites get their snippets from http://code.google.com/apis/gears/tools.html#gears_init . We can update this source, but will also have to get sites to update their copies. Some gears-using sites that I'm aware of: - http://mail.google.com - http://docs.google.com - http://rememberthemilk.com - http://zoho.com - http://www.passpack.com - http://www.mindmeister.com There's probably only a handful or two of others. 111368 6 eric 2009-02-26 17:47:43 -0800 Google Latitude also uses Gears, although maybe that doesn't require the plugin to load on the page. 111564 7 mpComplete 2009-02-27 15:06:26 -0800 We now have a workaround for Chrome so that Gears will still work. I'm not sure how easy a similar workaround for Safari would be. 111567 8 ggaren 2009-02-27 15:57:10 -0800 Would you be willing to explain what the work-around is? 111573 9 ggaren 2009-02-27 16:10:13 -0800 <rdar://problem/6633049> 111575 10 mpComplete 2009-02-27 16:15:59 -0800 I'll post a link when I check in the change, but the basic idea is that we run a snippet of javascript on each page which adds a javascript getter (using __defineGetter__) where the gears object is expected. The first time a page accesses this getter, the gears object is injected in a manner similar to how gears_init.js does it (except without setting display="none"). 111577 11 ggaren 2009-02-27 16:21:38 -0800 I don't think there's anything about that solution that can't be written in WebKit. Is there a particular reason that you chose to patch Chrome instead of WebKit? Another good solution for WebKit, if you're interested in improving WebKit, is to detect a type attribute of "application/x-googlegears" on an object element, in HTMLObjectElement::rendererIsNeeded, and apply special behavior based on that, to return true despite a display:none style. 111589 12 mpComplete 2009-02-27 17:28:03 -0800 The feeling on the Gears team is that this "workaround" for Chrome is a better way of loading Gears into pages, since it doesn't rely on gears_init.js scripts in the wild. We're hoping to find a similar method for Safari. If that's not possible in the short term, we can add a temporary special-case to webkit. For those interested, the Chrome change is here: http://src.chromium.org/viewvc/chrome?view=rev&revision=10663 111692 13 28142 playmobil 2009-03-01 06:14:29 -0800 Created attachment 28142 Special case gears object tag Per comment #11, this patch checks the type attribute and instantiates the plugin in the case of display:none and Gears. Is there a good way to test this? 112055 14 mpComplete 2009-03-03 11:47:14 -0800 Here's what the Gears team would like to happen: - Commit temporary special-case fix to webkit (see Jeremy's patch). (Though we'd need to test that it works in Safari first!) - Gears team works on a solution (in gears itself) so that we no longer rely on gears_init.js at all. - Remove the temporary special-case in webkit. How does that sound? 112066 15 playmobil 2009-03-03 12:59:16 -0800 I've verified that the attached patch fixes the issue in Safari. 112069 16 simon.fraser 2009-03-03 13:14:20 -0800 I'm ok with the patch as long as you file a follow-up bug to remove the hack once Gears is fixed, and the comment in the code refers to that bug. 112169 17 28260 playmobil 2009-03-04 02:07:13 -0800 Created attachment 28260 Updated patch Per Simon's comment, point to a followup bug for removing the temporary fix. 112205 18 simon.fraser 2009-03-04 09:07:57 -0800 Wait, bug 24356 does not exist. Please fix the bug number in the comment. 112238 19 28275 mpComplete 2009-03-04 11:02:39 -0800 Created attachment 28275 above patch with correct bug number I just fixed the above patch with the correct bug number (bug 24346). 112521 20 mrowe 2009-03-05 20:35:27 -0800 *** Bug 24383 has been marked as a duplicate of this bug. *** 112525 21 28275 fishd 2009-03-05 21:16:22 -0800 Comment on attachment 28275 above patch with correct bug number Landed as http://trac.webkit.org/changeset/41473 113201 22 pam 2009-03-11 11:03:33 -0700 Landed, so closing. 28142 2009-03-01 06:14:29 -0800 2009-03-04 02:07:13 -0800 Special case gears object tag gears_fix.patch text/plain 1816 playmobil Y29tbWl0IGI2NGFiMjI3ZTUzNzZjZDVhYzNmZGYzZTFmMjk4OWNjMjEwNWMzMWQKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIFN1biBNYXIgMSAx NjoxMDoyMiAyMDA5ICswMjAwCgogICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQyMTUKICAgIAogICAgR2VhcnMgZXhwZWN0cyBhbiBvYmplY3QgdGFn IHdpdGggZGlzcGxheTpub25lIHRvIGluc3RhbnRpYXRlIHRoZSBwbHVnaW4sIHNvIHdlIGFkZCBh IHdvcmthcm91bmQgdG8gbWFrZSB0aGlzIHdvcmsgYW5kIGZpeCBHZWFycyBvbiBXZWJLaXQgdHJ1 bmsuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBhNDM1MGUwLi5hOWE2ZWVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTAzLTAxICBKZXJlbXkg TW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNDIxNQorCisgICAgICAgIEdlYXJzIGV4cGVjdHMgYW4gb2JqZWN0 IHRhZyB3aXRoIGRpc3BsYXk6bm9uZSB0byBpbnN0YW50aWF0ZSB0aGUgcGx1Z2luLAorICAgICAg ICBzbyB3ZSBhZGQgYSB3b3JrYXJvdW5kIHRvIG1ha2UgdGhpcyB3b3JrIGFuZCBmaXggR2VhcnMg b24gV2ViS2l0IHRydW5rLgorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZCk6 CisKIDIwMDktMDItMjggIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVt ZW50LmNwcAppbmRleCA4OTljNTI3Li4xM2NjYzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTE9iamVjdEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVu dC5jcHAKQEAgLTEyMyw3ICsxMjMsMTEgQEAgYm9vbCBIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIAotICAgIHJldHVybiBIVE1MUGx1Z0luRWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChzdHlsZSk7CisgICAgLy8gV29ya2Fyb3VuZCBmb3IgR2VhcnMgcGx1Z2luIC0g c2VlIGJ1ZyAyNDIxNQorICAgIC8vIEdlYXJzIGV4cGVjdHMgdGhlIHBsdWdpbiB0byBiZSBpbnN0 YW50aWF0ZWQgZXZlbiBpZiBkaXNwbGF5Om5vbmUgaXMgc2V0CisgICAgLy8gZm9yIHRoZSBvYmpl Y3QgZWxlbWVudC4KKyAgICBib29sIGlzR2VhcnNQbHVnaW4gPSBlcXVhbElnbm9yaW5nQ2FzZShn ZXRBdHRyaWJ1dGUodHlwZUF0dHIpLCAiYXBwbGljYXRpb24veC1nb29nbGVnZWFycyIpOworICAg IHJldHVybiBpc0dlYXJzUGx1Z2luIHx8IEhUTUxQbHVnSW5FbGVtZW50OjpyZW5kZXJlcklzTmVl ZGVkKHN0eWxlKTsKIH0KIAogUmVuZGVyT2JqZWN0ICpIVE1MT2JqZWN0RWxlbWVudDo6Y3JlYXRl UmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSogc3R5bGUpCg== 28260 2009-03-04 02:07:13 -0800 2009-03-04 11:02:39 -0800 Updated patch gears_fix.patch text/plain 1870 playmobil Y29tbWl0IGI2NGFiMjI3ZTUzNzZjZDVhYzNmZGYzZTFmMjk4OWNjMjEwNWMzMWQKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIFN1biBNYXIgMSAx NjoxMDoyMiAyMDA5ICswMjAwCgogICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQyMTUKICAgIAogICAgR2VhcnMgZXhwZWN0cyBhbiBvYmplY3QgdGFn IHdpdGggZGlzcGxheTpub25lIHRvIGluc3RhbnRpYXRlIHRoZSBwbHVnaW4sIHNvIHdlIGFkZCBh IHdvcmthcm91bmQgdG8gbWFrZSB0aGlzIHdvcmsgYW5kIGZpeCBHZWFycyBvbiBXZWJLaXQgdHJ1 bmsuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBhNDM1MGUwLi5hOWE2ZWVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTAzLTAxICBKZXJlbXkg TW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNDIxNQorCisgICAgICAgIEdlYXJzIGV4cGVjdHMgYW4gb2JqZWN0 IHRhZyB3aXRoIGRpc3BsYXk6bm9uZSB0byBpbnN0YW50aWF0ZSB0aGUgcGx1Z2luLAorICAgICAg ICBzbyB3ZSBhZGQgYSB3b3JrYXJvdW5kIHRvIG1ha2UgdGhpcyB3b3JrIGFuZCBmaXggR2VhcnMg b24gV2ViS2l0IHRydW5rLgorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZCk6 CisKIDIwMDktMDItMjggIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVt ZW50LmNwcAppbmRleCA4OTljNTI3Li4xM2NjYzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTE9iamVjdEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVu dC5jcHAKQEAgLTEyMyw3ICsxMjMsMTEgQEAgYm9vbCBIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIAotICAgIHJldHVybiBIVE1MUGx1Z0luRWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChzdHlsZSk7CisgICAgLy8gVGVtcG9yYXJ5IFdvcmthcm91bmQgZm9yIEdlYXJz IHBsdWdpbiAtIHNlZSBidWcgMjQyMTUgZm9yIGRldGFpbHMgYW5kIGJ1ZyAyNDM1NiB0byB0cmFj ayByZW1vdmFsLgorICAgIC8vIEdlYXJzIGV4cGVjdHMgdGhlIHBsdWdpbiB0byBiZSBpbnN0YW50 aWF0ZWQgZXZlbiBpZiBkaXNwbGF5Om5vbmUgaXMgc2V0CisgICAgLy8gZm9yIHRoZSBvYmplY3Qg ZWxlbWVudC4KKyAgICBib29sIGlzR2VhcnNQbHVnaW4gPSBlcXVhbElnbm9yaW5nQ2FzZShnZXRB dHRyaWJ1dGUodHlwZUF0dHIpLCAiYXBwbGljYXRpb24veC1nb29nbGVnZWFycyIpOworICAgIHJl dHVybiBpc0dlYXJzUGx1Z2luIHx8IEhUTUxQbHVnSW5FbGVtZW50OjpyZW5kZXJlcklzTmVlZGVk KHN0eWxlKTsKIH0KIAogUmVuZGVyT2JqZWN0ICpIVE1MT2JqZWN0RWxlbWVudDo6Y3JlYXRlUmVu ZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSogc3R5bGUpCg== 28275 2009-03-04 11:02:39 -0800 2009-03-04 11:52:28 -0800 above patch with correct bug number gears_fix.patch text/plain 1870 mpComplete Y29tbWl0IGI2NGFiMjI3ZTUzNzZjZDVhYzNmZGYzZTFmMjk4OWNjMjEwNWMzMWQKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIFN1biBNYXIgMSAx NjoxMDoyMiAyMDA5ICswMjAwCgogICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQyMTUKICAgIAogICAgR2VhcnMgZXhwZWN0cyBhbiBvYmplY3QgdGFn IHdpdGggZGlzcGxheTpub25lIHRvIGluc3RhbnRpYXRlIHRoZSBwbHVnaW4sIHNvIHdlIGFkZCBh IHdvcmthcm91bmQgdG8gbWFrZSB0aGlzIHdvcmsgYW5kIGZpeCBHZWFycyBvbiBXZWJLaXQgdHJ1 bmsuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBhNDM1MGUwLi5hOWE2ZWVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTAzLTAxICBKZXJlbXkg TW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNDIxNQorCisgICAgICAgIEdlYXJzIGV4cGVjdHMgYW4gb2JqZWN0 IHRhZyB3aXRoIGRpc3BsYXk6bm9uZSB0byBpbnN0YW50aWF0ZSB0aGUgcGx1Z2luLAorICAgICAg ICBzbyB3ZSBhZGQgYSB3b3JrYXJvdW5kIHRvIG1ha2UgdGhpcyB3b3JrIGFuZCBmaXggR2VhcnMg b24gV2ViS2l0IHRydW5rLgorCisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZCk6 CisKIDIwMDktMDItMjggIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2h0bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVt ZW50LmNwcAppbmRleCA4OTljNTI3Li4xM2NjYzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTE9iamVjdEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVu dC5jcHAKQEAgLTEyMyw3ICsxMjMsMTEgQEAgYm9vbCBIVE1MT2JqZWN0RWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgIAotICAgIHJldHVybiBIVE1MUGx1Z0luRWxlbWVudDo6cmVuZGVy ZXJJc05lZWRlZChzdHlsZSk7CisgICAgLy8gVGVtcG9yYXJ5IFdvcmthcm91bmQgZm9yIEdlYXJz IHBsdWdpbiAtIHNlZSBidWcgMjQyMTUgZm9yIGRldGFpbHMgYW5kIGJ1ZyAyNDM0NiB0byB0cmFj ayByZW1vdmFsLgorICAgIC8vIEdlYXJzIGV4cGVjdHMgdGhlIHBsdWdpbiB0byBiZSBpbnN0YW50 aWF0ZWQgZXZlbiBpZiBkaXNwbGF5Om5vbmUgaXMgc2V0CisgICAgLy8gZm9yIHRoZSBvYmplY3Qg ZWxlbWVudC4KKyAgICBib29sIGlzR2VhcnNQbHVnaW4gPSBlcXVhbElnbm9yaW5nQ2FzZShnZXRB dHRyaWJ1dGUodHlwZUF0dHIpLCAiYXBwbGljYXRpb24veC1nb29nbGVnZWFycyIpOworICAgIHJl dHVybiBpc0dlYXJzUGx1Z2luIHx8IEhUTUxQbHVnSW5FbGVtZW50OjpyZW5kZXJlcklzTmVlZGVk KHN0eWxlKTsKIH0KIAogUmVuZGVyT2JqZWN0ICpIVE1MT2JqZWN0RWxlbWVudDo6Y3JlYXRlUmVu ZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSogc3R5bGUpCg==