24202 2009-02-26 10:18:25 -0800 drawNodeHighlight assumes the highlight is drawn in it's own buffer 2009-02-26 10:59:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan oldest_to_newest 111213 0 ojan 2009-02-26 10:18:25 -0800 It first clears the relevant quad and then fills the rect. This won't work for Chromium since we would like to draw the highlight in the same buffer as the page. Instead, we can clip the nested quad from the quad being drawn (e.g. clip the borderQuad from the marginQuad before drawing it). This works for Chromium and Safari as best I can tell. 111214 1 28021 ojan 2009-02-26 10:19:54 -0800 Created attachment 28021 Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page. WebCore/ChangeLog | 16 ++++++++++++ WebCore/inspector/InspectorController.cpp | 38 ++++++++++++++++------------ 2 files changed, 38 insertions(+), 16 deletions(-) 111220 2 28021 aroben 2009-02-26 10:36:05 -0800 Comment on attachment 28021 Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page. > + WARNING: NO TEST CASES ADDED OR CHANGED You should remove this line from your ChangeLog, perhaps replacing it with an explanation (e.g., that there's no change in behavior and it's covered by existing manual Inspector tests). r=me 111221 3 dglazkov 2009-02-26 10:41:14 -0800 Has this landed yet? 111230 4 dglazkov 2009-02-26 10:59:38 -0800 Landed as http://trac.webkit.org/changeset/41258. 28021 2009-02-26 10:19:54 -0800 2009-02-26 10:36:05 -0800 Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page. i-and-Chromium-since-Chromium-draws-the-inspector-highlighting-in-the-same-buffer-as-the-page..patch text/plain 3715 ojan NDMwZDhkNjYxY2YzNzI5N2IxNzZhOWU0ZTAxNWJjYjQ1MDgxOWVhZgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYzE1YWZkLi5mNDcwN2Fh IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDA5LTAyLTI2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2 ZSBkcmF3Tm9kZUhpZ2hsaWdodCBjbGlwIGluc3RlYWQgb2YgY2xlYXJpbmcuIFRoaXMgbWFrZXMg aXQgd29yayBmb3IKKyAgICAgICAgYm90aCBTYWZhcmkgYW5kIENocm9taXVtIHNpbmNlIENocm9t aXVtIGRyYXdzIHRoZSBpbnNwZWN0b3IgaGlnaGxpZ2h0aW5nCisgICAgICAgIGluIHRoZSBzYW1l IGJ1ZmZlciBhcyB0aGUgcGFnZS4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFE REVEIE9SIENIQU5HRUQKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnF1YWRUb1BhdGgpOgorICAgICAgICAoV2ViQ29yZTo6 ZHJhd091dGxpbmVkUXVhZCk6CisgICAgICAgIChXZWJDb3JlOjpkcmF3T3V0bGluZWRRdWFkV2l0 aENsaXApOgorICAgICAgICAoV2ViQ29yZTo6ZHJhd0hpZ2hsaWdodEZvckJveCk6CisKIDIwMDkt MDItMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxl ci5jcHAKaW5kZXggOTExNDY1ZC4uOTljYTdmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAKQEAgLTI4NTUsMjYgKzI4NTUsMjMgQEAgdm9pZCBJbnNwZWN0b3JD b250cm9sbGVyOjpyZW1vdmVCcmVha3BvaW50KGludHB0cl90IHNvdXJjZUlELCB1bnNpZ25lZCBs aW5lTnVtYmUKIH0KICNlbmRpZgogCi1zdGF0aWMgdm9pZCBkcmF3T3V0bGluZWRRdWFkKEdyYXBo aWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRRdWFkJiBxdWFkLCBjb25zdCBDb2xvciYg ZmlsbENvbG9yKQorc3RhdGljIFBhdGggcXVhZFRvUGF0aChjb25zdCBGbG9hdFF1YWQmIHF1YWQp CiB7Ci0gICAgc3RhdGljIGNvbnN0IGludCBvdXRsaW5lVGhpY2tuZXNzID0gMjsKLSAgICBzdGF0 aWMgY29uc3QgQ29sb3Igb3V0bGluZUNvbG9yKDYyLCA4NiwgMTgwLCAyMjgpOwotCiAgICAgUGF0 aCBxdWFkUGF0aDsKICAgICBxdWFkUGF0aC5tb3ZlVG8ocXVhZC5wMSgpKTsKICAgICBxdWFkUGF0 aC5hZGRMaW5lVG8ocXVhZC5wMigpKTsKICAgICBxdWFkUGF0aC5hZGRMaW5lVG8ocXVhZC5wMygp KTsKICAgICBxdWFkUGF0aC5hZGRMaW5lVG8ocXVhZC5wNCgpKTsKICAgICBxdWFkUGF0aC5jbG9z ZVN1YnBhdGgoKTsKLSAgICAKLSAgICAvLyBDbGVhciB0aGUgcXVhZAotICAgIHsKLSAgICAgICAg Y29udGV4dC5zYXZlKCk7Ci0gICAgICAgIGNvbnRleHQuc2V0Q29tcG9zaXRlT3BlcmF0aW9uKENv bXBvc2l0ZUNsZWFyKTsKLSAgICAgICAgY29udGV4dC5hZGRQYXRoKHF1YWRQYXRoKTsKLSAgICAg ICAgY29udGV4dC5maWxsUGF0aCgpOwotICAgICAgICBjb250ZXh0LnJlc3RvcmUoKTsKLSAgICB9 CisgICAgcmV0dXJuIHF1YWRQYXRoOworfQorCitzdGF0aWMgdm9pZCBkcmF3T3V0bGluZWRRdWFk KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgRmxvYXRRdWFkJiBxdWFkLCBjb25zdCBD b2xvciYgZmlsbENvbG9yKQoreworICAgIHN0YXRpYyBjb25zdCBpbnQgb3V0bGluZVRoaWNrbmVz cyA9IDI7CisgICAgc3RhdGljIGNvbnN0IENvbG9yIG91dGxpbmVDb2xvcig2MiwgODYsIDE4MCwg MjI4KTsKKworICAgIFBhdGggcXVhZFBhdGggPSBxdWFkVG9QYXRoKHF1YWQpOwogCiAgICAgLy8g Q2xpcCBvdXQgdGhlIHF1YWQsIHRoZW4gZHJhdyB3aXRoIGEgMnB4IHN0cm9rZSB0byBnZXQgYSBw aXhlbAogICAgIC8vIG9mIG91dGxpbmUgKGJlY2F1c2UgaW5mbGF0aW5nIGEgcXVhZCBpcyBoYXJk KQpAQCAtMjg5Nyw2ICsyODk0LDE1IEBAIHN0YXRpYyB2b2lkIGRyYXdPdXRsaW5lZFF1YWQoR3Jh cGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9hdFF1YWQmIHF1YWQsIGNvCiAgICAgY29u dGV4dC5maWxsUGF0aCgpOwogfQogCitzdGF0aWMgdm9pZCBkcmF3T3V0bGluZWRRdWFkV2l0aENs aXAoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9hdFF1YWQmIHF1YWQsIGNvbnN0 IEZsb2F0UXVhZCYgY2xpcFF1YWQsIGNvbnN0IENvbG9yJiBmaWxsQ29sb3IpCit7CisgICAgY29u dGV4dC5zYXZlKCk7CisgICAgUGF0aCBjbGlwUXVhZFBhdGggPSBxdWFkVG9QYXRoKGNsaXBRdWFk KTsKKyAgICBjb250ZXh0LmNsaXBPdXQoY2xpcFF1YWRQYXRoKTsKKyAgICBkcmF3T3V0bGluZWRR dWFkKGNvbnRleHQsIHF1YWQsIGZpbGxDb2xvcik7CisgICAgY29udGV4dC5yZXN0b3JlKCk7Cit9 CisKIHN0YXRpYyB2b2lkIGRyYXdIaWdobGlnaHRGb3JCb3goR3JhcGhpY3NDb250ZXh0JiBjb250 ZXh0LCBjb25zdCBGbG9hdFF1YWQmIGNvbnRlbnRRdWFkLCBjb25zdCBGbG9hdFF1YWQmIHBhZGRp bmdRdWFkLCBjb25zdCBGbG9hdFF1YWQmIGJvcmRlclF1YWQsIGNvbnN0IEZsb2F0UXVhZCYgbWFy Z2luUXVhZCkKIHsKICAgICBzdGF0aWMgY29uc3QgQ29sb3IgY29udGVudEJveENvbG9yKDEyNSwg MTczLCAyMTcsIDEyOCk7CkBAIC0yOTA1LDExICsyOTExLDExIEBAIHN0YXRpYyB2b2lkIGRyYXdI aWdobGlnaHRGb3JCb3goR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBGbG9hdFF1YWQm IGNvbnRlCiAgICAgc3RhdGljIGNvbnN0IENvbG9yIG1hcmdpbkJveENvbG9yKDEyNSwgMTczLCAy MTcsIDIyOCk7CiAKICAgICBpZiAobWFyZ2luUXVhZCAhPSBib3JkZXJRdWFkKQotICAgICAgICBk cmF3T3V0bGluZWRRdWFkKGNvbnRleHQsIG1hcmdpblF1YWQsIG1hcmdpbkJveENvbG9yKTsKKyAg ICAgICAgZHJhd091dGxpbmVkUXVhZFdpdGhDbGlwKGNvbnRleHQsIG1hcmdpblF1YWQsIGJvcmRl clF1YWQsIG1hcmdpbkJveENvbG9yKTsKICAgICBpZiAoYm9yZGVyUXVhZCAhPSBwYWRkaW5nUXVh ZCkKLSAgICAgICAgZHJhd091dGxpbmVkUXVhZChjb250ZXh0LCBib3JkZXJRdWFkLCBib3JkZXJC b3hDb2xvcik7CisgICAgICAgIGRyYXdPdXRsaW5lZFF1YWRXaXRoQ2xpcChjb250ZXh0LCBib3Jk ZXJRdWFkLCBwYWRkaW5nUXVhZCwgYm9yZGVyQm94Q29sb3IpOwogICAgIGlmIChwYWRkaW5nUXVh ZCAhPSBjb250ZW50UXVhZCkKLSAgICAgICAgZHJhd091dGxpbmVkUXVhZChjb250ZXh0LCBwYWRk aW5nUXVhZCwgcGFkZGluZ0JveENvbG9yKTsKKyAgICAgICAgZHJhd091dGxpbmVkUXVhZFdpdGhD bGlwKGNvbnRleHQsIHBhZGRpbmdRdWFkLCBjb250ZW50UXVhZCwgcGFkZGluZ0JveENvbG9yKTsK IAogICAgIGRyYXdPdXRsaW5lZFF1YWQoY29udGV4dCwgY29udGVudFF1YWQsIGNvbnRlbnRCb3hD b2xvcik7CiB9Cg==