<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24197</bug_id>
          
          <creation_ts>2009-02-26 04:59:37 -0800</creation_ts>
          <short_desc>ColorCG.cpp: Windows version of cgColor() is ifdefed on !PLATFORM(MAC) which is true for Chrome on OS X</short_desc>
          <delta_ts>2009-03-02 21:42:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Moskovich">playmobil</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>111161</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Moskovich">playmobil</who>
    <bug_when>2009-02-26 04:59:37 -0800</bug_when>
    <thetext>PLATFORM(MAC) isn&apos;t defined for Chrome, so on OS X we&apos;re picking up the Windows version of cgColor() from ColorCG.cpp rather than the Mac version from ColorMac.mm.

The define needs to be changed to either use !PLATFORM(DARWIN) or PLATFORM(WIN) so Chrome on OS X doesn&apos;t pick up the Windows version.

https://bugs.webkit.org/show_bug.cgi?id=23512 also bears mentioning in this context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111792</commentid>
    <comment_count>1</comment_count>
    <who name="Jeremy Moskovich">playmobil</who>
    <bug_when>2009-03-02 00:42:02 -0800</bug_when>
    <thetext>Fixed in r41345</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111965</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Mentovai">mark</who>
    <bug_when>2009-03-02 21:42:46 -0800</bug_when>
    <thetext>Jeremy, why did we want cgColor ColorMac.mm for mcChrome instead of ColorCG.cpp?  I just helped Pam out with this for the merge (she&apos;ll probably contact you separately about focusRingColor), but I don&apos;t understand why you wanted this change, it seems like it&apos;s going in the wrong direction.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>