24193 2009-02-26 01:39:25 -0800 [GTK] Checkbuttons not activated with space 2009-03-01 13:41:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned a.renevier oldest_to_newest 111151 0 xan.lopez 2009-02-26 01:39:25 -0800 Checkbuttons are not activated with space. The reason is that the IM code eats the event, then tries to reintroduce it, and fails when it sees that a checkbutton is not editable. I think the proper fix is simply to not have IM eat events when the focus is on non-editable frames (is frame the right terminology here?). And no, this does not fix https://bugs.webkit.org/show_bug.cgi?id=18363 :) 111152 1 28010 xan.lopez 2009-02-26 01:45:43 -0800 Created attachment 28010 imevent.patch commit 1f23190066d5e8740a0e6ab9b26a944a270d4fc5 Author: Xan Lopez <xan@gnome.org> Date: Thu Feb 26 11:44:29 2009 +0200 2009-02-26 Xan Lopez <xan@gnome.org> Reviewed by NOBODY (OOPS!). https://bugs.webkit.org/show_bug.cgi?id=24193 [GTK] Checkbuttons not activated with space Do not swallow key events with GtkIMContext for non-editable frames (FIXME: I don't think frame is the right name here). * WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleInputMethodKeydown): 111162 2 28010 ap 2009-02-26 05:19:06 -0800 Comment on attachment 28010 imevent.patch > Do not swallow key events with GtkIMContext for non-editable > frames (FIXME: I don't think frame is the right name here). That's non-editable content. > + if (!targetFrame || !targetFrame->editor()->canEdit()) > + return; Can targetFrame really be null here? It's not obvious to me that no input method has useful functions for non-editable content - some Mac IMs have such. So, it may be not quite correct to do an early return here. But it's clear that this code is in need of large refactoring anyway to support input events, and I think that this patch improves the behavior more than it (potentially) regresses it. > // TODO: Dispatch IE-compatible text input events for IM events. We use FIXME, not TODO. Even thought this is old code, it seems appropriate to correct it now. 111194 3 zecke 2009-02-26 08:33:44 -0800 Landed in r41249. 111736 4 xan.lopez 2009-03-01 13:41:17 -0800 *** Bug 23948 has been marked as a duplicate of this bug. *** 28010 2009-02-26 01:45:43 -0800 2009-02-26 05:19:06 -0800 imevent.patch imevent.patch text/plain 2320 xan.lopez RnJvbSAxZjIzMTkwMDY2ZDVlODc0MGEwZTZhYjliMjZhOTQ0YTI3MGQ0ZmM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFRodSwg MjYgRmViIDIwMDkgMTE6NDQ6MjkgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAyLTI2ICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MTkzCiAgICAgICAgW0dUS10gQ2hlY2tidXR0b25zIG5vdCBhY3RpdmF0ZWQgd2l0aCBzcGFjZQoK ICAgICAgICBEbyBub3Qgc3dhbGxvdyBrZXkgZXZlbnRzIHdpdGggR3RrSU1Db250ZXh0IGZvciBu b24tZWRpdGFibGUKICAgICAgICBmcmFtZXMgKEZJWE1FOiBJIGRvbid0IHRoaW5rIGZyYW1lIGlz IHRoZSByaWdodCBuYW1lIGhlcmUpLgoKICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudEd0ay5jcHA6CiAgICAgICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50OjpoYW5kbGVJbnB1dE1l dGhvZEtleWRvd24pOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRHdGsuY3BwIHwgICAgNSArKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMWE0YTkyZC4uNGU1NTY5YSAxMDA2NDQK LS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAwOS0wMi0yNiAgWGFuIExvcGV6ICA8eGFuQGdub21lLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxOTMKKyAgICAgICAgW0dUS10gQ2hlY2ti dXR0b25zIG5vdCBhY3RpdmF0ZWQgd2l0aCBzcGFjZQorCisgICAgICAgIERvIG5vdCBzd2FsbG93 IGtleSBldmVudHMgd2l0aCBHdGtJTUNvbnRleHQgZm9yIG5vbi1lZGl0YWJsZQorICAgICAgICBm cmFtZXMgKEZJWE1FOiBJIGRvbid0IHRoaW5rIGZyYW1lIGlzIHRoZSByaWdodCBuYW1lIGhlcmUp LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RWRpdG9yQ2xpZW50OjpoYW5kbGVJbnB1dE1ldGhvZEtleWRvd24pOgorCiAy MDA5LTAyLTIzICBYYW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKaW5kZXggZTc1YjFmYi4uOTUxYjAzZSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcApAQCAtNTA0LDggKzUwNCwxMSBA QCB2b2lkIEVkaXRvckNsaWVudDo6aGFuZGxlS2V5Ym9hcmRFdmVudChLZXlib2FyZEV2ZW50KiBl dmVudCkKIAogdm9pZCBFZGl0b3JDbGllbnQ6OmhhbmRsZUlucHV0TWV0aG9kS2V5ZG93bihLZXli b2FyZEV2ZW50KiBldmVudCkKIHsKLSAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IG1f d2ViVmlldy0+cHJpdjsKKyAgICBGcmFtZSogdGFyZ2V0RnJhbWUgPSBjb3JlKG1fd2ViVmlldykt PmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKKyAgICBpZiAoIXRhcmdl dEZyYW1lIHx8ICF0YXJnZXRGcmFtZS0+ZWRpdG9yKCktPmNhbkVkaXQoKSkKKyAgICAgICAgcmV0 dXJuOwogCisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBtX3dlYlZpZXctPnByaXY7 CiAgICAgLy8gVE9ETzogRGlzcGF0Y2ggSUUtY29tcGF0aWJsZSB0ZXh0IGlucHV0IGV2ZW50cyBm b3IgSU0gZXZlbnRzLgogICAgIGlmIChndGtfaW1fY29udGV4dF9maWx0ZXJfa2V5cHJlc3MocHJp di0+aW1Db250ZXh0LCBldmVudC0+a2V5RXZlbnQoKS0+Z2RrRXZlbnRLZXkoKSkpCiAgICAgICAg IGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwotLSAKMS42LjEKCg==