241889 2022-06-22 17:15:01 -0700 Null check parent node in InsertListCommand::unlistifyParagraph 2022-06-22 18:49:13 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ews-watchlist mifenton webkit-bug-importer oldest_to_newest 1877498 0 achristensen 2022-06-22 17:15:01 -0700 And make listNode a reference. 1877500 1 460435 achristensen 2022-06-22 17:18:04 -0700 Created attachment 460435 Patch 1877533 2 ews-feeder 2022-06-22 18:48:56 -0700 Committed r295764 (251769@main): <https://commits.webkit.org/251769@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460435. 1877534 3 webkit-bug-importer 2022-06-22 18:49:13 -0700 <rdar://problem/95740647> 460435 2022-06-22 17:18:04 -0700 2022-06-22 18:48:56 -0700 Patch bug-241889-20220622171803.patch text/plain 6428 achristensen RnJvbSA3NmM0ZjhhYzljOTk0Y2YyYjc4YTlmMGNmNjMwYTVhNzIxNjM1NGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IENocmlzdGVuc2VuIDxhY2hyaXN0ZW5zZW5AYXBwbGUu Y29tPgpEYXRlOiBXZWQsIDIyIEp1biAyMDIyIDE3OjE1OjEyIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gTnVsbCBjaGVjayBwYXJlbnQgbm9kZSBpbgogSW5zZXJ0TGlzdENvbW1hbmQ6OnVubGlzdGlm eVBhcmFncmFwaAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTg4 OQoKUmV2aWV3ZWQgYnkgV2Vuc29uIEhzaWVoLgoKKiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0lu c2VydExpc3RDb21tYW5kLmNwcDoKKFdlYkNvcmU6Okluc2VydExpc3RDb21tYW5kOjpkb0FwcGx5 Rm9yU2luZ2xlUGFyYWdyYXBoKToKKFdlYkNvcmU6Okluc2VydExpc3RDb21tYW5kOjp1bmxpc3Rp ZnlQYXJhZ3JhcGgpOgoqIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQu aDoKLS0tCiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luc2VydExpc3RDb21tYW5kLmNwcCB8IDI2 ICsrKysrKysrKystLS0tLS0tLS0tCiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luc2VydExpc3RD b21tYW5kLmggICB8ICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDE0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0 TGlzdENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRMaXN0Q29tbWFu ZC5jcHAKaW5kZXggNzc0ZjVlZWMzMDQ5Li45NTYwYmFkZmQwYWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuY3BwCkBAIC0yNzMsMjEgKzI3MywyMSBAQCB2 b2lkIEluc2VydExpc3RDb21tYW5kOjpkb0FwcGx5Rm9yU2luZ2xlUGFyYWdyYXBoKGJvb2wgZm9y Y2VDcmVhdGVMaXN0LCBjb25zdCBIVAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAg ICAgICAgIAotICAgICAgICB1bmxpc3RpZnlQYXJhZ3JhcGgoZW5kaW5nU2VsZWN0aW9uKCkudmlz aWJsZVN0YXJ0KCksIGxpc3ROb2RlLmdldCgpLCBsaXN0Q2hpbGROb2RlKTsKKyAgICAgICAgdW5s aXN0aWZ5UGFyYWdyYXBoKGVuZGluZ1NlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLCAqbGlzdE5v ZGUsIGxpc3RDaGlsZE5vZGUpOwogICAgIH0KIAogICAgIGlmICghbGlzdENoaWxkTm9kZSB8fCBz d2l0Y2hMaXN0VHlwZSB8fCBmb3JjZUNyZWF0ZUxpc3QpCiAgICAgICAgIG1fbGlzdEVsZW1lbnQg PSBsaXN0aWZ5UGFyYWdyYXBoKGVuZGluZ1NlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLCBsaXN0 VGFnKTsKIH0KIAotdm9pZCBJbnNlcnRMaXN0Q29tbWFuZDo6dW5saXN0aWZ5UGFyYWdyYXBoKGNv bnN0IFZpc2libGVQb3NpdGlvbiYgb3JpZ2luYWxTdGFydCwgSFRNTEVsZW1lbnQqIGxpc3ROb2Rl LCBOb2RlKiBsaXN0Q2hpbGROb2RlKQordm9pZCBJbnNlcnRMaXN0Q29tbWFuZDo6dW5saXN0aWZ5 UGFyYWdyYXBoKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgb3JpZ2luYWxTdGFydCwgSFRNTEVsZW1l bnQmIGxpc3ROb2RlLCBOb2RlKiBsaXN0Q2hpbGROb2RlKQogewogICAgIFJlZlB0cjxOb2RlPiBu ZXh0TGlzdENoaWxkOwogICAgIFJlZlB0cjxOb2RlPiBwcmV2aW91c0xpc3RDaGlsZDsKICAgICBW aXNpYmxlUG9zaXRpb24gc3RhcnQ7CiAgICAgVmlzaWJsZVBvc2l0aW9uIGVuZDsKIAotICAgIGlm ICghbGlzdE5vZGUtPnBhcmVudE5vZGUoKS0+aGFzRWRpdGFibGVTdHlsZSgpKQorICAgIGlmICgh bGlzdE5vZGUucGFyZW50Tm9kZSgpIHx8ICFsaXN0Tm9kZS5wYXJlbnROb2RlKCktPmhhc0VkaXRh YmxlU3R5bGUoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKGxpc3RDaGlsZE5vZGUtPmhh c1RhZ05hbWUobGlUYWcpKSB7CkBAIC0yOTksOSArMjk5LDkgQEAgdm9pZCBJbnNlcnRMaXN0Q29t bWFuZDo6dW5saXN0aWZ5UGFyYWdyYXBoKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgb3JpZ2luYWxT dGFydCwKICAgICAgICAgLy8gQSBwYXJhZ3JhcGggaXMgdmlzdWFsbHkgYSBsaXN0IGl0ZW0gbWlu dXMgYSBsaXN0IG1hcmtlci4gIFRoZSBwYXJhZ3JhcGggd2lsbCBiZSBtb3ZlZC4KICAgICAgICAg c3RhcnQgPSBzdGFydE9mUGFyYWdyYXBoKG9yaWdpbmFsU3RhcnQsIENhblNraXBPdmVyRWRpdGlu Z0JvdW5kYXJ5KTsKICAgICAgICAgZW5kID0gZW5kT2ZQYXJhZ3JhcGgoc3RhcnQsIENhblNraXBP dmVyRWRpdGluZ0JvdW5kYXJ5KTsKLSAgICAgICAgbmV4dExpc3RDaGlsZCA9IGVuY2xvc2luZ0xp c3RDaGlsZChlbmQubmV4dCgpLmRlZXBFcXVpdmFsZW50KCkuZGVwcmVjYXRlZE5vZGUoKSwgbGlz dE5vZGUpOworICAgICAgICBuZXh0TGlzdENoaWxkID0gZW5jbG9zaW5nTGlzdENoaWxkKGVuZC5u ZXh0KCkuZGVlcEVxdWl2YWxlbnQoKS5kZXByZWNhdGVkTm9kZSgpLCAmbGlzdE5vZGUpOwogICAg ICAgICBBU1NFUlQobmV4dExpc3RDaGlsZCAhPSBsaXN0Q2hpbGROb2RlKTsKLSAgICAgICAgcHJl dmlvdXNMaXN0Q2hpbGQgPSBlbmNsb3NpbmdMaXN0Q2hpbGQoc3RhcnQucHJldmlvdXMoKS5kZWVw RXF1aXZhbGVudCgpLmRlcHJlY2F0ZWROb2RlKCksIGxpc3ROb2RlKTsKKyAgICAgICAgcHJldmlv dXNMaXN0Q2hpbGQgPSBlbmNsb3NpbmdMaXN0Q2hpbGQoc3RhcnQucHJldmlvdXMoKS5kZWVwRXF1 aXZhbGVudCgpLmRlcHJlY2F0ZWROb2RlKCksICZsaXN0Tm9kZSk7CiAgICAgICAgIEFTU0VSVChw cmV2aW91c0xpc3RDaGlsZCAhPSBsaXN0Q2hpbGROb2RlKTsKICAgICB9CiAKQEAgLTMxNCw3ICsz MTQsNyBAQCB2b2lkIEluc2VydExpc3RDb21tYW5kOjp1bmxpc3RpZnlQYXJhZ3JhcGgoY29uc3Qg VmlzaWJsZVBvc2l0aW9uJiBvcmlnaW5hbFN0YXJ0LAogICAgIFJlZlB0cjxFbGVtZW50PiBub2Rl VG9JbnNlcnQgPSBwbGFjZWhvbGRlci5jb3B5UmVmKCk7CiAgICAgLy8gSWYgdGhlIGNvbnRlbnQg b2YgdGhlIGxpc3QgaXRlbSB3aWxsIGJlIG1vdmVkIGludG8gYW5vdGhlciBsaXN0LCBwdXQgaXQg aW4gYSBsaXN0IGl0ZW0KICAgICAvLyBzbyB0aGF0IHdlIGRvbid0IGNyZWF0ZSBhbiBvcnBoYW5l ZCBsaXN0IGNoaWxkLgotICAgIGlmIChlbmNsb3NpbmdMaXN0KGxpc3ROb2RlKSkgeworICAgIGlm IChlbmNsb3NpbmdMaXN0KCZsaXN0Tm9kZSkpIHsKICAgICAgICAgbm9kZVRvSW5zZXJ0ID0gSFRN TExJRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50KCkpOwogICAgICAgICBhcHBlbmROb2RlKHBsYWNl aG9sZGVyLmNvcHlSZWYoKSwgKm5vZGVUb0luc2VydCk7CiAgICAgfQpAQCAtMzI3LDE4ICszMjcs MTggQEAgdm9pZCBJbnNlcnRMaXN0Q29tbWFuZDo6dW5saXN0aWZ5UGFyYWdyYXBoKGNvbnN0IFZp c2libGVQb3NpdGlvbiYgb3JpZ2luYWxTdGFydCwKICAgICAgICAgLy8gRklYTUU6IFdlIGFwcGVh ciB0byBzcGxpdCBhdCBuZXh0TGlzdENoaWxkIGFzIG9wcG9zZWQgdG8gbGlzdENoaWxkTm9kZSBz byB0aGF0IHdoZW4gd2UgcmVtb3ZlCiAgICAgICAgIC8vIGxpc3RDaGlsZE5vZGUgYmVsb3cgaW4g bW92ZVBhcmFncmFwaHMsIHByZXZpb3VzTGlzdENoaWxkIHdpbGwgYmUgcmVtb3ZlZCBhbG9uZyB3 aXRoIGl0IGlmIGl0IGlzIAogICAgICAgICAvLyB1bnJlbmRlcmVkLiBCdXQgd2Ugb3VnaHQgdG8g cmVtb3ZlIG5leHRMaXN0Q2hpbGQgdG9vLCBpZiBpdCBpcyB1bnJlbmRlcmVkLgotICAgICAgICBz cGxpdEVsZW1lbnQoKmxpc3ROb2RlLCAqc3BsaXRUcmVlVG9Ob2RlKCpuZXh0TGlzdENoaWxkLCAq bGlzdE5vZGUpKTsKLSAgICAgICAgaW5zZXJ0Tm9kZUJlZm9yZShub2RlVG9JbnNlcnQucmVsZWFz ZU5vbk51bGwoKSwgKmxpc3ROb2RlKTsKLSAgICB9IGVsc2UgaWYgKG5leHRMaXN0Q2hpbGQgfHwg bGlzdENoaWxkTm9kZS0+cGFyZW50Tm9kZSgpICE9IGxpc3ROb2RlKSB7CisgICAgICAgIHNwbGl0 RWxlbWVudChsaXN0Tm9kZSwgKnNwbGl0VHJlZVRvTm9kZSgqbmV4dExpc3RDaGlsZCwgbGlzdE5v ZGUpKTsKKyAgICAgICAgaW5zZXJ0Tm9kZUJlZm9yZShub2RlVG9JbnNlcnQucmVsZWFzZU5vbk51 bGwoKSwgbGlzdE5vZGUpOworICAgIH0gZWxzZSBpZiAobmV4dExpc3RDaGlsZCB8fCBsaXN0Q2hp bGROb2RlLT5wYXJlbnROb2RlKCkgIT0gJmxpc3ROb2RlKSB7CiAgICAgICAgIC8vIEp1c3QgYmVj YXVzZSBsaXN0Q2hpbGROb2RlIGhhcyBubyBwcmV2aW91c0xpc3RDaGlsZCBkb2Vzbid0IG1lYW4g dGhlcmUgaXNuJ3QgYW55IGNvbnRlbnQKICAgICAgICAgLy8gaW4gbGlzdE5vZGUgdGhhdCBjb21l cyBiZWZvcmUgbGlzdENoaWxkTm9kZSwgYXMgbGlzdENoaWxkTm9kZSBjb3VsZCBoYXZlIGFuY2Vz dG9ycwogICAgICAgICAvLyBiZXR3ZWVuIGl0IGFuZCBsaXN0Tm9kZS4gU28sIHdlIHNwbGl0IHVw IHRvIGxpc3ROb2RlIGJlZm9yZSBpbnNlcnRpbmcgdGhlIHBsYWNlaG9sZGVyCiAgICAgICAgIC8v IHdoZXJlIHdlJ3JlIGFib3V0IHRvIG1vdmUgbGlzdENoaWxkTm9kZSB0by4KLSAgICAgICAgaWYg KFJlZlB0ciBsaXN0Q2hpbGROb2RlUGFyZW50Tm9kZSB7IGxpc3RDaGlsZE5vZGUtPnBhcmVudE5v ZGUoKSB9OyBsaXN0Q2hpbGROb2RlUGFyZW50Tm9kZSAmJiBsaXN0Q2hpbGROb2RlUGFyZW50Tm9k ZSAhPSBsaXN0Tm9kZSkKLSAgICAgICAgICAgIHNwbGl0RWxlbWVudCgqbGlzdE5vZGUsICpzcGxp dFRyZWVUb05vZGUoKmxpc3RDaGlsZE5vZGUsICpsaXN0Tm9kZSkuZ2V0KCkpOwotICAgICAgICBp bnNlcnROb2RlQmVmb3JlKG5vZGVUb0luc2VydC5yZWxlYXNlTm9uTnVsbCgpLCAqbGlzdE5vZGUp OworICAgICAgICBpZiAoUmVmUHRyIGxpc3RDaGlsZE5vZGVQYXJlbnROb2RlIHsgbGlzdENoaWxk Tm9kZS0+cGFyZW50Tm9kZSgpIH07IGxpc3RDaGlsZE5vZGVQYXJlbnROb2RlICYmIGxpc3RDaGls ZE5vZGVQYXJlbnROb2RlICE9ICZsaXN0Tm9kZSkKKyAgICAgICAgICAgIHNwbGl0RWxlbWVudChs aXN0Tm9kZSwgKnNwbGl0VHJlZVRvTm9kZSgqbGlzdENoaWxkTm9kZSwgbGlzdE5vZGUpLmdldCgp KTsKKyAgICAgICAgaW5zZXJ0Tm9kZUJlZm9yZShub2RlVG9JbnNlcnQucmVsZWFzZU5vbk51bGwo KSwgbGlzdE5vZGUpOwogICAgIH0gZWxzZQotICAgICAgICBpbnNlcnROb2RlQWZ0ZXIobm9kZVRv SW5zZXJ0LnJlbGVhc2VOb25OdWxsKCksICpsaXN0Tm9kZSk7CisgICAgICAgIGluc2VydE5vZGVB ZnRlcihub2RlVG9JbnNlcnQucmVsZWFzZU5vbk51bGwoKSwgbGlzdE5vZGUpOwogCiAgICAgVmlz aWJsZVBvc2l0aW9uIGluc2VydGlvblBvaW50ID0gVmlzaWJsZVBvc2l0aW9uKHBvc2l0aW9uQmVm b3JlTm9kZShwbGFjZWhvbGRlci5wdHIoKSkpOwogICAgIG1vdmVQYXJhZ3JhcGhzKHN0YXJ0LCBl bmQsIGluc2VydGlvblBvaW50LCB0cnVlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuaCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0 TGlzdENvbW1hbmQuaAppbmRleCA0MTk5ZjY5OTI2YjkuLjAwYzBmMDI1NTlmMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRMaXN0Q29tbWFuZC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0TGlzdENvbW1hbmQuaApAQCAtNTUsNyArNTUsNyBAQCBw cml2YXRlOgogICAgIGJvb2wgc2VsZWN0aW9uSGFzTGlzdE9mVHlwZShjb25zdCBWaXNpYmxlU2Vs ZWN0aW9uJiBzZWxlY3Rpb24sIGNvbnN0IFF1YWxpZmllZE5hbWUmKTsKICAgICBSZWY8SFRNTEVs ZW1lbnQ+IG1lcmdlV2l0aE5laWdoYm9yaW5nTGlzdHMoSFRNTEVsZW1lbnQmKTsKICAgICB2b2lk IGRvQXBwbHlGb3JTaW5nbGVQYXJhZ3JhcGgoYm9vbCBmb3JjZUNyZWF0ZUxpc3QsIGNvbnN0IEhU TUxRdWFsaWZpZWROYW1lJiwgU2ltcGxlUmFuZ2UmIGN1cnJlbnRTZWxlY3Rpb24pOwotICAgIHZv aWQgdW5saXN0aWZ5UGFyYWdyYXBoKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgb3JpZ2luYWxTdGFy dCwgSFRNTEVsZW1lbnQqIGxpc3ROb2RlLCBOb2RlKiBsaXN0Q2hpbGROb2RlKTsKKyAgICB2b2lk IHVubGlzdGlmeVBhcmFncmFwaChjb25zdCBWaXNpYmxlUG9zaXRpb24mIG9yaWdpbmFsU3RhcnQs IEhUTUxFbGVtZW50JiBsaXN0Tm9kZSwgTm9kZSogbGlzdENoaWxkTm9kZSk7CiAgICAgUmVmUHRy PEhUTUxFbGVtZW50PiBsaXN0aWZ5UGFyYWdyYXBoKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgb3Jp Z2luYWxTdGFydCwgY29uc3QgUXVhbGlmaWVkTmFtZSYgbGlzdFRhZyk7CiAgICAgUmVmUHRyPEhU TUxFbGVtZW50PiBtX2xpc3RFbGVtZW50OwogICAgIFR5cGUgbV90eXBlOwo=