241874 2022-06-22 14:44:45 -0700 RenderElement::addLayers should check for dialog content before inserting layers 2022-06-27 10:35:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235453 InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1877426 0 zalan 2022-06-22 14:44:45 -0700 ssia 1877430 1 460428 zalan 2022-06-22 14:51:39 -0700 Created attachment 460428 Patch 1877545 2 ews-feeder 2022-06-22 20:22:11 -0700 Committed r295767 (251772@main): <https://commits.webkit.org/251772@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460428. 1877546 3 webkit-bug-importer 2022-06-22 20:23:13 -0700 <rdar://problem/95744910> 1878519 4 zalan 2022-06-27 10:35:05 -0700 (In reply to Radar WebKit Bug Importer from comment #3) > <rdar://problem/95744910> <rdar://93232683> 460428 2022-06-22 14:51:39 -0700 2022-06-22 20:22:12 -0700 Patch bug-241874-20220622145138.patch text/plain 5074 zalan RnJvbSAyZDUyYWExNzEyNmMyNGRiNGUxMzY0MDUxYjU3YzlmZjlhZDBlYzZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBX ZWQsIDIyIEp1biAyMDIyIDE0OjQ0OjU3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gUmVuZGVyRWxl bWVudDo6YWRkTGF5ZXJzIHNob3VsZCBjaGVjayBmb3IgZGlhbG9nIGNvbnRlbnQKIGJlZm9yZSBp bnNlcnRpbmcgbGF5ZXJzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDE4NzQKClJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KCmFkZExheWVycyBzdG9wcyAocmVjdXJz aXZlKSBkZXNjZW5kaW5nIGluIHRoZSByZW5kZXIgdHJlZSBzb29uIGFmdGVyIGl0IGZpbmRzIGEg cm9vdCAoUikgd2l0aCBsYXllci4KSXQgc2F5cyB0aGF0IGlmIGEgc3VidHJlZSByb290IChSKSBo YXMgYSBsYXllciB0aGVuIGFsbCBsYXllcnMgaW4gdGhpcyBzdWJ0cmVlIG11c3QgaGF2ZSBhbHJl YWR5IGJlZW4gaW5zZXJ0ZWQgaW50byB0aGUgbGF5ZXIgdHJlZSBhdCBhbiBlYXJsaWVyIHRpbWUu CihpdCBzaW1wbHkgYXNzdW1lcyB0aGF0IGFueSBsYXllciBpbiB0aGUgc3VidHJlZSBpcyBhIGNo aWxkIG9mIChSKSwgb3Igc29tZSBvdGhlciBsYXllcnMgaW4gdGhlIHN1YnRyZWUpCgo8ZGl2IGlk PWNvbnRhaW5lcj4KICA8ZGl2IGlkPVI+CiAgICA8ZGl2IGlkPWNoaWxkPgoKVGhlIGluc2VydGlv biBpcyBib3R0b20gdG8gdG9wOyB3ZSBhdHRhY2gKMSwgKGNoaWxkKSB0byAoUikgZmlyc3QKMiwg Zm9sbG93ZWQgYnkgKFIpIHRvIChjb250YWluZXIpCmFkZExheWVycyBhc3N1bWVzIHRoYXQgd2hl biAoUikgaXMgYmVpbmcgaW5zZXJ0ZWQgKCMyKSwgd2UgZG9uJ3QgaGF2ZSB0byBkZXNjZW5kIGlu dG8gKFIpJ3Mgc3VidHJlZSBzaW5jZSBhbnkgcmVuZGVyZXIncyBsYXllciB0aGF0IHdhcyBpbnNl cnRlZCBiZWZvcmUgKGF0ICMxKSBtdXN0IGhhdmUgYWxyZWFkeSBiZWVuIHBhcmVudGVkLgoKSG93 ZXZlciB0b3BsYXllci9iYWNrZHJvcCBjb250ZW50IGlzIGFuIGV4Y2VwdGlvbiB3aGVyZSB0aGUg cGFyZW50IGxheWVyIG1heSBiZSBvdXRzaWRlIG9mIHRoZSBzdWJ0cmVlIGJ1dCBzdGlsbCBhY2Nl c3NpYmxlLiBJbiBzdWNoIGNhc2VzIHN1YnNlcXVlbnQgaW5zZXJ0aW9ucyAoYW5kIHRoZSByZWN1 cnNpdmUgbmF0dXJlIG9mIGZpbmRpbmcgbGF5ZXIgcGFyZW50cykgY291bGQgbGVhZCB0byBkb3Vi bGUgcGFyZW50aW5nIHdoZXJlIHdlIHRyeSB0byBpbnNlcnQgdGhlIHNhbWUgbGF5ZXIgaW50byB0 aGUgbGF5ZXIgdHJlZSBtdWx0aXBsZSB0aW1lcy4KCiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuY3BwOgooV2ViQ29yZTo6YWRkTGF5ZXJzKToKKFdlYkNvcmU6OlJlbmRl ckVsZW1lbnQ6Omluc2VydGVkSW50b1RyZWUpOgooV2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6YWRk TGF5ZXJzKTogRGVsZXRlZC4KKiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVu dC5oOgotLS0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcCB8IDMy ICsrKysrKysrKysrLS0tLS0tLS0tLS0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJF bGVtZW50LmggICB8ICAxIC0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTcg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3Bw CmluZGV4IDM4OGE3Yzk0NDdiNC4uODdjMGU3ZDcwZWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCkBAIC02MzYsMjYgKzYzNiwyNiBAQCBzdGF0aWMgUmVu ZGVyTGF5ZXIqIGxheWVyTmV4dFNpYmxpbmdSZXNwZWN0aW5nVG9wTGF5ZXIoY29uc3QgUmVuZGVy RWxlbWVudCYgcmVuZAogICAgIHJldHVybiBmaW5kTmV4dExheWVyKCpyZW5kZXJlci5wYXJlbnQo KSwgcGFyZW50TGF5ZXIsICZyZW5kZXJlcik7CiB9CiAKLXN0YXRpYyB2b2lkIGFkZExheWVycyhj b25zdCBSZW5kZXJFbGVtZW50JiBhZGRlZFJlbmRlcmVyLCBSZW5kZXJFbGVtZW50JiBjdXJyZW50 UmVuZGVyZXIsIFJlbmRlckxheWVyKiBwYXJlbnRMYXllcikKK3N0YXRpYyB2b2lkIGFkZExheWVy cyhjb25zdCBSZW5kZXJFbGVtZW50JiBpbnNlcnRlZFJlbmRlcmVyLCBSZW5kZXJFbGVtZW50JiBj dXJyZW50UmVuZGVyZXIsIFJlbmRlckxheWVyJiBwYXJlbnRMYXllcikKIHsKICAgICBpZiAoY3Vy cmVudFJlbmRlcmVyLmhhc0xheWVyKCkpIHsKLSAgICAgICAgaWYgKGlzSW5Ub3BMYXllck9yQmFj a2Ryb3AoY3VycmVudFJlbmRlcmVyLnN0eWxlKCksIGN1cnJlbnRSZW5kZXJlci5lbGVtZW50KCkp KQotICAgICAgICAgICAgcGFyZW50TGF5ZXIgPSBhZGRlZFJlbmRlcmVyLnZpZXcoKS5sYXllcigp OwotICAgICAgICBSZW5kZXJMYXllciogYmVmb3JlQ2hpbGQgPSBsYXllck5leHRTaWJsaW5nUmVz cGVjdGluZ1RvcExheWVyKGFkZGVkUmVuZGVyZXIsICpwYXJlbnRMYXllcik7Ci0gICAgICAgIHBh cmVudExheWVyLT5hZGRDaGlsZCgqZG93bmNhc3Q8UmVuZGVyTGF5ZXJNb2RlbE9iamVjdD4oY3Vy cmVudFJlbmRlcmVyKS5sYXllcigpLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIGF1dG8qIGxheWVy VG9Vc2UgPSAmcGFyZW50TGF5ZXI7CisgICAgICAgIGlmIChpc0luVG9wTGF5ZXJPckJhY2tkcm9w KGN1cnJlbnRSZW5kZXJlci5zdHlsZSgpLCBjdXJyZW50UmVuZGVyZXIuZWxlbWVudCgpKSkgewor ICAgICAgICAgICAgLy8gVGhlIHNwZWNpYWwgaGFuZGxpbmcgb2YgYSB0b3BsYXllci9iYWNrZHJv cCBjb250ZW50IG1heSByZXN1bHQgaW4gdHJ5aW5nIHRvIGluc2VydCB0aGUgYXNzb2NpYXRlZAor ICAgICAgICAgICAgLy8gbGF5ZXIgdHdpY2UgYXMgd2UgY29ubmVjdCBzdWJ0cmVlcy4KKyAgICAg ICAgICAgIGlmIChhdXRvKiBwYXJlbnRMYXllciA9IGRvd25jYXN0PFJlbmRlckxheWVyTW9kZWxP YmplY3Q+KGN1cnJlbnRSZW5kZXJlcikubGF5ZXIoKS0+cGFyZW50KCkpIHsKKyAgICAgICAgICAg ICAgICBBU1NFUlQocGFyZW50TGF5ZXIgPT0gY3VycmVudFJlbmRlcmVyLnZpZXcoKS5sYXllcigp KTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgICAgICBs YXllclRvVXNlID0gaW5zZXJ0ZWRSZW5kZXJlci52aWV3KCkubGF5ZXIoKTsKKyAgICAgICAgfQor ICAgICAgICBhdXRvKiBiZWZvcmVDaGlsZCA9IGxheWVyTmV4dFNpYmxpbmdSZXNwZWN0aW5nVG9w TGF5ZXIoaW5zZXJ0ZWRSZW5kZXJlciwgKmxheWVyVG9Vc2UpOworICAgICAgICBsYXllclRvVXNl LT5hZGRDaGlsZCgqZG93bmNhc3Q8UmVuZGVyTGF5ZXJNb2RlbE9iamVjdD4oY3VycmVudFJlbmRl cmVyKS5sYXllcigpLCBiZWZvcmVDaGlsZCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAg ICBmb3IgKGF1dG8mIGNoaWxkIDogY2hpbGRyZW5PZlR5cGU8UmVuZGVyRWxlbWVudD4oY3VycmVu dFJlbmRlcmVyKSkKLSAgICAgICAgYWRkTGF5ZXJzKGFkZGVkUmVuZGVyZXIsIGNoaWxkLCBwYXJl bnRMYXllcik7Ci19Ci0KLXZvaWQgUmVuZGVyRWxlbWVudDo6YWRkTGF5ZXJzKFJlbmRlckxheWVy KiBwYXJlbnRMYXllcikKLXsKLSAgICBpZiAoIXBhcmVudExheWVyKQotICAgICAgICByZXR1cm47 Ci0KLSAgICBXZWJDb3JlOjphZGRMYXllcnMoKnRoaXMsICp0aGlzLCBwYXJlbnRMYXllcik7Cisg ICAgICAgIGFkZExheWVycyhpbnNlcnRlZFJlbmRlcmVyLCBjaGlsZCwgcGFyZW50TGF5ZXIpOwog fQogCiB2b2lkIFJlbmRlckVsZW1lbnQ6OnJlbW92ZUxheWVycygpCkBAIC05MzcsOCArOTM3LDgg QEAgdm9pZCBSZW5kZXJFbGVtZW50OjppbnNlcnRlZEludG9UcmVlKElzSW50ZXJuYWxNb3ZlIGlz SW50ZXJuYWxNb3ZlKQogICAgIC8vIGFuZCBkb24ndCBoYXZlIGEgbGF5ZXIgYXR0YWNoZWQgdG8g b3Vyc2VsdmVzLgogICAgIFJlbmRlckxheWVyKiBwYXJlbnRMYXllciA9IG51bGxwdHI7CiAgICAg aWYgKGZpcnN0Q2hpbGQoKSB8fCBoYXNMYXllcigpKSB7Ci0gICAgICAgIGF1dG8qIHBhcmVudExh eWVyID0gbGF5ZXJQYXJlbnQoKTsKLSAgICAgICAgYWRkTGF5ZXJzKHBhcmVudExheWVyKTsKKyAg ICAgICAgaWYgKGF1dG8qIHBhcmVudExheWVyID0gbGF5ZXJQYXJlbnQoKSkKKyAgICAgICAgICAg IGFkZExheWVycygqdGhpcywgKnRoaXMsICpwYXJlbnRMYXllcik7CiAgICAgfQogCiAgICAgLy8g SWYgfHRoaXN8IGlzIHZpc2libGUgYnV0IHRoaXMgb2JqZWN0IHdhcyBub3QsIHRlbGwgdGhlIGxh eWVyIGl0IGhhcyBzb21lIHZpc2libGUgY29udGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJFbGVtZW50LmgKaW5kZXggOWRhYjlmNzExMTViLi4yYjIyOTNmYTk3MTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuaApAQCAtMTE5LDcgKzExOSw2IEBAIHB1 YmxpYzoKICAgICAvLyBjYW4gY29udGFpbiBhIG1peHR1cmUgb2YgYm94ZXMgYW5kIG90aGVyIG9i amVjdCB0eXBlcywgdGhlc2UgZnVuY3Rpb25zIG5lZWQgdG8gYmUgaW4gdGhlIGJhc2UgY2xhc3Mu CiAgICAgUmVuZGVyTGF5ZXIqIGxheWVyUGFyZW50KCkgY29uc3Q7CiAgICAgUmVuZGVyTGF5ZXIq IGxheWVyTmV4dFNpYmxpbmcoUmVuZGVyTGF5ZXImIHBhcmVudExheWVyKSBjb25zdDsKLSAgICB2 b2lkIGFkZExheWVycyhSZW5kZXJMYXllciogcGFyZW50TGF5ZXIpOwogICAgIHZvaWQgcmVtb3Zl TGF5ZXJzKCk7CiAgICAgdm9pZCBtb3ZlTGF5ZXJzKFJlbmRlckxheWVyJiBuZXdQYXJlbnQpOwog Cg==