241839 2022-06-21 22:21:10 -0700 GIFImageDecoder: Can't render some corrupted GIF images of the 88x31 GIF Collection 2022-06-23 17:51:14 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii darin sabouhallawa webkit-bug-importer oldest_to_newest 1877222 0 fujii 2022-06-21 22:21:10 -0700 GIFImageDecoder: Can't render some corrupted GIF images of the 88x31 GIF Collection Non-cocoa ports are uing GIFImageDecoder. It can't render some images of https://cyber.dabamos.de/88x31/ , but Safari, Chrome and Firefox can. For example, https://cyber.dabamos.de/88x31/besteyes2.gif https://cyber.dabamos.de/88x31/epicenter.gif https://cyber.dabamos.de/88x31/filetransit.gif GIFImageReader.cpp determines they are corrupted in the following condition. `*currentComponent` was 0. https://github.com/WebKit/WebKit/blob/49c1b53f803fe6952e293bfde206b22dc4ceadef/Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp#L502-L508 > // If we get anything other than ',' (image separator), '!' > // (extension), or ';' (trailer), there is extraneous data > // between blocks. The GIF87a spec tells us to keep reading > // until we find an image separator, but GIF89a says such > // a file is corrupt. We follow GIF89a and bail out. > if (*currentComponent != ',') > return false; 10635@main added the code. 1877225 1 fujii 2022-06-21 22:35:43 -0700 These GIF contain the following comments: > http://www.rtlsoft.com/animagic Created with Animagic GIF V 0.93 by Right to Left Software Inc. > http://www.rtlsoft.com/animagic Created with Animagic GIF V 1.02a by Right to Left Software Inc > http://www.rtlsoft.com/animagic Created with Animagic GIF V 1.05a by Right to Left Software Inc. To suppress this message in the registered version uncheck "Options | Animagic comment frame" 1877229 2 fujii 2022-06-21 23:30:22 -0700 Chromium's change. 242957 - Be more tolerant about corrupted GIF files - chromium https://bugs.chromium.org/p/chromium/issues/detail?id=242957 Issue 15914009: More tolerant about malformed GIF files - Code Review https://codereview.chromium.org/15914009 1877234 3 460405 fujii 2022-06-22 00:01:25 -0700 Created attachment 460405 WIP patch 1877245 4 460410 fujii 2022-06-22 01:01:10 -0700 Created attachment 460410 Patch 1877249 5 fujii 2022-06-22 01:10:27 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1678 1877304 6 460410 darin 2022-06-22 09:27:03 -0700 Comment on attachment 460410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460410&action=review > COMMIT_MESSAGE:1 > +GIFImageReader: Be torrent about invalid GIF files without a trailer(;) torrent -> tolerant 1878052 7 ews-feeder 2022-06-23 17:50:05 -0700 Committed 251813@main (9bdfe6d4600b): <https://commits.webkit.org/251813@main> Reviewed commits have been landed. Closing PR #1678 and removing active labels. 1878054 8 webkit-bug-importer 2022-06-23 17:51:14 -0700 <rdar://problem/95820038> 460405 2022-06-22 00:01:25 -0700 2022-06-22 01:01:05 -0700 WIP patch a.diff text/plain 1451 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9H SUZJbWFnZVJlYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwCmluZGV4IGQ3NzE4NmVhOTczOS4uNmI1ZTg4ZTU3MGFi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYv R0lGSW1hZ2VSZWFkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAKQEAgLTQ4OSw4ICs0ODksOCBAQCBib29sIEdJ RkltYWdlUmVhZGVyOjpwYXJzZShzaXplX3QgZGF0YVBvc2l0aW9uLCBzaXplX3QgbGVuLCBib29s IHBhcnNlU2l6ZU9ubHkpCiAgICAgICAgIH0KIAogICAgICAgICBjYXNlIEdJRkltYWdlU3RhcnQ6 IHsKLSAgICAgICAgICAgIGlmICgqY3VycmVudENvbXBvbmVudCA9PSAnOycpIHsgLy8gdGVybWlu YXRvci4KLSAgICAgICAgICAgICAgICBHRVROKDAsIEdJRkRvbmUpOworICAgICAgICAgICAgaWYg KCpjdXJyZW50Q29tcG9uZW50ID09ICcsJykgeyAvLyBpbWFnZSBzZXBhcmF0b3IuCisgICAgICAg ICAgICAgICAgR0VUTig5LCBHSUZJbWFnZUhlYWRlcik7CiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICB9CiAKQEAgLTUwMywxMSArNTAzLDEwIEBAIGJvb2wgR0lGSW1hZ2VSZWFk ZXI6OnBhcnNlKHNpemVfdCBkYXRhUG9zaXRpb24sIHNpemVfdCBsZW4sIGJvb2wgcGFyc2VTaXpl T25seSkKICAgICAgICAgICAgIC8vIChleHRlbnNpb24pLCBvciAnOycgKHRyYWlsZXIpLCB0aGVy ZSBpcyBleHRyYW5lb3VzIGRhdGEKICAgICAgICAgICAgIC8vIGJldHdlZW4gYmxvY2tzLiBUaGUg R0lGODdhIHNwZWMgdGVsbHMgdXMgdG8ga2VlcCByZWFkaW5nCiAgICAgICAgICAgICAvLyB1bnRp bCB3ZSBmaW5kIGFuIGltYWdlIHNlcGFyYXRvciwgYnV0IEdJRjg5YSBzYXlzIHN1Y2gKLSAgICAg ICAgICAgIC8vIGEgZmlsZSBpcyBjb3JydXB0LiBXZSBmb2xsb3cgR0lGODlhIGFuZCBiYWlsIG91 dC4KLSAgICAgICAgICAgIGlmICgqY3VycmVudENvbXBvbmVudCAhPSAnLCcpCi0gICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgICAgICAgICBHRVROKDksIEdJRkltYWdlSGVhZGVy KTsKKyAgICAgICAgICAgIC8vIGEgZmlsZSBpcyBjb3JydXB0LiBXZSBmb2xsb3cgbWFqb3IgYnJv d3NlcnMnIGltcGxlbWVudGF0aW9uCisgICAgICAgICAgICAvLyBhbmQgcHJvY2VlZCBhcyBpZiB0 aGUgZmlsZSB3ZXJlIGNvcnJlY3RseSB0ZXJtaW5hdGVkLCBzbyB0aGUKKyAgICAgICAgICAgIC8v IEdJRiB3aWxsIGRpc3BsYXkuCisgICAgICAgICAgICBHRVROKDAsIEdJRkRvbmUpOwogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAo= 460410 2022-06-22 01:01:10 -0700 2022-06-22 01:11:08 -0700 Patch bug-241839-20220622170109.patch text/plain 3981 fujii RnJvbSBiYjAwMTllNDEwMTBhMjU5MThlODE4YmVlMjUzOTQ2ZmU0ZDVjOTUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgMjIgSnVuIDIwMjIgMTY6NTY6MjkgKzA5MDAKU3ViamVjdDogW1BBVENI XSBHSUZJbWFnZVJlYWRlcjogQmUgdG9ycmVudCBhYm91dCBpbnZhbGlkIEdJRiBmaWxlcyB3aXRo b3V0IGEKIHRyYWlsZXIoOykgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI0MTgzOQoKR0lGIGZpbGVzIHNob3VsZCBiZSB0ZXJtaW5hdGVkIHdpdGggYSB0cmFpbGVyKDsp LiBIb3dldmVyLCBTYWZhcmksCkNocm9tZSBhbmQgRmlyZWZveCBjYW4gZGVjb2RlIGludmFsaWQg R0lGIGZpbGVzIHdpdGhvdXQgYSB0cmFpbGVyLgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgoqIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2JhZC10cmFpbGVyLWdpZi1leHBlY3RlZC5odG1s OiBBZGRlZC4KKiBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9iYWQtdHJhaWxlci1naWYuaHRtbDog QWRkZWQuCiogTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL2JhZC10cmFpbGVyLmdp ZjogQWRkZWQuCiogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJ RkltYWdlUmVhZGVyLmNwcDoKKEdJRkltYWdlUmVhZGVyOjpwYXJzZSk6IERvbid0IHJldHVybiBm YWxzZSBpbiB0aGUgY2FzZSBvZiBubyB0cmFpbGVyLgotLS0KIC4uLi9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwIHwgIDEzICsrKysrKy0tLS0tLS0KIC4uLi9m YXN0L2ltYWdlcy9iYWQtdHJhaWxlci1naWYtZXhwZWN0ZWQuaHRtbCAgICAgIHwgIDEwICsrKysr KysrKysKIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2JhZC10cmFpbGVyLWdpZi5odG1sICAgICAg IHwgIDEwICsrKysrKysrKysKIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9iYWQt dHJhaWxlci5naWYgIHwgQmluIDAgLT4gNDMgYnl0ZXMKIDQgZmlsZXMgY2hhbmdlZCwgMjYgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0 cy9mYXN0L2ltYWdlcy9iYWQtdHJhaWxlci1naWYtZXhwZWN0ZWQuaHRtbAogY3JlYXRlIG1vZGUg MTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2JhZC10cmFpbGVyLWdpZi5odG1sCiBjcmVh dGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL2JhZC10cmFp bGVyLmdpZgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwCmluZGV4IGQ3NzE4NmVhOTczOS4uNmI1 ZTg4ZTU3MGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9naWYvR0lGSW1hZ2VSZWFkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZVJlYWRlci5jcHAKQEAgLTQ4OSw4ICs0ODksOCBA QCBib29sIEdJRkltYWdlUmVhZGVyOjpwYXJzZShzaXplX3QgZGF0YVBvc2l0aW9uLCBzaXplX3Qg bGVuLCBib29sIHBhcnNlU2l6ZU9ubHkpCiAgICAgICAgIH0KIAogICAgICAgICBjYXNlIEdJRklt YWdlU3RhcnQ6IHsKLSAgICAgICAgICAgIGlmICgqY3VycmVudENvbXBvbmVudCA9PSAnOycpIHsg Ly8gdGVybWluYXRvci4KLSAgICAgICAgICAgICAgICBHRVROKDAsIEdJRkRvbmUpOworICAgICAg ICAgICAgaWYgKCpjdXJyZW50Q29tcG9uZW50ID09ICcsJykgeyAvLyBpbWFnZSBzZXBhcmF0b3Iu CisgICAgICAgICAgICAgICAgR0VUTig5LCBHSUZJbWFnZUhlYWRlcik7CiAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAKQEAgLTUwMywxMSArNTAzLDEwIEBAIGJvb2wgR0lG SW1hZ2VSZWFkZXI6OnBhcnNlKHNpemVfdCBkYXRhUG9zaXRpb24sIHNpemVfdCBsZW4sIGJvb2wg cGFyc2VTaXplT25seSkKICAgICAgICAgICAgIC8vIChleHRlbnNpb24pLCBvciAnOycgKHRyYWls ZXIpLCB0aGVyZSBpcyBleHRyYW5lb3VzIGRhdGEKICAgICAgICAgICAgIC8vIGJldHdlZW4gYmxv Y2tzLiBUaGUgR0lGODdhIHNwZWMgdGVsbHMgdXMgdG8ga2VlcCByZWFkaW5nCiAgICAgICAgICAg ICAvLyB1bnRpbCB3ZSBmaW5kIGFuIGltYWdlIHNlcGFyYXRvciwgYnV0IEdJRjg5YSBzYXlzIHN1 Y2gKLSAgICAgICAgICAgIC8vIGEgZmlsZSBpcyBjb3JydXB0LiBXZSBmb2xsb3cgR0lGODlhIGFu ZCBiYWlsIG91dC4KLSAgICAgICAgICAgIGlmICgqY3VycmVudENvbXBvbmVudCAhPSAnLCcpCi0g ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgICAgICAgICBHRVROKDksIEdJRklt YWdlSGVhZGVyKTsKKyAgICAgICAgICAgIC8vIGEgZmlsZSBpcyBjb3JydXB0LiBXZSBmb2xsb3cg bWFqb3IgYnJvd3NlcnMnIGltcGxlbWVudGF0aW9uCisgICAgICAgICAgICAvLyBhbmQgcHJvY2Vl ZCBhcyBpZiB0aGUgZmlsZSB3ZXJlIGNvcnJlY3RseSB0ZXJtaW5hdGVkLCBzbyB0aGUKKyAgICAg ICAgICAgIC8vIEdJRiB3aWxsIGRpc3BsYXkuCisgICAgICAgICAgICBHRVROKDAsIEdJRkRvbmUp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9pbWFnZXMvYmFkLXRyYWlsZXItZ2lmLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2ltYWdlcy9iYWQtdHJhaWxlci1naWYtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjdlZjQ4N2UzNDAyMQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2JhZC10cmFpbGVyLWdpZi1leHBlY3RlZC5odG1s CkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorICAgIGRpdiB7Cisg ICAgICAgIGhlaWdodDogMjAwcHg7CisgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgYmFj a2dyb3VuZDogZ3JlZW47CisgICAgfQorPC9zdHlsZT4KK1lvdSBzaG91bGQgc2VlIGEgZ3JlZW4g Ym94LgorPGRpdj48L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2Jh ZC10cmFpbGVyLWdpZi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvYmFkLXRyYWlsZXIt Z2lmLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi4zYzg4NTcx OWMyZjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9iYWQtdHJh aWxlci1naWYuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4K KyAgICBkaXYgeworICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgICB3aWR0aDogMjAwcHg7 CisgICAgICAgIGJhY2tncm91bmQ6IHVybChyZXNvdXJjZXMvYmFkLXRyYWlsZXIuZ2lmKTsKKyAg ICB9Cis8L3N0eWxlPgorWW91IHNob3VsZCBzZWUgYSBncmVlbiBib3guCis8ZGl2PjwvZGl2Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL2JhZC10cmFpbGVy LmdpZiBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9iYWQtdHJhaWxlci5naWYK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uN2VkYjAyMjY5YzJhYmY2Yjg5ODg3NzhjODM4YmRjYWE0NzQ2ZDBlNApHSVQg YmluYXJ5IHBhdGNoCmxpdGVyYWwgNDMKb2NtWj93YmhFSGJXTXA3dV9gdHh4JjtZfj9pYSVMRTZv VT9rMExkXmdGfVZPcTBGSSNxdW1BdTYKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoK