241782 2022-06-20 06:09:56 -0700 Remove Quirk dead code: passive mousewheel event hack for smoothscroll.js 2023-12-13 02:22:17 -0800 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207040 InRadar P2 Normal --- 1 zcorpan karlcow ahmad.saleem792 karlcow koivisto simon.fraser webkit-bug-importer oldest_to_newest 1876774 0 zcorpan 2022-06-20 06:09:56 -0700 This is dead code and can be removed: https://github.com/WebKit/WebKit/blob/dd956d5e74249681ddf904e0bbe401f308b65e0f/Source/WebCore/page/Quirks.cpp#L929-L946 The code above will return something when the event type is 'mousewheel' and event target is window. See https://github.com/whatwg/dom/issues/1088#issuecomment-1158593953 1878477 1 webkit-bug-importer 2022-06-27 06:10:13 -0700 <rdar://problem/95972172> 1993863 2 karlcow 2023-11-20 04:57:54 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20740 1993864 3 karlcow 2023-11-20 05:02:37 -0800 Thanks Ahmad for adding me! I had missed that bug. Simon is there a way to test this, to make extra-sure we are not breaking anything else. 1993986 4 ews-feeder 2023-11-20 14:31:15 -0800 Committed 270987@main (fc500207b6a8): <https://commits.webkit.org/270987@main> Reviewed commits have been landed. Closing PR #20740 and removing active labels. 1996174 5 zcorpan 2023-12-01 03:24:49 -0800 There are tests for passive mousewheel in https://wpt.fyi/results/dom/events/non-cancelable-when-passive?label=master&label=experimental&aligned&q=%2Fdom%2Fevents%2Fnon-cancelable-when-passive%2F 1997029 6 karlcow 2023-12-05 00:07:51 -0800 Thanks Simon for the link. These tests are failing with > promise_test: Unhandled rejection with value: object "Error: action_sequence() is not implemented by testdriver-vendor.js" which is a bug for something else. 1999225 7 gsnedders 2023-12-13 02:22:17 -0800 (In reply to Karl Dubost from comment #6) > Thanks Simon for the link. > > These tests are failing with > > > promise_test: Unhandled rejection with value: object "Error: action_sequence() is not implemented by testdriver-vendor.js" > > which is a bug for something else. when running them how? if you just load them in your browser it is expected that testdriver doesn't work, as there's no way for the browser to be controlled externally.