241660 2022-06-15 17:41:37 -0700 Make IPC::Attachment moveable on DARWIN 2022-06-19 21:26:29 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 238944 1 mattwoodrow mattwoodrow webkit-bug-importer oldest_to_newest 1876131 0 mattwoodrow 2022-06-15 17:41:37 -0700 This is the DARWIN-port specific piece of 238944. Currently Attachment just holds a mach_port_t, and doesn't attempt to do any memory management or ownership transfer of the port. This makes it very easy to leak. If we try to send an IPC message (and add the Attachment to m_attachments on Encoder), but fail to send the message, then we just leak the port. 1876132 1 webkit-bug-importer 2022-06-15 17:41:57 -0700 <rdar://problem/95253070> 1876153 2 mattwoodrow 2022-06-15 18:27:47 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1563 1876726 3 ews-feeder 2022-06-19 21:26:28 -0700 Committed r295666 (251671@main): <https://commits.webkit.org/251671@main> Reviewed commits have been landed. Closing PR #1563 and removing active labels.