24161 2009-02-25 09:35:12 -0800 listbox-deselect-scroll and listbox-selection-2 have mac specific code 2010-01-24 20:37:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 33783 33989 33994 0 sky webkit-unassigned eric tkent oldest_to_newest 110972 0 sky 2009-02-25 09:35:12 -0800 At a minimum LayoutTests/fast/forms/listbox-deselect-scroll.html should swap meta/control in the events it created. It would be nice if the cell height wasn't hard coded either, but looked up from the option. 110973 1 sky 2009-02-25 09:36:04 -0800 My comment should read, 'swap meta/control when run on windows'. 111007 2 27978 sky 2009-02-25 12:56:00 -0800 Created attachment 27978 Swaps meta/control when not run on a Mac. 111016 3 27978 eric 2009-02-25 13:11:28 -0800 Comment on attachment 27978 Swaps meta/control when not run on a Mac. This seems like the wrong way to fix this? Is this test already skipped on Apple's windows build? LayoutTests/platform/win/Skipped Maybe we already have a cleaner way to make these. 111023 4 sky 2009-02-25 13:39:19 -0800 The consensus seems to be to add a new method to event sending controller that simulates a meta click on a mac and control click on windows. 181725 5 tkent 2010-01-17 21:15:47 -0800 I'm planing to change the following eventSender functions: - eventSender.mouseDown([buttonNumber [, modifiers]]) - eventSender.mouseUp([buttonNumber [, modifiers]]) The modifiers parameter is similar to modifiers parameter of evenSender.keyDown(). It's an array of strings. A string can be - a concrete modifier key name; "ctrlKey", "shiftKey", "altKey", or "metaKey", or - a functional modifier name; "addSelectionKey", or "rangeSelectionKey". "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on Windows. "rangeSelectionKey" is an alias of "shiftKey". Comments? 181745 6 tkent 2010-01-17 23:17:22 -0800 (In reply to comment #5) > I'm planing to change the following eventSender functions: > - eventSender.mouseDown([buttonNumber [, modifiers]]) > - eventSender.mouseUp([buttonNumber [, modifiers]]) > > The modifiers parameter is similar to modifiers parameter of > evenSender.keyDown(). It's an array of strings. A string can be > - a concrete modifier key name; "ctrlKey", "shiftKey", "altKey", or > "metaKey", or > - a functional modifier name; "addSelectionKey", or "rangeSelectionKey". > "addSelectionKey" should be an alias of "metaKey" on Mac, "ctrlKey" on > Windows. > "rangeSelectionKey" is an alias of "shiftKey". I implemented it for Mac and works fine. I uploaded a patch on Bug#33783. 184146 7 tkent 2010-01-24 20:37:03 -0800 Now both of the tests should work well on non-Mac. 27978 2009-02-25 12:56:00 -0800 2009-02-25 13:11:28 -0800 Swaps meta/control when not run on a Mac. 24161.patch text/plain 1783 sky SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQxMjI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDItMjUgIFNjb3R0IFZpb2xldCAgPHNr eUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDE2MQorCisg ICAgICAgIENoYW5nZXMgdGhlIGxheW91dCB0ZXN0IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlz dGJveC1kZXNlbGVjdC1zY3JvbGwuaHRtbAorICAgICAgICB0byBzd2FwIG1ldGEvY29udHJvbCB3 aGVuIG5vdCBvbiBhIE1hYy4KKworICAgICAgICAqIGZhc3QvZm9ybXMvbGlzdGJveC1kZXNlbGVj dC1zY3JvbGwuaHRtbDoKKwogMjAwOS0wMi0yNSAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LWRlc2VsZWN0LXNjcm9sbC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlzdGJveC1kZXNlbGVjdC1zY3JvbGwuaHRtbAko cmV2aXNpb24gNDExNDkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2xpc3Rib3gtZGVzZWxl Y3Qtc2Nyb2xsLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1LDEyIEBACiAgICAgICAg ICAgICAgICAgdmFyIGJvcmRlciA9IDE7CiAgICAgICAgICAgICAgICAgdmFyIHkgPSBib3JkZXIg KyBpbmRleCAqIGl0ZW1IZWlnaHQgLSB3aW5kb3cucGFnZVlPZmZzZXQ7CiAgICAgICAgICAgICAg ICAgdmFyIGV2ZW50ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoIk1vdXNlRXZlbnQiKTsKLSAgICAg ICAgICAgICAgICBldmVudC5pbml0TW91c2VFdmVudCgibW91c2Vkb3duIiwgdHJ1ZSwgdHJ1ZSwg ZG9jdW1lbnQuZGVmYXVsdFZpZXcsIDEsIHNsLm9mZnNldExlZnQgKyBib3JkZXIsIHNsLm9mZnNl dFRvcCArIHksIHNsLm9mZnNldExlZnQgKyBib3JkZXIsIHNsLm9mZnNldFRvcCArIHksIGZhbHNl LCBmYWxzZSwgc2hpZnQsIG1ldGEsIDAsIGRvY3VtZW50KTsKKyAgICAgICAgICAgICAgICB2YXIg Y29udHJvbCA9IGZhbHNlOworICAgICAgICAgICAgICAgIGlmIChuYXZpZ2F0b3IudXNlckFnZW50 LnNlYXJjaCgvXGJNYWMgT1MgWFxiLykgPT0gLTEpIHsKKyAgICAgICAgICAgICAgICAgICAgY29u dHJvbCA9IG1ldGE7CisgICAgICAgICAgICAgICAgICAgIG1ldGEgPSBmYWxzZTsKKyAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgZXZlbnQuaW5pdE1vdXNlRXZlbnQoIm1vdXNlZG93 biIsIHRydWUsIHRydWUsIGRvY3VtZW50LmRlZmF1bHRWaWV3LCAxLCBzbC5vZmZzZXRMZWZ0ICsg Ym9yZGVyLCBzbC5vZmZzZXRUb3AgKyB5LCBzbC5vZmZzZXRMZWZ0ICsgYm9yZGVyLCBzbC5vZmZz ZXRUb3AgKyB5LCBjb250cm9sLCBmYWxzZSwgc2hpZnQsIG1ldGEsIDAsIGRvY3VtZW50KTsKICAg ICAgICAgICAgICAgICBzbC5kaXNwYXRjaEV2ZW50KGV2ZW50KTsKICAgICAgICAgICAgIH0KICAg ICAgICAgPC9zY3JpcHQ+Cg==