241517 2022-06-10 13:00:38 -0700 [webauthn] Enums should be DOMStrings 2022-08-29 13:33:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 242960 1 nsatragno pascoe pascoe timcappalli webkit-bug-importer oldest_to_newest 1875289 0 nsatragno 2022-06-10 13:00:38 -0700 WebAuthn enums should be DOMStrings instead, see the discussion on the spec [1]. If a value is not valid, it should be treated as not present (which usually means it should be converted into the default). This applies to AuthenticatorAttachment, ResidentKeyRequirement, UserVerificationRequirement, and AttestationConveyancePreference. The spec does not prescribe this, but it might be worth issuing a warning if an unknown value is detected to aid debugging. Example code: navigator.credentials.create({ publicKey: { challenge: new Uint8Array(), authenticatorSelection: { authenticatorAttachment: "not a valid member", }, rp: { name: "rp" }, user: { displayName: "display", name: "user", id: new Uint8Array() }, pubKeyCredParams: [], } }) This throws TypeError but it should instead be equivalent to having an empty authenticatorAttachment, and maybe issue a warning instead. [1] https://github.com/w3c/webauthn/issues/1738 1875290 1 webkit-bug-importer 2022-06-10 13:04:45 -0700 <rdar://problem/94835072> 1876344 2 pascoe 2022-06-16 15:50:29 -0700 We can remove AuthenticatorTransport::Cable after this. 1881190 3 pascoe 2022-07-06 16:36:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2143 1881794 4 ews-feeder 2022-07-08 15:26:42 -0700 Committed 252298@main (0ed0c27171ac): <https://commits.webkit.org/252298@main> Reviewed commits have been landed. Closing PR #2143 and removing active labels.