24151 2009-02-24 18:43:43 -0800 Fix S60 (Qt) build break 2009-07-07 21:25:22 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 27065 0 laszlo.gombos webkit-unassigned hausmann vestbo oldest_to_newest 110889 0 laszlo.gombos 2009-02-24 18:43:43 -0800 WebCore::unloadModule() is not implemented for the S60 (Qt) port. WebCore::unloadModule()should have the same implementation for the S60 Qt port as in all the non-mac and non-win ports. I would propose to create a default case and the S60 port (and possibly other non-win and non-mac ports) would just fall into the default case. Patch will follow. 110891 1 27955 laszlo.gombos 2009-02-24 18:49:57 -0800 Created attachment 27955 Create a default case for non-win and non-mac Qt builds 112187 2 27955 hausmann 2009-03-04 06:21:56 -0800 Comment on attachment 27955 Create a default case for non-win and non-mac Qt builds Nice fix and cleanup! 112188 3 hausmann 2009-03-04 06:22:30 -0800 Landed in r41419, sorry for the long turnaround :( 27955 2009-02-24 18:49:57 -0800 2009-03-04 06:21:56 -0800 Create a default case for non-win and non-mac Qt builds patch_24151.txt text/plain 2305 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTIwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDItMjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDE1MQorICAg ICAgICBGaXggUzYwIGJ1aWxkIGJyZWFrCisKKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlU3lzdGVt Lmg6IENyZWF0ZSBhIGRlZmF1bHQgY2FzZSBmb3Igbm9uLXdpbiBhbmQgbm9uLW1hYyBRdCBidWls ZHMKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwOiBEaXR0bworICAgICAg ICAoV2ViQ29yZTo6dW5sb2FkTW9kdWxlKToKKwogMjAwOS0wMi0yNCAgT2phbiBWYWZhaSAgPG9q YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHJldmlzaW9uIDQxMjA2KQorKysgV2ViQ29yZS9wbGF0Zm9y bS9GaWxlU3lzdGVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTk3LDkgKzk3LDYgQEAgY29uc3QgUGxh dGZvcm1GaWxlSGFuZGxlIGludmFsaWRQbGF0Zm9ybQogI2lmIGRlZmluZWQoUV9XU19NQUMpCiB0 eXBlZGVmIENGQnVuZGxlUmVmIFBsYXRmb3JtTW9kdWxlOwogdHlwZWRlZiB1bnNpZ25lZCBQbGF0 Zm9ybU1vZHVsZVZlcnNpb247Ci0jZWxpZiBkZWZpbmVkKFFfV1NfWDExKSB8fCBkZWZpbmVkKFFf V1NfUVdTKSB8fCBkZWZpbmVkKFFfV1NfUzYwKQotdHlwZWRlZiBRTGlicmFyeSogUGxhdGZvcm1N b2R1bGU7Ci10eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9kdWxlVmVyc2lvbjsKICNlbGlmIGRl ZmluZWQoUV9PU19XSU4pCiB0eXBlZGVmIEhNT0RVTEUgUGxhdGZvcm1Nb2R1bGU7CiBzdHJ1Y3Qg UGxhdGZvcm1Nb2R1bGVWZXJzaW9uIHsKQEAgLTExOSw2ICsxMTYsOSBAQCBzdHJ1Y3QgUGxhdGZv cm1Nb2R1bGVWZXJzaW9uIHsKICAgICB9CiAKIH07CisjZWxzZQordHlwZWRlZiBRTGlicmFyeSog UGxhdGZvcm1Nb2R1bGU7Cit0eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9kdWxlVmVyc2lvbjsK ICNlbmRpZgogCiAjZWxzZQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0LmNwcAko cmV2aXNpb24gNDEyMDYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0MywzMiArMTQzLDI0IEBAIGludCB3cml0ZVRvRmlsZShQbGF0 Zm9ybUZpbGVIYW5kbGUgaGFuZGwKICAgICByZXR1cm4gMDsKIH0KIAotI2lmIGRlZmluZWQoUV9X U19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpCiBib29sIHVubG9hZE1vZHVsZShQbGF0Zm9ybU1v ZHVsZSBtb2R1bGUpCiB7CisjaWYgZGVmaW5lZChRX1dTX01BQykKKyAgICBDRlJlbGVhc2UobW9k dWxlKTsKKyAgICByZXR1cm4gdHJ1ZTsKKworI2VsaWYgZGVmaW5lZChRX09TX1dJTikKKyAgICBy ZXR1cm4gOjpGcmVlTGlicmFyeShtb2R1bGUpOworCisjZWxzZQogICAgIGlmIChtb2R1bGUtPnVu bG9hZCgpKSB7CiAgICAgICAgIGRlbGV0ZSBtb2R1bGU7CiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KLQorICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgcmV0dXJuIGZhbHNlOwotfQog I2VuZGlmCi0KLSNpZiBkZWZpbmVkKFFfV1NfTUFDKQotYm9vbCB1bmxvYWRNb2R1bGUoUGxhdGZv cm1Nb2R1bGUgbW9kdWxlKQotewotICAgIENGUmVsZWFzZShtb2R1bGUpOwotICAgIHJldHVybiB0 cnVlOwotfQotI2VuZGlmCi0KLSNpZiBkZWZpbmVkKFFfT1NfV0lOKQotYm9vbCB1bmxvYWRNb2R1 bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQotewotICAgIHJldHVybiA6OkZyZWVMaWJyYXJ5KG1v ZHVsZSk7CiB9Ci0jZW5kaWYKIAogfQogCg==