241437 2022-06-08 13:46:27 -0700 WebGPU::ShaderModule::convertCheckResult() should use std::forward 2022-06-08 21:56:08 -0700 1 1 1 Unclassified WebKit WebGPU Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer darin dino mmaxfield webkit-bug-importer oldest_to_newest 1874797 0 ddkilzer 2022-06-08 13:46:27 -0700 WebGPU::ShaderModule::convertCheckResult() should use std::forward. Found by clang static analyzer: Source/WebGPU/WebGPU/ShaderModule.mm:125:16: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return WTFMove(check); ^ 1874798 1 webkit-bug-importer 2022-06-08 13:46:44 -0700 <rdar://problem/94662366> 1874808 2 460102 ddkilzer 2022-06-08 14:05:15 -0700 Created attachment 460102 Patch v1 1874883 3 460102 ddkilzer 2022-06-08 21:06:54 -0700 Comment on attachment 460102 Patch v1 Marking as cq+ since enough builds/tests have passed. 1874898 4 ews-feeder 2022-06-08 21:56:06 -0700 Committed r295409 (251415@main): <https://commits.webkit.org/251415@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460102. 460102 2022-06-08 14:05:15 -0700 2022-06-08 21:56:07 -0700 Patch v1 bug-241437-20220608140514.patch text/plain 1188 ddkilzer RnJvbSA1NzIzMmNjNDU4MzEwZmQwMGM1ZmNhMzFlYzU3YTYxM2Y0YjkzYTkyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogV2VkLCA4IEp1biAyMDIyIDEzOjQ3OjAxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gV2ViR1BV OjpTaGFkZXJNb2R1bGU6OmNvbnZlcnRDaGVja1Jlc3VsdCgpIHNob3VsZCB1c2UKIHN0ZDo6Zm9y d2FyZCA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjQxNDM3PiA8cmRhcjovLzk0NjYyMzY2PgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFNvdXJjZS9XZWJHUFUvV2ViR1BVL1NoYWRlck1v ZHVsZS5tbToKKFdlYkdQVTo6U2hhZGVyTW9kdWxlOjpjb252ZXJ0Q2hlY2tSZXN1bHQpOgotIFN3 aXRjaCBmcm9tIFdURk1vdmUoKSB0byBzdGQ6OmZvcndhcmQoKS4KLS0tCiBTb3VyY2UvV2ViR1BV L1dlYkdQVS9TaGFkZXJNb2R1bGUubW0gfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9T aGFkZXJNb2R1bGUubW0gYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9TaGFkZXJNb2R1bGUubW0KaW5k ZXggYjBjZjQxY2E4NmNjLi4xZTk3MzdjNzczZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJHUFUv V2ViR1BVL1NoYWRlck1vZHVsZS5tbQorKysgYi9Tb3VyY2UvV2ViR1BVL1dlYkdQVS9TaGFkZXJN b2R1bGUubW0KQEAgLTEyMiw3ICsxMjIsNyBAQCBSZWY8U2hhZGVyTW9kdWxlPiBEZXZpY2U6OmNy ZWF0ZVNoYWRlck1vZHVsZShjb25zdCBXR1BVU2hhZGVyTW9kdWxlRGVzY3JpcHRvciYgZAogYXV0 byBTaGFkZXJNb2R1bGU6OmNvbnZlcnRDaGVja1Jlc3VsdChzdGQ6OnZhcmlhbnQ8V0dTTDo6U3Vj Y2Vzc2Z1bENoZWNrLCBXR1NMOjpGYWlsZWRDaGVjaz4mJiBjaGVja1Jlc3VsdCkgLT4gQ2hlY2tS ZXN1bHQKIHsKICAgICByZXR1cm4gV1RGOjpzd2l0Y2hPbihXVEZNb3ZlKGNoZWNrUmVzdWx0KSwg W10oYXV0byYmIGNoZWNrKSAtPiBDaGVja1Jlc3VsdCB7Ci0gICAgICAgIHJldHVybiBXVEZNb3Zl KGNoZWNrKTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6Zm9yd2FyZDxkZWNsdHlwZShjaGVjayk+KGNo ZWNrKTsKICAgICB9KTsKIH0KIAotLSAKMi4zMi4wIChBcHBsZSBHaXQtMTMyKQoK