241435 2022-06-08 13:33:29 -0700 RenderImageResource::setCachedImage may produce a null renderer 2022-06-14 09:41:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok dylan esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1874789 0 zalan 2022-06-08 13:33:29 -0700 <rdar://93714107> 1874793 1 460101 zalan 2022-06-08 13:37:42 -0700 Created attachment 460101 [fast-cq]Patch 1874794 2 460101 bfulgham 2022-06-08 13:42:09 -0700 Comment on attachment 460101 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460101&action=review > Source/WebCore/rendering/RenderImageResource.cpp:67 > + // removeClient may have destroyed the renderer. Don't we still want to set the m_cachedimage value below (even though the existing renderer was possible destroyed)? 1874801 3 460101 bfulgham 2022-06-08 13:51:09 -0700 Comment on attachment 460101 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460101&action=review >> Source/WebCore/rendering/RenderImageResource.cpp:67 >> + // removeClient may have destroyed the renderer. > > Don't we still want to set the m_cachedimage value below (even though the existing renderer was possible destroyed)? I spoke to Alan offline. If 'm_renderer' is nullptr, we expect 'this' to be nullptr as well, so we should early return. 1874806 4 ews-feeder 2022-06-08 14:02:24 -0700 Committed r295393 (251399@main): <https://commits.webkit.org/251399@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460101. 1875771 5 graouts 2022-06-14 08:15:07 -0700 *** Bug 241512 has been marked as a duplicate of this bug. *** 1875779 6 simon.fraser 2022-06-14 08:49:18 -0700 Bug 241512 has a user-visible symptom, suggesting that we could create a layout test for this patch. 1875796 7 zalan 2022-06-14 09:33:25 -0700 (In reply to Simon Fraser (smfr) from comment #6) > Bug 241512 has a user-visible symptom, suggesting that we could create a > layout test for this patch. That would be awesome given the speculative nature of this fix. 1875801 8 zalan 2022-06-14 09:41:29 -0700 Yeah I can repro it (and it's <rdar://94689000>) 460101 2022-06-08 13:37:42 -0700 2022-06-08 14:02:25 -0700 [fast-cq]Patch bug-241435-20220608133741.patch text/plain 1295 zalan RnJvbSA0Njc1YTU4YTlkYjA1YmRmMTA2YTQ5NTQ1Y2E0YmMxYTgxYmNlNDg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBX ZWQsIDggSnVuIDIwMjIgMTM6MzM6NDIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBSZW5kZXJJbWFn ZVJlc291cmNlOjpzZXRDYWNoZWRJbWFnZSBtYXkgcHJvZHVjZSBhIG51bGwKIHJlbmRlcmVyIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDE0MzUgPHJkYXI6Ly85Mzcx NDEwNz4KClJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgoKVGhpcyBpcyBhIHNwZWN1bGF0aXZl IGZpeCB0byBhZGRyZXNzIG51bGwgZGVyZWYgb24gdGhlIHJlbmRlcmVyLgoKKiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2VSZXNvdXJjZS5jcHA6CihXZWJDb3JlOjpSZW5kZXJJ bWFnZVJlc291cmNlOjpzZXRDYWNoZWRJbWFnZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckltYWdlUmVzb3VyY2UuY3BwIHwgNCArKysrCiAxIGZpbGUgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckltYWdlUmVzb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdl UmVzb3VyY2UuY3BwCmluZGV4IDhmMmU5YjYxYjQ0NC4uNDhhNGY2ZGE0M2NlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2VSZXNvdXJjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlUmVzb3VyY2UuY3BwCkBAIC02Myw2 ICs2MywxMCBAQCB2b2lkIFJlbmRlckltYWdlUmVzb3VyY2U6OnNldENhY2hlZEltYWdlKENhY2hl ZEltYWdlKiBuZXdJbWFnZSkKIAogICAgIGlmIChtX2NhY2hlZEltYWdlICYmIG1fcmVuZGVyZXIg JiYgbV9jYWNoZWRJbWFnZVJlbW92ZUNsaWVudElzTmVlZGVkKQogICAgICAgICBtX2NhY2hlZElt YWdlLT5yZW1vdmVDbGllbnQoKm1fcmVuZGVyZXIpOworICAgIGlmICghbV9yZW5kZXJlcikgewor ICAgICAgICAvLyByZW1vdmVDbGllbnQgbWF5IGhhdmUgZGVzdHJveWVkIHRoZSByZW5kZXJlci4K KyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICBtX2NhY2hlZEltYWdlID0gbmV3SW1hZ2U7CiAg ICAgbV9jYWNoZWRJbWFnZVJlbW92ZUNsaWVudElzTmVlZGVkID0gdHJ1ZTsKICAgICBpZiAoIW1f Y2FjaGVkSW1hZ2UpCi0tIAoyLjMyLjAgKEFwcGxlIEdpdC0xMzIpCgo=