241426 2022-06-08 10:52:52 -0700 WTF::CrossThreadCopierBase::copy() should use std::forward 2022-06-08 16:27:07 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1874758 0 ddkilzer 2022-06-08 10:52:52 -0700 WTF::CrossThreadCopierBase::copy() should use std::forward. Found by clang static analyzer: In file included from OpenSource/Source/WTF/wtf/Language.cpp:29: OpenSource/Source/WTF/wtf/CrossThreadCopier.h:225:106: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return CrossThreadCopier<std::remove_const_t<std::remove_reference_t<decltype(type)>>>::copy(WTFMove(type)); ^ 1874759 1 webkit-bug-importer 2022-06-08 10:53:27 -0700 <rdar://problem/94648592> 1874763 2 460098 ddkilzer 2022-06-08 10:57:51 -0700 Created attachment 460098 Patch v1 1874822 3 460098 ddkilzer 2022-06-08 15:00:39 -0700 Comment on attachment 460098 Patch v1 Marking cq+ as enough builds and test runs have completed that I think it's safe to land this. 1874849 4 ews-feeder 2022-06-08 16:27:04 -0700 Committed r295400 (251406@main): <https://commits.webkit.org/251406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460098. 460098 2022-06-08 10:57:51 -0700 2022-06-08 16:27:05 -0700 Patch v1 bug-241426-20220608105750.patch text/plain 1291 ddkilzer RnJvbSAwODIxMzRiYmVmOGJlZWI2NThmODAyOGI1NDllNjFjYTIzNzE4OWY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogV2VkLCA4IEp1biAyMDIyIDEwOjQ5OjM3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gV1RGOjpD cm9zc1RocmVhZENvcGllckJhc2U6OmNvcHkoKSBzaG91bGQgdXNlIHN0ZDo6Zm9yd2FyZAogPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzI0MTQyNj4gPHJkYXI6Ly85NDY0ODU5Mj4KClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKKiBTb3VyY2UvV1RGL3d0Zi9Dcm9zc1RocmVhZENvcGllci5oOgoo V1RGOjpDcm9zc1RocmVhZENvcGllckJhc2U6OmNvcHkpOgotIFN3aXRjaCBmcm9tIFdURk1vdmUo KSB0byBzdGQ6OmZvcndhcmQoKS4KLS0tCiBTb3VyY2UvV1RGL3d0Zi9Dcm9zc1RocmVhZENvcGll ci5oIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ3Jvc3NUaHJlYWRDb3BpZXIuaCBiL1NvdXJj ZS9XVEYvd3RmL0Nyb3NzVGhyZWFkQ29waWVyLmgKaW5kZXggNDFlMTFiMzY1NzdkLi5hOGNmNGFj YTkwYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Nyb3NzVGhyZWFkQ29waWVyLmgKKysr IGIvU291cmNlL1dURi93dGYvQ3Jvc3NUaHJlYWRDb3BpZXIuaApAQCAtMjIyLDcgKzIyMiw3IEBA IHRlbXBsYXRlPHR5cGVuYW1lLi4uIFR5cGVzPiBzdHJ1Y3QgQ3Jvc3NUaHJlYWRDb3BpZXJCYXNl PGZhbHNlLCBmYWxzZSwgc3RkOjp2YXJpCiAgICAgc3RhdGljIHN0ZDo6dmFyaWFudDxUeXBlcy4u Lj4gY29weShUeXBlJiYgc291cmNlKQogICAgIHsKICAgICAgICAgcmV0dXJuIHN0ZDo6dmlzaXQo W10gKGF1dG8mJiB0eXBlKSAtPiBzdGQ6OnZhcmlhbnQ8VHlwZXMuLi4+IHsKLSAgICAgICAgICAg IHJldHVybiBDcm9zc1RocmVhZENvcGllcjxzdGQ6OnJlbW92ZV9jb25zdF90PHN0ZDo6cmVtb3Zl X3JlZmVyZW5jZV90PGRlY2x0eXBlKHR5cGUpPj4+Ojpjb3B5KFdURk1vdmUodHlwZSkpOworICAg ICAgICAgICAgcmV0dXJuIENyb3NzVGhyZWFkQ29waWVyPHN0ZDo6cmVtb3ZlX2NvbnN0X3Q8c3Rk OjpyZW1vdmVfcmVmZXJlbmNlX3Q8ZGVjbHR5cGUodHlwZSk+Pj46OmNvcHkoc3RkOjpmb3J3YXJk PGRlY2x0eXBlKHR5cGUpPih0eXBlKSk7CiAgICAgICAgIH0sIFdURk1vdmUoc291cmNlKSk7CiAg ICAgfQogfTsKLS0gCjIuMzIuMCAoQXBwbGUgR2l0LTEzMikKCg==