24141 2009-02-24 15:34:38 -0800 Add clarity to V8 interceptor helper function. 2009-02-25 13:18:18 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov tony oldest_to_newest 110842 0 dglazkov 2009-02-24 15:34:38 -0800 By renaming it to notHandledByInterceptor! 110843 1 27939 dglazkov 2009-02-24 15:38:50 -0800 Created attachment 27939 Add clarity to V8 interceptor helper function, v1. WebCore/ChangeLog | 13 +++++++++++++ .../v8/custom/V8HTMLPlugInElementCustom.cpp | 16 ++++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-) 110848 2 27939 eric 2009-02-24 16:03:06 -0800 Comment on attachment 27939 Add clarity to V8 interceptor helper function, v1. OK. 110856 3 dglazkov 2009-02-24 16:14:42 -0800 Landed as http://trac.webkit.org/changeset/41196. 111002 4 tony 2009-02-25 12:32:11 -0800 Should there be a change to V8Proxy.h to reflect the function rename? 111018 5 dglazkov 2009-02-25 13:18:18 -0800 I landed it downstream. I intentionally keep V8Proxy.h from landing upstream until all of the custom bindings are done and it actually replaces v8_proxy.h. To keep it loose, y'know? 27939 2009-02-24 15:38:50 -0800 2009-02-24 16:03:06 -0800 Add clarity to V8 interceptor helper function, v1. Add-clarity-to-V8-interceptor-helper-function-v1..patch text/plain 3408 dglazkov NmEwYjk2OGJmYjZhYjZlZjFkODAwZjM4MTZhYzNjNWJhZGZhMTE1NwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYmUxZDRjLi41YjgwMzUz IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTAyLTI0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTQxCisgICAg ICAgIEFkZCBjbGFyaXR5IHRvIFY4IGludGVyY2VwdG9yIGhlbHBlciBmdW5jdGlvbi4KKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok5BTUVEX1BST1BFUlRZX0dFVFRFUik6IFJlbmFtZWQgdG8gbm90 SGFuZGxlZEJ5SW50ZXJjZXB0b3IuCisgICAgICAgIChXZWJDb3JlOjpOQU1FRF9QUk9QRVJUWV9T RVRURVIpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OklOREVYRURfUFJPUEVSVFlfR0VUVEVS KTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpJTkRFWEVEX1BST1BFUlRZX1NFVFRFUik6IERp dHRvLgorCiAyMDA5LTAyLTI0ICBNYXJrIE1lbnRvdmFpICA8bWFya0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxQbHVnSW5FbGVtZW50Q3VzdG9tLmNwcCBiL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTFBsdWdJbkVsZW1lbnRDdXN0b20uY3BwCmluZGV4IDRj ZDE5ZDIuLmE2ZTQxYTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 SFRNTFBsdWdJbkVsZW1lbnRDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SFRNTFBsdWdJbkVsZW1lbnRDdXN0b20uY3BwCkBAIC00OCwxMSArNDgsMTEgQEAgTkFN RURfUFJPUEVSVFlfR0VUVEVSKEhUTUxQbHVnSW5FbGVtZW50KQogICAgIEhUTUxQbHVnSW5FbGVt ZW50KiBpbXAgPSBWOFByb3h5OjpET01XcmFwcGVyVG9Ob2RlPEhUTUxQbHVnSW5FbGVtZW50Pihp bmZvLkhvbGRlcigpKTsKICAgICBTY3JpcHRJbnN0YW5jZSBzY3JpcHRJbnN0YW5jZSA9IGltcC0+ Z2V0SW5zdGFuY2UoKTsKICAgICBpZiAoIXNjcmlwdEluc3RhbmNlKQotICAgICAgICByZXR1cm4g ZGVmZXJUb0ludGVyY2VwdG9yKCk7CisgICAgICAgIHJldHVybiBub3RIYW5kbGVkQnlJbnRlcmNl cHRvcigpOwogCiAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGluc3RhbmNlID0gdjg6OkxvY2Fs PHY4OjpPYmplY3Q+OjpOZXcoc2NyaXB0SW5zdGFuY2UtPmluc3RhbmNlKCkpOwogICAgIGlmIChp bnN0YW5jZS5Jc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiBkZWZlclRvSW50ZXJjZXB0b3IoKTsK KyAgICAgICAgcmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAKICAgICByZXR1cm4g TlBPYmplY3RHZXROYW1lZFByb3BlcnR5KGluc3RhbmNlLCBuYW1lKTsKIH0KQEAgLTYzLDExICs2 MywxMSBAQCBOQU1FRF9QUk9QRVJUWV9TRVRURVIoSFRNTFBsdWdJbkVsZW1lbnQpCiAgICAgSFRN TFBsdWdJbkVsZW1lbnQqIGltcCA9IFY4UHJveHk6OkRPTVdyYXBwZXJUb05vZGU8SFRNTFBsdWdJ bkVsZW1lbnQ+KGluZm8uSG9sZGVyKCkpOwogICAgIFNjcmlwdEluc3RhbmNlIHNjcmlwdEluc3Rh bmNlID0gaW1wLT5nZXRJbnN0YW5jZSgpOwogICAgIGlmICghc2NyaXB0SW5zdGFuY2UpCi0gICAg ICAgIHJldHVybiBkZWZlclRvSW50ZXJjZXB0b3IoKTsKKyAgICAgICAgcmV0dXJuIG5vdEhhbmRs ZWRCeUludGVyY2VwdG9yKCk7CiAKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gaW5zdGFuY2Ug PSB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyhzY3JpcHRJbnN0YW5jZS0+aW5zdGFuY2UoKSk7 CiAgICAgaWYgKGluc3RhbmNlLklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIGRlZmVyVG9JbnRl cmNlcHRvcigpOworICAgICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAog ICAgIHJldHVybiBOUE9iamVjdFNldE5hbWVkUHJvcGVydHkoaW5zdGFuY2UsIG5hbWUsIHZhbHVl KTsKIH0KQEAgLTg0LDExICs4NCwxMSBAQCBJTkRFWEVEX1BST1BFUlRZX0dFVFRFUihIVE1MUGx1 Z0luRWxlbWVudCkKICAgICBIVE1MUGx1Z0luRWxlbWVudCogaW1wID0gVjhQcm94eTo6RE9NV3Jh cHBlclRvTm9kZTxIVE1MUGx1Z0luRWxlbWVudD4oaW5mby5Ib2xkZXIoKSk7CiAgICAgU2NyaXB0 SW5zdGFuY2Ugc2NyaXB0SW5zdGFuY2UgPSBpbXAtPmdldEluc3RhbmNlKCk7CiAgICAgaWYgKCFz Y3JpcHRJbnN0YW5jZSkKLSAgICAgICAgcmV0dXJuIGRlZmVyVG9JbnRlcmNlcHRvcigpOworICAg ICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAogICAgIHY4OjpMb2NhbDx2 ODo6T2JqZWN0PiBpbnN0YW5jZSA9IHY4OjpMb2NhbDx2ODo6T2JqZWN0Pjo6TmV3KHNjcmlwdElu c3RhbmNlLT5pbnN0YW5jZSgpKTsKICAgICBpZiAoaW5zdGFuY2UuSXNFbXB0eSgpKQotICAgICAg ICByZXR1cm4gZGVmZXJUb0ludGVyY2VwdG9yKCk7CisgICAgICAgIHJldHVybiBub3RIYW5kbGVk QnlJbnRlcmNlcHRvcigpOwogCiAgICAgcmV0dXJuIE5QT2JqZWN0R2V0SW5kZXhlZFByb3BlcnR5 KGluc3RhbmNlLCBpbmRleCk7CiB9CkBAIC05OSwxMSArOTksMTEgQEAgSU5ERVhFRF9QUk9QRVJU WV9TRVRURVIoSFRNTFBsdWdJbkVsZW1lbnQpCiAgICAgSFRNTFBsdWdJbkVsZW1lbnQqIGltcCA9 IFY4UHJveHk6OkRPTVdyYXBwZXJUb05vZGU8SFRNTFBsdWdJbkVsZW1lbnQ+KGluZm8uSG9sZGVy KCkpOwogICAgIFNjcmlwdEluc3RhbmNlIHNjcmlwdEluc3RhbmNlID0gaW1wLT5nZXRJbnN0YW5j ZSgpOwogICAgIGlmICghc2NyaXB0SW5zdGFuY2UpCi0gICAgICAgIHJldHVybiBkZWZlclRvSW50 ZXJjZXB0b3IoKTsKKyAgICAgICAgcmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAK ICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gaW5zdGFuY2UgPSB2ODo6TG9jYWw8djg6Ok9iamVj dD46Ok5ldyhzY3JpcHRJbnN0YW5jZS0+aW5zdGFuY2UoKSk7CiAgICAgaWYgKGluc3RhbmNlLklz RW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIGRlZmVyVG9JbnRlcmNlcHRvcigpOworICAgICAgICBy ZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAogICAgIHJldHVybiBOUE9iamVjdFNl dEluZGV4ZWRQcm9wZXJ0eShpbnN0YW5jZSwgaW5kZXgsIHZhbHVlKTsKIH0K