24139 2009-02-24 14:39:55 -0800 ScriptInstance.h missing an #include 2009-02-24 15:23:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 24109 1 mark mark dglazkov eric oldest_to_newest 110826 0 mark 2009-02-24 14:39:55 -0800 There's an #include missing in WebCore/bindings/v8/ScriptInstance.h. The file uses RefPtr.h and so should #include <wtf/RefPtr.h>. Dimitri, you broke my build! 110827 1 27937 mark 2009-02-24 14:43:02 -0800 Created attachment 27937 fix 110829 2 27937 eric 2009-02-24 14:53:04 -0800 Comment on attachment 27937 fix Looks OK. 110835 3 dglazkov 2009-02-24 15:15:43 -0800 I break builds because it gives me false sense of power which offers momentary relief of the overwhelming feeling of insecurity. BTW, why are you using these? I haven't updated the projects to use them yet :) 110836 4 mark 2009-02-24 15:17:13 -0800 The gyp-based build is not bound by your puny project files. I look for added files after WebKit merges and add them. It's the only way to keep myself green. 110838 5 dglazkov 2009-02-24 15:18:40 -0800 Well, be careful young Jedi. The files in bindings/v8/custom lack corresponding inliners in V8Proxy, which I haven't yet landed. 110839 6 mark 2009-02-24 15:21:17 -0800 Thanks, I'll pull them back out if I have to. I was wondering how the missing #include didn't break any of the "proper" builds. This change should still be checked in. 110841 7 dglazkov 2009-02-24 15:23:10 -0800 Landed as http://trac.webkit.org/changeset/41194. 27937 2009-02-24 14:43:02 -0800 2009-02-24 14:53:04 -0800 fix 24139.1.patch text/plain 876 mark SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTE5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDItMjQgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMzkKKworICAgICAgICBB ZGQgbWlzc2luZyAjaW5jbHVkZS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdEluc3Rh bmNlLmg6CisKIDIwMDktMDItMDUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4gYW5k IEVyaWMgU2VpZGVsIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0SW5zdGFuY2UuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEluc3RhbmNlLmgJKHJldmlzaW9u IDQxMTg4KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRJbnN0YW5jZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zNSw2ICszNSw3IEBACiAKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgog I2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAK