241386 2022-06-07 15:37:39 -0700 Set protections on MAP_ALIGNED platforms too for WTF::OSAllocator::tryReserveUncommittedAligned 2022-06-08 09:32:13 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All Other RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236460 InRadar P2 Normal --- 1 iamleot+webkit-bugzilla webkit-unassigned benjamin cdumez cmarcelo ews-watchlist iamleot+webkit-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1874589 0 iamleot+webkit-bugzilla 2022-06-07 15:37:39 -0700 Since 247105@main when tryReserveUncommittedAligned() on Unix-like platforms that supports MAP_ALIGNED (except macOS and Linux) pages are initially mmap-ed via PROT_NONE but then the protections are never readjusted. At least in NetBSD running jsc, e.g. via `jsc -e 0', it ends up in a SIGSEGV. 1874590 1 460075 iamleot+webkit-bugzilla 2022-06-07 15:39:13 -0700 Created attachment 460075 REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too Since the introduction of tryReserveUncommittedAligned() on platforms that have MAP_ALIGNED via 247105@main, reserved pages via that function never had the protections adjusted and will likely ends up in SIGSEGV. 1874591 2 iamleot+webkit-bugzilla 2022-06-07 15:43:59 -0700 After this patch and https://bugs.webkit.org/show_bug.cgi?id=241386 is applied jsc should build and runs on NetBSD too without any further patches. 1874592 3 460075 iamleot+webkit-bugzilla 2022-06-07 15:44:45 -0700 Comment on attachment 460075 REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too Mark it as ready for review. 1874717 4 ysuzuki 2022-06-08 08:02:22 -0700 @Leonardo Also I recommend joining WebKit slack from https://webkit.org/getting-started/ And joining #jsc / #reviews channel. There are JSC reviewers you can ask for reviews :) 1874719 5 iamleot+webkit-bugzilla 2022-06-08 08:17:15 -0700 Great suggestion! I'm there too now! :) Thank you very much Yusuke! 1874726 6 460075 ysuzuki 2022-06-08 08:42:49 -0700 Comment on attachment 460075 REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too r=me 1874730 7 ews-feeder 2022-06-08 09:31:30 -0700 Committed r295382 (251390@main): <https://commits.webkit.org/251390@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460075. 1874731 8 webkit-bug-importer 2022-06-08 09:32:13 -0700 <rdar://problem/94641219> 460075 2022-06-07 15:39:13 -0700 2022-06-08 09:31:31 -0700 REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too 0001-REGRESSION-247105-main-Set-protections-on-MAP_ALIGNE.patch text/plain 1756 iamleot+webkit-bugzilla RnJvbSAxODg0MTk1YmZhOTljNDE1YjViNDFmYjczMDczNjM5OTI1MDg3OGQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW9uYXJkbyBUYWNjYXJpIDxsZW90QE5ldEJTRC5vcmc+CkRh dGU6IFR1ZSwgNyBKdW4gMjAyMiAyMzoxMzoyOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFJFR1JF U1NJT04oMjQ3MTA1QG1haW4pOiBTZXQgcHJvdGVjdGlvbnMgb24gTUFQX0FMSUdORUQKIHBsYXRm b3JtcyB0b28gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTM4NgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpTaW5jZSB0aGUgaW50cm9kdWN0aW9uIG9mIHRy eVJlc2VydmVVbmNvbW1pdHRlZEFsaWduZWQoKSBvbiBwbGF0Zm9ybXMKdGhhdCBoYXZlIE1BUF9B TElHTkVEIHZpYSAyNDcxMDVAbWFpbiwgcmVzZXJ2ZWQgcGFnZXMgdmlhIHRoYXQKZnVuY3Rpb24g bmV2ZXIgaGFkIHRoZSBwcm90ZWN0aW9ucyBhZGp1c3RlZCBhbmQgd2lsbCBsaWtlbHkgZW5kcwp1 cCBpbiBTSUdTRUdWLgoKKiBTb3VyY2UvV1RGL3d0Zi9wb3NpeC9PU0FsbG9jYXRvclBPU0lYLmNw cDoKKFdURjo6T1NBbGxvY2F0b3I6OnRyeVJlc2VydmVVbmNvbW1pdHRlZEFsaWduZWQpOgotLS0K IFNvdXJjZS9XVEYvd3RmL3Bvc2l4L09TQWxsb2NhdG9yUE9TSVguY3BwIHwgMTAgKysrKysrKy0t LQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9wb3NpeC9PU0FsbG9jYXRvclBPU0lYLmNwcCBiL1NvdXJj ZS9XVEYvd3RmL3Bvc2l4L09TQWxsb2NhdG9yUE9TSVguY3BwCmluZGV4IDMxM2U2NWEyNGM4Yi4u YTFjMGQxOWY5Y2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9wb3NpeC9PU0FsbG9jYXRv clBPU0lYLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9wb3NpeC9PU0FsbG9jYXRvclBPU0lYLmNw cApAQCAtMTgzLDExICsxODMsMTUgQEAgdm9pZCogT1NBbGxvY2F0b3I6OnRyeVJlc2VydmVVbmNv bW1pdHRlZEFsaWduZWQoc2l6ZV90IGJ5dGVzLCBzaXplX3QgYWxpZ25tZW50LAogI2RlZmluZSBN QVBfTk9SRVNFUlZFIDAKICNlbmRpZgogICAgIFVOVVNFRF9QQVJBTSh1c2FnZSk7Ci0gICAgVU5V U0VEX1BBUkFNKHdyaXRhYmxlKTsKLSAgICBVTlVTRURfUEFSQU0oZXhlY3V0YWJsZSk7CiAgICAg VU5VU0VEX1BBUkFNKGppdENhZ2VFbmFibGVkKTsKICAgICBVTlVTRURfUEFSQU0oaW5jbHVkZXNH dWFyZFBhZ2VzKTsKLSAgICB2b2lkKiByZXN1bHQgPSBtbWFwKDAsIGJ5dGVzLCBQUk9UX05PTkUs IE1BUF9OT1JFU0VSVkUgfCBNQVBfUFJJVkFURSB8IE1BUF9BTk9OIHwgTUFQX0FMSUdORUQoZ2V0 TFNCU2V0KGFsaWdubWVudCkpLCAtMSwgMCk7CisgICAgaW50IHByb3RlY3Rpb24gPSBQUk9UX1JF QUQ7CisgICAgaWYgKHdyaXRhYmxlKQorICAgICAgICBwcm90ZWN0aW9uIHw9IFBST1RfV1JJVEU7 CisgICAgaWYgKGV4ZWN1dGFibGUpCisgICAgICAgIHByb3RlY3Rpb24gfD0gUFJPVF9FWEVDOwor CisgICAgdm9pZCogcmVzdWx0ID0gbW1hcCgwLCBieXRlcywgcHJvdGVjdGlvbiwgTUFQX05PUkVT RVJWRSB8IE1BUF9QUklWQVRFIHwgTUFQX0FOT04gfCBNQVBfQUxJR05FRChnZXRMU0JTZXQoYWxp Z25tZW50KSksIC0xLCAwKTsKICAgICBpZiAocmVzdWx0ID09IE1BUF9GQUlMRUQpCiAgICAgICAg IHJldHVybiBudWxscHRyOwogICAgIGlmIChyZXN1bHQpCi0tIAoyLjM2LjEKCg==