241369 2022-06-07 07:56:34 -0700 [JSC][ARMv7] Don't save CSRs respected by the JIT ABI on VM entry 2022-06-09 04:31:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 glore webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer xan.lopez oldest_to_newest 1874496 0 glore 2022-06-07 07:56:34 -0700 Patch incoming. 1874506 1 460062 glore 2022-06-07 08:59:51 -0700 Created attachment 460062 Patch 1874534 2 460062 mark.lam 2022-06-07 11:25:57 -0700 Comment on attachment 460062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460062&action=review r=me with comment fix up. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:776 > + # but are not in RegisterSet::vmCalleeSaveRegisters() need to be saved here. > + # I.e.: Only those registers that are callee save in the C ABI, but are not > + # callee save in teh JIT ABI. nit: "here. I.e.: Only" -> "here i.e. only". /teh/the/ 1874944 3 460118 glore 2022-06-09 02:56:37 -0700 Created attachment 460118 Patch 1874945 4 460119 glore 2022-06-09 02:58:11 -0700 Created attachment 460119 Patch 1874956 5 ews-feeder 2022-06-09 04:30:53 -0700 Committed r295416 (251422@main): <https://commits.webkit.org/251422@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460119. 1874957 6 webkit-bug-importer 2022-06-09 04:31:16 -0700 <rdar://problem/94713078> 460062 2022-06-07 08:59:51 -0700 2022-06-09 02:56:32 -0700 Patch bug-241369-20220607155949.patch text/plain 2411 glore RnJvbSAxZGUzNjNhMDM4ZjhhYzU2MzUzMWJlYmMwZjU0OTM5MWJmNjc0ODhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXphIExvcmUgPGdsb3JlQGlnYWxpYS5jb20+CkRhdGU6IFR1 ZSwgNyBKdW4gMjAyMiAxNDo1NDo1OSArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIFtKU0NdW0FSTXY3 XSBEb24ndCBzYXZlIENTUnMgcmVzcGVjdGVkIGJ5IHRoZSBKSVQgQUJJLgoKaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTM2OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpJdCBpcyBub3QgbmVjZXNzYXJ5IHRvIHNhdmUgYW5kIHJlc3RvcmUgQ1NScyByZXNw ZWN0ZWQgYnkgdGhlIEpJVCBBQkkgb24KVk0gZW50cnkvZXhpdC4gVGhlIGNvbXBpbGVyIHdpbGwg cHJlc2VydmUgdGhlbS4gKHIxMCBhbmQgcjExIG9uIEFSTXY3LikKCiogU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgotLS0KIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSB8IDEwICsrKysrKystLS0KIDEg ZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCmluZGV4 IGZkNDcyNTMzNTUzYi4uMjhkNGNiZTI4Yjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC03NTYsNyArNzU2LDcgQEAg ZW5kCiBpZiBDX0xPT1Agb3IgQ19MT09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0 IG9yIFg4Nl82NF9XSU4gb3IgUklTQ1Y2NAogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNv dW50ID0gMAogZWxzaWYgQVJNdjcKLSAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9 IDcgKyAyICogMSAvLyA3IDMyLWJpdCBHUFJzICsgMSA2NC1iaXQgRlBSCisgICAgY29uc3QgQ2Fs bGVlU2F2ZVJlZ2lzdGVyQ291bnQgPSA1ICsgMiAqIDEgLy8gNSAzMi1iaXQgR1BScyArIDEgNjQt Yml0IEZQUgogZWxzaWYgTUlQUwogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0g MwogZWxzaWYgWDg2IG9yIFg4Nl9XSU4KQEAgLTc3MCwxMCArNzcwLDE0IEBAIGNvbnN0IENhbGxl ZVJlZ2lzdGVyU2F2ZVNpemUgPSBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCAqIE1hY2hpbmVSZWdp c3RlclNpemUKIGNvbnN0IFZNRW50cnlUb3RhbEZyYW1lU2l6ZSA9IChDYWxsZWVSZWdpc3RlclNh dmVTaXplICsgc2l6ZW9mIFZNRW50cnlSZWNvcmQgKyBTdGFja0FsaWdubWVudCAtIDEpICYgflN0 YWNrQWxpZ25tZW50TWFzawogCiBtYWNybyBwdXNoQ2FsbGVlU2F2ZXMoKQorICAgICMgTm90ZTog T25seSByZWdpc3RlcnMgdGhhdCBhcmUgaW4gUmVnaXN0ZXJTZXQ6OmNhbGxlZVNhdmVSZWdpc3Rl cnMoKSwKKyAgICAjIGJ1dCBhcmUgbm90IGluIFJlZ2lzdGVyU2V0Ojp2bUNhbGxlZVNhdmVSZWdp c3RlcnMoKSBuZWVkIHRvIGJlIHNhdmVkIGhlcmUuCisgICAgIyBJLmUuOiBPbmx5IHRob3NlIHJl Z2lzdGVycyB0aGF0IGFyZSBjYWxsZWUgc2F2ZSBpbiB0aGUgQyBBQkksIGJ1dCBhcmUgbm90Cisg ICAgIyBjYWxsZWUgc2F2ZSBpbiB0ZWggSklUIEFCSS4KICAgICBpZiBDX0xPT1Agb3IgQ19MT09Q X1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4gb3IgUklTQ1Y2 NAogICAgIGVsc2lmIEFSTXY3CiAgICAgICAgIGVtaXQgInZwdXNoLjY0IHtkMTV9IgotICAgICAg ICBlbWl0ICJwdXNoIHtyNC1yNiwgcjgtcjExfSIKKyAgICAgICAgZW1pdCAicHVzaCB7cjQtcjYs IHI4LXI5fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImFkZGl1ICRzcCwgJHNwLCAt MTIiCiAgICAgICAgIGVtaXQgInN3ICRzMCwgMCgkc3ApIiAjIGNzcjAvbWV0YURhdGEKQEAgLTc5 NSw3ICs3OTksNyBAQCBlbmQKIG1hY3JvIHBvcENhbGxlZVNhdmVzKCkKICAgICBpZiBDX0xPT1Ag b3IgQ19MT09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4g b3IgUklTQ1Y2NAogICAgIGVsc2lmIEFSTXY3Ci0gICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4 LXIxMX0iCisgICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4LXI5fSIKICAgICAgICAgZW1pdCAi dnBvcC42NCB7ZDE1fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImx3ICRzMCwgMCgk c3ApIgotLSAKMi4zMC4yCgo= 460118 2022-06-09 02:56:37 -0700 2022-06-09 02:58:05 -0700 Patch bug-241369-20220609095636.patch text/plain 2411 glore RnJvbSA2ZmUzNmZmMjIwYjVlZWM3YjQ1MjMzNzI5MGQyYzBlYjlkMGY0ODA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXphIExvcmUgPGdsb3JlQGlnYWxpYS5jb20+CkRhdGU6IFR1 ZSwgNyBKdW4gMjAyMiAxNDo1NDo1OSArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIFtKU0NdW0FSTXY3 XSBEb24ndCBzYXZlIENTUnMgcmVzcGVjdGVkIGJ5IHRoZSBKSVQgQUJJLgoKaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTM2OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpJdCBpcyBub3QgbmVjZXNzYXJ5IHRvIHNhdmUgYW5kIHJlc3RvcmUgQ1NScyByZXNw ZWN0ZWQgYnkgdGhlIEpJVCBBQkkgb24KVk0gZW50cnkvZXhpdC4gVGhlIGNvbXBpbGVyIHdpbGwg cHJlc2VydmUgdGhlbS4gKHIxMCBhbmQgcjExIG9uIEFSTXY3LikKCiogU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgotLS0KIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSB8IDEwICsrKysrKystLS0KIDEg ZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCmluZGV4 IGZkNDcyNTMzNTUzYi4uYzYxNjc4YTU0M2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC03NTYsNyArNzU2LDcgQEAg ZW5kCiBpZiBDX0xPT1Agb3IgQ19MT09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0 IG9yIFg4Nl82NF9XSU4gb3IgUklTQ1Y2NAogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNv dW50ID0gMAogZWxzaWYgQVJNdjcKLSAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9 IDcgKyAyICogMSAvLyA3IDMyLWJpdCBHUFJzICsgMSA2NC1iaXQgRlBSCisgICAgY29uc3QgQ2Fs bGVlU2F2ZVJlZ2lzdGVyQ291bnQgPSA1ICsgMiAqIDEgLy8gNSAzMi1iaXQgR1BScyArIDEgNjQt Yml0IEZQUgogZWxzaWYgTUlQUwogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0g MwogZWxzaWYgWDg2IG9yIFg4Nl9XSU4KQEAgLTc3MCwxMCArNzcwLDE0IEBAIGNvbnN0IENhbGxl ZVJlZ2lzdGVyU2F2ZVNpemUgPSBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCAqIE1hY2hpbmVSZWdp c3RlclNpemUKIGNvbnN0IFZNRW50cnlUb3RhbEZyYW1lU2l6ZSA9IChDYWxsZWVSZWdpc3RlclNh dmVTaXplICsgc2l6ZW9mIFZNRW50cnlSZWNvcmQgKyBTdGFja0FsaWdubWVudCAtIDEpICYgflN0 YWNrQWxpZ25tZW50TWFzawogCiBtYWNybyBwdXNoQ2FsbGVlU2F2ZXMoKQorICAgICMgTm90ZTog T25seSByZWdpc3RlcnMgdGhhdCBhcmUgaW4gUmVnaXN0ZXJTZXQ6OmNhbGxlZVNhdmVSZWdpc3Rl cnMoKSwKKyAgICAjIGJ1dCBhcmUgbm90IGluIFJlZ2lzdGVyU2V0Ojp2bUNhbGxlZVNhdmVSZWdp c3RlcnMoKSBuZWVkIHRvIGJlIHNhdmVkIGhlcmUsCisgICAgIyBpLmUuOiBvbmx5IHRob3NlIHJl Z2lzdGVycyB0aGF0IGFyZSBjYWxsZWUgc2F2ZSBpbiB0aGUgQyBBQkksIGJ1dCBhcmUgbm90Cisg ICAgIyBjYWxsZWUgc2F2ZSBpbiB0aGUgSklUIEFCSS4KICAgICBpZiBDX0xPT1Agb3IgQ19MT09Q X1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4gb3IgUklTQ1Y2 NAogICAgIGVsc2lmIEFSTXY3CiAgICAgICAgIGVtaXQgInZwdXNoLjY0IHtkMTV9IgotICAgICAg ICBlbWl0ICJwdXNoIHtyNC1yNiwgcjgtcjExfSIKKyAgICAgICAgZW1pdCAicHVzaCB7cjQtcjYs IHI4LXI5fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImFkZGl1ICRzcCwgJHNwLCAt MTIiCiAgICAgICAgIGVtaXQgInN3ICRzMCwgMCgkc3ApIiAjIGNzcjAvbWV0YURhdGEKQEAgLTc5 NSw3ICs3OTksNyBAQCBlbmQKIG1hY3JvIHBvcENhbGxlZVNhdmVzKCkKICAgICBpZiBDX0xPT1Ag b3IgQ19MT09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4g b3IgUklTQ1Y2NAogICAgIGVsc2lmIEFSTXY3Ci0gICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4 LXIxMX0iCisgICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4LXI5fSIKICAgICAgICAgZW1pdCAi dnBvcC42NCB7ZDE1fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImx3ICRzMCwgMCgk c3ApIgotLSAKMi4zMC4yCgo= 460119 2022-06-09 02:58:11 -0700 2022-06-09 04:30:55 -0700 Patch bug-241369-20220609095810.patch text/plain 2405 glore RnJvbSBhZDNkYTI3NWFiZThjYjQ3NjdlZTU5NGUwMjczYTk4ZDg5Yjc2NTQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZXphIExvcmUgPGdsb3JlQGlnYWxpYS5jb20+CkRhdGU6IFR1 ZSwgNyBKdW4gMjAyMiAxNDo1NDo1OSArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIFtKU0NdW0FSTXY3 XSBEb24ndCBzYXZlIENTUnMgcmVzcGVjdGVkIGJ5IHRoZSBKSVQgQUJJLgoKaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTM2OQoKUmV2aWV3ZWQgYnkgTWFyayBMYW0u CgpJdCBpcyBub3QgbmVjZXNzYXJ5IHRvIHNhdmUgYW5kIHJlc3RvcmUgQ1NScyByZXNwZWN0ZWQg YnkgdGhlIEpJVCBBQkkgb24KVk0gZW50cnkvZXhpdC4gVGhlIGNvbXBpbGVyIHdpbGwgcHJlc2Vy dmUgdGhlbS4gKHIxMCBhbmQgcjExIG9uIEFSTXY3LikKCiogU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSB8IDEwICsrKysrKystLS0KIDEgZmlsZSBj aGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCmluZGV4IGZkNDcy NTMzNTUzYi4uYzYxNjc4YTU0M2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC03NTYsNyArNzU2LDcgQEAgZW5kCiBp ZiBDX0xPT1Agb3IgQ19MT09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4 Nl82NF9XSU4gb3IgUklTQ1Y2NAogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0g MAogZWxzaWYgQVJNdjcKLSAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDcgKyAy ICogMSAvLyA3IDMyLWJpdCBHUFJzICsgMSA2NC1iaXQgRlBSCisgICAgY29uc3QgQ2FsbGVlU2F2 ZVJlZ2lzdGVyQ291bnQgPSA1ICsgMiAqIDEgLy8gNSAzMi1iaXQgR1BScyArIDEgNjQtYml0IEZQ UgogZWxzaWYgTUlQUwogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gMwogZWxz aWYgWDg2IG9yIFg4Nl9XSU4KQEAgLTc3MCwxMCArNzcwLDE0IEBAIGNvbnN0IENhbGxlZVJlZ2lz dGVyU2F2ZVNpemUgPSBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCAqIE1hY2hpbmVSZWdpc3RlclNp emUKIGNvbnN0IFZNRW50cnlUb3RhbEZyYW1lU2l6ZSA9IChDYWxsZWVSZWdpc3RlclNhdmVTaXpl ICsgc2l6ZW9mIFZNRW50cnlSZWNvcmQgKyBTdGFja0FsaWdubWVudCAtIDEpICYgflN0YWNrQWxp Z25tZW50TWFzawogCiBtYWNybyBwdXNoQ2FsbGVlU2F2ZXMoKQorICAgICMgTm90ZTogT25seSBy ZWdpc3RlcnMgdGhhdCBhcmUgaW4gUmVnaXN0ZXJTZXQ6OmNhbGxlZVNhdmVSZWdpc3RlcnMoKSwK KyAgICAjIGJ1dCBhcmUgbm90IGluIFJlZ2lzdGVyU2V0Ojp2bUNhbGxlZVNhdmVSZWdpc3RlcnMo KSBuZWVkIHRvIGJlIHNhdmVkIGhlcmUsCisgICAgIyBpLmUuOiBvbmx5IHRob3NlIHJlZ2lzdGVy cyB0aGF0IGFyZSBjYWxsZWUgc2F2ZSBpbiB0aGUgQyBBQkksIGJ1dCBhcmUgbm90CisgICAgIyBj YWxsZWUgc2F2ZSBpbiB0aGUgSklUIEFCSS4KICAgICBpZiBDX0xPT1Agb3IgQ19MT09QX1dJTiBv ciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4gb3IgUklTQ1Y2NAogICAg IGVsc2lmIEFSTXY3CiAgICAgICAgIGVtaXQgInZwdXNoLjY0IHtkMTV9IgotICAgICAgICBlbWl0 ICJwdXNoIHtyNC1yNiwgcjgtcjExfSIKKyAgICAgICAgZW1pdCAicHVzaCB7cjQtcjYsIHI4LXI5 fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImFkZGl1ICRzcCwgJHNwLCAtMTIiCiAg ICAgICAgIGVtaXQgInN3ICRzMCwgMCgkc3ApIiAjIGNzcjAvbWV0YURhdGEKQEAgLTc5NSw3ICs3 OTksNyBAQCBlbmQKIG1hY3JvIHBvcENhbGxlZVNhdmVzKCkKICAgICBpZiBDX0xPT1Agb3IgQ19M T09QX1dJTiBvciBBUk02NCBvciBBUk02NEUgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4gb3IgUklT Q1Y2NAogICAgIGVsc2lmIEFSTXY3Ci0gICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4LXIxMX0i CisgICAgICAgIGVtaXQgInBvcCB7cjQtcjYsIHI4LXI5fSIKICAgICAgICAgZW1pdCAidnBvcC42 NCB7ZDE1fSIKICAgICBlbHNpZiBNSVBTCiAgICAgICAgIGVtaXQgImx3ICRzMCwgMCgkc3ApIgot LSAKMi4zMC4yCgo=