241342 2022-06-06 11:48:01 -0700 REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistently failing 2022-06-09 14:41:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=241233 InRadar P2 Normal --- 1 ryanhaddad rackler achristensen darin katherine_cheney rackler webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1874334 0 ryanhaddad 2022-06-06 11:48:01 -0700 TestWebKitAPI.HSTS.ThirdParty /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:117 Expected equality of these values: [webView _test_waitForAlert] Which is: " " "http://example.com/ hi" /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:118 Expected equality of these values: httpServer.totalRequests() Which is: 1 2u Which is: 2 https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.HSTS.ThirdParty 1874335 1 webkit-bug-importer 2022-06-06 11:48:10 -0700 <rdar://problem/94448628> 1874340 2 ryanhaddad 2022-06-06 12:03:29 -0700 This test makes requests to example.com, maybe it is the same as https://bugs.webkit.org/show_bug.cgi?id=241233? 1874810 3 rackler 2022-06-08 14:15:05 -0700 I have disabled this test for iOS while this issue is investigated. 1874813 4 rackler 2022-06-08 14:20:15 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1392 1874844 5 ews-feeder 2022-06-08 16:06:11 -0700 Test gardening commit r295398 (251404@main): <https://commits.webkit.org/251404@main> Reviewed commits have been landed. Closing PR #1392 and removing active labels. 1874888 6 achristensen 2022-06-08 21:24:49 -0700 Aha! determineITPStateInternal is returning true on macOS and false on iOS, which causes ITP to be enabled by default on macOS but not iOS, which causes the HSTS mitigation to happen on macOS but not iOS. The code is fine, the test needs to just enable ITP everywhere. 1875038 7 460136 achristensen 2022-06-09 10:23:36 -0700 Created attachment 460136 Patch 1875114 8 ews-feeder 2022-06-09 14:41:53 -0700 Committed r295437 (251443@main): <https://commits.webkit.org/251443@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460136. 460136 2022-06-09 10:23:36 -0700 2022-06-09 14:41:54 -0700 Patch bug-241342-20220609102335.patch text/plain 1845 achristensen RnJvbSAxMDdiZWI1NGQwNWFlMjJlNDE5YjQ2NmRmNGNiNGJjYTc0MWZjZjc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IENocmlzdGVuc2VuIDxhY2hyaXN0ZW5zZW5AYXBwbGUu Y29tPgpEYXRlOiBUaHUsIDkgSnVuIDIwMjIgMTA6MjI6MTEgLTA3MDAKU3ViamVjdDogW1BBVENI XSBSRUdSRVNTSU9OOiBbaU9TXSBUZXN0V2ViS2l0QVBJLkhTVFMuVGhpcmRQYXJ0eSBpcyBjb25z aXN0ZWx5CiBmYWlsaW5nIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDEzNDIKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL0hTVFMubW06CihUZXN0V2ViS2l0QVBJOjpoc3RzV2ViVmlld0Fu ZERlbGVnYXRlKToKKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgotLS0KIFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvSFNUUy5tbSB8IDYgKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9IU1RTLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9IU1RTLm1tCmluZGV4IDk1MjQ3NTY0OTg5OS4uYzJlMTRkOGI2ODA1 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0hTVFMu bW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9IU1RTLm1tCkBA IC00Nyw2ICs0Nyw3IEBAIHN0ZDo6cGFpcjxSZXRhaW5QdHI8V0tXZWJWaWV3PiwgUmV0YWluUHRy PFRlc3ROYXZpZ2F0aW9uRGVsZWdhdGU+PiBoc3RzV2ViVmlld0FuCiAgICAgW3N0b3JlQ29uZmln dXJhdGlvbiBzZXRBbGxvd3NIU1RTV2l0aFVudHJ1c3RlZFJvb3RDZXJ0aWZpY2F0ZTpZRVNdOwog ICAgIGF1dG8gdmlld0NvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtXS1dlYlZpZXdDb25maWd1cmF0 aW9uIG5ld10pOwogICAgIFt2aWV3Q29uZmlndXJhdGlvbiBzZXRXZWJzaXRlRGF0YVN0b3JlOmFk b3B0TlMoW1tXS1dlYnNpdGVEYXRhU3RvcmUgYWxsb2NdIF9pbml0V2l0aENvbmZpZ3VyYXRpb246 c3RvcmVDb25maWd1cmF0aW9uLmdldCgpXSkuZ2V0KCldOworICAgIFtbdmlld0NvbmZpZ3VyYXRp b24gd2Vic2l0ZURhdGFTdG9yZV0gX3NldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkOllF U107CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdp dGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIDEwMCwgMTAwKSBjb25maWd1cmF0aW9uOnZpZXdDb25m aWd1cmF0aW9uLmdldCgpXSk7CiAgICAgYXV0byBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1Rlc3ROYXZp Z2F0aW9uRGVsZWdhdGUgbmV3XSk7CiAgICAgW3dlYlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRl OmRlbGVnYXRlLmdldCgpXTsKQEAgLTkxLDEyICs5Miw3IEBAIFRFU1QoSFNUUywgQmFzaWMpCiAg ICAgRVhQRUNUX1dLX1NUUkVRKHdlYlZpZXcuZ2V0KCkuVVJMLmFic29sdXRlU3RyaW5nLCAiaHR0 cHM6Ly9leGFtcGxlLmNvbS8iKTsKIH0KIAotLy8gRklYTUU6IFJlLWVuYWJsZSBhZnRlciB3ZWJr aXQub3JnL2IvMjQxMzQyIGlzIHJlc29sdmVkCi0jaWYgKFBMQVRGT1JNKElPUykpCi1URVNUKEhT VFMsIERJU0FCTEVEX1RoaXJkUGFydHkpCi0jZWxzZQogVEVTVChIU1RTLCBUaGlyZFBhcnR5KQot I2VuZGlmCiB7CiAgICAgYXV0byBodHRwc1NlcnZlciA9IGhzdHNTZXJ2ZXIoKTsKIAotLSAKMi4z Mi4wIChBcHBsZSBHaXQtMTMyKQoK