24133 2009-02-24 13:27:51 -0800 Crash when loading GMail and stop loading 2009-02-26 12:10:48 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned ap oldest_to_newest 110799 0 manyoso 2009-02-24 13:27:51 -0800 Loading up Gmail.com and then canceling the load while it is still loading results in a crash and ASSERT: ASSERTION FAILED: docLoader->requestCount() == 0 (../../../../WebCore/loader/loader.cpp:178 void WebCore::Loader::cancelRequests(WebCore::DocLoader*)) Patch forthcoming. 110812 1 27933 manyoso 2009-02-24 13:57:55 -0800 Created attachment 27933 Fixes crash I'm trying to come up with reproducible test, but if not this is the fix. 110943 2 ap 2009-02-25 06:56:20 -0800 This is exactly the kind of fix that really needs automated tests. We have some examples of slow loading e.g. in http/tests/incremental 110945 3 manyoso 2009-02-25 07:11:33 -0800 I've been working on a test all morning. In fact, I did all of this precisely to try and generate a layout test: http://trac.webkit.org/changeset/41211 However, now that the Qt port can do such a slow loading tests, I haven't been able to come up with one that causes the crash. Here's why: The theory behind the crash is that if the user stops the loading while the preloader is active, then this results in a crash. However, with a layout test I can not automate this stoppage of loading since I'd have to be able to do it via JavaScript. Well, no JavaScript is executed in this preloading stage. That's the whole point of the preloader actually. While a script is loading the preloader goes ahead and continues tokenizing and initiates the network loading of other resources, but it does not allow to execute scripts out of order. Thus, while a script is loading and the tokenizer is thus blocked, I can not programmatically stop the load via JavaScript. I don't know how to get around this. 110946 4 ap 2009-02-25 07:16:03 -0800 Could preloading be stopped with JS running in a different frame? 111229 5 28022 manyoso 2009-02-26 10:56:17 -0800 Created attachment 28022 New version that includes a layout test I've added a layout test that crashes reproducibly and reliably without this patch. 111256 6 28029 manyoso 2009-02-26 11:52:04 -0800 Created attachment 28029 New version crashes more reliably 111260 7 28029 darin 2009-02-26 11:53:51 -0800 Comment on attachment 28029 New version crashes more reliably Too bad we have to add another function to DocLoader! Good fix, though, and great to have a high quality test for it. r=me 111261 8 28029 ap 2009-02-26 11:57:54 -0800 Comment on attachment 28029 New version crashes more reliably > + * http/tests/misc/slow-preload-cancel-expected.txt: Added. > + * http/tests/misc/slow-preload-cancel.html: Added. Please fix the ChangeLog to mention new files. > +</script> > \ No newline at end of file Please add one. 111267 9 manyoso 2009-02-26 12:10:48 -0800 Fixed with r41265. 27933 2009-02-24 13:57:55 -0800 2009-02-26 10:56:17 -0800 Fixes crash crash_on_gmail.patch text/plain 3164 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWI2ZGZiOC4uNjJiM2MzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yNCAgWW9uZyBMaSAgPHlv bmcubGlAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENsZWFyIGFsbCBwZW5kaW5nIHByZWxvYWRzIGluIHRoZSBEb2NMb2Fk ZXIgb2JqZWN0IHdoZW4gd2UgZGVjaWRlIHRvCisgICAgICAgIGNhbmNlbCBpdHMgYWxsIHJlcXVl c3RzLgorCisgICAgICAgICogbG9hZGVyL0RvY0xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEb2NMb2FkZXI6OmNsZWFyUGVuZGluZ1ByZWxvYWRzKToKKyAgICAgICAgKiBsb2FkZXIvRG9j TG9hZGVyLmg6CisgICAgICAgICogbG9hZGVyL2xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMb2FkZXI6OmNhbmNlbFJlcXVlc3RzKToKKwogMjAwOS0wMi0yNCAgRGF2aWQgTGV2aW4gIDxs ZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5 YWtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAgYi9XZWJDb3Jl L2xvYWRlci9Eb2NMb2FkZXIuY3BwCmluZGV4IDAzODA0NzQuLjFjNWYwYjcgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRG9jTG9h ZGVyLmNwcApAQCAtMyw2ICszLDcgQEAKICAgICBDb3B5cmlnaHQgKEMpIDIwMDEgRGlyayBNdWVs bGVyIChtdWVsbGVyQGtkZS5vcmcpCiAgICAgQ29weXJpZ2h0IChDKSAyMDAyIFdhbGRvIEJhc3Rp YW4gKGJhc3RpYW5Aa2RlLm9yZykKICAgICBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDYs IDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICAgIENvcHlyaWdodCAoQykg MjAwOSBUb3JjaCBNb2JpbGUgSW5jLiBodHRwOi8vd3d3LnRvcmNobW9iaWxlLmNvbS8KIAogICAg IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKICAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBH ZW5lcmFsIFB1YmxpYwpAQCAtMzc3LDYgKzM3OCwxMSBAQCB2b2lkIERvY0xvYWRlcjo6Y2xlYXJQ cmVsb2FkcygpCiAgICAgbV9wcmVsb2Fkcy5jbGVhcigpOwogfQogCit2b2lkIERvY0xvYWRlcjo6 Y2xlYXJQZW5kaW5nUHJlbG9hZHMoKQoreworICAgIG1fcGVuZGluZ1ByZWxvYWRzLmNsZWFyKCk7 Cit9CisKICNpZiBQUkVMT0FEX0RFQlVHCiB2b2lkIERvY0xvYWRlcjo6cHJpbnRQcmVsb2FkU3Rh dHMoKQogewpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jTG9hZGVyLmggYi9XZWJDb3Jl L2xvYWRlci9Eb2NMb2FkZXIuaAppbmRleCAxN2VkY2M1Li41ZTQ5MTI5IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIu aApAQCAtMiw2ICsyLDcgQEAKICAgICBDb3B5cmlnaHQgKEMpIDE5OTggTGFycyBLbm9sbCAoa25v bGxAbXBpLWhkLm1wZy5kZSkKICAgICBDb3B5cmlnaHQgKEMpIDIwMDEgRGlyayBNdWVsbGVyIDxt dWVsbGVyQGtkZS5vcmc+CiAgICAgQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2IEFwcGxl IENvbXB1dGVyLCBJbmMuCisgICAgQ29weXJpZ2h0IChDKSAyMDA5IFRvcmNoIE1vYmlsZSBJbmMu IGh0dHA6Ly93d3cudG9yY2htb2JpbGUuY29tLwogCiAgICAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICAgIG1vZGlmeSBpdCB1 bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC0xMDAs NiArMTAxLDcgQEAgcHVibGljOgogICAgIGludCByZXF1ZXN0Q291bnQoKTsKICAgICAKICAgICB2 b2lkIGNsZWFyUHJlbG9hZHMoKTsKKyAgICB2b2lkIGNsZWFyUGVuZGluZ1ByZWxvYWRzKCk7CiAg ICAgdm9pZCBwcmVsb2FkKENhY2hlZFJlc291cmNlOjpUeXBlLCBjb25zdCBTdHJpbmcmIHVybCwg Y29uc3QgU3RyaW5nJiBjaGFyc2V0LCBib29sIHJlZmVyZW5jZWRGcm9tQm9keSk7CiAgICAgdm9p ZCBjaGVja0ZvclBlbmRpbmdQcmVsb2FkcygpOwogICAgIHZvaWQgcHJpbnRQcmVsb2FkU3RhdHMo KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL2xvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRl ci9sb2FkZXIuY3BwCmluZGV4IGM3ZTU0NWEuLjc4MDg3ZDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv bG9hZGVyL2xvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcApAQCAtMTU5 LDYgKzE1OSw4IEBAIHZvaWQgTG9hZGVyOjpzZXJ2ZVBlbmRpbmdSZXF1ZXN0cyhQcmlvcml0eSBt aW5pbXVtUHJpb3JpdHkpCiAgICAgCiB2b2lkIExvYWRlcjo6Y2FuY2VsUmVxdWVzdHMoRG9jTG9h ZGVyKiBkb2NMb2FkZXIpCiB7CisgICAgZG9jTG9hZGVyLT5jbGVhclBlbmRpbmdQcmVsb2Fkcygp OworCiAgICAgaWYgKG1fbm9uSFRUUFByb3RvY29sSG9zdC5oYXNSZXF1ZXN0cygpKQogICAgICAg ICBtX25vbkhUVFBQcm90b2NvbEhvc3QuY2FuY2VsUmVxdWVzdHMoZG9jTG9hZGVyKTsKICAgICAK QEAgLTE3MiwxMCArMTc0LDcgQEAgdm9pZCBMb2FkZXI6OmNhbmNlbFJlcXVlc3RzKERvY0xvYWRl ciogZG9jTG9hZGVyKQogCiAgICAgc2NoZWR1bGVTZXJ2ZVBlbmRpbmdSZXF1ZXN0cygpOwogICAg IAotICAgIGlmIChkb2NMb2FkZXItPmxvYWRJblByb2dyZXNzKCkpCi0gICAgICAgIEFTU0VSVChk b2NMb2FkZXItPnJlcXVlc3RDb3VudCgpID09IDEpOwotICAgIGVsc2UKLSAgICAgICAgQVNTRVJU KGRvY0xvYWRlci0+cmVxdWVzdENvdW50KCkgPT0gMCk7CisgICAgQVNTRVJUKGRvY0xvYWRlci0+ cmVxdWVzdENvdW50KCkgPT0gKGRvY0xvYWRlci0+bG9hZEluUHJvZ3Jlc3MoKSA/IDEgOiAwKSk7 CiB9CiAgICAgCiBMb2FkZXI6Okhvc3Q6Okhvc3QoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLCB1 bnNpZ25lZCBtYXhSZXF1ZXN0c0luRmxpZ2h0KQo= 28022 2009-02-26 10:56:17 -0800 2009-02-26 11:52:04 -0800 New version that includes a layout test crash_on_gmail.patch text/plain 5390 manyoso ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZjIxZGIzLi5lNzM5NmQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDIt MjYgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMzMKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGNoZWNr cyBmb3IgYSBjcmFzaCBpbiBhIHBhcnRpY3VsYXIgc2VxdWVuY2UgdGhhdCBpbnZva2VzCisgICAg ICAgIHRoZSBIVE1MIHByZWxvYWQgc2Nhbm5lciBhbmQgdGhlbiBjYW5jZWxzIGFsbCBsb2Fkcy4K KworICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL3Nsb3ctcHJlbG9hZC1jYW5j ZWwuaHRtbDogQWRkZWQuCisKIDIwMDktMDItMjUgIENhbWVyb24gWndhcmljaCAgPGN3endhcmlj aEB1d2F0ZXJsb28uY2E+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2gu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvc2xvdy1wcmVsb2FkLWNh bmNlbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvc2xvdy1wcmVs b2FkLWNhbmNlbC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uMGUxMzRkMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlz Yy9zbG93LXByZWxvYWQtY2FuY2VsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKKworVGhp cyB0ZXN0IGNoZWNrcyB0aGF0IGNhbmNlbGluZyBhIGxvYWQgd2hlbiBhIHByZWxvYWQgaXMgaGFw cGVuaW5nIGRvZXNuJ3QgY3Jhc2guCisKK0lmIHRlc3RpbmcgbWFudWFsbHksIGlmIHlvdXIgYnJv d3NlciBkb2Vzbid0IGNyYXNoIHRoZW4gdGhpcyB3YXMgYSBzdWNjZXNzLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Nsb3ctcHJlbG9hZC1jYW5jZWwuaHRtbCBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2RmMGRmNAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLmh0bWwKQEAg LTAsMCArMSwyMSBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9u ZSgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKzwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9zY3JpcHQtc2xvdzEucGwiPjwvc2NyaXB0PiA8IS0t IHRoaXMgY2F1c2UgdGhlIHByZWxvYWQgc2Nhbm5lciB0byBraWNrIGluIC0tPgorPC9oZWFkPgor PGJvZHk+Cis8aW1nIHNyYz0icmVzb3VyY2VzL2ltYWdlLXNsb3cucGwiPiA8IS0tIHRoaXMgY2F1 c2VzIGEgcGVuZGluZyBwcmVsb2FkIHRvIGhhcHBlbiAtLT4KKzxwPlRoaXMgdGVzdCBjaGVja3Mg dGhhdCBjYW5jZWxpbmcgYSBsb2FkIHdoZW4gYSBwcmVsb2FkIGlzIGhhcHBlbmluZyBkb2Vzbid0 IGNyYXNoLgorPHA+SWYgdGVzdGluZyBtYW51YWxseSwgaWYgeW91ciBicm93c2VyIGRvZXNuJ3Qg Y3Jhc2ggdGhlbiB0aGlzIHdhcyBhIHN1Y2Nlc3MuCis8c2NyaXB0Pgord2luZG93LmNsb3NlKCk7 IC8vdGhpcyBjYXVzZWQgdGhlIGNyYXNoIGFzIHRoZSBwcmVsb2FkIHdvdWxkIHN0YXJ0IGF0IHRo aXMgcG9pbnQKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIyMThm ZS4uZWJjMjdjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMi0yNiAgWW9uZyBMaSAgPHlvbmcubGlA dG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLmh0bWwK KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMzMK KyAgICAgICAgQ2xlYXIgYWxsIHBlbmRpbmcgcHJlbG9hZHMgaW4gdGhlIERvY0xvYWRlciBvYmpl Y3Qgd2hlbiB3ZSBkZWNpZGUgdG8KKyAgICAgICAgY2FuY2VsIGl0cyBhbGwgcmVxdWVzdHMuCisK KyAgICAgICAgKiBsb2FkZXIvRG9jTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY0xv YWRlcjo6Y2xlYXJQZW5kaW5nUHJlbG9hZHMpOgorICAgICAgICAqIGxvYWRlci9Eb2NMb2FkZXIu aDoKKyAgICAgICAgKiBsb2FkZXIvbG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxvYWRl cjo6Y2FuY2VsUmVxdWVzdHMpOgorCiAyMDA5LTAyLTI2ICBCZW5qYW1pbiBNZXllciAgPGJlbmph bWluLm1leWVyQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2Ug U3RhaWtvcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAgYi9XZWJD b3JlL2xvYWRlci9Eb2NMb2FkZXIuY3BwCmluZGV4IDAzODA0NzQuLjFjNWYwYjcgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRG9j TG9hZGVyLmNwcApAQCAtMyw2ICszLDcgQEAKICAgICBDb3B5cmlnaHQgKEMpIDIwMDEgRGlyayBN dWVsbGVyIChtdWVsbGVyQGtkZS5vcmcpCiAgICAgQ29weXJpZ2h0IChDKSAyMDAyIFdhbGRvIEJh c3RpYW4gKGJhc3RpYW5Aa2RlLm9yZykKICAgICBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIw MDYsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICAgIENvcHlyaWdodCAo QykgMjAwOSBUb3JjaCBNb2JpbGUgSW5jLiBodHRwOi8vd3d3LnRvcmNobW9iaWxlLmNvbS8KIAog ICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtMzc3LDYgKzM3OCwxMSBAQCB2b2lkIERvY0xvYWRlcjo6Y2xl YXJQcmVsb2FkcygpCiAgICAgbV9wcmVsb2Fkcy5jbGVhcigpOwogfQogCit2b2lkIERvY0xvYWRl cjo6Y2xlYXJQZW5kaW5nUHJlbG9hZHMoKQoreworICAgIG1fcGVuZGluZ1ByZWxvYWRzLmNsZWFy KCk7Cit9CisKICNpZiBQUkVMT0FEX0RFQlVHCiB2b2lkIERvY0xvYWRlcjo6cHJpbnRQcmVsb2Fk U3RhdHMoKQogewpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jTG9hZGVyLmggYi9XZWJD b3JlL2xvYWRlci9Eb2NMb2FkZXIuaAppbmRleCAxN2VkY2M1Li41ZTQ5MTI5IDEwMDY0NAotLS0g YS9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2NMb2Fk ZXIuaApAQCAtMiw2ICsyLDcgQEAKICAgICBDb3B5cmlnaHQgKEMpIDE5OTggTGFycyBLbm9sbCAo a25vbGxAbXBpLWhkLm1wZy5kZSkKICAgICBDb3B5cmlnaHQgKEMpIDIwMDEgRGlyayBNdWVsbGVy IDxtdWVsbGVyQGtkZS5vcmc+CiAgICAgQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2IEFw cGxlIENvbXB1dGVyLCBJbmMuCisgICAgQ29weXJpZ2h0IChDKSAyMDA5IFRvcmNoIE1vYmlsZSBJ bmMuIGh0dHA6Ly93d3cudG9yY2htb2JpbGUuY29tLwogCiAgICAgVGhpcyBsaWJyYXJ5IGlzIGZy ZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICAgIG1vZGlmeSBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC0x MDAsNiArMTAxLDcgQEAgcHVibGljOgogICAgIGludCByZXF1ZXN0Q291bnQoKTsKICAgICAKICAg ICB2b2lkIGNsZWFyUHJlbG9hZHMoKTsKKyAgICB2b2lkIGNsZWFyUGVuZGluZ1ByZWxvYWRzKCk7 CiAgICAgdm9pZCBwcmVsb2FkKENhY2hlZFJlc291cmNlOjpUeXBlLCBjb25zdCBTdHJpbmcmIHVy bCwgY29uc3QgU3RyaW5nJiBjaGFyc2V0LCBib29sIHJlZmVyZW5jZWRGcm9tQm9keSk7CiAgICAg dm9pZCBjaGVja0ZvclBlbmRpbmdQcmVsb2FkcygpOwogICAgIHZvaWQgcHJpbnRQcmVsb2FkU3Rh dHMoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL2xvYWRlci5jcHAgYi9XZWJDb3JlL2xv YWRlci9sb2FkZXIuY3BwCmluZGV4IGM3ZTU0NWEuLjc4MDg3ZDYgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvbG9hZGVyL2xvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcApAQCAt MTU5LDYgKzE1OSw4IEBAIHZvaWQgTG9hZGVyOjpzZXJ2ZVBlbmRpbmdSZXF1ZXN0cyhQcmlvcml0 eSBtaW5pbXVtUHJpb3JpdHkpCiAgICAgCiB2b2lkIExvYWRlcjo6Y2FuY2VsUmVxdWVzdHMoRG9j TG9hZGVyKiBkb2NMb2FkZXIpCiB7CisgICAgZG9jTG9hZGVyLT5jbGVhclBlbmRpbmdQcmVsb2Fk cygpOworCiAgICAgaWYgKG1fbm9uSFRUUFByb3RvY29sSG9zdC5oYXNSZXF1ZXN0cygpKQogICAg ICAgICBtX25vbkhUVFBQcm90b2NvbEhvc3QuY2FuY2VsUmVxdWVzdHMoZG9jTG9hZGVyKTsKICAg ICAKQEAgLTE3MiwxMCArMTc0LDcgQEAgdm9pZCBMb2FkZXI6OmNhbmNlbFJlcXVlc3RzKERvY0xv YWRlciogZG9jTG9hZGVyKQogCiAgICAgc2NoZWR1bGVTZXJ2ZVBlbmRpbmdSZXF1ZXN0cygpOwog ICAgIAotICAgIGlmIChkb2NMb2FkZXItPmxvYWRJblByb2dyZXNzKCkpCi0gICAgICAgIEFTU0VS VChkb2NMb2FkZXItPnJlcXVlc3RDb3VudCgpID09IDEpOwotICAgIGVsc2UKLSAgICAgICAgQVNT RVJUKGRvY0xvYWRlci0+cmVxdWVzdENvdW50KCkgPT0gMCk7CisgICAgQVNTRVJUKGRvY0xvYWRl ci0+cmVxdWVzdENvdW50KCkgPT0gKGRvY0xvYWRlci0+bG9hZEluUHJvZ3Jlc3MoKSA/IDEgOiAw KSk7CiB9CiAgICAgCiBMb2FkZXI6Okhvc3Q6Okhvc3QoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1l LCB1bnNpZ25lZCBtYXhSZXF1ZXN0c0luRmxpZ2h0KQo= 28029 2009-02-26 11:52:04 -0800 2009-02-26 12:00:01 -0800 New version crashes more reliably crash_on_gmail.patch text/plain 6067 manyoso ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZjIxZGIzLi5lNzM5NmQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDIt MjYgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMzMKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGNoZWNr cyBmb3IgYSBjcmFzaCBpbiBhIHBhcnRpY3VsYXIgc2VxdWVuY2UgdGhhdCBpbnZva2VzCisgICAg ICAgIHRoZSBIVE1MIHByZWxvYWQgc2Nhbm5lciBhbmQgdGhlbiBjYW5jZWxzIGFsbCBsb2Fkcy4K KworICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL3Nsb3ctcHJlbG9hZC1jYW5j ZWwuaHRtbDogQWRkZWQuCisKIDIwMDktMDItMjUgIENhbWVyb24gWndhcmljaCAgPGN3endhcmlj aEB1d2F0ZXJsb28uY2E+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2gu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvcmVzb3VyY2VzL3Nsb3ct cHJlbG9hZC1jYW5jZWwtMS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Jlc291 cmNlcy9zbG93LXByZWxvYWQtY2FuY2VsLTEuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi4zZGY5YWRjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9taXNjL3Jlc291cmNlcy9zbG93LXByZWxvYWQtY2FuY2VsLTEuaHRtbApAQCAtMCwwICsx LDE5IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cisg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorPC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0icmVzb3VyY2VzL3NjcmlwdC1zbG93MS5wbCI+PC9zY3JpcHQ+IDwhLS0gdGhpcyBj YXVzZSB0aGUgcHJlbG9hZCBzY2FubmVyIHRvIGtpY2sgaW4gLS0+Cis8L2hlYWQ+Cis8Ym9keT4K KzxpbWcgc3JjPSJyZXNvdXJjZXMvaW1hZ2Utc2xvdy5wbCI+IDwhLS0gdGhpcyBjYXVzZXMgYSBw ZW5kaW5nIHByZWxvYWQgdG8gaGFwcGVuIC0tPgorPHNjcmlwdD4KK3dpbmRvdy5jbG9zZSgpOyAv L3RoaXMgY2F1c2VkIHRoZSBjcmFzaCBhcyB0aGUgcHJlbG9hZCB3b3VsZCBzdGFydCBhdCB0aGlz IHBvaW50CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvc2xvdy1wcmVsb2FkLWNhbmNlbC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvc2xvdy1wcmVsb2FkLWNhbmNl bC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTVlZjYw NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9zbG93LXBy ZWxvYWQtY2FuY2VsLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1RoaXMgdGVzdCBjaGVj a3MgdGhhdCBjYW5jZWxpbmcgYSBsb2FkIHdoZW4gYSBwcmVsb2FkIGlzIGhhcHBlbmluZyBkb2Vz bid0IGNyYXNoLgorCitJZiB0ZXN0aW5nIG1hbnVhbGx5LCBpZiB5b3VyIGJyb3dzZXIgZG9lc24n dCBjcmFzaCB0aGVuIHRoaXMgd2FzIGEgc3VjY2Vzcy4KKworVGVzdApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Nsb3ctcHJlbG9hZC1jYW5jZWwuaHRtbCBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTFjZmVkNwotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9zbG93LXByZWxvYWQtY2FuY2VsLmh0bWwKQEAgLTAs MCArMSwxMiBAQAorPHA+VGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGNhbmNlbGluZyBhIGxvYWQgd2hl biBhIHByZWxvYWQgaXMgaGFwcGVuaW5nIGRvZXNuJ3QgY3Jhc2guPC9wPgorPHA+SWYgdGVzdGlu ZyBtYW51YWxseSwgaWYgeW91ciBicm93c2VyIGRvZXNuJ3QgY3Jhc2ggdGhlbiB0aGlzIHdhcyBh IHN1Y2Nlc3MuPC9wPgorPGJ1dHRvbiB0eXBlPSJidXR0b24iIG9uY2xpY2s9J3dpbmRvdy5vcGVu KCJyZXNvdXJjZXMvc2xvdy1wcmVsb2FkLWNhbmNlbC5odG1sIik7Jz5UZXN0PC9idXR0b24+Cis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRl c3RDb250cm9sbGVyLnNldENhbk9wZW5XaW5kb3dzKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKK30KKword2luZG93Lm9wZW4oInJlc291cmNlcy9zbG93LXByZWxvYWQtY2FuY2VsLTEuaHRt bCIpOworPC9zY3JpcHQ+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MjIxOGZlLi5lYmMy N2NmIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTAyLTI2ICBZb25nIExpICA8eW9uZy5saUB0b3JjaG1v YmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogaHR0cC90ZXN0cy9taXNjL3Nsb3ctcHJlbG9hZC1jYW5jZWwuaHRtbAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDEzMworICAgICAg ICBDbGVhciBhbGwgcGVuZGluZyBwcmVsb2FkcyBpbiB0aGUgRG9jTG9hZGVyIG9iamVjdCB3aGVu IHdlIGRlY2lkZSB0bworICAgICAgICBjYW5jZWwgaXRzIGFsbCByZXF1ZXN0cy4KKworICAgICAg ICAqIGxvYWRlci9Eb2NMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jTG9hZGVyOjpj bGVhclBlbmRpbmdQcmVsb2Fkcyk6CisgICAgICAgICogbG9hZGVyL0RvY0xvYWRlci5oOgorICAg ICAgICAqIGxvYWRlci9sb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TG9hZGVyOjpjYW5j ZWxSZXF1ZXN0cyk6CisKIDIwMDktMDItMjYgIEJlbmphbWluIE1leWVyICA8YmVuamFtaW4ubWV5 ZXJAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29z LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRG9jTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9h ZGVyL0RvY0xvYWRlci5jcHAKaW5kZXggMDM4MDQ3NC4uMWM1ZjBiNyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9sb2FkZXIvRG9jTG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIu Y3BwCkBAIC0zLDYgKzMsNyBAQAogICAgIENvcHlyaWdodCAoQykgMjAwMSBEaXJrIE11ZWxsZXIg KG11ZWxsZXJAa2RlLm9yZykKICAgICBDb3B5cmlnaHQgKEMpIDIwMDIgV2FsZG8gQmFzdGlhbiAo YmFzdGlhbkBrZGUub3JnKQogICAgIENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAw OCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgICAgQ29weXJpZ2h0IChDKSAyMDA5 IFRvcmNoIE1vYmlsZSBJbmMuIGh0dHA6Ly93d3cudG9yY2htb2JpbGUuY29tLwogCiAgICAgVGhp cyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v cgogICAgIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVy YWwgUHVibGljCkBAIC0zNzcsNiArMzc4LDExIEBAIHZvaWQgRG9jTG9hZGVyOjpjbGVhclByZWxv YWRzKCkKICAgICBtX3ByZWxvYWRzLmNsZWFyKCk7CiB9CiAKK3ZvaWQgRG9jTG9hZGVyOjpjbGVh clBlbmRpbmdQcmVsb2FkcygpCit7CisgICAgbV9wZW5kaW5nUHJlbG9hZHMuY2xlYXIoKTsKK30K KwogI2lmIFBSRUxPQURfREVCVUcKIHZvaWQgRG9jTG9hZGVyOjpwcmludFByZWxvYWRTdGF0cygp CiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9Eb2NMb2FkZXIuaCBiL1dlYkNvcmUvbG9h ZGVyL0RvY0xvYWRlci5oCmluZGV4IDE3ZWRjYzUuLjVlNDkxMjkgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvbG9hZGVyL0RvY0xvYWRlci5oCisrKyBiL1dlYkNvcmUvbG9hZGVyL0RvY0xvYWRlci5oCkBA IC0yLDYgKzIsNyBAQAogICAgIENvcHlyaWdodCAoQykgMTk5OCBMYXJzIEtub2xsIChrbm9sbEBt cGktaGQubXBnLmRlKQogICAgIENvcHlyaWdodCAoQykgMjAwMSBEaXJrIE11ZWxsZXIgPG11ZWxs ZXJAa2RlLm9yZz4KICAgICBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDYgQXBwbGUgQ29t cHV0ZXIsIEluYy4KKyAgICBDb3B5cmlnaHQgKEMpIDIwMDkgVG9yY2ggTW9iaWxlIEluYy4gaHR0 cDovL3d3dy50b3JjaG1vYmlsZS5jb20vCiAKICAgICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgICAgbW9kaWZ5IGl0IHVuZGVy IHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTEwMCw2ICsx MDEsNyBAQCBwdWJsaWM6CiAgICAgaW50IHJlcXVlc3RDb3VudCgpOwogICAgIAogICAgIHZvaWQg Y2xlYXJQcmVsb2FkcygpOworICAgIHZvaWQgY2xlYXJQZW5kaW5nUHJlbG9hZHMoKTsKICAgICB2 b2lkIHByZWxvYWQoQ2FjaGVkUmVzb3VyY2U6OlR5cGUsIGNvbnN0IFN0cmluZyYgdXJsLCBjb25z dCBTdHJpbmcmIGNoYXJzZXQsIGJvb2wgcmVmZXJlbmNlZEZyb21Cb2R5KTsKICAgICB2b2lkIGNo ZWNrRm9yUGVuZGluZ1ByZWxvYWRzKCk7CiAgICAgdm9pZCBwcmludFByZWxvYWRTdGF0cygpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL2xv YWRlci5jcHAKaW5kZXggYzdlNTQ1YS4uNzgwODdkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2Fk ZXIvbG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9sb2FkZXIuY3BwCkBAIC0xNTksNiAr MTU5LDggQEAgdm9pZCBMb2FkZXI6OnNlcnZlUGVuZGluZ1JlcXVlc3RzKFByaW9yaXR5IG1pbmlt dW1Qcmlvcml0eSkKICAgICAKIHZvaWQgTG9hZGVyOjpjYW5jZWxSZXF1ZXN0cyhEb2NMb2FkZXIq IGRvY0xvYWRlcikKIHsKKyAgICBkb2NMb2FkZXItPmNsZWFyUGVuZGluZ1ByZWxvYWRzKCk7CisK ICAgICBpZiAobV9ub25IVFRQUHJvdG9jb2xIb3N0Lmhhc1JlcXVlc3RzKCkpCiAgICAgICAgIG1f bm9uSFRUUFByb3RvY29sSG9zdC5jYW5jZWxSZXF1ZXN0cyhkb2NMb2FkZXIpOwogICAgIApAQCAt MTcyLDEwICsxNzQsNyBAQCB2b2lkIExvYWRlcjo6Y2FuY2VsUmVxdWVzdHMoRG9jTG9hZGVyKiBk b2NMb2FkZXIpCiAKICAgICBzY2hlZHVsZVNlcnZlUGVuZGluZ1JlcXVlc3RzKCk7CiAgICAgCi0g ICAgaWYgKGRvY0xvYWRlci0+bG9hZEluUHJvZ3Jlc3MoKSkKLSAgICAgICAgQVNTRVJUKGRvY0xv YWRlci0+cmVxdWVzdENvdW50KCkgPT0gMSk7Ci0gICAgZWxzZQotICAgICAgICBBU1NFUlQoZG9j TG9hZGVyLT5yZXF1ZXN0Q291bnQoKSA9PSAwKTsKKyAgICBBU1NFUlQoZG9jTG9hZGVyLT5yZXF1 ZXN0Q291bnQoKSA9PSAoZG9jTG9hZGVyLT5sb2FkSW5Qcm9ncmVzcygpID8gMSA6IDApKTsKIH0K ICAgICAKIExvYWRlcjo6SG9zdDo6SG9zdChjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIHVuc2ln bmVkIG1heFJlcXVlc3RzSW5GbGlnaHQpCg==