241323 2022-06-05 21:33:13 -0700 [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content 2022-06-06 06:09:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham ntim simon.fraser webkit-bug-importer zalan oldest_to_newest 1874231 0 zalan 2022-06-05 21:33:13 -0700 ssia 1874232 1 460044 zalan 2022-06-05 21:35:16 -0700 Created attachment 460044 [fast-cq]Patch 1874253 2 460044 ntim 2022-06-06 01:42:44 -0700 Comment on attachment 460044 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460044&action=review nice > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:697 > + if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned()) I'm pretty sure `float` has no effect on flex items. See: data:text/html,<div style="display: flex;"><div style="float: right; width: 200px; height: 200px; background: red"></div></div> or data:text/html,<div style="display: flex;">dsdfdsofjdskfdslvndlcvnfsldjnvdfoskgdfjngfdjnfdljgksdfngfdlg<div style="float: left; width: 200px; height: 200px; background: red"></div></div> I could be wrong though 1874279 3 ews-feeder 2022-06-06 06:08:43 -0700 Committed r295282 (251328@main): <https://commits.webkit.org/251328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460044. 1874280 4 webkit-bug-importer 2022-06-06 06:09:13 -0700 <rdar://problem/94432777> 460044 2022-06-05 21:35:16 -0700 2022-06-06 06:08:43 -0700 [fast-cq]Patch bug-241323-20220605213515.patch text/plain 2564 zalan RnJvbSA4OTZlMDkzNDI5Nzk1ZDRhMDBmNjM1ZmVjZmU0NDIzMzFlYzQ4ZjcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBT dW4sIDUgSnVuIDIwMjIgMjE6MzM6MzEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbTEZDXVtGRkNd IFBvcHVsYXRlIGNhblVzZUZvckZsZXhMYXlvdXQgd2l0aCB1bnN1cHBvcnRlZAogc3R5bGVzIGFu ZCBjb250ZW50IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDEzMjMK ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3Ig YmVpbmcgYWJsZSB0byBydW4gV1BUIHRlc3RzIChmaWx0ZXIgb3V0IHVuc3VwcG9ydGVkIGNvbnRl bnQpLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRp b25Db3ZlcmFnZS5jcHA6CihXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6Y2FuVXNlRm9yRmxl eExheW91dCk6Ci0tLQogLi4uL2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2Uu Y3BwIHwgMjkgKysrKysrKysrKysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2UuY3BwIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2UuY3BwCmluZGV4 IDM0MjE1Y2RlMmJlYi4uOGQxYjBiYmFlY2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Db3ZlcmFnZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2Uu Y3BwCkBAIC02NzgsOCArNjc4LDMzIEBAIGJvb2wgY2FuVXNlRm9yRmxleExheW91dChjb25zdCBS ZW5kZXJGbGV4aWJsZUJveCYgZmxleEJveCkKIHsKICAgICBpZiAoIWZsZXhCb3guZG9jdW1lbnQo KS5zZXR0aW5ncygpLmZsZXhGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxlZCgpKQog ICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgQVNTRVJUX05PVF9JTVBMRU1FTlRFRF9ZRVQoKTsK LSAgICByZXR1cm4gZmFsc2U7CisKKyAgICBhdXRvJiBmbGV4Qm94U3R5bGUgPSBmbGV4Qm94LnN0 eWxlKCk7CisgICAgaWYgKCFmbGV4Qm94U3R5bGUuaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSB8 fCAhZmxleEJveFN0eWxlLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKKyAgICAgICAgcmV0dXJu IGZhbHNlOworICAgIGlmIChmbGV4Qm94U3R5bGUuZmxleFdyYXAoKSA9PSBGbGV4V3JhcDo6UmV2 ZXJzZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmIChmbGV4Qm94U3R5bGUuYWxpZ25J dGVtcygpLnBvc2l0aW9uKCkgPT0gSXRlbVBvc2l0aW9uOjpCYXNlbGluZSkKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIGlmIChmbGV4Qm94U3R5bGUuYWxpZ25Db250ZW50KCkucG9zaXRpb24o KSAhPSBDb250ZW50UG9zaXRpb246Ok5vcm1hbCB8fCBmbGV4Qm94U3R5bGUuYWxpZ25Db250ZW50 KCkuZGlzdHJpYnV0aW9uKCkgIT0gQ29udGVudERpc3RyaWJ1dGlvbjo6RGVmYXVsdCB8fCBmbGV4 Qm94U3R5bGUuYWxpZ25Db250ZW50KCkub3ZlcmZsb3coKSAhPSBPdmVyZmxvd0FsaWdubWVudDo6 RGVmYXVsdCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghZmxleEJveFN0eWxlLnJv d0dhcCgpLmlzTm9ybWFsKCkgfHwgIWZsZXhCb3hTdHlsZS5jb2x1bW5HYXAoKS5pc05vcm1hbCgp KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBmb3IgKGF1dG8mIGZsZXhJdGVtIDogY2hp bGRyZW5PZlR5cGU8UmVuZGVyRWxlbWVudD4oZmxleEJveCkpIHsKKyAgICAgICAgaWYgKCFpczxS ZW5kZXJCb3g+KGZsZXhJdGVtKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg aWYgKGZsZXhJdGVtLmlzRmxvYXRpbmcoKSB8fCBmbGV4SXRlbS5pc091dE9mRmxvd1Bvc2l0aW9u ZWQoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgaWYgKGZsZXhJdGVtLmlz U1ZHUm9vdE9yTGVnYWN5U1ZHUm9vdCgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAg ICAgICBhdXRvJiBmbGV4SXRlbVN0eWxlID0gZmxleEl0ZW0uc3R5bGUoKTsKKyAgICAgICAgaWYg KCFmbGV4SXRlbVN0eWxlLm1heFdpZHRoKCkuaXNVbmRlZmluZWQoKSB8fCAhZmxleEl0ZW1TdHls ZS5tYXhIZWlnaHQoKS5pc1VuZGVmaW5lZCgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgICAgICBpZiAoZmxleEl0ZW0uaGFzSW50cmluc2ljQXNwZWN0UmF0aW8oKSB8fCBmbGV4SXRl bVN0eWxlLmhhc0FzcGVjdFJhdGlvKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQorICAgIHJldHVybiB0cnVlOwogfQogCiB9Ci0tIAoyLjMyLjAgKEFwcGxlIEdpdC0xMzIpCgo=