241322 2022-06-05 19:27:37 -0700 Mobile Safari desktop mode user agent reports a different macOS version than Safari on Mac 2022-06-06 17:17:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build iPhone / iPad All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217364 InRadar P2 Normal --- 1 apps webkit-unassigned achristensen ap bfulgham gsnedders luming_yin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1874222 0 apps 2022-06-05 19:27:37 -0700 When Mobile Safari is set to request the desktop website in iOS and iPadOS, it reports a user agent string with the macOS version as 10.15.6: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15 On the other hand, Safari on Mac always reports the macOS version as 10.15.7: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15 This inconsistency should be fixed (i.e. Mobile Safari should report 10.15.7 in desktop mode) because it could make it easier for a website to detect whether the visitor is using Mac Safari or is using Mobile Safari, defeating the purpose of desktop mode. 1874224 1 460042 apps 2022-06-05 20:02:15 -0700 Created attachment 460042 Patch 1874273 2 gsnedders 2022-06-06 05:05:15 -0700 This has repeatedly bugged me (after all, it provides another way to sniff for iOS v. macOS), but I've never taken the small amount of time to actually fix this. (Thanks Nitin!) 1874319 3 ap 2022-06-06 09:47:34 -0700 Thank you for the patch! Would you be willing to re-submit it with a commit message? It cannot be landed without one. `webkit-patch upload` would include the commit message, and you can confirm that its format matches existing landed commits. It looks like https://webkit.org/contributing-code/ is currently out of date, we need to fix it ASAP. 1874349 4 460050 apps 2022-06-06 12:44:55 -0700 Created attachment 460050 Patch 1874350 5 apps 2022-06-06 12:45:27 -0700 (In reply to Alexey Proskuryakov from comment #3) > Would you be willing to re-submit it with a commit message? It cannot be > landed without one. `webkit-patch upload` would include the commit message, > and you can confirm that its format matches existing landed commits. done! 1874371 6 ap 2022-06-06 14:29:18 -0700 Sorry, it's not quite it yet (needs a "Reviewed by NOBODY (OOPS!)" line, otherwise tooling that replaces it with an actual reviewer name won't work). I think that if you reset, run `git-webkit setup`, and re-commit, the correct template should be generated. 1874389 7 460054 apps 2022-06-06 15:18:37 -0700 Created attachment 460054 Patch 1874390 8 apps 2022-06-06 15:19:23 -0700 (In reply to Alexey Proskuryakov from comment #6) > Sorry, it's not quite it yet (needs a "Reviewed by NOBODY (OOPS!)" line, > otherwise tooling that replaces it with an actual reviewer name won't work). > > I think that if you reset, run `git-webkit setup`, and re-commit, the > correct template should be generated. Should be fixed now. 1874395 9 460054 ap 2022-06-06 15:57:15 -0700 Comment on attachment 460054 Patch Let's see what happens! 1874404 10 ews-feeder 2022-06-06 17:16:04 -0700 Committed r295305 (251347@main): <https://commits.webkit.org/251347@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460054. 1874405 11 webkit-bug-importer 2022-06-06 17:17:16 -0700 <rdar://problem/94474123> 460042 2022-06-05 20:02:15 -0700 2022-06-06 12:44:51 -0700 Patch bug-241322-20220605230214.patch text/plain 1070 apps ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Vc2VyQWdlbnRJT1MubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1tCmluZGV4IGIxODQx ZDk3NDdmNDQ5NmViZjIwYjFiNTEzY2I1MmRiYTFiNGY5ZGEuLmIyMjE5MjExYjJhYWZlN2NkNTZj Njk2YWUzNDQ1ZDgxMjM3NjliOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9Vc2VyQWdlbnRJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1Vz ZXJBZ2VudElPUy5tbQpAQCAtODUsNyArODUsNyBAQCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRX aXRoQXBwbGljYXRpb25OYW1lKGNvbnN0IFN0cmluZyYgYXBwbGljYXRpb25OYW1lLCBjb25zdAog ewogICAgIGF1dG8gc2VwYXJhdG9yID0gYXBwbGljYXRpb25OYW1lLmlzRW1wdHkoKSA/ICIiIDog IiAiOwogICAgIGlmICh0eXBlID09IFVzZXJBZ2VudFR5cGU6OkRlc2t0b3ApCi0gICAgICAgIHJl dHVybiBtYWtlU3RyaW5nKCJNb3ppbGxhLzUuMCAoTWFjaW50b3NoOyBJbnRlbCBNYWMgT1MgWCAx MF8xNV82KSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIiwgc2VwYXJh dG9yLCBhcHBsaWNhdGlvbk5hbWUpOworICAgICAgICByZXR1cm4gbWFrZVN0cmluZygiTW96aWxs YS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTVfNykgQXBwbGVXZWJLaXQvNjA1 LjEuMTUgKEtIVE1MLCBsaWtlIEdlY2tvKSIsIHNlcGFyYXRvciwgYXBwbGljYXRpb25OYW1lKTsK IAogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgZGVwcmVjYXRlIGFuZCByZW1vdmUgdGhpcyBvdmVy cmlkZTsgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc5Mjcg Zm9yIGRldGFpbHMuCiAgICAgaWYgKGF1dG8gb3ZlcnJpZGUgPSBkeW5hbWljX2NmX2Nhc3Q8Q0ZT dHJpbmdSZWY+KGFkb3B0Q0YoQ0ZQcmVmZXJlbmNlc0NvcHlBcHBWYWx1ZShDRlNUUigiVXNlckFn ZW50IiksIENGU1RSKCJjb20uYXBwbGUuV2ViRm91bmRhdGlvbiIpKSkpKQo= 460050 2022-06-06 12:44:55 -0700 2022-06-06 15:18:32 -0700 Patch bug-241322-20220606154454.patch text/plain 1591 apps RnJvbSAwNjNjZDVkZGU0YjRlNTkzYmQyZDRhMjgzNzUzYThkNTAyNmI5ODgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBuaXRpbnNlc2hhZHJpIDw2MTI1ODEyNituaXRpbnNlc2hhZHJp QHVzZXJzLm5vcmVwbHkuZ2l0aHViLmNvbT4KRGF0ZTogTW9uLCA2IEp1biAyMDIyIDE1OjM4OjI5 IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSBNb2JpbGUgU2FmYXJpIGRlc2t0b3AgbW9kZSBy ZXBvcnQgdGhlIHNhbWUgbWFjT1MgdmVyc2lvbgogaW4gdGhlIHVzZXIgYWdlbnQgYXMgU2FmYXJp IG9uIE1hYwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTMyMgoK KiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1tOgpDaGFuZ2UgcmVw b3J0ZWQgbWFjT1MgdmVyc2lvbiBpbiB1c2VyIGFnZW50IHRvIDEwLjE1LjcuCi0tLQogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL1VzZXJBZ2VudElPUy5tbSB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9Vc2VyQWdlbnRJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1tCmluZGV4IGIxODQxZDk3NDdmNC4uYjIyMTkyMTFiMmFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Vc2VyQWdlbnRJT1MubW0KQEAgLTg1 LDcgKzg1LDcgQEAgU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50V2l0aEFwcGxpY2F0aW9uTmFtZShj b25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3QKIHsKICAgICBhdXRvIHNlcGFyYXRv ciA9IGFwcGxpY2F0aW9uTmFtZS5pc0VtcHR5KCkgPyAiIiA6ICIgIjsKICAgICBpZiAodHlwZSA9 PSBVc2VyQWdlbnRUeXBlOjpEZXNrdG9wKQotICAgICAgICByZXR1cm4gbWFrZVN0cmluZygiTW96 aWxsYS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTVfNikgQXBwbGVXZWJLaXQv NjA1LjEuMTUgKEtIVE1MLCBsaWtlIEdlY2tvKSIsIHNlcGFyYXRvciwgYXBwbGljYXRpb25OYW1l KTsKKyAgICAgICAgcmV0dXJuIG1ha2VTdHJpbmcoIk1vemlsbGEvNS4wIChNYWNpbnRvc2g7IElu dGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0LzYwNS4xLjE1IChLSFRNTCwgbGlrZSBH ZWNrbykiLCBzZXBhcmF0b3IsIGFwcGxpY2F0aW9uTmFtZSk7CiAKICAgICAvLyBGSVhNRTogV2Ug c2hvdWxkIGRlcHJlY2F0ZSBhbmQgcmVtb3ZlIHRoaXMgb3ZlcnJpZGU7IHNlZSBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTI3IGZvciBkZXRhaWxzLgogICAgIGlm IChhdXRvIG92ZXJyaWRlID0gZHluYW1pY19jZl9jYXN0PENGU3RyaW5nUmVmPihhZG9wdENGKENG UHJlZmVyZW5jZXNDb3B5QXBwVmFsdWUoQ0ZTVFIoIlVzZXJBZ2VudCIpLCBDRlNUUigiY29tLmFw cGxlLldlYkZvdW5kYXRpb24iKSkpKSkKLS0gCjIuMzIuMSAoQXBwbGUgR2l0LTEzMykKCg== 460054 2022-06-06 15:18:37 -0700 2022-06-06 17:16:05 -0700 Patch bug-241322-20220606181836.patch text/plain 1669 apps RnJvbSBlZWUxNWUwNzcwMmI0M2JkODRmZWE2MzZlYzE2YjE2NGRhNTU5ZjNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBuaXRpbnNlc2hhZHJpIDw2MTI1ODEyNituaXRpbnNlc2hhZHJp QHVzZXJzLm5vcmVwbHkuZ2l0aHViLmNvbT4KRGF0ZTogTW9uLCA2IEp1biAyMDIyIDE4OjE2OjIy IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSBNb2JpbGUgU2FmYXJpIGRlc2t0b3AgbW9kZSBy ZXBvcnQgdGhlIHNhbWUgbWFjT1MgdmVyc2lvbgogaW4gdGhlIHVzZXIgYWdlbnQgYXMgU2FmYXJp IG9uIE1hYwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTMyMgoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9Vc2VyQWdlbnRJT1MubW06CihXZWJDb3JlOjpzdGFuZGFyZFVzZXJBZ2VudFdpdGhBcHBsaWNh dGlvbk5hbWUpOgpDaGFuZ2UgcmVwb3J0ZWQgbWFjT1MgdmVyc2lvbiBpbiB1c2VyIGFnZW50IHRv IDEwLjE1LjcuCi0tLQogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1VzZXJBZ2VudElPUy5t bSB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Vc2VyQWdlbnRJT1MubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVXNlckFnZW50SU9TLm1tCmluZGV4IGIxODQx ZDk3NDdmNC4uYjIyMTkyMTFiMmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvVXNlckFnZW50SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9V c2VyQWdlbnRJT1MubW0KQEAgLTg1LDcgKzg1LDcgQEAgU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50 V2l0aEFwcGxpY2F0aW9uTmFtZShjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3QK IHsKICAgICBhdXRvIHNlcGFyYXRvciA9IGFwcGxpY2F0aW9uTmFtZS5pc0VtcHR5KCkgPyAiIiA6 ICIgIjsKICAgICBpZiAodHlwZSA9PSBVc2VyQWdlbnRUeXBlOjpEZXNrdG9wKQotICAgICAgICBy ZXR1cm4gbWFrZVN0cmluZygiTW96aWxsYS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFgg MTBfMTVfNikgQXBwbGVXZWJLaXQvNjA1LjEuMTUgKEtIVE1MLCBsaWtlIEdlY2tvKSIsIHNlcGFy YXRvciwgYXBwbGljYXRpb25OYW1lKTsKKyAgICAgICAgcmV0dXJuIG1ha2VTdHJpbmcoIk1vemls bGEvNS4wIChNYWNpbnRvc2g7IEludGVsIE1hYyBPUyBYIDEwXzE1XzcpIEFwcGxlV2ViS2l0LzYw NS4xLjE1IChLSFRNTCwgbGlrZSBHZWNrbykiLCBzZXBhcmF0b3IsIGFwcGxpY2F0aW9uTmFtZSk7 CiAKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGRlcHJlY2F0ZSBhbmQgcmVtb3ZlIHRoaXMgb3Zl cnJpZGU7IHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTI3 IGZvciBkZXRhaWxzLgogICAgIGlmIChhdXRvIG92ZXJyaWRlID0gZHluYW1pY19jZl9jYXN0PENG U3RyaW5nUmVmPihhZG9wdENGKENGUHJlZmVyZW5jZXNDb3B5QXBwVmFsdWUoQ0ZTVFIoIlVzZXJB Z2VudCIpLCBDRlNUUigiY29tLmFwcGxlLldlYkZvdW5kYXRpb24iKSkpKSkKLS0gCjIuMzIuMSAo QXBwbGUgR2l0LTEzMykKCg==