<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>241298</bug_id>
          
          <creation_ts>2022-06-03 18:19:00 -0700</creation_ts>
          <short_desc>[Xcode] Use workspace builds by default in build-webkit</short_desc>
          <delta_ts>2022-06-22 12:49:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=241508</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>241295</blocked>
    
    <blocked>241863</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Elliott Williams">emw</reporter>
          <assigned_to name="Elliott Williams">emw</assigned_to>
          <cc>emw</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1874092</commentid>
    <comment_count>0</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2022-06-03 18:19:00 -0700</bug_when>
    <thetext>`build-webkit --use-workspace` has been functional for some time now, and WebKit is free of XCBuild validation warnings. We can make --use-workspace the default, and speed up EWS and other open-source build workflows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874093</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-03 18:20:06 -0700</bug_when>
    <thetext>&lt;rdar://problem/94375189&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874094</commentid>
    <comment_count>2</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2022-06-03 18:20:15 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1306</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875048</commentid>
    <comment_count>3</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2022-06-09 11:16:32 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1421</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875212</commentid>
    <comment_count>4</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2022-06-10 04:37:44 -0700</bug_when>
    <thetext>Hopefully affects bug 241508</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875331</commentid>
    <comment_count>5</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2022-06-10 16:24:14 -0700</bug_when>
    <thetext>(In reply to Kimmo Kinnunen from comment #4)
&gt; Hopefully affects bug 241508

It should! I&apos;ve had a post-commit bot testing workspace builds &lt;https://build.webkit.org/#/builders/463&gt;, which sees 1-2 minute incremental builds in the best case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875589</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-13 12:21:47 -0700</bug_when>
    <thetext>Committed r295496 (251501@main): &lt;https://commits.webkit.org/251501@main&gt;

Reviewed commits have been landed. Closing PR #1306 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1875742</commentid>
    <comment_count>7</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2022-06-14 03:49:09 -0700</bug_when>
    <thetext>*** Bug 241508 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>