<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>241297</bug_id>
          
          <creation_ts>2022-06-03 18:09:31 -0700</creation_ts>
          <short_desc>[PGO] WebKit always uses empty profiling data on release builds</short_desc>
          <delta_ts>2022-06-03 19:19:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Elliott Williams">emw</assigned_to>
          <cc>emw</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1874089</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2022-06-03 18:09:31 -0700</bug_when>
    <thetext>PROFILE_DATA_PATH_INTERNAL_YES = $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.profdata.compressed;

We&apos;re missing a `WebKitAdditions` in the release build path.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874090</commentid>
    <comment_count>1</comment_count>
    <who name="Elliott Williams">emw</who>
    <bug_when>2022-06-03 18:11:48 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/1304</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874091</commentid>
    <comment_count>2</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2022-06-03 18:11:52 -0700</bug_when>
    <thetext>(In reply to Wenson Hsieh from comment #0)
&gt; PROFILE_DATA_PATH_INTERNAL_YES =
&gt; $(BUILT_PRODUCTS_DIR)$(WK_LIBRARY_HEADERS_FOLDER_PATH)/Profiling/WebKit.
&gt; profdata.compressed;
&gt; 
&gt; We&apos;re missing a `WebKitAdditions` in the release build path.

(More specifically, this should be `…/WebKitAdditions/Profiling/WebKit`)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874097</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-06-03 19:18:15 -0700</bug_when>
    <thetext>Committed r295259 (251305@main): &lt;https://commits.webkit.org/251305@main&gt;

Reviewed commits have been landed. Closing PR #1304 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874098</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-06-03 19:19:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/94376562&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>