24129 2009-02-24 11:22:31 -0800 Dropdown list doesn't open when onmousedown handler returns false 2022-09-29 12:53:54 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) All All RESOLVED INVALID http://www.emule-island.com/ HasReduction P2 Normal --- 0 jasneet webkit-unassigned ahmad.saleem792 ap barraclough bfulgham ian jasneet rakeshchaitan oldest_to_newest 110777 0 jasneet 2009-02-24 11:22:31 -0800 I Steps: Go to http://www.emule-island.com/ II Issue : In right column, Dropdown for Films is not working. On clicking dropdown arrow, doesn't show dropdown list III Conclusion: In the javascript, they are setting the <div>s with className "menuItem" with the following: alldiv[i].onmousedown = selectMenuItem; in which selectMenuItem is a function defined as: function selectMenuItem(e) { if(document.all)e = event; if (e.target) source = e.target; else if (e.srcElement) source = e.srcElement; if (source.nodeType == 3) // defeat Safari bug source = source.parentNode; return false; } This is causing the issue in webkit. IV Other Browsers: FF3: OK IE7: OK V Nightly tested: 41018 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=6932 110778 1 27923 jasneet 2009-02-24 11:22:50 -0800 Created attachment 27923 reduced testcase 574485 2 barraclough 2012-03-08 18:57:36 -0800 This doesn't look like an issue in the JSC part of the code, like bindings or events? 576455 3 rakeshchaitan 2012-03-12 13:24:44 -0700 (In reply to comment #2) > This doesn't look like an issue in the JSC part of the code, like bindings or events? The event handler "selectMenuItem" in the script mentioned above returns false. Hence the default action is prevented from JSEventListener::handleEvent() (http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/JSEventListener.cpp#L156). If returning false from event handler is for preventing default action then this is an expected behavior? 576467 4 ap 2012-03-12 13:35:36 -0700 If it still works in Firefox and IE, then it may not be expected! 577540 5 rakeshchaitan 2012-03-13 10:54:59 -0700 (In reply to comment #4) > If it still works in Firefox and IE, then it may not be expected! The specs http://dev.w3.org/html5/spec/Overview.html#event-handler-attributes says "If return value is a boolean with the value false, then cancel the event." and I think our implementation is as per specs. Shall we keep it as it is or make it similar to Firefox/IE? 577594 6 ap 2012-03-13 11:28:22 -0700 I don't have a complete answer. If HTML5 is blatantly incompatible with both IE and Firefox, then the spec and WebKit should likely change. But there may be something more subtle in this particular case. 581959 7 ian 2012-03-19 11:14:52 -0700 The event should be canceled, that's not the problem here. The difference is that in Firefox, the dropdown drops before the event is fired. Compare the behaviours on this test: http://software.hixie.ch/utilities/js/live-dom-viewer/saved/1412 The HTML spec doesn't say anything about how the widgets are implemented at that level. It differs from platform to platform, so there's not much the spec _can_ say. For compatibility, though, it seems that select widgets implemented using dropdowns should drop down before the mousedown event is fired at the DOM. 1902098 8 ahmad.saleem792 2022-09-29 10:59:01 -0700 *** Safari 16 *** log: object "[object HTMLSelectElement]" (311 props: 0="[object HTMLOptionElement]", autocomplete="", disabled=false, form="null"...) log: false log: object "[object HTMLDivElement]" (288 props: align="", title="", lang="", translate=true...) log: true *** Chrome Canary 108 *** log: object "[object HTMLSelectElement]" (338 props: 0="[object HTMLOptionElement]", autocomplete="", disabled=false, form="null"...) log: false log: object "[object HTMLDivElement]" (315 props: align="", title="", lang="", translate=true...) log: true *** Firefox Nightly 107 *** log: object "[object HTMLSelectElement]" (285 props: 0="[object HTMLOptionElement]", item=function item() {\n [native code]\n}, namedItem=function namedItem() {\n [native code]\n}, add=function add() {\n [native code]\n}...) log: false log: object "[object HTMLDivElement]" (261 props: align="", click=function click() {\n [native code]\n}, attachInternals=function attachInternals() {\n [native code]\n}, focus=function focus() {\n [native code]\n}...) log: true _________ Just wanted to share updated results based on test case from Comment 07. It seems to me that all browsers are showing same. Can someone confirm whether something else is required? Thanks! 1902152 9 ap 2022-09-29 12:53:54 -0700 Other browsers match Safari now, returning false from mousedown event handler prevents opening the menu. 27923 2009-02-24 11:22:50 -0800 2009-02-24 11:22:50 -0800 reduced testcase test_standard.html text/html 1031 jasneet PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+DQo8aHRtbD4NCjxoZWFkPg0KPHNjcmlw dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KZnVuY3Rpb24gaW5pdE1lbnVJdGVtcygpIHsNCgl2 YXIgYWxsZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoIkRJViIpDQoJZm9yKGk9 MDtpPGFsbGRpdi5sZW5ndGg7aSsrKSB7DQoJCWlmKGFsbGRpdltpXS5jbGFzc05hbWU9PSdtZW51 SXRlbScpIA0KCQl7DQoJCQlhbGxkaXZbaV0ub25tb3VzZWRvd24gPSBzZWxlY3RNZW51SXRlbTsN CgkJfQ0KCX0NCn0NCg0KZnVuY3Rpb24gc2VsZWN0TWVudUl0ZW0oZSkgew0KCWlmKGRvY3VtZW50 LmFsbCllID0gZXZlbnQ7DQoJaWYgKGUudGFyZ2V0KSBzb3VyY2UgPSBlLnRhcmdldDsgDQoJCQkJ ZWxzZSBpZiAoZS5zcmNFbGVtZW50KSBzb3VyY2UgPSBlLnNyY0VsZW1lbnQ7DQoJCQlpZiAoc291 cmNlLm5vZGVUeXBlID09IDMpIC8vIGRlZmVhdCBTYWZhcmkgYnVnDQoJCQkJc291cmNlID0gc291 cmNlLnBhcmVudE5vZGU7DQoJCQkJDQoJcmV0dXJuIGZhbHNlOw0KfQ0KDQpmdW5jdGlvbiBhZGRM b2FkRXZlbnQoZnVuYykgewkNCgl2YXIgb2xkb25sb2FkID0gd2luZG93Lm9ubG9hZDsNCglpZiAo dHlwZW9mIHdpbmRvdy5vbmxvYWQgIT0gJ2Z1bmN0aW9uJyl7DQogICAgCXdpbmRvdy5vbmxvYWQg PSBmdW5jOw0KCX0gZWxzZSB7DQoJCXdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpew0KCQlmdW5j KCk7DQoJCX0NCgl9IA0KfQ0KYWRkTG9hZEV2ZW50KGluaXRNZW51SXRlbXMpOw0KPC9zY3JpcHQ+ DQo8L2hlYWQ+DQo8Ym9keT4NCjxkaXYgY2xhc3M9Im1lbnVJdGVtIj4NCiAgPHNlbGVjdD4NCiAg ICA8b3B0aW9uIHZhbHVlPSIxIj5vcHRpb24gMTwvb3B0aW9uPg0KICAgIDxvcHRpb24gdmFsdWU9 IjIiPm9wdGlvbiAyPC9vcHRpb24+DQogIDwvc2VsZWN0Pg0KPC9kaXY+DQo8L2JvZHk+DQo8L2h0 bWw+DQo=