241255 2022-06-02 21:17:47 -0700 [LFC][FFC] FlexLayout::computeLogicalHeightForFlexItems should check if the logical height value is auto 2022-06-03 06:32:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1873789 0 zalan 2022-06-02 21:17:47 -0700 ssia 1873791 1 459984 zalan 2022-06-02 21:20:46 -0700 Created attachment 459984 [fast-cq]Patch 1873877 2 ews-feeder 2022-06-03 06:31:57 -0700 Committed r295203 (251260@main): <https://commits.webkit.org/251260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459984. 1873878 3 webkit-bug-importer 2022-06-03 06:32:13 -0700 <rdar://problem/94343289> 459984 2022-06-02 21:20:46 -0700 2022-06-03 06:31:58 -0700 [fast-cq]Patch bug-241255-20220602212045.patch text/plain 7539 zalan RnJvbSA4MjZkMDNkODQwOTJhNWMzNzNmN2ViZTM5MWE5ZTI3NjM3MjcyM2EyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDIgSnVuIDIwMjIgMjE6MTg6MDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbTEZDXVtGRkNd IEZsZXhMYXlvdXQ6OmNvbXB1dGVMb2dpY2FsSGVpZ2h0Rm9yRmxleEl0ZW1zCiBzaG91bGQgY2hl Y2sgaWYgdGhlIGxvZ2ljYWwgaGVpZ2h0IHZhbHVlIGlzIGF1dG8KIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDEyNTUKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKRmxleExheW91dCBzaG91bGQgYWx3YXlzIG9wZXJhdGUgb24gbG9naWNhbCB2YWx1ZXMgZXZl biBpZiBqdXN0IGNoZWNraW5nIHdoZXRoZXIgaGVpZ2h0L3dpZHRoIGlzIGF1dG8uCgoqIFNvdXJj ZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9GbGV4Rm9ybWF0dGluZ0Nv bnRleHQuY3BwOgooV2ViQ29yZTo6TGF5b3V0OjpGbGV4Rm9ybWF0dGluZ0NvbnRleHQ6OmNvbnZl cnRGbGV4SXRlbXNUb0xvZ2ljYWxTcGFjZSk6CiogU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1h dHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3BwOgooV2ViQ29yZTo6TGF5b3V0OjpGbGV4 TGF5b3V0Ojpjb21wdXRlTG9naWNhbEhlaWdodEZvckZsZXhJdGVtcyk6CiogU291cmNlL1dlYkNv cmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuaDoKKFdlYkNvcmU6 OkxheW91dDo6RmxleExheW91dDo6TG9naWNhbEZsZXhJdGVtOjpzZXRUb3ApOgooV2ViQ29yZTo6 TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0ZW06OnNldExlZnQpOgooV2ViQ29yZTo6 TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0ZW06OnNldFdpZHRoKToKKFdlYkNvcmU6 OkxheW91dDo6RmxleExheW91dDo6TG9naWNhbEZsZXhJdGVtOjpzZXRIZWlnaHQpOgooV2ViQ29y ZTo6TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0ZW06OnJlY3QgY29uc3QpOgooV2Vi Q29yZTo6TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0ZW06OnRvcExlZnQgY29uc3Qp OgooV2ViQ29yZTo6TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2FsRmxleEl0ZW06OnRvcCBjb25z dCk6CihXZWJDb3JlOjpMYXlvdXQ6OkZsZXhMYXlvdXQ6OkxvZ2ljYWxGbGV4SXRlbTo6Ym90dG9t IGNvbnN0KToKKFdlYkNvcmU6OkxheW91dDo6RmxleExheW91dDo6TG9naWNhbEZsZXhJdGVtOjps ZWZ0IGNvbnN0KToKKFdlYkNvcmU6OkxheW91dDo6RmxleExheW91dDo6TG9naWNhbEZsZXhJdGVt OjpyaWdodCBjb25zdCk6CihXZWJDb3JlOjpMYXlvdXQ6OkZsZXhMYXlvdXQ6OkxvZ2ljYWxGbGV4 SXRlbTo6d2lkdGggY29uc3QpOgooV2ViQ29yZTo6TGF5b3V0OjpGbGV4TGF5b3V0OjpMb2dpY2Fs RmxleEl0ZW06OmhlaWdodCBjb25zdCk6CihXZWJDb3JlOjpMYXlvdXQ6OkZsZXhMYXlvdXQ6Okxv Z2ljYWxGbGV4SXRlbTo6aXNIZWlnaHRBdXRvIGNvbnN0KToKKFdlYkNvcmU6OkxheW91dDo6Rmxl eExheW91dDo6TG9naWNhbEZsZXhJdGVtOjpMb2dpY2FsRmxleEl0ZW0pOgotLS0KIC4uLi9mbGV4 L0ZsZXhGb3JtYXR0aW5nQ29udGV4dC5jcHAgICAgICAgICAgICB8IDExICsrKysrLQogLi4uL2Zv cm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3BwICAgIHwgIDMgKy0KIC4uLi9mb3Jt YXR0aW5nQ29udGV4dHMvZmxleC9GbGV4TGF5b3V0LmggICAgICB8IDM5ICsrKysrKysrKysrLS0t LS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9m bGV4L0ZsZXhGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9y bWF0dGluZ0NvbnRleHRzL2ZsZXgvRmxleEZvcm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCAyNjZk ZWQ5YTc5Y2UuLjFkN2I3OGJlNGViZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0ZsZXhGb3JtYXR0 aW5nQ29udGV4dC5jcHAKQEAgLTIxNyw5ICsyMTcsMTYgQEAgRmxleExheW91dDo6TG9naWNhbEZs ZXhJdGVtcyBGbGV4Rm9ybWF0dGluZ0NvbnRleHQ6OmNvbnZlcnRGbGV4SXRlbXNUb0xvZ2ljYWxT cGEKICAgICB9OwogICAgIHJlb3JkZXJGbGV4SXRlbXNJZkFwcGxpY2FibGUoKTsKIAorICAgIGF1 dG8gZmxleERpcmVjdGlvbiA9IHJvb3QoKS5zdHlsZSgpLmZsZXhEaXJlY3Rpb24oKTsKKyAgICBh dXRvIGZsZXhEaXJlY3Rpb25Jc0lubGluZUF4aXMgPSBmbGV4RGlyZWN0aW9uID09IEZsZXhEaXJl Y3Rpb246OlJvdyB8fCBmbGV4RGlyZWN0aW9uID09IEZsZXhEaXJlY3Rpb246OlJvd1JldmVyc2U7 CiAgICAgYXV0byBsb2dpY2FsRmxleEl0ZW1MaXN0ID0gRmxleExheW91dDo6TG9naWNhbEZsZXhJ dGVtcyhmbGV4SXRlbUxpc3Quc2l6ZSgpKTsKLSAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGlu ZGV4IDwgZmxleEl0ZW1MaXN0LnNpemUoKTsgKytpbmRleCkKLSAgICAgICAgbG9naWNhbEZsZXhJ dGVtTGlzdFtpbmRleF0gPSB7IGZsZXhJdGVtTGlzdFtpbmRleF0ubWFyZ2luUmVjdCwgKmZsZXhJ dGVtTGlzdFtpbmRleF0ubGF5b3V0Qm94IH07CisgICAgZm9yIChzaXplX3QgaW5kZXggPSAwOyBp bmRleCA8IGZsZXhJdGVtTGlzdC5zaXplKCk7ICsraW5kZXgpIHsKKyAgICAgICAgYXV0byYgbGF5 b3V0Qm94ID0gKmZsZXhJdGVtTGlzdFtpbmRleF0ubGF5b3V0Qm94OworICAgICAgICBhdXRvJiBz dHlsZSA9IGxheW91dEJveC5zdHlsZSgpOworICAgICAgICBhdXRvIGxvZ2ljYWxXaWR0aFR5cGUg PSBmbGV4RGlyZWN0aW9uSXNJbmxpbmVBeGlzID8gc3R5bGUud2lkdGgoKS50eXBlKCkgOiBzdHls ZS5oZWlnaHQoKS50eXBlKCk7CisgICAgICAgIGF1dG8gbG9naWNhbEhlaWdodFR5cGUgPSBmbGV4 RGlyZWN0aW9uSXNJbmxpbmVBeGlzID8gc3R5bGUuaGVpZ2h0KCkudHlwZSgpIDogc3R5bGUud2lk dGgoKS50eXBlKCk7CisgICAgICAgIGxvZ2ljYWxGbGV4SXRlbUxpc3RbaW5kZXhdID0geyBmbGV4 SXRlbUxpc3RbaW5kZXhdLm1hcmdpblJlY3QsIGxvZ2ljYWxXaWR0aFR5cGUsIGxvZ2ljYWxIZWln aHRUeXBlLCBsYXlvdXRCb3ggfTsKKyAgICB9CiAgICAgcmV0dXJuIGxvZ2ljYWxGbGV4SXRlbUxp c3Q7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29u dGV4dHMvZmxleC9GbGV4TGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0 aW5nQ29udGV4dHMvZmxleC9GbGV4TGF5b3V0LmNwcAppbmRleCAxYWExMjMwMDAxNDEuLjEwMjg3 YjVlYzAzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9mbGV4L0ZsZXhMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3Jt YXR0aW5nQ29udGV4dHMvZmxleC9GbGV4TGF5b3V0LmNwcApAQCAtMjM3LDggKzIzNyw3IEBAIHZv aWQgRmxleExheW91dDo6Y29tcHV0ZUxvZ2ljYWxIZWlnaHRGb3JGbGV4SXRlbXMoTG9naWNhbEZs ZXhJdGVtcyYgZmxleEl0ZW1zLCBMCiAgICAgYXV0byBhbGlnbkl0ZW1zID0gZmxleEJveFN0eWxl KCkuYWxpZ25JdGVtcygpOwogCiAgICAgZm9yIChhdXRvJiBmbGV4SXRlbSA6IGZsZXhJdGVtcykg ewotICAgICAgICBhdXRvJiBoZWlnaHQgPSBmbGV4SXRlbS5zdHlsZSgpLmhlaWdodCgpOwotICAg ICAgICBpZiAoIWhlaWdodC5pc0F1dG8oKSkKKyAgICAgICAgaWYgKCFmbGV4SXRlbS5pc0hlaWdo dEF1dG8oKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBzd2l0Y2ggKGFsaWduSXRl bXMucG9zaXRpb24oKSkgewogICAgICAgICBjYXNlIEl0ZW1Qb3NpdGlvbjo6Tm9ybWFsOgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4L0Zs ZXhMYXlvdXQuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxl eC9GbGV4TGF5b3V0LmgKaW5kZXggOWM3N2Q4YjI2NzRiLi5hMDkxZjkxODA5ZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvZmxleC9GbGV4TGF5 b3V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9mbGV4 L0ZsZXhMYXlvdXQuaApAQCAtNDIsMjggKzQyLDM1IEBAIHB1YmxpYzoKIAogICAgIHN0cnVjdCBM b2dpY2FsRmxleEl0ZW0gewogICAgIHB1YmxpYzoKLSAgICAgICAgTG9naWNhbEZsZXhJdGVtKGNv bnN0IEZsZXhSZWN0JiwgY29uc3QgQ29udGFpbmVyQm94Jik7CisgICAgICAgIExvZ2ljYWxGbGV4 SXRlbShjb25zdCBGbGV4UmVjdCYsIExlbmd0aFR5cGUgd2lkdGhUeXBlLCBMZW5ndGhUeXBlIGhl aWdodFR5cGUsIGNvbnN0IENvbnRhaW5lckJveCYpOwogICAgICAgICBMb2dpY2FsRmxleEl0ZW0o KSA9IGRlZmF1bHQ7CiAKLSAgICAgICAgdm9pZCBzZXRUb3AoTGF5b3V0VW5pdCB0b3ApIHsgbV9t YXJnaW5SZWN0LnNldFRvcCh0b3ApOyB9Ci0gICAgICAgIHZvaWQgc2V0TGVmdChMYXlvdXRVbml0 IGxlZnQpIHsgbV9tYXJnaW5SZWN0LnNldExlZnQobGVmdCk7IH0KLSAgICAgICAgdm9pZCBzZXRX aWR0aChMYXlvdXRVbml0IHdpZHRoKSB7IG1fbWFyZ2luUmVjdC5zZXRXaWR0aCh3aWR0aCk7IH0K LSAgICAgICAgdm9pZCBzZXRIZWlnaHQoTGF5b3V0VW5pdCBoZWlnaHQpIHsgbV9tYXJnaW5SZWN0 LnNldEhlaWdodChoZWlnaHQpOyB9CisgICAgICAgIHZvaWQgc2V0VG9wKExheW91dFVuaXQgdG9w KSB7IG1fbWFyZ2luUmVjdC52YWx1ZS5zZXRUb3AodG9wKTsgfQorICAgICAgICB2b2lkIHNldExl ZnQoTGF5b3V0VW5pdCBsZWZ0KSB7IG1fbWFyZ2luUmVjdC52YWx1ZS5zZXRMZWZ0KGxlZnQpOyB9 CisgICAgICAgIHZvaWQgc2V0V2lkdGgoTGF5b3V0VW5pdCB3aWR0aCkgeyBtX21hcmdpblJlY3Qu dmFsdWUuc2V0V2lkdGgod2lkdGgpOyB9CisgICAgICAgIHZvaWQgc2V0SGVpZ2h0KExheW91dFVu aXQgaGVpZ2h0KSB7IG1fbWFyZ2luUmVjdC52YWx1ZS5zZXRIZWlnaHQoaGVpZ2h0KTsgfQogCi0g ICAgICAgIEZsZXhSZWN0IHJlY3QoKSBjb25zdCB7IHJldHVybiBtX21hcmdpblJlY3Q7IH0KLSAg ICAgICAgTGF5b3V0UG9pbnQgdG9wTGVmdCgpIGNvbnN0IHsgcmV0dXJuIG1fbWFyZ2luUmVjdC50 b3BMZWZ0KCk7IH0KLSAgICAgICAgTGF5b3V0VW5pdCB0b3AoKSBjb25zdCB7IHJldHVybiBtX21h cmdpblJlY3QudG9wKCk7IH0KLSAgICAgICAgTGF5b3V0VW5pdCBib3R0b20oKSBjb25zdCB7IHJl dHVybiBtX21hcmdpblJlY3QuYm90dG9tKCk7IH0KLSAgICAgICAgTGF5b3V0VW5pdCBsZWZ0KCkg Y29uc3QgeyByZXR1cm4gbV9tYXJnaW5SZWN0LmxlZnQoKTsgfQotICAgICAgICBMYXlvdXRVbml0 IHJpZ2h0KCkgY29uc3QgeyByZXR1cm4gbV9tYXJnaW5SZWN0LnJpZ2h0KCk7IH0KLSAgICAgICAg TGF5b3V0VW5pdCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fbWFyZ2luUmVjdC53aWR0aCgpOyB9 Ci0gICAgICAgIExheW91dFVuaXQgaGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gbV9tYXJnaW5SZWN0 LmhlaWdodCgpOyB9CisgICAgICAgIEZsZXhSZWN0IHJlY3QoKSBjb25zdCB7IHJldHVybiBtX21h cmdpblJlY3QudmFsdWU7IH0KKyAgICAgICAgTGF5b3V0UG9pbnQgdG9wTGVmdCgpIGNvbnN0IHsg cmV0dXJuIG1fbWFyZ2luUmVjdC52YWx1ZS50b3BMZWZ0KCk7IH0KKyAgICAgICAgTGF5b3V0VW5p dCB0b3AoKSBjb25zdCB7IHJldHVybiBtX21hcmdpblJlY3QudmFsdWUudG9wKCk7IH0KKyAgICAg ICAgTGF5b3V0VW5pdCBib3R0b20oKSBjb25zdCB7IHJldHVybiBtX21hcmdpblJlY3QudmFsdWUu Ym90dG9tKCk7IH0KKyAgICAgICAgTGF5b3V0VW5pdCBsZWZ0KCkgY29uc3QgeyByZXR1cm4gbV9t YXJnaW5SZWN0LnZhbHVlLmxlZnQoKTsgfQorICAgICAgICBMYXlvdXRVbml0IHJpZ2h0KCkgY29u c3QgeyByZXR1cm4gbV9tYXJnaW5SZWN0LnZhbHVlLnJpZ2h0KCk7IH0KKyAgICAgICAgTGF5b3V0 VW5pdCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fbWFyZ2luUmVjdC52YWx1ZS53aWR0aCgpOyB9 CisgICAgICAgIExheW91dFVuaXQgaGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gbV9tYXJnaW5SZWN0 LnZhbHVlLmhlaWdodCgpOyB9CisKKyAgICAgICAgYm9vbCBpc0hlaWdodEF1dG8oKSBjb25zdCB7 IHJldHVybiBtX21hcmdpblJlY3QuaGVpZ2h0VHlwZSA9PSBMZW5ndGhUeXBlOjpBdXRvOyB9CiAK ICAgICAgICAgY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlKCkgY29uc3QgeyByZXR1cm4gbV9sYXlv dXRCb3gtPnN0eWxlKCk7IH0KICAgICAgICAgY29uc3QgQ29udGFpbmVyQm94JiBsYXlvdXRCb3go KSBjb25zdCB7IHJldHVybiAqbV9sYXlvdXRCb3g7IH0KIAogICAgIHByaXZhdGU6Ci0gICAgICAg IEZsZXhSZWN0IG1fbWFyZ2luUmVjdDsKKyAgICAgICAgc3RydWN0IE1hcmdpblJlY3QgeworICAg ICAgICAgICAgRmxleFJlY3QgdmFsdWU7CisgICAgICAgICAgICBMZW5ndGhUeXBlIHdpZHRoVHlw ZSB7IExlbmd0aFR5cGU6OkF1dG8gfTsKKyAgICAgICAgICAgIExlbmd0aFR5cGUgaGVpZ2h0VHlw ZSB7IExlbmd0aFR5cGU6OkF1dG8gfTsKKyAgICAgICAgfTsKKyAgICAgICAgTWFyZ2luUmVjdCBt X21hcmdpblJlY3QgeyB9OwogICAgICAgICBDaGVja2VkUHRyPGNvbnN0IENvbnRhaW5lckJveD4g bV9sYXlvdXRCb3g7ICAgICAgICAKICAgICB9OwogICAgIHVzaW5nIExvZ2ljYWxGbGV4SXRlbXMg PSBWZWN0b3I8TG9naWNhbEZsZXhJdGVtPjsgICAgCkBAIC04Niw4ICs5Myw4IEBAIHByaXZhdGU6 CiAgICAgY29uc3QgUmVuZGVyU3R5bGUmIG1fZmxleEJveFN0eWxlOwogfTsKIAotaW5saW5lIEZs ZXhMYXlvdXQ6OkxvZ2ljYWxGbGV4SXRlbTo6TG9naWNhbEZsZXhJdGVtKGNvbnN0IEZsZXhSZWN0 JiBtYXJnaW5SZWN0LCBjb25zdCBDb250YWluZXJCb3gmIGxheW91dEJveCkKLSAgICA6IG1fbWFy Z2luUmVjdChtYXJnaW5SZWN0KQoraW5saW5lIEZsZXhMYXlvdXQ6OkxvZ2ljYWxGbGV4SXRlbTo6 TG9naWNhbEZsZXhJdGVtKGNvbnN0IEZsZXhSZWN0JiBtYXJnaW5SZWN0LCBMZW5ndGhUeXBlIHdp ZHRoVHlwZSwgTGVuZ3RoVHlwZSBoZWlnaHRUeXBlLCBjb25zdCBDb250YWluZXJCb3gmIGxheW91 dEJveCkKKyAgICA6IG1fbWFyZ2luUmVjdCh7IG1hcmdpblJlY3QsIHdpZHRoVHlwZSwgaGVpZ2h0 VHlwZSB9KQogICAgICwgbV9sYXlvdXRCb3gobGF5b3V0Qm94KQogewogfQotLSAKMi4zMi4wIChB cHBsZSBHaXQtMTMyKQoK