241252 2022-06-02 20:08:12 -0700 Optimize HTMLTokenizer::bufferASCIICharacter() 2022-06-03 07:38:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap webkit-bug-importer oldest_to_newest 1873773 0 cdumez 2022-06-02 20:08:12 -0700 Optimize HTMLTokenizer::bufferASCIICharacter() by appending several characters at once whenever possible. 1873774 1 cdumez 2022-06-02 20:17:41 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1265 1873813 2 ews-feeder 2022-06-02 22:42:38 -0700 Committed r295171 (251255@main): <https://commits.webkit.org/251255@main> Reviewed commits have been landed. Closing PR #1265 and removing active labels. 1873814 3 webkit-bug-importer 2022-06-02 22:43:13 -0700 <rdar://problem/94330783> 1873823 4 ap 2022-06-02 23:40:01 -0700 Is this actually an optimization? Seems like loop un-unrolling, this has to be slower than before? 1873895 5 cdumez 2022-06-03 07:38:30 -0700 (In reply to Alexey Proskuryakov from comment #4) > Is this actually an optimization? Seems like loop un-unrolling, this has to > be slower than before? I started A/B testing to confirm. In this case, the length of the literal is known at build time and the function is inlined so I wouldn't expect this to regress. However, I believe that appending all the characters at once to the Vector is beneficial so that it can make appropriate decisions internally about resizing its buffer. We'll see.