241231 2022-06-02 10:49:11 -0700 Regression(r294902) Web Inspector highlight gets stuck when hovering over items. 2022-06-02 18:20:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1873625 0 zalan 2022-06-02 10:49:11 -0700 <rdar://94257879> 1873632 1 459967 zalan 2022-06-02 11:16:19 -0700 Created attachment 459967 Patch 1873635 2 459967 simon.fraser 2022-06-02 11:20:35 -0700 Comment on attachment 459967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459967&action=review > COMMIT_MESSAGE:14 > +This problem could be addressed in a few different ways including > +- RenderLayer d'tor should always issue repaint when the "full repaint" flag is set (we may not be able to resolve the coordinates in d'tor) > +- call force repaint on the renderer and ignore the repaint optimization (hard to tell when to use forced repaint) > +- make sure repaint is actually issued before destroying the layer (local change. We may make the same mistake again) This level of detail might be better in the bug, rather than the commit message. > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:-957 > - // We only repaint |child| if we have a RenderLayer as its visual overflow may not be tracked by its parent. I guess this comment was stale? I see no layer checks here. 1873650 3 zalan 2022-06-02 11:58:50 -0700 Staring from r294902, when the RenderLayer says "I am scheduled for a full repaint", any subsequent repaint call on the associated renderer returns early (no repaint) as we are certain that a full repaint is going to be issued still within the current "rendering update" frame as part of the post-layout tasks. Except this one case when soon after marking the RenderLayer dirty with the "needs full repaint" flag, we destroy both the layer and the associated renderer. In such cases the layer has no chance to issue the repaint. This problem could be addressed in a few different ways including 1. RenderLayer d'tor should always issue repaint when the "full repaint" flag is set (we may not be able to resolve the coordinates in d'tor) 2. call force repaint on the renderer and ignore the repaint optimization (hard to tell when to use forced repaint) 3. make sure repaint is actually issued before destroying the layer (local change. We may make the same mistake again) Since this bug is very specific to the destroying/detaching flow, I think it's ok to go with #3. 1873651 4 459970 zalan 2022-06-02 12:00:13 -0700 Created attachment 459970 Patch 1873652 5 zalan 2022-06-02 12:00:49 -0700 > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:-957 > > - // We only repaint |child| if we have a RenderLayer as its visual overflow may not be tracked by its parent. > > I guess this comment was stale? I see no layer checks here. Yeah, I noticed it was stale and removed it. 1873734 6 ews-feeder 2022-06-02 17:08:09 -0700 Committed r295155 (251243@main): <https://commits.webkit.org/251243@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459970. 459967 2022-06-02 11:16:19 -0700 2022-06-02 12:00:11 -0700 Patch bug-241231-20220602111618.patch text/plain 4613 zalan RnJvbSBhZGI0YTNkNzA1YWRmMTFjOTc5NTRlNTM4MzRlOWRjZmVlM2VhYzMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDIgSnVuIDIwMjIgMTA6NTA6NDMgLTA3MDAKU3ViamVjdDogW1BBVENIXSBSZWdyZXNzaW9u KHIyOTQ5MDIpIFdlYiBJbnNwZWN0b3IgaGlnaGxpZ2h0IGdldHMgc3R1Y2sgd2hlbgogaG92ZXJp bmcgb3ZlciBpdGVtcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MTIzMQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpUaGlzIHBhdGNoIGVuc3VyZXMgdGhh dCByZXBhaW50KCkgZ29lcyB0aHJvdWdoIGZvciB0aGUgImFib3V0LXRvLWJlLWRlc3Ryb3llZCIg Y29udGVudC4KClN0YXJpbmcgZnJvbSByMjk0OTAyLCB3aGVuIHRoZSBSZW5kZXJMYXllciBzYXlz ICJJIGFtIHNjaGVkdWxlZCBmb3IgYSBmdWxsIHJlcGFpbnQiLCBhbnkgc3Vic2VxdWVudCByZXBh aW50IGNhbGwgb24gdGhlIGFzc29jaWF0ZWQgcmVuZGVyZXIgcmV0dXJucyBlYXJseSAobm8gcmVw YWludCkgYXMgd2UgYXJlIGNlcnRhaW4gdGhhdCBhIGZ1bGwgcmVwYWludCBpcyBnb2luZyB0byBi ZSBpc3N1ZWQgc3RpbGwgd2l0aGluIHRoZSBjdXJyZW50ICJyZW5kZXJpbmcgdXBkYXRlIiBmcmFt ZSBhcyBwYXJ0IG9mIHRoZSBwb3N0LWxheW91dCB0YXNrcy4KRXhjZXB0IHRoaXMgb25lIGNhc2Ug d2hlbiBzb29uIGFmdGVyIG1hcmtpbmcgdGhlIFJlbmRlckxheWVyIGRpcnR5IHdpdGggdGhlICJu ZWVkcyBmdWxsIHJlcGFpbnQiIGZsYWcsIHdlIGRlc3Ryb3kgYm90aCB0aGUgbGF5ZXIgYW5kIHRo ZSBhc3NvY2lhdGVkIHJlbmRlcmVyLiBJbiB0aGlzIGNhc2UgdGhlIGxheWVyIGhhcyBubyBjaGFu Y2UgdG8gaXNzdWUgdGhlIHJlcGFpbnQuCgpUaGlzIHByb2JsZW0gY291bGQgYmUgYWRkcmVzc2Vk IGluIGEgZmV3IGRpZmZlcmVudCB3YXlzIGluY2x1ZGluZwotIFJlbmRlckxheWVyIGQndG9yIHNo b3VsZCBhbHdheXMgaXNzdWUgcmVwYWludCB3aGVuIHRoZSAiZnVsbCByZXBhaW50IiBmbGFnIGlz IHNldCAod2UgbWF5IG5vdCBiZSBhYmxlIHRvIHJlc29sdmUgdGhlIGNvb3JkaW5hdGVzIGluIGQn dG9yKQotIGNhbGwgZm9yY2UgcmVwYWludCBvbiB0aGUgcmVuZGVyZXIgYW5kIGlnbm9yZSB0aGUg cmVwYWludCBvcHRpbWl6YXRpb24gKGhhcmQgdG8gdGVsbCB3aGVuIHRvIHVzZSBmb3JjZWQgcmVw YWludCkKLSBtYWtlIHN1cmUgcmVwYWludCBpcyBhY3R1YWxseSBpc3N1ZWQgYmVmb3JlIGRlc3Ry b3lpbmcgdGhlIGxheWVyIChsb2NhbCBjaGFuZ2UuIFdlIG1heSBtYWtlIHRoZSBzYW1lIG1pc3Rh a2UgYWdhaW4pCgpTaW5jZSB0aGlzIGJ1ZyBpcyB2ZXJ5IHNwZWNpZmljIHRvIHRoZSBkZXN0cm95 aW5nL2RldGFjaGluZyBmbG93LCBJIHRoaW5rIGl0J3Mgb2sgdG8gZ28gd2l0aCB0aGUgbGFzdCBz b2x1dGlvbi4KCiogTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFpbnQtcmVuZGVyZXItd2l0 aC1sYXllci1vbi1kZXRhY2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKiBMYXlvdXRUZXN0cy9mYXN0 L3JlcGFpbnQvcmVwYWludC1yZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC5odG1sOiBBZGRl ZC4KKiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwOgooV2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxkZXI6OmRldGFjaEZyb21SZW5kZXJFbGVtZW50 KToKLS0tCiAuLi4vcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcCAgfCAg MyArLQogLi4ucmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2gtZXhwZWN0ZWQudHh0IHwgIDEg KwogLi4ucmVwYWludC1yZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC5odG1sIHwgMzMgKysr KysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvcmVwYWludC9y ZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNoLWV4cGVjdGVkLnR4dAogY3JlYXRl IG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXJlbmRlcmVyLXdp dGgtbGF5ZXItb24tZGV0YWNoLmh0bWwKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcAppbmRleCAwYTczODNiYzBlZmEu LjU4MTU2MGE1NDI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0 aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv dXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCkBAIC05NTMsMTIgKzk1MywxMSBAQCBSZW5k ZXJQdHI8UmVuZGVyT2JqZWN0PiBSZW5kZXJUcmVlQnVpbGRlcjo6ZGV0YWNoRnJvbVJlbmRlckVs ZW1lbnQoUmVuZGVyRWxlbWVudAogICAgIC8vIHRoYXQgYSBwb3NpdGlvbmVkIGNoaWxkIGdvdCB5 YW5rZWQpLiBXZSBhbHNvIHJlcGFpbnQsIHNvIHRoYXQgdGhlIGFyZWEgZXhwb3NlZCB3aGVuIHRo ZSBjaGlsZAogICAgIC8vIGRpc2FwcGVhcnMgZ2V0cyByZXBhaW50ZWQgcHJvcGVybHkuCiAgICAg aWYgKCFwYXJlbnQucmVuZGVyVHJlZUJlaW5nRGVzdHJveWVkKCkgJiYgY2hpbGQuZXZlckhhZExh eW91dCgpKSB7Ci0gICAgICAgIGNoaWxkLnNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2Fs YygpOwotICAgICAgICAvLyBXZSBvbmx5IHJlcGFpbnQgfGNoaWxkfCBpZiB3ZSBoYXZlIGEgUmVu ZGVyTGF5ZXIgYXMgaXRzIHZpc3VhbCBvdmVyZmxvdyBtYXkgbm90IGJlIHRyYWNrZWQgYnkgaXRz IHBhcmVudC4KICAgICAgICAgaWYgKGNoaWxkLmlzQm9keSgpKQogICAgICAgICAgICAgcGFyZW50 LnZpZXcoKS5yZXBhaW50Um9vdENvbnRlbnRzKCk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IGNoaWxkLnJlcGFpbnQoKTsKKyAgICAgICAgY2hpbGQuc2V0TmVlZHNMYXlvdXRBbmRQcmVmV2lk dGhzUmVjYWxjKCk7CiAgICAgfQogCiAgICAgLy8gSWYgd2UgaGF2ZSBhIGxpbmUgYm94IHdyYXBw ZXIsIGRlbGV0ZSBpdC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBh aW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNoLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjdlZjIy ZTlhNDMxYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBh aW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx IEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcmVwYWludC1y ZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBh aW50L3JlcGFpbnQtcmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2guaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjhlMjI0ODljNTMyYgotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5 ZXItb24tZGV0YWNoLmh0bWwKQEAgLTAsMCArMSwzMyBAQAorPHN0eWxlPgorI3JlbW92ZV9tZSB7 CisgIHRyYW5zZm9ybTogdHJhbnNsYXRlWCgxMHB4KTsKKyAgYmFja2dyb3VuZC1jb2xvcjogcmVk OworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogMTAwcHg7Cit9Cis8L3N0eWxlPgorPCEtLSBQ QVNTIGlmIG5vIHJlZCAtLT4KKzxkaXYgaWQ9cmVtb3ZlX21lPjwvZGl2PgorPHByZSBpZD1yZXN1 bHQ+PC9wcmU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgIHRlc3RSdW5u ZXIud2FpdFVudGlsRG9uZSgpOworICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKK30KKworZG9j dW1lbnQuYm9keS5vZmZzZXRIZWlnaHQ7CisKK3NldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgIGlm ICh3aW5kb3cuaW50ZXJuYWxzKQorICAgIGludGVybmFscy5zdGFydFRyYWNraW5nUmVwYWludHMo KTsKKyAgCisgIHJlbW92ZV9tZS5yZW1vdmUoKTsKKworICBpZiAod2luZG93LmludGVybmFscykg eworICAgIHJlc3VsdC5pbm5lclRleHQgPSBpbnRlcm5hbHMucmVwYWludFJlY3RzQXNUZXh0KCku aW5kZXhPZigiMTggOCAxMDAgMTAwIikgIT0gLTEgPyAiUEFTUyIgOiAiRkFJTCI7CisgICAgaW50 ZXJuYWxzLnN0b3BUcmFja2luZ1JlcGFpbnRzKCk7CisgIH0KKyAgaWYgKHdpbmRvdy50ZXN0UnVu bmVyKQorICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfSwgMSk7Cis8L3NjcmlwdD4KXCBO byBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCi0tIAoyLjMyLjAgKEFwcGxlIEdpdC0xMzIpCgo= 459970 2022-06-02 12:00:13 -0700 2022-06-02 18:20:48 -0700 Patch bug-241231-20220602120012.patch text/plain 4057 zalan RnJvbSA2MGUzYjRiOTViNzEzYjRlYTgwZGUxYmMzYzZjMzkxZTdiY2EwM2Y2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDIgSnVuIDIwMjIgMTA6NTA6NDMgLTA3MDAKU3ViamVjdDogW1BBVENIXSBSZWdyZXNzaW9u KHIyOTQ5MDIpIFdlYiBJbnNwZWN0b3IgaGlnaGxpZ2h0IGdldHMgc3R1Y2sgd2hlbgogaG92ZXJp bmcgb3ZlciBpdGVtcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MTIzMQoKUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgoKVGhpcyBwYXRjaCBlbnN1cmVzIHRoYXQg cmVwYWludCgpIGdvZXMgdGhyb3VnaCBmb3IgdGhlICJhYm91dC10by1iZS1kZXN0cm95ZWQiIGNv bnRlbnQuCgpTdGFyaW5nIGZyb20gcjI5NDkwMiwgd2hlbiB0aGUgUmVuZGVyTGF5ZXIgc2F5cyAi SSBhbSBzY2hlZHVsZWQgZm9yIGEgZnVsbCByZXBhaW50IiwgYW55IHN1YnNlcXVlbnQgcmVwYWlu dCBjYWxsIG9uIHRoZSBhc3NvY2lhdGVkIHJlbmRlcmVyIHJldHVybnMgZWFybHkgKG5vIHJlcGFp bnQpIGFzIHdlIGFyZSBjZXJ0YWluIHRoYXQgYSBmdWxsIHJlcGFpbnQgaXMgZ29pbmcgdG8gYmUg aXNzdWVkIHN0aWxsIHdpdGhpbiB0aGUgY3VycmVudCAicmVuZGVyaW5nIHVwZGF0ZSIgZnJhbWUg YXMgcGFydCBvZiB0aGUgcG9zdC1sYXlvdXQgdGFza3MuCkV4Y2VwdCB0aGlzIG9uZSBjYXNlIHdo ZW4gc29vbiBhZnRlciBtYXJraW5nIHRoZSBSZW5kZXJMYXllciBkaXJ0eSB3aXRoIHRoZSAibmVl ZHMgZnVsbCByZXBhaW50IiBmbGFnLCB3ZSBkZXN0cm95IGJvdGggdGhlIGxheWVyIGFuZCB0aGUg YXNzb2NpYXRlZCByZW5kZXJlci4gSW4gdGhpcyBjYXNlIHRoZSBsYXllciBoYXMgbm8gY2hhbmNl IHRvIGlzc3VlIHRoZSByZXBhaW50LgoKKiBMYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcmVwYWlu dC1yZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC1leHBlY3RlZC50eHQ6IEFkZGVkLgoqIExh eW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0 YWNoLmh0bWw6IEFkZGVkLgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5k ZXJUcmVlQnVpbGRlci5jcHA6CihXZWJDb3JlOjpSZW5kZXJUcmVlQnVpbGRlcjo6ZGV0YWNoRnJv bVJlbmRlckVsZW1lbnQpOgotLS0KIC4uLi9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1 aWxkZXIuY3BwICB8ICAzICstCiAuLi5yZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC1leHBl Y3RlZC50eHQgfCAgMSArCiAuLi5yZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNo Lmh0bWwgfCAzMyArKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDM1IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMv ZmFzdC9yZXBhaW50L3JlcGFpbnQtcmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2gtZXhwZWN0 ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFp bnQtcmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2guaHRtbAoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCmluZGV4 IDBhNzM4M2JjMGVmYS4uNTgxNTYwYTU0MjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAgLTk1MywxMiAr OTUzLDExIEBAIFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IFJlbmRlclRyZWVCdWlsZGVyOjpkZXRh Y2hGcm9tUmVuZGVyRWxlbWVudChSZW5kZXJFbGVtZW50CiAgICAgLy8gdGhhdCBhIHBvc2l0aW9u ZWQgY2hpbGQgZ290IHlhbmtlZCkuIFdlIGFsc28gcmVwYWludCwgc28gdGhhdCB0aGUgYXJlYSBl eHBvc2VkIHdoZW4gdGhlIGNoaWxkCiAgICAgLy8gZGlzYXBwZWFycyBnZXRzIHJlcGFpbnRlZCBw cm9wZXJseS4KICAgICBpZiAoIXBhcmVudC5yZW5kZXJUcmVlQmVpbmdEZXN0cm95ZWQoKSAmJiBj aGlsZC5ldmVySGFkTGF5b3V0KCkpIHsKLSAgICAgICAgY2hpbGQuc2V0TmVlZHNMYXlvdXRBbmRQ cmVmV2lkdGhzUmVjYWxjKCk7Ci0gICAgICAgIC8vIFdlIG9ubHkgcmVwYWludCB8Y2hpbGR8IGlm IHdlIGhhdmUgYSBSZW5kZXJMYXllciBhcyBpdHMgdmlzdWFsIG92ZXJmbG93IG1heSBub3QgYmUg dHJhY2tlZCBieSBpdHMgcGFyZW50LgogICAgICAgICBpZiAoY2hpbGQuaXNCb2R5KCkpCiAgICAg ICAgICAgICBwYXJlbnQudmlldygpLnJlcGFpbnRSb290Q29udGVudHMoKTsKICAgICAgICAgZWxz ZQogICAgICAgICAgICAgY2hpbGQucmVwYWludCgpOworICAgICAgICBjaGlsZC5zZXROZWVkc0xh eW91dEFuZFByZWZXaWR0aHNSZWNhbGMoKTsKICAgICB9CiAKICAgICAvLyBJZiB3ZSBoYXZlIGEg bGluZSBib3ggd3JhcHBlciwgZGVsZXRlIGl0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9yZXBhaW50L3JlcGFpbnQtcmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2gtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFpbnQtcmVuZGVyZXItd2l0aC1sYXll ci1vbi1kZXRhY2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMC4uN2VmMjJlOWE0MzFhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9yZXBhaW50L3JlcGFpbnQtcmVuZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2gtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEgQEAKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVw YWludC9yZXBhaW50LXJlbmRlcmVyLXdpdGgtbGF5ZXItb24tZGV0YWNoLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L3JlcGFpbnQvcmVwYWludC1yZW5kZXJlci13aXRoLWxheWVyLW9uLWRldGFjaC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uOGUyMjQ4OWM1MzJi Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L3JlcGFpbnQtcmVu ZGVyZXItd2l0aC1sYXllci1vbi1kZXRhY2guaHRtbApAQCAtMCwwICsxLDMzIEBACis8c3R5bGU+ CisjcmVtb3ZlX21lIHsKKyAgdHJhbnNmb3JtOiB0cmFuc2xhdGVYKDEwcHgpOworICBiYWNrZ3Jv dW5kLWNvbG9yOiByZWQ7CisgIHdpZHRoOiAxMDBweDsKKyAgaGVpZ2h0OiAxMDBweDsKK30KKzwv c3R5bGU+Cis8IS0tIFBBU1MgaWYgbm8gcmVkIC0tPgorPGRpdiBpZD1yZW1vdmVfbWU+PC9kaXY+ Cis8cHJlIGlkPXJlc3VsdD48L3ByZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOworfQorCitkb2N1bWVudC5ib2R5Lm9mZnNldEhlaWdodDsKKworc2V0VGltZW91dChmdW5j dGlvbigpIHsKKyAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnN0YXJ0VHJh Y2tpbmdSZXBhaW50cygpOworICAKKyAgcmVtb3ZlX21lLnJlbW92ZSgpOworCisgIGlmICh3aW5k b3cuaW50ZXJuYWxzKSB7CisgICAgcmVzdWx0LmlubmVyVGV4dCA9IGludGVybmFscy5yZXBhaW50 UmVjdHNBc1RleHQoKS5pbmRleE9mKCIxOCA4IDEwMCAxMDAiKSAhPSAtMSA/ICJQQVNTIiA6ICJG QUlMIjsKKyAgICBpbnRlcm5hbHMuc3RvcFRyYWNraW5nUmVwYWludHMoKTsKKyAgfQorICBpZiAo d2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCAxKTsK Kzwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKLS0gCjIuMzIuMCAoQXBwbGUg R2l0LTEzMikKCg==