241164 2022-05-31 17:15:39 -0700 text-align: match-parent on root handles direction incorrectly 2022-06-01 22:07:15 -0700 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kiet.ho ntim kiet.ho ntim webkit-bug-importer oldest_to_newest 1873180 0 kiet.ho 2022-05-31 17:15:39 -0700 Failing WPT test: https://wpt.fyi/results/css/css-text/text-align/text-align-match-parent-root-rtl.html?label=master&label=experimental&aligned&q=text-align-match-parent-root-rtl.html 1873207 1 ntim 2022-05-31 19:48:48 -0700 We do use the direction of the parent, which is effectively why it's wrong for the WPT: https://webkit-search.igalia.com/webkit/rev/00d01db2338b1568d39aa439334f39f0353d0b00/Source/WebCore/style/StyleBuilderConverter.h#617-622 There's no parent in the WPT, so it should just behave like `text-align: start`. 1873208 2 kiet.ho 2022-05-31 19:51:18 -0700 (In reply to Tim Nguyen (:ntim) from comment #1) > We do use the direction of the parent, which is effectively why it's wrong > for the WPT: > https://webkit-search.igalia.com/webkit/rev/ > 00d01db2338b1568d39aa439334f39f0353d0b00/Source/WebCore/style/ > StyleBuilderConverter.h#617-622 > > There's no parent in the WPT, so it should just behave like `text-align: > start`. I see what you mean now - I didn't want to give this a generic "failing WPT test" title, but I also didn't do any digging into the root cause, so I just named it according to my best guess. 1873284 3 ntim 2022-06-01 05:51:23 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1208 1873513 4 ews-feeder 2022-06-01 22:06:16 -0700 Committed r295120 (251211@main): <https://commits.webkit.org/251211@main> Reviewed commits have been landed. Closing PR #1208 and removing active labels. 1873514 5 webkit-bug-importer 2022-06-01 22:07:15 -0700 <rdar://problem/94266878>