241128 2022-05-31 06:29:30 -0700 [WPE][GTK] Expose ENABLE_VIDEO build option 2022-06-02 12:47:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED INVALID P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply mcatanzaro oldest_to_newest 1872954 0 mcatanzaro 2022-05-31 06:29:30 -0700 We should expose ENABLE_VIDEO as a public build option because it allows disabling GStreamer, a major dependency. This is useful on embedded systems where video is not needed. 1872957 1 mcatanzaro 2022-05-31 06:31:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1181 1873012 2 ews-feeder 2022-05-31 10:06:29 -0700 Committed r295057 (251152@main): <https://commits.webkit.org/251152@main> Reviewed commits have been landed. Closing PR #1181 and removing active labels. 1873069 3 aperez 2022-05-31 12:20:09 -0700 (In reply to Michael Catanzaro from comment #0) > We should expose ENABLE_VIDEO as a public build option because it allows > disabling GStreamer, a major dependency. This is useful on embedded systems > where video is not needed. For future reference, in case someone arrives to this bug trying to avoid the GStreamer dependency in their builds: ENABLE_VIDEO and ENABLE_WEB_AUDIO need to be *both disabled* in order for the WebKit WPE and GTK ports to avoid the GStreamer dependency. 1873094 4 mcatanzaro 2022-05-31 13:21:18 -0700 Oh... and that option is not public either. I suppose I'd better expose that too? 1873181 5 mcatanzaro 2022-05-31 17:18:20 -0700 Maybe I should change this to USE_GSTREAMER instead? That can toggle both ENABLE_VIDEO and ENABLE_WEB_AUDIO. 1873629 6 mcatanzaro 2022-06-02 11:11:33 -0700 ENABLE_VIDEO and ENABLE_WEB_AUDIO were both already public, in GStreamerDefinitions.cmake: WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON) Adrian and I were both wrong. I'll just revert this. 1873630 7 mcatanzaro 2022-06-02 11:13:51 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/1249 1873661 8 ews-feeder 2022-06-02 12:19:48 -0700 Committed r295136 (251227@main): <https://commits.webkit.org/251227@main> Reviewed commits have been landed. Closing PR #1249 and removing active labels.