241105 2022-05-30 11:15:30 -0700 Ensure logical properties have skip-builder 2022-05-31 06:43:04 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 obrufau obrufau esprehn+autocc ews-watchlist glenn gyuyoung.kim joepeck macpherson menard ntim simon.fraser webkit-bug-importer oldest_to_newest 1872787 0 obrufau 2022-05-30 11:15:30 -0700 Builder::applyProperty resolves logical properties into physical ones. So there is no need to define BuilderCustom methods for them. Thus, most already have skip-builder:true. However, contain-intrinsic-block-size and contain-intrinsic-inline-size don't have that, and then they have some unnecessary methods in BuilderCustom. 1872790 1 459869 obrufau 2022-05-30 11:21:01 -0700 Created attachment 459869 Patch 1872931 2 459869 ntim 2022-05-31 04:06:23 -0700 Comment on attachment 459869 Patch Nice cleanup! 1872958 3 ews-feeder 2022-05-31 06:40:02 -0700 Committed r295050 (251145@main): <https://commits.webkit.org/251145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459869. 1872961 4 webkit-bug-importer 2022-05-31 06:41:13 -0700 <rdar://problem/94147952> 1872965 5 cathiechen 2022-05-31 06:43:04 -0700 Thanks, Oriol! The patch looks good to me:) 459869 2022-05-30 11:21:01 -0700 2022-05-31 06:40:03 -0700 Patch bug-241105-20220530202100.patch text/plain 6148 obrufau RnJvbSA2ZWEyYTdiMmU3ODA1NWNlZmEyZTI2MzJhZDRmOTA5ZjE3YTE1Yzg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPcmlvbCBCcnVmYXUgPG9icnVmYXVAaWdhbGlhLmNvbT4KRGF0 ZTogTW9uLCAzMCBNYXkgMjAyMiAxOToyMDo1NCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEVuc3Vy ZSBsb2dpY2FsIHByb3BlcnRpZXMgaGF2ZSBza2lwLWJ1aWxkZXIKIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDExMDUKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKQnVpbGRlcjo6YXBwbHlQcm9wZXJ0eSByZXNvbHZlcyBsb2dpY2FsIHByb3BlcnRpZXMgaW50 byBwaHlzaWNhbCBvbmVzLgpTbyB0aGVyZSBpcyBubyBuZWVkIHRvIGRlZmluZSBCdWlsZGVyQ3Vz dG9tIG1ldGhvZHMgZm9yIHRoZW0uClRodXMsIG1vc3QgYWxyZWFkeSBoYXZlIHNraXAtYnVpbGRl cjp0cnVlLiBUaGlzIHBhdGNoIGNvdmVycyB0aGUgb25seQp0d28gZXhjZXB0aW9ucy4KCk5vIHRl c3Qgc2luY2UgdGhlcmUgc2hvdWxkIGJlIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KCiogU291cmNl L1dlYkNvcmUvY3NzL0NTU1Byb3BlcnRpZXMuanNvbjoKRmxhZyBjb250YWluLWludHJpbnNpYy1i bG9jay1zaXplIGFuZCBjb250YWluLWludHJpbnNpYy1pbmxpbmUtc2l6ZSB3aXRoCnNraXAtYnVp bGRlcjp0cnVlLgoKKiBTb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGw6ClJlcXVpcmUgbG9n aWNhbCBwcm9wZXJ0aWVzIHRvIGhhdmUgc2tpcC1idWlsZGVyOnRydWUuCgoqIFNvdXJjZS9XZWJD b3JlL3N0eWxlL1N0eWxlQnVpbGRlckN1c3RvbS5oOgooV2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJD dXN0b206OmFwcGx5SW5pdGlhbENvbnRhaW5JbnRyaW5zaWNCbG9ja1NpemUpOiBEZWxldGVkLgoo V2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJDdXN0b206OmFwcGx5SW5oZXJpdENvbnRhaW5JbnRyaW5z aWNCbG9ja1NpemUpOiBEZWxldGVkLgooV2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJDdXN0b206OmFw cGx5VmFsdWVDb250YWluSW50cmluc2ljQmxvY2tTaXplKTogRGVsZXRlZC4KKFdlYkNvcmU6OlN0 eWxlOjpCdWlsZGVyQ3VzdG9tOjphcHBseUluaXRpYWxDb250YWluSW50cmluc2ljSW5saW5lU2l6 ZSk6IERlbGV0ZWQuCihXZWJDb3JlOjpTdHlsZTo6QnVpbGRlckN1c3RvbTo6YXBwbHlJbmhlcml0 Q29udGFpbkludHJpbnNpY0lubGluZVNpemUpOiBEZWxldGVkLgooV2ViQ29yZTo6U3R5bGU6OkJ1 aWxkZXJDdXN0b206OmFwcGx5VmFsdWVDb250YWluSW50cmluc2ljSW5saW5lU2l6ZSk6IERlbGV0 ZWQuClJlbW92ZSB1bm5lY2Vzc2FyeSBsb2dpYy4KLS0tCiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UHJvcGVydGllcy5qc29uICAgICB8ICA0ICstCiBTb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3Au cGwgICAgICAgICAgICB8ICAxICsKIFNvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlckN1 c3RvbS5oIHwgNTQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCA1NiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUHJvcGVydGllcy5qc29uIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnRp ZXMuanNvbgppbmRleCBiNzIyMGRlM2JiZC4uYTgyOWNjODE3OTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0aWVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1Byb3BlcnRpZXMuanNvbgpAQCAtNTI1MSw3ICs1MjUxLDcgQEAKICAgICAgICAgfSwKICAg ICAgICAgImNvbnRhaW4taW50cmluc2ljLWJsb2NrLXNpemUiOiB7CiAgICAgICAgICAgICAiY29k ZWdlbi1wcm9wZXJ0aWVzIjogewotICAgICAgICAgICAgICAgICJjdXN0b20iOiAiQWxsIiwKKyAg ICAgICAgICAgICAgICAic2tpcC1idWlsZGVyIjogdHJ1ZSwKICAgICAgICAgICAgICAgICAic2V0 dGluZ3MtZmxhZyI6ICJjc3NDb250YWluSW50cmluc2ljU2l6ZUVuYWJsZWQiLAogICAgICAgICAg ICAgICAgICJsb2dpY2FsLXByb3BlcnR5LWdyb3VwIjogewogICAgICAgICAgICAgICAgICAgICAi bmFtZSI6ICJjb250YWluLWludHJpbnNpYy1zaXplIiwKQEAgLTUyNjgsNyArNTI2OCw3IEBACiAg ICAgICAgIH0sCiAgICAgICAgICJjb250YWluLWludHJpbnNpYy1pbmxpbmUtc2l6ZSI6IHsKICAg ICAgICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7Ci0gICAgICAgICAgICAgICAgImN1c3Rv bSI6ICJBbGwiLAorICAgICAgICAgICAgICAgICJza2lwLWJ1aWxkZXIiOiB0cnVlLAogICAgICAg ICAgICAgICAgICJzZXR0aW5ncy1mbGFnIjogImNzc0NvbnRhaW5JbnRyaW5zaWNTaXplRW5hYmxl ZCIsCiAgICAgICAgICAgICAgICAgImxvZ2ljYWwtcHJvcGVydHktZ3JvdXAiOiB7CiAgICAgICAg ICAgICAgICAgICAgICJuYW1lIjogImNvbnRhaW4taW50cmluc2ljLXNpemUiLApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsIGIvU291cmNlL1dlYkNvcmUvY3NzL21h a2Vwcm9wLnBsCmluZGV4IGI4OTJhN2VlMTM1Li42MTY2ZmYxZTZkZiAxMDA3NTUKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtl cHJvcC5wbApAQCAtMTQ4Miw2ICsxNDgyLDcgQEAgZm9yZWFjaCBteSAkbmFtZSAoQG5hbWVzKSB7 CiAgIG5leHQgaWYgKGV4aXN0cyAkcHJvcGVydGllc1dpdGhTdHlsZUJ1aWxkZXJPcHRpb25zeyRu YW1lfXsibG9uZ2hhbmRzIn0pOwogICBuZXh0IGlmIChleGlzdHMgJHByb3BlcnRpZXNXaXRoU3R5 bGVCdWlsZGVyT3B0aW9uc3skbmFtZX17InNraXAtYnVpbGRlciJ9KTsKICAgbmV4dCBpZiAoZXhp c3RzICRzeW5vbnltc3skbmFtZX0pOworICBkaWUgIlByb3BlcnR5ICRuYW1lIGlzIGxvZ2ljYWwg YnV0IGRvZXNuJ3QgaGF2ZSBza2lwLWJ1aWxkZXJcbiIgaWYgaXNMb2dpY2FsKCRuYW1lKTsKIAog ICBteSAkaW5kZW50ID0gIiAgICAiOwogICBpZiAoISRwcm9wZXJ0aWVzV2l0aFN0eWxlQnVpbGRl ck9wdGlvbnN7JG5hbWV9eyJjdXN0b20ifXsiSW5pdGlhbCJ9KSB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxkZXJDdXN0b20uaCBiL1NvdXJjZS9XZWJDb3JlL3N0 eWxlL1N0eWxlQnVpbGRlckN1c3RvbS5oCmluZGV4IDNjOTlhMjFmNjRmLi5hNTdjZGZhYmY4NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmgKKysr IGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmgKQEAgLTg3LDggKzg3 LDYgQEAgcHVibGljOgogICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VTVE9NX0hBTkRMRVJTKENvbnRh aW4pOwogICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VTVE9NX0hBTkRMRVJTKENvbnRhaW5JbnRyaW5z aWNXaWR0aCk7CiAgICAgREVDTEFSRV9QUk9QRVJUWV9DVVNUT01fSEFORExFUlMoQ29udGFpbklu dHJpbnNpY0hlaWdodCk7Ci0gICAgREVDTEFSRV9QUk9QRVJUWV9DVVNUT01fSEFORExFUlMoQ29u dGFpbkludHJpbnNpY0Jsb2NrU2l6ZSk7Ci0gICAgREVDTEFSRV9QUk9QRVJUWV9DVVNUT01fSEFO RExFUlMoQ29udGFpbkludHJpbnNpY0lubGluZVNpemUpOwogICAgIERFQ0xBUkVfUFJPUEVSVFlf Q1VTVE9NX0hBTkRMRVJTKENvbnRlbnQpOwogICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VTVE9NX0hB TkRMRVJTKENvdW50ZXJJbmNyZW1lbnQpOwogICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VTVE9NX0hB TkRMRVJTKENvdW50ZXJSZXNldCk7CkBAIC0yMTU3LDU3ICsyMTU1LDUgQEAgaW5saW5lIHZvaWQg QnVpbGRlckN1c3RvbTo6YXBwbHlWYWx1ZUNvbnRhaW5JbnRyaW5zaWNIZWlnaHQoQnVpbGRlclN0 YXRlJiBidWlsZGUKICAgICBzdHlsZS5zZXRDb250YWluSW50cmluc2ljSGVpZ2h0KGxlbmd0aFZh bHVlKTsKIH0KIAotaW5saW5lIHZvaWQgQnVpbGRlckN1c3RvbTo6YXBwbHlJbml0aWFsQ29udGFp bkludHJpbnNpY0Jsb2NrU2l6ZShCdWlsZGVyU3RhdGUmIGJ1aWxkZXJTdGF0ZSkKLXsKLSAgICBh dXRvJiBzdHlsZSA9IGJ1aWxkZXJTdGF0ZS5zdHlsZSgpOwotICAgIGF1dG8gcmVzb2x2ZWRJRCA9 IENTU1Byb3BlcnR5OjpyZXNvbHZlRGlyZWN0aW9uQXdhcmVQcm9wZXJ0eShDU1NQcm9wZXJ0eUNv bnRhaW5JbnRyaW5zaWNCbG9ja1NpemUsIHN0eWxlLmRpcmVjdGlvbigpLCBzdHlsZS53cml0aW5n TW9kZSgpKTsKLQotICAgIGlmIChyZXNvbHZlZElEID09IENTU1Byb3BlcnR5Q29udGFpbkludHJp bnNpY0hlaWdodCkKLSAgICAgICAgYXBwbHlJbml0aWFsQ29udGFpbkludHJpbnNpY0hlaWdodChi dWlsZGVyU3RhdGUpOwotICAgIGVsc2UKLSAgICAgICAgYXBwbHlJbml0aWFsQ29udGFpbkludHJp bnNpY1dpZHRoKGJ1aWxkZXJTdGF0ZSk7Ci19Ci0KLWlubGluZSB2b2lkIEJ1aWxkZXJDdXN0b206 OmFwcGx5SW5oZXJpdENvbnRhaW5JbnRyaW5zaWNCbG9ja1NpemUoQnVpbGRlclN0YXRlJikKLXsK LX0KLQotaW5saW5lIHZvaWQgQnVpbGRlckN1c3RvbTo6YXBwbHlWYWx1ZUNvbnRhaW5JbnRyaW5z aWNCbG9ja1NpemUoQnVpbGRlclN0YXRlJiBidWlsZGVyU3RhdGUsIENTU1ZhbHVlJiB2YWx1ZSkK LXsKLSAgICBhdXRvJiBzdHlsZSA9IGJ1aWxkZXJTdGF0ZS5zdHlsZSgpOwotICAgIGF1dG8gcmVz b2x2ZWRJRCA9IENTU1Byb3BlcnR5OjpyZXNvbHZlRGlyZWN0aW9uQXdhcmVQcm9wZXJ0eShDU1NQ cm9wZXJ0eUNvbnRhaW5JbnRyaW5zaWNCbG9ja1NpemUsIHN0eWxlLmRpcmVjdGlvbigpLCBzdHls ZS53cml0aW5nTW9kZSgpKTsKLQotICAgIGlmIChyZXNvbHZlZElEID09IENTU1Byb3BlcnR5Q29u dGFpbkludHJpbnNpY0hlaWdodCkKLSAgICAgICAgYXBwbHlWYWx1ZUNvbnRhaW5JbnRyaW5zaWNI ZWlnaHQoYnVpbGRlclN0YXRlLCB2YWx1ZSk7Ci0gICAgZWxzZQotICAgICAgICBhcHBseVZhbHVl Q29udGFpbkludHJpbnNpY1dpZHRoKGJ1aWxkZXJTdGF0ZSwgdmFsdWUpOwotfQotCi1pbmxpbmUg dm9pZCBCdWlsZGVyQ3VzdG9tOjphcHBseUluaXRpYWxDb250YWluSW50cmluc2ljSW5saW5lU2l6 ZShCdWlsZGVyU3RhdGUmIGJ1aWxkZXJTdGF0ZSkKLXsKLSAgICBhdXRvJiBzdHlsZSA9IGJ1aWxk ZXJTdGF0ZS5zdHlsZSgpOwotICAgIGF1dG8gcmVzb2x2ZWRJRCA9IENTU1Byb3BlcnR5OjpyZXNv bHZlRGlyZWN0aW9uQXdhcmVQcm9wZXJ0eShDU1NQcm9wZXJ0eUNvbnRhaW5JbnRyaW5zaWNCbG9j a1NpemUsIHN0eWxlLmRpcmVjdGlvbigpLCBzdHlsZS53cml0aW5nTW9kZSgpKTsKLQotICAgIGlm IChyZXNvbHZlZElEID09IENTU1Byb3BlcnR5Q29udGFpbkludHJpbnNpY1dpZHRoKQotICAgICAg ICBhcHBseUluaXRpYWxDb250YWluSW50cmluc2ljV2lkdGgoYnVpbGRlclN0YXRlKTsKLSAgICBl bHNlCi0gICAgICAgIGFwcGx5SW5pdGlhbENvbnRhaW5JbnRyaW5zaWNIZWlnaHQoYnVpbGRlclN0 YXRlKTsKLX0KLQotaW5saW5lIHZvaWQgQnVpbGRlckN1c3RvbTo6YXBwbHlJbmhlcml0Q29udGFp bkludHJpbnNpY0lubGluZVNpemUoQnVpbGRlclN0YXRlJikKLXsKLX0KLQotaW5saW5lIHZvaWQg QnVpbGRlckN1c3RvbTo6YXBwbHlWYWx1ZUNvbnRhaW5JbnRyaW5zaWNJbmxpbmVTaXplKEJ1aWxk ZXJTdGF0ZSYgYnVpbGRlclN0YXRlLCBDU1NWYWx1ZSYgdmFsdWUpCi17Ci0gICAgYXV0byYgc3R5 bGUgPSBidWlsZGVyU3RhdGUuc3R5bGUoKTsKLSAgICBhdXRvIHJlc29sdmVkSUQgPSBDU1NQcm9w ZXJ0eTo6cmVzb2x2ZURpcmVjdGlvbkF3YXJlUHJvcGVydHkoQ1NTUHJvcGVydHlDb250YWluSW50 cmluc2ljQmxvY2tTaXplLCBzdHlsZS5kaXJlY3Rpb24oKSwgc3R5bGUud3JpdGluZ01vZGUoKSk7 Ci0KLSAgICBpZiAocmVzb2x2ZWRJRCA9PSBDU1NQcm9wZXJ0eUNvbnRhaW5JbnRyaW5zaWNXaWR0 aCkKLSAgICAgICAgYXBwbHlWYWx1ZUNvbnRhaW5JbnRyaW5zaWNXaWR0aChidWlsZGVyU3RhdGUs IHZhbHVlKTsKLSAgICBlbHNlCi0gICAgICAgIGFwcGx5VmFsdWVDb250YWluSW50cmluc2ljSGVp Z2h0KGJ1aWxkZXJTdGF0ZSwgdmFsdWUpOwotfQotCiB9CiB9Ci0tIAoyLjI1LjEKCg==