241081 2022-05-29 14:28:39 -0700 [webkitpy] run-benchmark script fails to find the lsof command on Linux 2022-06-14 03:12:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez dewei_zhu ews-watchlist glenn jbedard lmoura saam slewis webkit-bug-importer oldest_to_newest 1872653 0 clopez 2022-05-29 14:28:39 -0700 The lsof command is shipped on Linux typically on /usr/bin meanwhile on Mac is shipped on /usr/sbin The GTK perf bot is having issues with this and is causing the tests to fail. 1872657 1 459842 clopez 2022-05-29 14:49:57 -0700 Created attachment 459842 Patch 1872799 2 459842 lmoura 2022-05-30 12:24:13 -0700 Comment on attachment 459842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459842&action=review Looks good. Minor suggestion inline. > Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:71 > + lsof_path = shutil.which('lsof') if shutil.which('lsof') else '/usr/sbin/lsof' Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the extra which call? 1872800 3 lmoura 2022-05-30 12:24:56 -0700 (In reply to Lauro Moura from comment #2) > Comment on attachment 459842 [details] > > Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the > extra which call? Obviously, I meant `lsof_path = ...`. 1872838 4 459842 dewei_zhu 2022-05-30 16:15:02 -0700 Comment on attachment 459842 Patch r=me 1874205 5 webkit-bug-importer 2022-06-05 14:29:12 -0700 <rdar://problem/94408913> 1875725 6 clopez 2022-06-14 02:12:26 -0700 (In reply to Lauro Moura from comment #2) > Maybe `lsov_path = shutil.which('lsof') or '/usr/sbin/lsof'` to avoid the > extra which call? Good idea, seems cleaner. I will land with this 1875727 7 460226 clopez 2022-06-14 02:15:49 -0700 Created attachment 460226 Patch for landing 1875738 8 ews-feeder 2022-06-14 03:12:36 -0700 Committed r295520 (251525@main): <https://commits.webkit.org/251525@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460226. 459842 2022-05-29 14:49:57 -0700 2022-06-14 02:15:45 -0700 Patch bug-241081-20220529224956.patch text/plain 2130 clopez RnJvbSA0NGJhNGNhM2E5M2U5Y2IwZmFhNmUxYWQ5NzIzYmI4YTM5YzMzOWQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiA8Y2xvcGV6QGln YWxpYS5jb20+CkRhdGU6IFN1biwgMjkgTWF5IDIwMjIgMjI6Mjk6MTQgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbd2Via2l0cHldIHJ1bi1iZW5jaG1hcmsgc2NyaXB0IGZhaWxzIHRvIGZpbmQgdGhl IGxzb2YKIGNvbW1hbmQgb24gTGludXggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0MTA4MQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpUaGUgbHNvZiBjb21t YW5kIGlzIHNoaXBwZWQgb24gTGludXggdHlwaWNhbGx5IG9uIC91c3IvYmluIG1lYW53aGlsZSBv bgpNYWMgaXMgc2hpcHBlZCBvbiAvdXNyL3NiaW4uIENoZWNrIGlmIGlzIG9uIFBBVEggYmVmb3Jl IGRlZmF1bHRpbmcgdG8gdGhlCk1hYyBwYXRoLgoKKiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Jl bmNobWFya19ydW5uZXIvaHR0cF9zZXJ2ZXJfZHJpdmVyL3NpbXBsZV9odHRwX3NlcnZlcl9kcml2 ZXIucHk6CiAgKFNpbXBsZUhUVFBTZXJ2ZXJEcml2ZXIuX2ZpbmRfaHR0cF9zZXJ2ZXJfcG9ydCk6 Ci0tLQogLi4uL2h0dHBfc2VydmVyX2RyaXZlci9zaW1wbGVfaHR0cF9zZXJ2ZXJfZHJpdmVyLnB5 ICAgICAgICAgIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJr X3J1bm5lci9odHRwX3NlcnZlcl9kcml2ZXIvc2ltcGxlX2h0dHBfc2VydmVyX2RyaXZlci5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9odHRwX3NlcnZlcl9kcml2 ZXIvc2ltcGxlX2h0dHBfc2VydmVyX2RyaXZlci5weQppbmRleCAyZjgwZjkyODljZTMuLmFjNzNl N2I3NDRlZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVu bmVyL2h0dHBfc2VydmVyX2RyaXZlci9zaW1wbGVfaHR0cF9zZXJ2ZXJfZHJpdmVyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9odHRwX3NlcnZlcl9kcml2 ZXIvc2ltcGxlX2h0dHBfc2VydmVyX2RyaXZlci5weQpAQCAtMiw2ICsyLDcgQEAgaW1wb3J0IGxv Z2dpbmcKIGltcG9ydCBvcwogaW1wb3J0IHJlCiBpbXBvcnQgc3VicHJvY2VzcworaW1wb3J0IHNo dXRpbAogaW1wb3J0IHN5cwogaW1wb3J0IHRpbWUKIApAQCAtNjYsNyArNjcsOSBAQCBjbGFzcyBT aW1wbGVIVFRQU2VydmVyRHJpdmVyKEhUVFBTZXJ2ZXJEcml2ZXIpOgogICAgICAgICAgICAgICAg IHNlbGYuX3NlcnZlcl9wb3J0ID0gY29ubmVjdGlvbnNbMF0ubGFkZHJbMV0KICAgICAgICAgZXhj ZXB0IEltcG9ydEVycm9yOgogICAgICAgICAgICAgdHJ5OgotICAgICAgICAgICAgICAgIG91dHB1 dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9zYmluL2xzb2YnLCAnLWEnLCAnLVAn LCAnLWlUQ1AnLCAnLXNUQ1A6TElTVEVOJywgJy1wJywgc3RyKHNlbGYuX3NlcnZlcl9wcm9jZXNz LnBpZCldKQorICAgICAgICAgICAgICAgICMgbHNvZiBvbiBMaW51eCBpcyBzaGlwcGVkIG9uIC91 c3IvYmluIHR5cGljYWxseSwgYnV0IG9uIE1hYyBvbiAvdXNyL3NiaW4KKyAgICAgICAgICAgICAg ICBsc29mX3BhdGggPSBzaHV0aWwud2hpY2goJ2xzb2YnKSBpZiBzaHV0aWwud2hpY2goJ2xzb2Yn KSBlbHNlICcvdXNyL3NiaW4vbHNvZicKKyAgICAgICAgICAgICAgICBvdXRwdXQgPSBzdWJwcm9j ZXNzLmNoZWNrX291dHB1dChbbHNvZl9wYXRoLCAnLWEnLCAnLVAnLCAnLWlUQ1AnLCAnLXNUQ1A6 TElTVEVOJywgJy1wJywgc3RyKHNlbGYuX3NlcnZlcl9wcm9jZXNzLnBpZCldKQogICAgICAgICAg ICAgICAgIHNlbGYuX3NlcnZlcl9wb3J0ID0gaW50KHJlLnNlYXJjaChyJ1RDUCAuKjooXGQrKSBc KExJU1RFTlwpJywgc3RyKG91dHB1dCkpLmdyb3VwKDEpKQogICAgICAgICAgICAgZXhjZXB0IEV4 Y2VwdGlvbiBhcyBlcnJvcjoKICAgICAgICAgICAgICAgICBfbG9nLmluZm8oJ0Vycm9yOiAlcycg JSBlcnJvcikKLS0gCjIuMjAuMQoK 460226 2022-06-14 02:15:49 -0700 2022-06-14 03:12:37 -0700 Patch for landing bug-241081-20220614111548.patch text/plain 2087 clopez RnJvbSBlMDEyNTg2Zjg5MDFlMmIwMGU0MWU2OTQ5ZjU3MjZkY2NhODJlMjE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiA8Y2xvcGV6QGln YWxpYS5jb20+CkRhdGU6IFN1biwgMjkgTWF5IDIwMjIgMjI6Mjk6MTQgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbd2Via2l0cHldIHJ1bi1iZW5jaG1hcmsgc2NyaXB0IGZhaWxzIHRvIGZpbmQgdGhl IGxzb2YKIGNvbW1hbmQgb24gTGludXggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0MTA4MQoKUmV2aWV3ZWQgYnkgRGV3ZWkgWmh1LgoKVGhlIGxzb2YgY29tbWFuZCBp cyBzaGlwcGVkIG9uIExpbnV4IHR5cGljYWxseSBvbiAvdXNyL2JpbiBtZWFud2hpbGUgb24KTWFj IGlzIHNoaXBwZWQgb24gL3Vzci9zYmluLiBDaGVjayBpZiBpcyBvbiBQQVRIIGJlZm9yZSBkZWZh dWx0aW5nIHRvIHRoZQpNYWMgcGF0aC4KCiogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1h cmtfcnVubmVyL2h0dHBfc2VydmVyX2RyaXZlci9zaW1wbGVfaHR0cF9zZXJ2ZXJfZHJpdmVyLnB5 OgogIChTaW1wbGVIVFRQU2VydmVyRHJpdmVyLl9maW5kX2h0dHBfc2VydmVyX3BvcnQpOgotLS0K IC4uLi9odHRwX3NlcnZlcl9kcml2ZXIvc2ltcGxlX2h0dHBfc2VydmVyX2RyaXZlci5weSAgICAg ICAgICB8IDUgKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5u ZXIvaHR0cF9zZXJ2ZXJfZHJpdmVyL3NpbXBsZV9odHRwX3NlcnZlcl9kcml2ZXIucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvaHR0cF9zZXJ2ZXJfZHJpdmVyL3Np bXBsZV9odHRwX3NlcnZlcl9kcml2ZXIucHkKaW5kZXggMmY4MGY5Mjg5Y2UzLi5kMzJkZDc2Mzkz YTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9o dHRwX3NlcnZlcl9kcml2ZXIvc2ltcGxlX2h0dHBfc2VydmVyX2RyaXZlci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvaHR0cF9zZXJ2ZXJfZHJpdmVyL3Np bXBsZV9odHRwX3NlcnZlcl9kcml2ZXIucHkKQEAgLTIsNiArMiw3IEBAIGltcG9ydCBsb2dnaW5n CiBpbXBvcnQgb3MKIGltcG9ydCByZQogaW1wb3J0IHN1YnByb2Nlc3MKK2ltcG9ydCBzaHV0aWwK IGltcG9ydCBzeXMKIGltcG9ydCB0aW1lCiAKQEAgLTY2LDcgKzY3LDkgQEAgY2xhc3MgU2ltcGxl SFRUUFNlcnZlckRyaXZlcihIVFRQU2VydmVyRHJpdmVyKToKICAgICAgICAgICAgICAgICBzZWxm Ll9zZXJ2ZXJfcG9ydCA9IGNvbm5lY3Rpb25zWzBdLmxhZGRyWzFdCiAgICAgICAgIGV4Y2VwdCBJ bXBvcnRFcnJvcjoKICAgICAgICAgICAgIHRyeToKLSAgICAgICAgICAgICAgICBvdXRwdXQgPSBz dWJwcm9jZXNzLmNoZWNrX291dHB1dChbJy91c3Ivc2Jpbi9sc29mJywgJy1hJywgJy1QJywgJy1p VENQJywgJy1zVENQOkxJU1RFTicsICctcCcsIHN0cihzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5waWQp XSkKKyAgICAgICAgICAgICAgICAjIGxzb2Ygb24gTGludXggaXMgc2hpcHBlZCBvbiAvdXNyL2Jp biB0eXBpY2FsbHksIGJ1dCBvbiBNYWMgb24gL3Vzci9zYmluCisgICAgICAgICAgICAgICAgbHNv Zl9wYXRoID0gc2h1dGlsLndoaWNoKCdsc29mJykgb3IgJy91c3Ivc2Jpbi9sc29mJworICAgICAg ICAgICAgICAgIG91dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFtsc29mX3BhdGgsICct YScsICctUCcsICctaVRDUCcsICctc1RDUDpMSVNURU4nLCAnLXAnLCBzdHIoc2VsZi5fc2VydmVy X3Byb2Nlc3MucGlkKV0pCiAgICAgICAgICAgICAgICAgc2VsZi5fc2VydmVyX3BvcnQgPSBpbnQo cmUuc2VhcmNoKHInVENQIC4qOihcZCspIFwoTElTVEVOXCknLCBzdHIob3V0cHV0KSkuZ3JvdXAo MSkpCiAgICAgICAgICAgICBleGNlcHQgRXhjZXB0aW9uIGFzIGVycm9yOgogICAgICAgICAgICAg ICAgIF9sb2cuaW5mbygnRXJyb3I6ICVzJyAlIGVycm9yKQo=