241077 2022-05-29 09:49:40 -0700 Include <sys/sysinfo.h> only on FreeBSD and Linux 2022-05-30 15:00:14 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build All Other RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=241099 InRadar P2 Normal --- 1 iamleot+webkit-bugzilla webkit-unassigned fujii ggaren iamleot+webkit-bugzilla webkit-bug-importer oldest_to_newest 1872626 0 iamleot+webkit-bugzilla 2022-05-29 09:49:40 -0700 Include <sys/sysinfo.h> only on FreeBSD and Linux 1872627 1 iamleot+webkit-bugzilla 2022-05-29 09:52:10 -0700 Patch coming... sorry, that was my first time using Tools/Scripts/webkit-patch and it seems that it didn't well well! 1872628 2 459836 iamleot+webkit-bugzilla 2022-05-29 09:53:33 -0700 Created attachment 459836 Include <sys/sysinfo.h> only on FreeBSD and Linux sysinfo(2)/sysinfo(3) is used only on FreeBSD and Linux and could be not available in other Unix-like operating systems. 1872629 3 iamleot+webkit-bugzilla 2022-05-29 09:55:08 -0700 Only for the record here the complete transcript when trying to build JSC via `Tools/Scripts/build-jsc --jsc-only`: ``` [...] -- Configuring done -- Generating done -- Build files have been written to: ...WebKit/WebKitBuild/Release [363/1074] Building CXX object Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/AvailableMemory.cpp.o FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/AvailableMemory.cpp.o /usr/bin/c++ -DBUILDING_JSCONLY__ -DBUILDING_WITH_CMAKE=1 -DBUILDING_bmalloc -DHAVE_CONFIG_H=1 -DPAS_BMALLOC=1 -I...WebKit/Source/bmalloc -I...WebKit/Source/bmalloc/bmalloc -I...WebKit/Source/bmalloc/libpas/src/libpas -fdiagnostics-color=always -Wextra -Wall -pipe -Wno-odr -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wno-missing-field-initializers -Wno-cast-align -std=c++2a -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/AvailableMemory.cpp.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/AvailableMemory.cpp.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/AvailableMemory.cpp.o -c ...WebKit/Source/bmalloc/bmalloc/AvailableMemory.cpp ...WebKit/Source/bmalloc/bmalloc/AvailableMemory.cpp:47:10: fatal error: sys/sysinfo.h: No such file or directory 47 | #include <sys/sysinfo.h> | ^~~~~~~~~~~~~~~ compilation terminated. [370/1074] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/RunLoop.cpp.o ninja: build stopped: subcommand failed. ``` 1872646 4 459836 fujii 2022-05-29 12:55:58 -0700 Comment on attachment 459836 Include <sys/sysinfo.h> only on FreeBSD and Linux View in context: https://bugs.webkit.org/attachment.cgi?id=459836&action=review > COMMIT_MESSAGE:4 > +available in other Unix-like operating systems. This commit message doesn't comply with WebKit format. WebKit has own prepare-commit-msg hook. "./Tools/Scripts/git-webkit setup" will setup for you. Could you redo this patch with it? 1872649 5 459836 iamleot+webkit-bugzilla 2022-05-29 13:26:22 -0700 Comment on attachment 459836 Include <sys/sysinfo.h> only on FreeBSD and Linux Marking it as obsolete because the commit message format is not okay. (Sorry, I didn't known about `Tools/Scripts/git-webkit setup`, thanks to Fujii for pointing it out, patch hopefully adjusted coming soon!) 1872650 6 459840 iamleot+webkit-bugzilla 2022-05-29 13:27:14 -0700 Created attachment 459840 Include <sys/sysinfo.h> only on FreeBSD and Linux sysinfo(2)/sysinfo(3) is used only on FreeBSD and Linux and could be not available in other Unix-like operating systems. 1872651 7 iamleot+webkit-bugzilla 2022-05-29 13:28:13 -0700 Hello Fujii, (In reply to Fujii Hironori from comment #4) > Comment on attachment 459836 [details] > Include <sys/sysinfo.h> only on FreeBSD and Linux > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459836&action=review > > > COMMIT_MESSAGE:4 > > +available in other Unix-like operating systems. > > This commit message doesn't comply with WebKit format. WebKit has own > prepare-commit-msg hook. > "./Tools/Scripts/git-webkit setup" will setup for you. Could you redo this > patch with it? Sure! (sorry, I didn't known about it) I have hopefully reformatted it accordingly. If it needs further adjustment please let me know and/or feel free to adjust the commit message as you prefer. Thank you! 1872666 8 459840 fujii 2022-05-29 16:44:36 -0700 Comment on attachment 459840 Include <sys/sysinfo.h> only on FreeBSD and Linux View in context: https://bugs.webkit.org/attachment.cgi?id=459840&action=review > Source/bmalloc/bmalloc/AvailableMemory.cpp:-47 > -#include <sys/sysinfo.h> Unfortunately, sytle checker doesn't like this change. > ERROR: Source/bmalloc/bmalloc/AvailableMemory.cpp:54: "sys/sysinfo.h" already included at Source/bmalloc/bmalloc/AvailableMemory.cpp:50 [build/include] [4] #if BOS(FREEBSD) || BOS(LINUX) #include <sys/sysinfo.h> #endif This condition matches with the implementation of AvailableMemory.cpp. You can style errors with Tools/Scripts/check-webkit-style before uploading. If you use `webkit-patch upload` or `git-webkit pr` scripts to upload your patch, it automatically run check-webkit-style. 1872667 9 fujii 2022-05-29 16:45:47 -0700 If you don't mind, it'd be great if you change another conidtion to `#if OS(LINUX) || OS(FREEBSD)` in this patch to match with the implementation. https://github.com/WebKit/WebKit/blob/main/Source/WTF/wtf/RAMSize.cpp#L34 1872714 10 iamleot+webkit-bugzilla 2022-05-30 03:57:51 -0700 (In reply to Fujii Hironori from comment #9) > If you don't mind, it'd be great if you change another conidtion to `#if > OS(LINUX) || OS(FREEBSD)` in this patch to match with the implementation. > https://github.com/WebKit/WebKit/blob/main/Source/WTF/wtf/RAMSize.cpp#L34 I would prefer to do that in a separate patch to avoid possible regressions (I think that the components are separate and this bug actually fix build on non-FreeBSD/non-Linux Unix-like operating systems while the change in RAMSize.cpp will possibly impact FreeBSD only). 1872716 11 459854 iamleot+webkit-bugzilla 2022-05-30 04:12:04 -0700 Created attachment 459854 Include <sys/sysinfo.h> only on FreeBSD and Linux sysinfo(2)/sysinfo(3) is used only on FreeBSD and Linux and could be not available in other Unix-like operating systems. 1872718 12 iamleot+webkit-bugzilla 2022-05-30 04:12:58 -0700 (In reply to Fujii Hironori from comment #8) > Comment on attachment 459840 [details] > Include <sys/sysinfo.h> only on FreeBSD and Linux > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459840&action=review > > > Source/bmalloc/bmalloc/AvailableMemory.cpp:-47 > > -#include <sys/sysinfo.h> > > Unfortunately, sytle checker doesn't like this change. > > > ERROR: Source/bmalloc/bmalloc/AvailableMemory.cpp:54: "sys/sysinfo.h" already included at Source/bmalloc/bmalloc/AvailableMemory.cpp:50 [build/include] [4] > > #if BOS(FREEBSD) || BOS(LINUX) > #include <sys/sysinfo.h> > #endif > > This condition matches with the implementation of AvailableMemory.cpp. > > You can style errors with Tools/Scripts/check-webkit-style before uploading. > If you use `webkit-patch upload` or `git-webkit pr` scripts to upload your > patch, it automatically run check-webkit-style. Thanks, I have resubmitted it and I hope it's fine this time! 1872726 13 iamleot+webkit-bugzilla 2022-05-30 04:41:45 -0700 (In reply to Leonardo Taccari from comment #10) > (In reply to Fujii Hironori from comment #9) > > If you don't mind, it'd be great if you change another conidtion to `#if > > OS(LINUX) || OS(FREEBSD)` in this patch to match with the implementation. > > https://github.com/WebKit/WebKit/blob/main/Source/WTF/wtf/RAMSize.cpp#L34 > > I would prefer to do that in a separate patch to avoid possible regressions > (I think that the components are separate and this bug actually fix build on > non-FreeBSD/non-Linux Unix-like operating systems while the change in > RAMSize.cpp will possibly impact FreeBSD only). I have opened https://bugs.webkit.org/show_bug.cgi?id=241099 for that. 1872757 14 ews-feeder 2022-05-30 07:19:13 -0700 Found 2 new test failures: webgl/2.0.0/conformance2/textures/image_bitmap_from_image_bitmap/tex-2d-rgb8ui-rgb_integer-unsigned_byte.html, webgl/2.0.0/conformance2/textures/image_bitmap_from_image_bitmap/tex-3d-srgb8_alpha8-rgba-unsigned_byte.html 1872824 15 ews-feeder 2022-05-30 15:00:00 -0700 Committed r295033 (251128@main): <https://commits.webkit.org/251128@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459854. 1872826 16 webkit-bug-importer 2022-05-30 15:00:14 -0700 <rdar://problem/94123044> 459836 2022-05-29 09:53:33 -0700 2022-05-29 13:26:22 -0700 Include <sys/sysinfo.h> only on FreeBSD and Linux 0001-Include-sys-sysinfo.h-only-on-FreeBSD-and-Linux.patch text/plain 1040 iamleot+webkit-bugzilla RnJvbSA0NmI4M2VhMGFjYzk0YmI5NzIzYjFjYjZhODI0ZjRmZDE2ZTYzN2QwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW9uYXJkbyBUYWNjYXJpIDxsZW90QE5ldEJTRC5vcmc+CkRh dGU6IFN1biwgMjkgTWF5IDIwMjIgMTg6MzI6MTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBJbmNs dWRlIDxzeXMvc3lzaW5mby5oPiBvbmx5IG9uIEZyZWVCU0QgYW5kIExpbnV4CgpzeXNpbmZvKDIp L3N5c2luZm8oMykgaXMgdXNlZCBvbmx5IG9uIEZyZWVCU0QgYW5kIExpbnV4IGFuZCBjb3VsZCBi ZSBub3QKYXZhaWxhYmxlIGluIG90aGVyIFVuaXgtbGlrZSBvcGVyYXRpbmcgc3lzdGVtcy4KLS0t CiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9yeS5jcHAgfCAzICsrLQogMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcCBiL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcAppbmRleCBjZDA0ZjU5ZjVjOWUuLmZjYTNh NTcwNzc2YSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFpbGFibGVNZW1v cnkuY3BwCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcApA QCAtNDQsMTMgKzQ0LDE0IEBACiAjaW1wb3J0IDxtYWNoL21hY2hfZXJyb3IuaD4KICNpbXBvcnQg PG1hdGguaD4KICNlbGlmIEJPUyhVTklYKQotI2luY2x1ZGUgPHN5cy9zeXNpbmZvLmg+CiAjaWYg Qk9TKExJTlVYKQogI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxmY250bC5oPgorI2lu Y2x1ZGUgPHN5cy9zeXNpbmZvLmg+CiAjZWxpZiBCT1MoRlJFRUJTRCkKICNpbmNsdWRlICJWTUFs bG9jYXRlLmgiCiAjaW5jbHVkZSA8c3lzL3N5c2N0bC5oPgorI2luY2x1ZGUgPHN5cy9zeXNpbmZv Lmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8c3lzL3VzZXIuaD4KICNlbmRp ZgotLSAKMi4zNS4zCgo= 459840 2022-05-29 13:27:14 -0700 2022-05-30 04:11:27 -0700 Include <sys/sysinfo.h> only on FreeBSD and Linux 0001-Include-sys-sysinfo.h-only-on-FreeBSD-and-Linux.patch text/plain 1164 iamleot+webkit-bugzilla RnJvbSBlMzgxOTE3YTM3YmYxY2Q5MGRmOGM3OWExMTAwOTY5ZjM2ZDkwZGJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW9uYXJkbyBUYWNjYXJpIDxsZW90QE5ldEJTRC5vcmc+CkRh dGU6IFN1biwgMjkgTWF5IDIwMjIgMjI6MjM6MDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBJbmNs dWRlIDxzeXMvc3lzaW5mby5oPiBvbmx5IG9uIEZyZWVCU0QgYW5kIExpbnV4CiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMDc3CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCnN5c2luZm8oMikvc3lzaW5mbygzKSBpcyB1c2VkIG9ubHkgb24gRnJlZUJTRCBh bmQgTGludXggYW5kIGNvdWxkIGJlIG5vdAphdmFpbGFibGUgaW4gb3RoZXIgVW5peC1saWtlIG9w ZXJhdGluZyBzeXN0ZW1zLgoKKiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9y eS5jcHA6Ci0tLQogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFpbGFibGVNZW1vcnkuY3BwIHwg MyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9yeS5jcHAgYi9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9yeS5jcHAKaW5kZXggY2QwNGY1OWY1 YzllLi5mY2EzYTU3MDc3NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQXZh aWxhYmxlTWVtb3J5LmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1l bW9yeS5jcHAKQEAgLTQ0LDEzICs0NCwxNCBAQAogI2ltcG9ydCA8bWFjaC9tYWNoX2Vycm9yLmg+ CiAjaW1wb3J0IDxtYXRoLmg+CiAjZWxpZiBCT1MoVU5JWCkKLSNpbmNsdWRlIDxzeXMvc3lzaW5m by5oPgogI2lmIEJPUyhMSU5VWCkKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8ZmNu dGwuaD4KKyNpbmNsdWRlIDxzeXMvc3lzaW5mby5oPgogI2VsaWYgQk9TKEZSRUVCU0QpCiAjaW5j bHVkZSAiVk1BbGxvY2F0ZS5oIgogI2luY2x1ZGUgPHN5cy9zeXNjdGwuaD4KKyNpbmNsdWRlIDxz eXMvc3lzaW5mby5oPgogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgogI2luY2x1ZGUgPHN5cy91c2Vy Lmg+CiAjZW5kaWYKLS0gCjIuMzUuMwoK 459854 2022-05-30 04:12:04 -0700 2022-05-30 15:00:00 -0700 Include <sys/sysinfo.h> only on FreeBSD and Linux 0001-Include-sys-sysinfo.h-only-on-FreeBSD-and-Linux.patch text/plain 1009 iamleot+webkit-bugzilla RnJvbSAyOTllMjEzMmRlZjkyNDJkYmFkMjlkNjk4MDBjZDZiNTA1NWY1NThiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW9uYXJkbyBUYWNjYXJpIDxsZW90QE5ldEJTRC5vcmc+CkRh dGU6IE1vbiwgMzAgTWF5IDIwMjIgMTM6MDg6NTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBJbmNs dWRlIDxzeXMvc3lzaW5mby5oPiBvbmx5IG9uIEZyZWVCU0QgYW5kIExpbnV4CiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQxMDc3CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCnN5c2luZm8oMikvc3lzaW5mbygzKSBpcyB1c2VkIG9ubHkgb24gRnJlZUJTRCBh bmQgTGludXggYW5kIGNvdWxkIGJlIG5vdAphdmFpbGFibGUgaW4gb3RoZXIgVW5peC1saWtlIG9w ZXJhdGluZyBzeXN0ZW1zLgoKKiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9y eS5jcHA6Ci0tLQogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFpbGFibGVNZW1vcnkuY3BwIHwg MiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9ibWFsbG9jL2JtYWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcAppbmRleCBjZDA0ZjU5ZjVjOWUuLmM4OWRlNTY4N2Q1 NyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFpbGFibGVNZW1vcnkuY3Bw CisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQXZhaWxhYmxlTWVtb3J5LmNwcApAQCAtNDQs NyArNDQsOSBAQAogI2ltcG9ydCA8bWFjaC9tYWNoX2Vycm9yLmg+CiAjaW1wb3J0IDxtYXRoLmg+ CiAjZWxpZiBCT1MoVU5JWCkKKyNpZiBCT1MoRlJFRUJTRCkgfHwgQk9TKExJTlVYKQogI2luY2x1 ZGUgPHN5cy9zeXNpbmZvLmg+CisjZW5kaWYKICNpZiBCT1MoTElOVVgpCiAjaW5jbHVkZSA8YWxn b3JpdGhtPgogI2luY2x1ZGUgPGZjbnRsLmg+Ci0tIAoyLjM2LjEKCg==