241062 2022-05-28 06:31:06 -0700 [LFC][IFC] LineBuilder::initialConstraintsForLine needs to know whether there is previous line and if it ended with line break 2022-05-29 10:11:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1872543 0 zalan 2022-05-28 06:31:06 -0700 ssia 1872544 1 459826 zalan 2022-05-28 06:33:13 -0700 Created attachment 459826 [fast-cq]Patch 1872635 2 ews-feeder 2022-05-29 10:10:15 -0700 Committed r295018 (251112@main): <https://commits.webkit.org/251112@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459826. 1872636 3 webkit-bug-importer 2022-05-29 10:11:13 -0700 <rdar://problem/94090072> 459826 2022-05-28 06:33:13 -0700 2022-05-29 10:10:16 -0700 [fast-cq]Patch bug-241062-20220528063312.patch text/plain 5676 zalan RnJvbSA3ZDVhY2ExMmYyYzAyNzcyMDVhZjJkOTJlNzU2N2JkYmI3ZWQzZGQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBT YXQsIDI4IE1heSAyMDIyIDA2OjMxOjIxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gW0xGQ11bSUZD XSBMaW5lQnVpbGRlcjo6aW5pdGlhbENvbnN0cmFpbnRzRm9yTGluZSBuZWVkcyB0bwoga25vdyB3 aGV0aGVyIHRoZXJlIGlzIHByZXZpb3VzIGxpbmUgYW5kIGlmIGl0IGVuZGVkIHdpdGggbGluZSBi cmVhawogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MTA2MgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZWVkIHRvIHBhc3MgaW4gdGhlIFByZXZpb3Vz TGluZSBzdHJ1Y3QuCgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMv aW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcDoKKFdlYkNvcmU6OkxheW91dDo6TGluZUJ1aWxk ZXI6OmxheW91dElubGluZUNvbnRlbnQpOgooV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6 Y29tcHV0ZWRJbnRyaW5zaWNXaWR0aCk6CihXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCdWlsZGVyOjpp bml0aWFsQ29uc3RyYWludHNGb3JMaW5lIGNvbnN0KToKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5oOgotLS0KIC4uLi9p bmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwICAgICAgICAgICAgICAgICAgfCAxNSArKysrKysr Ky0tLS0tLS0KIC4uLi9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVy LmggfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zv cm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwCmluZGV4IDBkMGE5 MjFkY2E0ZC4uMmY0N2RkN2JmOTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1 aWxkZXIuY3BwCkBAIC0zMjEsNyArMzIxLDggQEAgc3RydWN0IFVzZWRDb25zdHJhaW50cyB7CiB9 OwogTGluZUJ1aWxkZXI6OkxpbmVDb250ZW50IExpbmVCdWlsZGVyOjpsYXlvdXRJbmxpbmVDb250 ZW50KGNvbnN0IElubGluZUl0ZW1SYW5nZSYgbmVlZHNMYXlvdXRSYW5nZSwgY29uc3QgSW5saW5l UmVjdCYgbGluZUxvZ2ljYWxSZWN0LCBjb25zdCBzdGQ6Om9wdGlvbmFsPFByZXZpb3VzTGluZT4m IHByZXZpb3VzTGluZSkKIHsKLSAgICBpbml0aWFsaXplKGluaXRpYWxDb25zdHJhaW50c0Zvckxp bmUobGluZUxvZ2ljYWxSZWN0LCBwcmV2aW91c0xpbmUpLCBuZWVkc0xheW91dFJhbmdlLnN0YXJ0 LCBwcmV2aW91c0xpbmUpOworICAgIGF1dG8gcHJldmlvdXNMaW5lRW5kc1dpdGhMaW5lQnJlYWsg PSAhcHJldmlvdXNMaW5lID8gc3RkOjpudWxsb3B0IDogc3RkOjptYWtlX29wdGlvbmFsKHByZXZp b3VzTGluZS0+ZW5kc1dpdGhMaW5lQnJlYWspOworICAgIGluaXRpYWxpemUoaW5pdGlhbENvbnN0 cmFpbnRzRm9yTGluZShsaW5lTG9naWNhbFJlY3QsIHByZXZpb3VzTGluZUVuZHNXaXRoTGluZUJy ZWFrKSwgbmVlZHNMYXlvdXRSYW5nZS5zdGFydCwgcHJldmlvdXNMaW5lKTsKIAogICAgIGF1dG8g Y29tbWl0dGVkQ29udGVudCA9IHBsYWNlSW5saW5lQ29udGVudChuZWVkc0xheW91dFJhbmdlKTsK ICAgICBhdXRvIGNvbW1pdHRlZFJhbmdlID0gY2xvc2UobmVlZHNMYXlvdXRSYW5nZSwgY29tbWl0 dGVkQ29udGVudCk7CkBAIC00MDAsNyArNDAxLDggQEAgTGluZUJ1aWxkZXI6OkludHJpbnNpY0Nv bnRlbnQgTGluZUJ1aWxkZXI6OmNvbXB1dGVkSW50cmluc2ljV2lkdGgoY29uc3QgSW5saW5lSXQK IHsKICAgICBBU1NFUlQoaXNJbkludHJpbnNpY1dpZHRoTW9kZSgpKTsKICAgICBhdXRvIGxpbmVM b2dpY2FsV2lkdGggPSAqaW50cmluc2ljV2lkdGhNb2RlKCkgPT0gSW50cmluc2ljV2lkdGhNb2Rl OjpNYXhpbXVtID8gbWF4SW5saW5lTGF5b3V0VW5pdCgpIDogMC5mOwotICAgIGF1dG8gbGluZUNv bnN0cmFpbnRzID0gaW5pdGlhbENvbnN0cmFpbnRzRm9yTGluZSh7IDAsIDAsIGxpbmVMb2dpY2Fs V2lkdGgsIDAgfSwgcHJldmlvdXNMaW5lKTsKKyAgICBhdXRvIHByZXZpb3VzTGluZUVuZHNXaXRo TGluZUJyZWFrID0gIXByZXZpb3VzTGluZSA/IHN0ZDo6bnVsbG9wdCA6IHN0ZDo6bWFrZV9vcHRp b25hbChwcmV2aW91c0xpbmUtPmVuZHNXaXRoTGluZUJyZWFrKTsKKyAgICBhdXRvIGxpbmVDb25z dHJhaW50cyA9IGluaXRpYWxDb25zdHJhaW50c0ZvckxpbmUoeyAwLCAwLCBsaW5lTG9naWNhbFdp ZHRoLCAwIH0sIHByZXZpb3VzTGluZUVuZHNXaXRoTGluZUJyZWFrKTsKICAgICBpbml0aWFsaXpl KGxpbmVDb25zdHJhaW50cywgbmVlZHNMYXlvdXRSYW5nZS5zdGFydCwgcHJldmlvdXNMaW5lKTsK IAogICAgIGF1dG8gY29tbWl0dGVkQ29udGVudCA9IHBsYWNlSW5saW5lQ29udGVudChuZWVkc0xh eW91dFJhbmdlKTsKQEAgLTYyNyw3ICs2MjksNyBAQCBzdGQ6Om9wdGlvbmFsPEhvcml6b250YWxD b25zdHJhaW50cz4gTGluZUJ1aWxkZXI6OmZsb2F0Q29uc3RyYWludHMoY29uc3QgSW5saW5lUgog ICAgIHJldHVybiBIb3Jpem9udGFsQ29uc3RyYWludHMgeyB0b0xheW91dFVuaXQobGluZUxvZ2lj YWxMZWZ0KSwgdG9MYXlvdXRVbml0KGxpbmVMb2dpY2FsUmlnaHQgLSBsaW5lTG9naWNhbExlZnQp IH07CiB9CiAKLVVzZWRDb25zdHJhaW50cyBMaW5lQnVpbGRlcjo6aW5pdGlhbENvbnN0cmFpbnRz Rm9yTGluZShjb25zdCBJbmxpbmVSZWN0JiBpbml0aWFsTGluZUxvZ2ljYWxSZWN0LCBjb25zdCBz dGQ6Om9wdGlvbmFsPFByZXZpb3VzTGluZT4mIHByZXZpb3VzTGluZSkgY29uc3QKK1VzZWRDb25z dHJhaW50cyBMaW5lQnVpbGRlcjo6aW5pdGlhbENvbnN0cmFpbnRzRm9yTGluZShjb25zdCBJbmxp bmVSZWN0JiBpbml0aWFsTGluZUxvZ2ljYWxSZWN0LCBzdGQ6Om9wdGlvbmFsPGJvb2w+IHByZXZp b3VzTGluZUVuZHNXaXRoTGluZUJyZWFrKSBjb25zdAogewogICAgIGF1dG8gbGluZUxvZ2ljYWxM ZWZ0ID0gaW5pdGlhbExpbmVMb2dpY2FsUmVjdC5sZWZ0KCk7CiAgICAgYXV0byBsaW5lTG9naWNh bFJpZ2h0ID0gaW5pdGlhbExpbmVMb2dpY2FsUmVjdC5yaWdodCgpOwpAQCAtNjQ5LDcgKzY1MSw3 IEBAIFVzZWRDb25zdHJhaW50cyBMaW5lQnVpbGRlcjo6aW5pdGlhbENvbnN0cmFpbnRzRm9yTGlu ZShjb25zdCBJbmxpbmVSZWN0JiBpbml0aWFsCiAgICAgICAgIC8vIElmICdlYWNoLWxpbmUnIGlz IHNwZWNpZmllZCwgaW5kZW50YXRpb24gYWxzbyBhcHBsaWVzIHRvIGFsbCBsaW5lcyB3aGVyZSB0 aGUgcHJldmlvdXMgbGluZSBlbmRzIHdpdGggYSBoYXJkIGJyZWFrLgogICAgICAgICAvLyBbSW50 ZWdyYXRpb25dIHJvb3QoKS0+cGFyZW50KCkgd291bGQgbm9ybWFsbHkgcHJvZHVjZSBhIHZhbGlk IGxheW91dCBib3guCiAgICAgICAgIGJvb2wgc2hvdWxkSW5kZW50ID0gZmFsc2U7Ci0gICAgICAg IGlmICghcHJldmlvdXNMaW5lKSB7CisgICAgICAgIGlmICghcHJldmlvdXNMaW5lRW5kc1dpdGhM aW5lQnJlYWspIHsKICAgICAgICAgICAgIHNob3VsZEluZGVudCA9ICFyb290LmlzQW5vbnltb3Vz KCk7CiAgICAgICAgICAgICBpZiAocm9vdC5pc0Fub255bW91cygpKSB7CiAgICAgICAgICAgICAg ICAgYXV0byBpc0ludGVncmF0ZWRSb290Qm94Rmlyc3RDaGlsZCA9IGxheW91dFN0YXRlKCkuaXNJ bnRlZ3JhdGVkUm9vdEJveEZpcnN0Q2hpbGQoKTsKQEAgLTY1OCw5ICs2NjAsOCBAQCBVc2VkQ29u c3RyYWludHMgTGluZUJ1aWxkZXI6OmluaXRpYWxDb25zdHJhaW50c0ZvckxpbmUoY29uc3QgSW5s aW5lUmVjdCYgaW5pdGlhbAogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAg ICAgc2hvdWxkSW5kZW50ID0gaXNJbnRlZ3JhdGVkUm9vdEJveEZpcnN0Q2hpbGQgPT0gTGF5b3V0 U3RhdGU6OklzSW50ZWdyYXRlZFJvb3RCb3hGaXJzdENoaWxkOjpZZXM7CiAgICAgICAgICAgICB9 Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBzaG91bGRJbmRlbnQgPSByb290LnN0eWxl KCkudGV4dEluZGVudExpbmUoKSA9PSBUZXh0SW5kZW50TGluZTo6RWFjaExpbmUgJiYgcHJldmlv dXNMaW5lLT5lbmRzV2l0aExpbmVCcmVhazsKLSAgICAgICAgfQorICAgICAgICB9IGVsc2UKKyAg ICAgICAgICAgIHNob3VsZEluZGVudCA9IHJvb3Quc3R5bGUoKS50ZXh0SW5kZW50TGluZSgpID09 IFRleHRJbmRlbnRMaW5lOjpFYWNoTGluZSAmJiAqcHJldmlvdXNMaW5lRW5kc1dpdGhMaW5lQnJl YWs7CiAKICAgICAgICAgLy8gU3BlY2lmeWluZyAnaGFuZ2luZycgaW52ZXJ0cyB3aGV0aGVyIHRo ZSBsaW5lIHNob3VsZCBiZSBpbmRlbnRlZCBvciBub3QuCiAgICAgICAgIGlmIChyb290LnN0eWxl KCkudGV4dEluZGVudFR5cGUoKSA9PSBUZXh0SW5kZW50VHlwZTo6SGFuZ2luZykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGlu ZUxpbmVCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRz L2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5oCmluZGV4IDM5ZTZhN2VhYzYwNy4uMGZjNjg5NWQz NmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRz L2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9m b3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmgKQEAgLTEwNyw3ICsx MDcsNyBAQCBwcml2YXRlOgogICAgICAgICBzaXplX3QgcGFydGlhbFRyYWlsaW5nQ29udGVudExl bmd0aCB7IDAgfTsKICAgICAgICAgc3RkOjpvcHRpb25hbDxJbmxpbmVMYXlvdXRVbml0PiBvdmVy Zmxvd0xvZ2ljYWxXaWR0aCB7IH07CiAgICAgfTsKLSAgICBVc2VkQ29uc3RyYWludHMgaW5pdGlh bENvbnN0cmFpbnRzRm9yTGluZShjb25zdCBJbmxpbmVSZWN0JiBpbml0aWFsTGluZUxvZ2ljYWxS ZWN0LCBjb25zdCBzdGQ6Om9wdGlvbmFsPFByZXZpb3VzTGluZT4mKSBjb25zdDsKKyAgICBVc2Vk Q29uc3RyYWludHMgaW5pdGlhbENvbnN0cmFpbnRzRm9yTGluZShjb25zdCBJbmxpbmVSZWN0JiBp bml0aWFsTGluZUxvZ2ljYWxSZWN0LCBzdGQ6Om9wdGlvbmFsPGJvb2w+IHByZXZpb3VzTGluZUVu ZHNXaXRoTGluZUJyZWFrKSBjb25zdDsKICAgICBzdGQ6Om9wdGlvbmFsPEhvcml6b250YWxDb25z dHJhaW50cz4gZmxvYXRDb25zdHJhaW50cyhjb25zdCBJbmxpbmVSZWN0JiBsaW5lTG9naWNhbFJl Y3QpIGNvbnN0OwogCiAgICAgdm9pZCBoYW5kbGVGbG9hdENvbnRlbnQoY29uc3QgSW5saW5lSXRl bSYpOwotLSAKMi4zMi4wIChBcHBsZSBHaXQtMTMyKQoK