24103 2009-02-23 13:55:36 -0800 [GTK] Use correct return value for WebView button-release handler 2009-02-26 08:27:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned christian oldest_to_newest 110634 0 xan.lopez 2009-02-23 13:55:36 -0800 We are returning whatever the core code tells us it did, but this does not play well with the GTK+ model. GTK+ in general expects it will see a button-release if it saw a button-press and no motion/leave/etc events in between. EventHandler.cpp will, in some cases, not handle press but handle release, confusing the parent container of the WebView. As a workaround return always FALSE for button-release (this is the same than the Windows port does). 110637 1 27892 xan.lopez 2009-02-23 13:58:10 -0800 Created attachment 27892 releaseevent.patch Fix return value for release-event handler. 110638 2 27893 xan.lopez 2009-02-23 14:01:49 -0800 Created attachment 27893 releaseevent.patch Slightly improve comment, don't confuse event with click. 110783 3 christian 2009-02-24 11:29:17 -0800 > Slightly improve comment, don't confuse event with click. While I would of course prefer to actually fix the event handlers in WebCore that don't play together , I suppose this is a passable compromise. We might want to document somewhere that WebKit won't ever catch button events but still process them. Maybe in the introductory section of WebKitWebView? 110785 4 xan.lopez 2009-02-24 11:35:58 -0800 (In reply to comment #3) > > Slightly improve comment, don't confuse event with click. > > While I would of course prefer to actually fix the event handlers in WebCore > that don't play together , I suppose this is a passable compromise. I'm not sure there's anything to fix. The event model and semantics of GTK+ and WebCore do not necesarily need to work OK together in all cases, and it's our responsibility to act as proxies between them. For this case in particular, ap says WebCore is working as it should be, for example. > > We might want to document somewhere that WebKit won't ever catch button events > but still process them. Maybe in the introductory section of WebKitWebView? > Yes, I guess this should be documented. Do you think this approach in general makes sense? We could do other things, like catch everything (return TRUE always for both events), catch nothing (return FALSE always for both events)... 110786 5 christian 2009-02-24 11:47:13 -0800 (In reply to comment #4) > (In reply to comment #3) > > > Slightly improve comment, don't confuse event with click. > > > > While I would of course prefer to actually fix the event handlers in WebCore > > that don't play together , I suppose this is a passable compromise. > > I'm not sure there's anything to fix. The event model and semantics of GTK+ and > WebCore do not necesarily need to work OK together in all cases, and it's our > responsibility to act as proxies between them. For this case in particular, ap > says WebCore is working as it should be, for example. Yes, I'm not suggesting to change WebCore. If anything, we could try to make sure that a handled button-press is always followed by a handled button-release, i.e. just keep track of what button-press did and do the same in button-release. > > We might want to document somewhere that WebKit won't ever catch button events > > but still process them. Maybe in the introductory section of WebKitWebView? > > Yes, I guess this should be documented. Do you think this approach in general > makes sense? We could do other things, like catch everything (return TRUE > always for both events), catch nothing (return FALSE always for both events)... I would think what I described above could be better. If that doesn't work for whatever reason, always returning FALSE is probably the best we can do. 110787 6 xan.lopez 2009-02-24 11:54:19 -0800 (In reply to comment #5) > > I'm not sure there's anything to fix. The event model and semantics of GTK+ and > > WebCore do not necesarily need to work OK together in all cases, and it's our > > responsibility to act as proxies between them. For this case in particular, ap > > says WebCore is working as it should be, for example. > > Yes, I'm not suggesting to change WebCore. If anything, we could try to make > sure that a handled button-press is always followed by a handled > button-release, i.e. just keep track of what button-press did and do the same > in button-release. Right, I thought about that too, but I think I prefer trying this first and see if it's enough, like you do. 111163 7 27893 ap 2009-02-26 05:29:29 -0800 Comment on attachment 27893 releaseevent.patch Looks reasonable, r=me 111190 8 zecke 2009-02-26 08:27:52 -0800 Landed in r41248. 27892 2009-02-23 13:58:10 -0800 2009-02-23 14:01:49 -0800 releaseevent.patch releaseevent.patch text/plain 3261 xan.lopez RnJvbSBkMzYyZTBhZDRlNDVmYWViNWMxMDhiNjFiOWRjNjU1N2FhOWU3MTU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IE1vbiwg MjMgRmViIDIwMDkgMjM6NTY6NTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAyLTIzICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MTAzCiAgICAgICAgW0dUS10gVXNlIGNvcnJlY3QgcmV0dXJuIHZhbHVlIGZvciBXZWJWaWV3IGJ1 dHRvbi1yZWxlYXNlIGhhbmRsZXIKCiAgICAgICAgV2UgYXJlIHJldHVybmluZyB3aGF0ZXZlciB0 aGUgY29yZSBjb2RlIHRlbGxzIHVzIGl0IGRpZCwgYnV0IHRoaXMKICAgICAgICBkb2VzIG5vdCBw bGF5IHdlbGwgd2l0aCB0aGUgR1RLKyBtb2RlbC4gR1RLKyBpbiBnZW5lcmFsIGV4cGVjdHMgaXQK ICAgICAgICB3aWxsIHNlZSBhIGJ1dHRvbi1yZWxlYXNlIGlmIGl0IHNhdyBhIGJ1dHRvbi1wcmVz cyBhbmQgbm8KICAgICAgICBtb3Rpb24vbGVhdmUvZXRjIGV2ZW50cyBpbiBiZXR3ZWVuLiBFdmVu dEhhbmRsZXIuY3BwIHdpbGwsIGluIHNvbWUKICAgICAgICBjYXNlcywgbm90IGhhbmRsZSBwcmVz cyBidXQgaGFuZGxlIHJlbGVhc2UsIGNvbmZ1c2luZyB0aGUgcGFyZW50CiAgICAgICAgY29udGFp bmVyIG9mIHRoZSBXZWJWaWV3LgoKICAgICAgICBBcyBhIHdvcmthcm91bmQgcmV0dXJuIGFsd2F5 cyBGQUxTRSBmb3IgYnV0dG9uLXJlbGVhc2UgKHRoaXMgaXMKICAgICAgICB0aGUgc2FtZSB0aGFu IHRoZSBXaW5kb3dzIHBvcnQgZG9lcykuCgogICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxOSArKysr KysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg MTIgKysrKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwppbmRleCAxYTRhOTJkLi4yNjZiMjcxIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAy MDA5LTAyLTIzICBYYW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNDEwMworICAgICAgICBbR1RLXSBVc2UgY29ycmVjdCByZXR1cm4gdmFs dWUgZm9yIFdlYlZpZXcgYnV0dG9uLXJlbGVhc2UgaGFuZGxlcgorCisgICAgICAgIFdlIGFyZSBy ZXR1cm5pbmcgd2hhdGV2ZXIgdGhlIGNvcmUgY29kZSB0ZWxscyB1cyBpdCBkaWQsIGJ1dCB0aGlz CisgICAgICAgIGRvZXMgbm90IHBsYXkgd2VsbCB3aXRoIHRoZSBHVEsrIG1vZGVsLiBHVEsrIGlu IGdlbmVyYWwgZXhwZWN0cyBpdAorICAgICAgICB3aWxsIHNlZSBhIGJ1dHRvbi1yZWxlYXNlIGlm IGl0IHNhdyBhIGJ1dHRvbi1wcmVzcyBhbmQgbm8KKyAgICAgICAgbW90aW9uL2xlYXZlL2V0YyBl dmVudHMgaW4gYmV0d2Vlbi4gRXZlbnRIYW5kbGVyLmNwcCB3aWxsLCBpbiBzb21lCisgICAgICAg IGNhc2VzLCBub3QgaGFuZGxlIHByZXNzIGJ1dCBoYW5kbGUgcmVsZWFzZSwgY29uZnVzaW5nIHRo ZSBwYXJlbnQKKyAgICAgICAgY29udGFpbmVyIG9mIHRoZSBXZWJWaWV3LgorCisgICAgICAgIEFz IGEgd29ya2Fyb3VuZCByZXR1cm4gYWx3YXlzIEZBTFNFIGZvciBidXR0b24tcmVsZWFzZSAodGhp cyBpcworICAgICAgICB0aGUgc2FtZSB0aGFuIHRoZSBXaW5kb3dzIHBvcnQgZG9lcykuCisKKyAg ICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisKKzIwMDktMDItMjMgIFhhbiBMb3Bl eiAgPHhhbkBnbm9tZS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5 YWtvdi4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI2MjQKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggYjA0ZWYwNS4uZmMzYzk1 NSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTQ5NiwxMCArNDk2LDE2IEBA IHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfYnV0dG9uX3JlbGVhc2VfZXZlbnQoR3Rr V2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50CiAgICAgfQogCiAgICAgRnJhbWUqIG1haW5GcmFtZSA9 IGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgpOwotICAgIGlmICghbWFpbkZyYW1lLT52aWV3KCkp Ci0gICAgICAgIHJldHVybiBGQUxTRTsKKyAgICBpZiAobWFpbkZyYW1lLT52aWV3KCkpCisgICAg ICAgIG1haW5GcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KFBs YXRmb3JtTW91c2VFdmVudChldmVudCkpOworCisgICAgLyogV2UgYWx3YXlzIHJldHVybiBGQUxT RSBoZXJlIGJlY2F1c2UgV2ViS2l0IGNhbiwgZm9yIHRoZSBzYW1lIGV2ZW50LCBkZWNpZGUKKyAg ICAgKiB0byBub3QgaGFuZGxlIHByZXNzLWV2ZW50IGJ1dCBoYW5kbGUgcmVsZWFzZS1ldmVudCwg d2hpY2ggY2FuIHRvdGFsbHkgY29uZnVzZQorICAgICAqIHNvbWUgR1RLKyBjb250YWluZXJzLiBU aGlzIHdheSB3ZSBndWFyYW50ZWUgdGhhdCB0aGlzIGNhc2UgbmV2ZXIgaGFwcGVucywgYW5kCisg ICAgICogdGhhdCBpZiBwcmVzcy1ldmVudCBnb2VzIHRocm91Z2ggcmVsZWFzZS1ldmVudCBhbHNv IGdvZXMgdGhyb3VnaC4KKyAgICAgKi8KIAotICAgIHJldHVybiBtYWluRnJhbWUtPmV2ZW50SGFu ZGxlcigpLT5oYW5kbGVNb3VzZVJlbGVhc2VFdmVudChQbGF0Zm9ybU1vdXNlRXZlbnQoZXZlbnQp KTsKKyAgICByZXR1cm4gRkFMU0U7CiB9CiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3Zp ZXdfbW90aW9uX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudE1vdGlvbiogZXZlbnQp Ci0tIAoxLjYuMQoK 27893 2009-02-23 14:01:49 -0800 2009-02-26 05:29:29 -0800 releaseevent.patch releaseevent.patch text/plain 3312 xan.lopez RnJvbSBmNDU1YjAwYmRiMTc4M2IxMDNlYjM0MGJmMGQxOGEzOTRlODQ5NjNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IE1vbiwg MjMgRmViIDIwMDkgMjM6NTY6NTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAyLTIzICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0 MTAzCiAgICAgICAgW0dUS10gVXNlIGNvcnJlY3QgcmV0dXJuIHZhbHVlIGZvciBXZWJWaWV3IGJ1 dHRvbi1yZWxlYXNlIGhhbmRsZXIKCiAgICAgICAgV2UgYXJlIHJldHVybmluZyB3aGF0ZXZlciB0 aGUgY29yZSBjb2RlIHRlbGxzIHVzIGl0IGRpZCwgYnV0IHRoaXMKICAgICAgICBkb2VzIG5vdCBw bGF5IHdlbGwgd2l0aCB0aGUgR1RLKyBtb2RlbC4gR1RLKyBpbiBnZW5lcmFsIGV4cGVjdHMgaXQK ICAgICAgICB3aWxsIHNlZSBhIGJ1dHRvbi1yZWxlYXNlIGlmIGl0IHNhdyBhIGJ1dHRvbi1wcmVz cyBhbmQgbm8KICAgICAgICBtb3Rpb24vbGVhdmUvZXRjIGV2ZW50cyBpbiBiZXR3ZWVuLiBFdmVu dEhhbmRsZXIuY3BwIHdpbGwsIGluIHNvbWUKICAgICAgICBjYXNlcywgbm90IGhhbmRsZSBwcmVz cyBidXQgaGFuZGxlIHJlbGVhc2UsIGNvbmZ1c2luZyB0aGUgcGFyZW50CiAgICAgICAgY29udGFp bmVyIG9mIHRoZSBXZWJWaWV3LgoKICAgICAgICBBcyBhIHdvcmthcm91bmQgcmV0dXJuIGFsd2F5 cyBGQUxTRSBmb3IgYnV0dG9uLXJlbGVhc2UgKHRoaXMgaXMKICAgICAgICB0aGUgc2FtZSB0aGFu IHRoZSBXaW5kb3dzIHBvcnQgZG9lcykuCgogICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxOSArKysr KysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAg MTMgKysrKysrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKaW5kZXggMWE0YTkyZC4uMjY2YjI3MSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAog MjAwOS0wMi0yMyAgWGFuIExvcGV6ICA8eGFuQGdub21lLm9yZz4KIAorICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQxMDMKKyAgICAgICAgW0dUS10gVXNlIGNvcnJlY3QgcmV0dXJuIHZh bHVlIGZvciBXZWJWaWV3IGJ1dHRvbi1yZWxlYXNlIGhhbmRsZXIKKworICAgICAgICBXZSBhcmUg cmV0dXJuaW5nIHdoYXRldmVyIHRoZSBjb3JlIGNvZGUgdGVsbHMgdXMgaXQgZGlkLCBidXQgdGhp cworICAgICAgICBkb2VzIG5vdCBwbGF5IHdlbGwgd2l0aCB0aGUgR1RLKyBtb2RlbC4gR1RLKyBp biBnZW5lcmFsIGV4cGVjdHMgaXQKKyAgICAgICAgd2lsbCBzZWUgYSBidXR0b24tcmVsZWFzZSBp ZiBpdCBzYXcgYSBidXR0b24tcHJlc3MgYW5kIG5vCisgICAgICAgIG1vdGlvbi9sZWF2ZS9ldGMg ZXZlbnRzIGluIGJldHdlZW4uIEV2ZW50SGFuZGxlci5jcHAgd2lsbCwgaW4gc29tZQorICAgICAg ICBjYXNlcywgbm90IGhhbmRsZSBwcmVzcyBidXQgaGFuZGxlIHJlbGVhc2UsIGNvbmZ1c2luZyB0 aGUgcGFyZW50CisgICAgICAgIGNvbnRhaW5lciBvZiB0aGUgV2ViVmlldy4KKworICAgICAgICBB cyBhIHdvcmthcm91bmQgcmV0dXJuIGFsd2F5cyBGQUxTRSBmb3IgYnV0dG9uLXJlbGVhc2UgKHRo aXMgaXMKKyAgICAgICAgdGhlIHNhbWUgdGhhbiB0aGUgV2luZG93cyBwb3J0IGRvZXMpLgorCisg ICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorCisyMDA5LTAyLTIzICBYYW4gTG9w ZXogIDx4YW5AZ25vbWUub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3Vy eWFrb3YuCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNjI0CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGIwNGVmMDUuLmEzOTI2 ZDIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC00OTYsMTAgKzQ5NiwxNyBA QCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2J1dHRvbl9yZWxlYXNlX2V2ZW50KEd0 a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudAogICAgIH0KIAogICAgIEZyYW1lKiBtYWluRnJhbWUg PSBjb3JlKHdlYlZpZXcpLT5tYWluRnJhbWUoKTsKLSAgICBpZiAoIW1haW5GcmFtZS0+dmlldygp KQotICAgICAgICByZXR1cm4gRkFMU0U7CisgICAgaWYgKG1haW5GcmFtZS0+dmlldygpKQorICAg ICAgICBtYWluRnJhbWUtPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVNb3VzZVJlbGVhc2VFdmVudChQ bGF0Zm9ybU1vdXNlRXZlbnQoZXZlbnQpKTsKKworICAgIC8qIFdlIGFsd2F5cyByZXR1cm4gRkFM U0UgaGVyZSBiZWNhdXNlIFdlYktpdCBjYW4sIGZvciB0aGUgc2FtZSBjbGljaywgZGVjaWRlCisg ICAgICogdG8gbm90IGhhbmRsZSBwcmVzcy1ldmVudCBidXQgaGFuZGxlIHJlbGVhc2UtZXZlbnQs IHdoaWNoIGNhbiB0b3RhbGx5IGNvbmZ1c2UKKyAgICAgKiBzb21lIEdUSysgY29udGFpbmVycyB3 aGVuIHRoZXJlIGFyZSBubyBvdGhlciBldmVudHMgaW4gYmV0d2Vlbi4gVGhpcyB3YXkgd2UKKyAg ICAgKiBndWFyYW50ZWUgdGhhdCB0aGlzIGNhc2UgbmV2ZXIgaGFwcGVucywgYW5kIHRoYXQgaWYg cHJlc3MtZXZlbnQgZ29lcyB0aHJvdWdoCisgICAgICogcmVsZWFzZS1ldmVudCBhbHNvIGdvZXMg dGhyb3VnaC4KKyAgICAgKi8KIAotICAgIHJldHVybiBtYWluRnJhbWUtPmV2ZW50SGFuZGxlcigp LT5oYW5kbGVNb3VzZVJlbGVhc2VFdmVudChQbGF0Zm9ybU1vdXNlRXZlbnQoZXZlbnQpKTsKKyAg ICByZXR1cm4gRkFMU0U7CiB9CiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfbW90 aW9uX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudE1vdGlvbiogZXZlbnQpCi0tIAox LjYuMQoK