240970 2022-05-26 12:58:22 -0700 [Interop 2021] WPT upstream expectation change: css/css-flexbox/flex-minimum-height-flex-items-023.html fails 2022-06-22 10:35:35 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All Unspecified NEW InRadar P2 Normal --- 214292 1 rreno webkit-unassigned bfulgham karlcow webkit-bug-importer oldest_to_newest 1872073 0 rreno 2022-05-26 12:58:22 -0700 The green square appears to overflow by 25% from expected. Link to the WPT result: https://wpt.fyi/results/css/css-flexbox/flex-minimum-height-flex-items-023.html?label=master&label=experimental&aligned This was fixed in r273955 1872074 1 webkit-bug-importer 2022-05-26 13:00:14 -0700 <rdar://problem/93990164> 1872078 2 rreno 2022-05-26 13:07:23 -0700 This may have slipped by our test suite because these flex-minimum-height-flex-items-XXX.html tests are marked [ImageOnlyFailure] in TestExpectations: 023 029 013 015 1872091 3 rreno 2022-05-26 13:42:23 -0700 After looking a little further into this, it looks like the test changed to match Chrome's behavior in Oct 2021, 9 months after r273955 The commit message for the WPT test (https://github.com/web-platform-tests/wpt/commit/2c83d2e8d545706b565dc6e3dcf77daa77eb5e96) indicates that the behavior of Chrome, FF, and WebKit was out of spec according to the discussion here: https://github.com/w3c/csswg-drafts/issues/6693 When running Safari against that revision and the test as it existed in 03/2021 it looks like the revision did cause the test to pass but the interpretation of the spec may have changed. I'll look more closely at the csswg discussion. 1872251 4 karlcow 2022-05-26 19:53:29 -0700 Firefox bug about it https://bugzilla.mozilla.org/show_bug.cgi?id=1735589