24096 2009-02-23 08:29:20 -0800 Use PLATFORM(CF) instead of PLATFORM(MAC) in CurrentTime.cpp 2010-03-11 04:30:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 playmobil webkit-unassigned aroben eric oldest_to_newest 110581 0 playmobil 2009-02-23 08:29:20 -0800 This change allows Chrome on OS X to use the CF functions for currentTime() rather than the POSIX variant. 110582 1 27882 playmobil 2009-02-23 08:31:31 -0800 Created attachment 27882 PLATFORM(CF) Is PLATFORM(CF) OK to use here? A concern has been raised about Apple's CF variant on Windows, if this is a problem, would PLATFORM(DARWIN) && PLATFORM(CF) be a better choice? 110583 2 aroben 2009-02-23 08:47:42 -0800 (In reply to comment #1) > Is PLATFORM(CF) OK to use here? A concern has been raised about Apple's CF > variant on Windows, if this is a problem, would PLATFORM(DARWIN) && > PLATFORM(CF) be a better choice? We still want Windows to use the WIN_OS code, as it is higher-resolution than CFAbsoluteTimeGetCurrent on Windows. One option would be to do what you proposed: PLATFORM(DARWIN) && PLATFORM(CF). Another option would be to make the WIN_OS code the first branch of the #if/#elif chain. I think I prefer the latter. 110584 3 27883 playmobil 2009-02-23 08:57:15 -0800 Created attachment 27883 Address aroben's comments from previous patch Thanks, I've put the Windows case first and added a comment so the reasoning behind the change isn't lost. 110588 4 27883 aroben 2009-02-23 09:10:37 -0800 Comment on attachment 27883 Address aroben's comments from previous patch > +#elif PLATFORM(GTK) > + > +// Note: GTK on Windows will pick up the PLATFORM(WIN) implementation above which provides > +// better accuracy compared with Windows implementation of g_get_current_time: > +// (http://www.google.com/codesearch/p?hl=en#HHnNRjks1t0/glib-2.5.2/glib/gmain.c&q=g_get_current_time). > +// Non-Windows GTK builds could use gettimeofday() directly but for the sake of consistency lets use GTK function. Looks like this patch helps out GTK/win, too! r=me 110595 5 dglazkov 2009-02-23 09:55:52 -0800 Landed as http://trac.webkit.org/changeset/41149. 27882 2009-02-23 08:31:31 -0800 2009-02-23 08:57:15 -0800 PLATFORM(CF) time.patch text/plain 1208 playmobil Y29tbWl0IGE5ZTY4ODc5ZDM5YzIzZmVmZDczZDkwMzA1Nzg1YTgyYzBmNzVmNjEKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIE1vbiBGZWIgMjMg MTg6Mjg6MzYgMjAwOSArMDIwMAoKICAgIFBMQVRGT1JNKE1BQyktPlBMQVRGT1JNKENGKSBzaW5j ZSB3ZSB3YW50IHRvIHVzZSB0aGUgQ0YgZnVuY3Rpb25zIGluIENocm9tZSBvbiBPUyBYLgoKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwppbmRleCA2OGM5N2FiLi44YWY3MjA4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAK KzIwMDktMDItMjMgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBMQVRGT1JNKE1B QyktPlBMQVRGT1JNKENGKSBzaW5jZSB3ZSB3YW50IHRvIHVzZSB0aGUgQ0YgZnVuY3Rpb25zIGlu IENocm9tZSBvbiBPUyBYLgorCisgICAgICAgICogd3RmL0N1cnJlbnRUaW1lLmNwcDoKKwogMjAw OS0wMi0yMiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1 aWxkIGZpeD8KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DdXJyZW50VGltZS5jcHAg Yi9KYXZhU2NyaXB0Q29yZS93dGYvQ3VycmVudFRpbWUuY3BwCmluZGV4IGYyMzQ5NWYuLmIyYTRm ZjcgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DdXJyZW50VGltZS5jcHAKKysrIGIv SmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcApAQCAtMzIsNyArMzIsNyBAQAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkN1cnJlbnRUaW1lLmgiCiAKLSNpZiBQTEFURk9S TShNQUMpCisjaWYgUExBVEZPUk0oQ0YpCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ0ZEYXRl Lmg+CiAjZWxpZiBQTEFURk9STShHVEspCiAjaW5jbHVkZSA8Z2xpYi5oPgpAQCAtNTUsNyArNTUs NyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogY29uc3QgZG91YmxlIG1zUGVyU2Vjb25kID0gMTAwMC4w OwogCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKENGKQogCiBkb3VibGUgY3VycmVu dFRpbWUoKQogewo= 27883 2009-02-23 08:57:15 -0800 2009-02-23 09:10:37 -0800 Address aroben's comments from previous patch time.patch text/plain 3792 playmobil Y29tbWl0IDgyMGUxY2QyMWU1ZTFiNWFmZDZlMjdiZWM0ZGI5YTRhNDZlN2U0YmQKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIE1vbiBGZWIgMjMg MTg6Mjg6MzYgMjAwOSArMDIwMAoKICAgIFBMQVRGT1JNKE1BQyktPlBMQVRGT1JNKENGKSBzaW5j ZSB3ZSB3YW50IHRvIHVzZSB0aGUgQ0YgZnVuY3Rpb25zIGluIENocm9tZSBvbiBPUyBYLgoKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwppbmRleCA2OGM5N2FiLi44YWY3MjA4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAK KzIwMDktMDItMjMgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBMQVRGT1JNKE1B QyktPlBMQVRGT1JNKENGKSBzaW5jZSB3ZSB3YW50IHRvIHVzZSB0aGUgQ0YgZnVuY3Rpb25zIGlu IENocm9tZSBvbiBPUyBYLgorCisgICAgICAgICogd3RmL0N1cnJlbnRUaW1lLmNwcDoKKwogMjAw OS0wMi0yMiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1 aWxkIGZpeD8KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DdXJyZW50VGltZS5jcHAg Yi9KYXZhU2NyaXB0Q29yZS93dGYvQ3VycmVudFRpbWUuY3BwCmluZGV4IGYyMzQ5NWYuLmM1MjAy ODMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9DdXJyZW50VGltZS5jcHAKKysrIGIv SmF2YVNjcmlwdENvcmUvd3RmL0N1cnJlbnRUaW1lLmNwcApAQCAtMzIsMTMgKzMyLDkgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJDdXJyZW50VGltZS5oIgogCi0jaWYgUExBVEZP Uk0oTUFDKQotI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NGRGF0ZS5oPgotI2VsaWYgUExBVEZP Uk0oR1RLKQotI2luY2x1ZGUgPGdsaWIuaD4KLSNlbGlmIFBMQVRGT1JNKFdYKQotI2luY2x1ZGUg PHd4L2RhdGV0aW1lLmg+Ci0jZWxpZiBQTEFURk9STShXSU5fT1MpCisjaWYgUExBVEZPUk0oV0lO X09TKQorLy8gV2luZG93cyBpcyBmaXJzdCBzaW5jZSB3ZSB3YW50IHRvIHVzZSBoaXJlcyB0aW1l cnMsIGRlc3BpdGUgUExBVEZPUk0oQ0YpCisvLyBiZWluZyBkZWZpbmVkLgogLy8gSWYgZGVmaW5l ZCwgV0lOMzJfTEVBTl9BTkRfTUVBTiBkaXNhYmxlcyB0aW1lQmVnaW5QZXJpb2QvdGltZUVuZFBl cmlvZC4KICN1bmRlZiBXSU4zMl9MRUFOX0FORF9NRUFOCiAjaW5jbHVkZSA8d2luZG93cy5oPgpA QCAtNDcsNiArNDMsMTIgQEAKICNpbmNsdWRlIDxzeXMvdGltZWIuaD4KICNpbmNsdWRlIDxzeXMv dHlwZXMuaD4KICNpbmNsdWRlIDx0aW1lLmg+CisjZWxpZiBQTEFURk9STShDRikKKyNpbmNsdWRl IDxDb3JlRm91bmRhdGlvbi9DRkRhdGUuaD4KKyNlbGlmIFBMQVRGT1JNKEdUSykKKyNpbmNsdWRl IDxnbGliLmg+CisjZWxpZiBQTEFURk9STShXWCkKKyNpbmNsdWRlIDx3eC9kYXRldGltZS5oPgog I2Vsc2UgLy8gUG9zaXggc3lzdGVtcyByZWx5aW5nIG9uIHRoZSBnZXR0aW1lb2ZkYXkoKQogI2lu Y2x1ZGUgPHN5cy90aW1lLmg+CiAjZW5kaWYKQEAgLTU1LDM1ICs1Nyw3IEBAIG5hbWVzcGFjZSBX VEYgewogCiBjb25zdCBkb3VibGUgbXNQZXJTZWNvbmQgPSAxMDAwLjA7CiAKLSNpZiBQTEFURk9S TShNQUMpCi0KLWRvdWJsZSBjdXJyZW50VGltZSgpCi17Ci0gICAgcmV0dXJuIENGQWJzb2x1dGVU aW1lR2V0Q3VycmVudCgpICsga0NGQWJzb2x1dGVUaW1lSW50ZXJ2YWxTaW5jZTE5NzA7Ci19Ci0K LSNlbGlmIFBMQVRGT1JNKEdUSykKLQotLy8gTm90ZTogR1RLIG9uIFdpbmRvd3Mgd2lsbCBwaWNr IHVwIHRoZSBQTEFURk9STShXSU4pIGltcGxlbWVudGF0aW9uIGFib3ZlIHdoaWNoIHByb3ZpZGVz Ci0vLyBiZXR0ZXIgYWNjdXJhY3kgY29tcGFyZWQgd2l0aCBXaW5kb3dzIGltcGxlbWVudGF0aW9u IG9mIGdfZ2V0X2N1cnJlbnRfdGltZToKLS8vIChodHRwOi8vd3d3Lmdvb2dsZS5jb20vY29kZXNl YXJjaC9wP2hsPWVuI0hIbk5SamtzMXQwL2dsaWItMi41LjIvZ2xpYi9nbWFpbi5jJnE9Z19nZXRf Y3VycmVudF90aW1lKS4KLS8vIE5vbi1XaW5kb3dzIEdUSyBidWlsZHMgY291bGQgdXNlIGdldHRp bWVvZmRheSgpIGRpcmVjdGx5IGJ1dCBmb3IgdGhlIHNha2Ugb2YgY29uc2lzdGVuY3kgbGV0cyB1 c2UgR1RLIGZ1bmN0aW9uLgotZG91YmxlIGN1cnJlbnRUaW1lKCkKLXsKLSAgICBHVGltZVZhbCBu b3c7Ci0gICAgZ19nZXRfY3VycmVudF90aW1lKCZub3cpOwotICAgIHJldHVybiBzdGF0aWNfY2Fz dDxkb3VibGU+KG5vdy50dl9zZWMpICsgc3RhdGljX2Nhc3Q8ZG91YmxlPihub3cudHZfdXNlYyAv IDEwMDAwMDAuMCk7Ci19Ci0KLSNlbGlmIFBMQVRGT1JNKFdYKQotCi1kb3VibGUgY3VycmVudFRp bWUoKQotewotICAgIHd4RGF0ZVRpbWUgbm93ID0gd3hEYXRlVGltZTo6VU5vdygpOwotICAgIHJl dHVybiAoZG91YmxlKW5vdy5HZXRUaWNrcygpICsgKGRvdWJsZSkobm93LkdldE1pbGxpc2Vjb25k KCkgLyAxMDAwLjApOwotfQotCi0jZWxpZiBQTEFURk9STShXSU5fT1MpCisjaWYgUExBVEZPUk0o V0lOX09TKQogCiBzdGF0aWMgTEFSR0VfSU5URUdFUiBxcGNGcmVxdWVuY3k7CiBzdGF0aWMgYm9v bCBzeW5jZWRUaW1lOwpAQCAtMjEwLDYgKzE4NCwzNCBAQCBkb3VibGUgY3VycmVudFRpbWUoKQog ICAgIHJldHVybiB1dGMgLyAxMDAwLjA7CiB9CiAKKyNlbGlmIFBMQVRGT1JNKENGKQorCitkb3Vi bGUgY3VycmVudFRpbWUoKQoreworICAgIHJldHVybiBDRkFic29sdXRlVGltZUdldEN1cnJlbnQo KSArIGtDRkFic29sdXRlVGltZUludGVydmFsU2luY2UxOTcwOworfQorCisjZWxpZiBQTEFURk9S TShHVEspCisKKy8vIE5vdGU6IEdUSyBvbiBXaW5kb3dzIHdpbGwgcGljayB1cCB0aGUgUExBVEZP Uk0oV0lOKSBpbXBsZW1lbnRhdGlvbiBhYm92ZSB3aGljaCBwcm92aWRlcworLy8gYmV0dGVyIGFj Y3VyYWN5IGNvbXBhcmVkIHdpdGggV2luZG93cyBpbXBsZW1lbnRhdGlvbiBvZiBnX2dldF9jdXJy ZW50X3RpbWU6CisvLyAoaHR0cDovL3d3dy5nb29nbGUuY29tL2NvZGVzZWFyY2gvcD9obD1lbiNI SG5OUmprczF0MC9nbGliLTIuNS4yL2dsaWIvZ21haW4uYyZxPWdfZ2V0X2N1cnJlbnRfdGltZSku CisvLyBOb24tV2luZG93cyBHVEsgYnVpbGRzIGNvdWxkIHVzZSBnZXR0aW1lb2ZkYXkoKSBkaXJl Y3RseSBidXQgZm9yIHRoZSBzYWtlIG9mIGNvbnNpc3RlbmN5IGxldHMgdXNlIEdUSyBmdW5jdGlv bi4KK2RvdWJsZSBjdXJyZW50VGltZSgpCit7CisgICAgR1RpbWVWYWwgbm93OworICAgIGdfZ2V0 X2N1cnJlbnRfdGltZSgmbm93KTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8ZG91YmxlPihub3cu dHZfc2VjKSArIHN0YXRpY19jYXN0PGRvdWJsZT4obm93LnR2X3VzZWMgLyAxMDAwMDAwLjApOwor fQorCisjZWxpZiBQTEFURk9STShXWCkKKworZG91YmxlIGN1cnJlbnRUaW1lKCkKK3sKKyAgICB3 eERhdGVUaW1lIG5vdyA9IHd4RGF0ZVRpbWU6OlVOb3coKTsKKyAgICByZXR1cm4gKGRvdWJsZSlu b3cuR2V0VGlja3MoKSArIChkb3VibGUpKG5vdy5HZXRNaWxsaXNlY29uZCgpIC8gMTAwMC4wKTsK K30KKwogI2Vsc2UgLy8gT3RoZXIgUG9zaXggc3lzdGVtcyByZWx5IG9uIHRoZSBnZXR0aW1lb2Zk YXkoKS4KIAogZG91YmxlIGN1cnJlbnRUaW1lKCkK