24094 2009-02-23 07:37:36 -0800 Cleanup leak messages on exit 2009-02-23 11:53:27 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned oldest_to_newest 110577 0 manyoso 2009-02-23 07:37:36 -0800 Right now with the Qt port, WebCore::CachedResource is being leaked on exit. This happens for every webpage that has a cached resource. But that is ok, because WebCore::Cache itself is *designed* to be leaked on exit as it is a singleton. However, WebCore::CachedResource has a RefCountedLeakMessage that prints on exit. After consulting with Antti it was determined that the best thing the Qt port could do in this instance is match the Mac ports behavior. This patch clears the cache on exit only in Debug builds in the same manner that the Mac port does. 110578 1 27880 manyoso 2009-02-23 07:38:14 -0800 Created attachment 27880 Clean up leak messages 110600 2 27880 darin 2009-02-23 10:53:47 -0800 Comment on attachment 27880 Clean up leak messages Looks good. r=me 110609 3 manyoso 2009-02-23 11:53:13 -0800 Landed with r41151. 27880 2009-02-23 07:38:14 -0800 2009-02-23 10:53:47 -0800 Clean up leak messages cache_leak.patch text/plain 2812 manyoso ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggZTQwZmY0Mi4uNmUwZjYwNCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTY0 LDYgKzY0LDcgQEAKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0LmgiCiAjaW5jbHVkZSAiV2luZG93 RmVhdHVyZXMuaCIKICNpbmNsdWRlICJMb2NhbGl6ZWRTdHJpbmdzLmgiCisjaW5jbHVkZSAiQ2Fj aGUuaCIKICNpbmNsdWRlICJydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuaCIKIAogI2luY2x1 ZGUgPFFBcHBsaWNhdGlvbj4KQEAgLTQyOSw2ICs0MzAsMTQgQEAgdm9pZCBRV2ViUGFnZVByaXZh dGU6Ol9xX3dlYkFjdGlvblRyaWdnZXJlZChib29sIGNoZWNrZWQpCiAgICAgcS0+dHJpZ2dlckFj dGlvbihhY3Rpb24sIGNoZWNrZWQpOwogfQogCisjaWZuZGVmIE5ERUJVRwordm9pZCBRV2ViUGFn ZVByaXZhdGU6Ol9xX2NsZWFudXBMZWFrTWVzc2FnZXMoKQoreworICAgIC8vIE5lZWQgdGhpcyB0 byBtYWtlIGxlYWsgbWVzc2FnZXMgYWNjdXJhdGUuCisgICAgY2FjaGUoKS0+c2V0Q2FwYWNpdGll cygwLCAwLCAwKTsKK30KKyNlbmRpZgorCiB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6dXBkYXRlQWN0 aW9uKFFXZWJQYWdlOjpXZWJBY3Rpb24gYWN0aW9uKQogewogICAgIFFBY3Rpb24gKmEgPSBhY3Rp b25zW2FjdGlvbl07CkBAIC0xMjUxLDYgKzEyNjAsOSBAQCBRV2ViUGFnZTo6UVdlYlBhZ2UoUU9i amVjdCAqcGFyZW50KQogICAgIHNldFZpZXcocW9iamVjdF9jYXN0PFFXaWRnZXQgKj4ocGFyZW50 KSk7CiAKICAgICBjb25uZWN0KHRoaXMsIFNJR05BTChsb2FkUHJvZ3Jlc3MoaW50KSksIHRoaXMs IFNMT1QoX3Ffb25Mb2FkUHJvZ3Jlc3NDaGFuZ2VkKGludCkpKTsKKyNpZm5kZWYgTkRFQlVHCisg ICAgY29ubmVjdChRQ29yZUFwcGxpY2F0aW9uOjppbnN0YW5jZSgpLCBTSUdOQUwoYWJvdXRUb1F1 aXQoKSksIHRoaXMsIFNMT1QoX3FfY2xlYW51cExlYWtNZXNzYWdlcygpKSk7CisjZW5kaWYKIH0K IAogLyohCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmggYi9XZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmgKaW5kZXggMmJiYmMyYS4uMjg1M2ZjYyAxMDA2NDQKLS0tIGEvV2ViS2l0 L3F0L0FwaS9xd2VicGFnZS5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuaApAQCAtMzI1 LDYgKzMyNSw5IEBAIHByb3RlY3RlZDoKIHByaXZhdGU6CiAgICAgUV9QUklWQVRFX1NMT1QoZCwg dm9pZCBfcV9vbkxvYWRQcm9ncmVzc0NoYW5nZWQoaW50KSkKICAgICBRX1BSSVZBVEVfU0xPVChk LCB2b2lkIF9xX3dlYkFjdGlvblRyaWdnZXJlZChib29sIGNoZWNrZWQpKQorI2lmbmRlZiBOREVC VUcKKyAgICBRX1BSSVZBVEVfU0xPVChkLCB2b2lkIF9xX2NsZWFudXBMZWFrTWVzc2FnZXMoKSkK KyNlbmRpZgogICAgIFFXZWJQYWdlUHJpdmF0ZSAqZDsKIAogICAgIGZyaWVuZCBjbGFzcyBRV2Vi RnJhbWU7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlX3AuaCBiL1dlYktpdC9x dC9BcGkvcXdlYnBhZ2VfcC5oCmluZGV4IGZkOTE1YTIuLmE4OTdiZjEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9xdC9BcGkvcXdlYnBhZ2VfcC5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2VfcC5o CkBAIC03OSw2ICs3OSw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgX3Ffb25Mb2FkUHJvZ3Jlc3ND aGFuZ2VkKGludCk7CiAgICAgdm9pZCBfcV93ZWJBY3Rpb25UcmlnZ2VyZWQoYm9vbCBjaGVja2Vk KTsKKyNpZm5kZWYgTkRFQlVHCisgICAgdm9pZCBfcV9jbGVhbnVwTGVha01lc3NhZ2VzKCk7Cisj ZW5kaWYKICAgICB2b2lkIHVwZGF0ZUFjdGlvbihRV2ViUGFnZTo6V2ViQWN0aW9uIGFjdGlvbik7 CiAgICAgdm9pZCB1cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpOwogICAgIHZvaWQgdXBkYXRlRWRp dG9yQWN0aW9ucygpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYWU4MzI0Ni4uNmRhNDQ3ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIw MDktMDItMjMgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdG8g ZW1wdHkgdGhlIGNhY2hlIG9uIGV4aXQgdG8gZ2V0IHJpZCBvZiBzdXBlcmZsdW91cyBsZWFrIG1l c3NhZ2VzCisgICAgICAgIGZvciBDYWNoZWRSZXNvdXJjZSdzIGluIG9yZGVyIHRvIGtlZXAgdGhl IGxlYWsgbWVzc2FnZXMgYWNjdXJhdGUuICBUaGlzCisgICAgICAgIGlzIGFuYWxhZ291cyB0byB3 aGF0IHRoZSBNYWMgcG9ydCBpcyBkb2luZyBvbiBhcHBsaWNhdGlvbiBleGl0IHdoZW4gYWxsCisg ICAgICAgIFdlYlZpZXcncyBoYXZlIGJlZW4gY2xvc2VkLgorCisgICAgICAgICogQXBpL3F3ZWJw YWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6X3FfY2xlYW51cExlYWtNZXNzYWdl cyk6CisgICAgICAgIChRV2ViUGFnZTo6UVdlYlBhZ2UpOgorICAgICAgICAqIEFwaS9xd2VicGFn ZS5oOgorICAgICAgICAqIEFwaS9xd2VicGFnZV9wLmg6CisKIDIwMDktMDItMTYgIFNpbW9uIEhh dXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFRvciBBcm5lIFZlc3Riw7guCg==