24093 2009-02-23 06:37:16 -0800 Autofocus inputs don't always honor selector input:focus 2011-11-08 21:48:01 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://lachy.id.au/dev/markup/tests/html5/autofocus/016.html HasReduction P2 Normal --- 19264 1 rik webkit-unassigned ap kaustubh.ra michelangelo rniwa tkent webkit.review.bot oldest_to_newest 110573 0 rik 2009-02-23 06:37:16 -0800 This test by Lachlan Hunt fails. The focus is good but the field should be green. 159923 1 michelangelo 2009-11-02 14:19:27 -0800 *** Bug 31031 has been marked as a duplicate of this bug. *** 472136 2 kaustubh.ra 2011-09-23 03:19:19 -0700 I guess this has been fixed. Can be closed. 472626 3 ap 2011-09-23 16:53:15 -0700 Should we land this as a regression test? 497843 4 114010 kaustubh.ra 2011-11-08 01:30:55 -0800 Created attachment 114010 Patch for Adding test case As this has been already fixed, adding regression test case for the same. 498027 5 114010 tkent 2011-11-08 07:09:07 -0800 Comment on attachment 114010 Patch for Adding test case View in context: https://bugs.webkit.org/attachment.cgi?id=114010&action=review > LayoutTests/fast/forms/autofocus-input-css-style-change.html:18 > +if (window.layoutTestController) { > + layoutTestController.dumpAsText(); > +} > + > +var test = document.getElementById("test"); > +if (document.defaultView.getComputedStyle(test, null).getPropertyValue('background-color') == "rgb(0, 128, 0)") > + result.innerHTML = "PASS"; The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body. 498028 6 tkent 2011-11-08 07:09:28 -0800 (In reply to comment #5) > The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body. consistent -> inconsistent. 498109 7 114010 ap 2011-11-08 08:47:43 -0800 Comment on attachment 114010 Patch for Adding test case The comment seems minor enough to land as is, marking cq+. 498178 8 114010 webkit.review.bot 2011-11-08 10:04:26 -0800 Comment on attachment 114010 Patch for Adding test case Clearing flags on attachment: 114010 Committed r99582: <http://trac.webkit.org/changeset/99582> 498179 9 webkit.review.bot 2011-11-08 10:04:30 -0800 All reviewed patches have been landed. Closing bug. 498645 10 kaustubh.ra 2011-11-08 21:48:01 -0800 Thanks for the review Kent & Alexey. 114010 2011-11-08 01:30:55 -0800 2011-11-08 10:04:26 -0800 Patch for Adding test case 24093_patch.txt text/plain 2031 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk5NTM4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMDcgIEthdXN0dWJoIEF0cmF3YWxr YXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXV0b2ZvY3VzIGlucHV0cyBk b24ndCBhbHdheXMgaG9ub3Igc2VsZWN0b3IgaW5wdXQ6Zm9jdXMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDA5MworCisgICAgICAgIEFscmVhZHkg Zml4ZWQgYW5kIHdvcmtzIG9uIFRPVC4gQWRkaW5nIGxheW91dCB0ZXN0IGNhc2UgZm9yIHRoZSBz YW1lLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW5wdXQtY3NzLXN0eWxlLWNoYW5nZS1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvYXV0b2ZvY3VzLWlucHV0LWNzcy1zdHlsZS1j aGFuZ2UuaHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y bWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHNraXAgZmxha3kgY3Jhc2hl ciBvbiBHVEsuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1pbnB1dC1j c3Mtc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL2F1dG9mb2N1cy1pbnB1dC1jc3Mtc3R5bGUtY2hhbmdlLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0b2ZvY3VzLWlucHV0LWNz cy1zdHlsZS1jaGFuZ2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAK K1RoZSBmb2xsb3dpbmcgdGV4dCBib3ggc2hvdWxkIGhhdmUgZm9jdXMgYW5kIHNob3VsZCBiZSBn cmVlbi4KKworCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG9mb2N1cy1p bnB1dC1jc3Mtc3R5bGUtY2hhbmdlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9hdXRvZm9jdXMtaW5wdXQtY3NzLXN0eWxlLWNoYW5nZS5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvZm9jdXMtaW5wdXQtY3NzLXN0eWxlLWNo YW5nZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIxIEBACis8IURPQ1lUUEUgaHRtbD4K KzxodG1sPgorPHN0eWxlPgoraW5wdXQgeyBiYWNrZ3JvdW5kOiByZWQ7IH0KK2lucHV0OmZvY3Vz IHsgYmFja2dyb3VuZDogZ3JlZW47IH0KKzwvc3R5bGU+Cis8Ym9keT4KKzxwPlRoZSBmb2xsb3dp bmcgdGV4dCBib3ggc2hvdWxkIGhhdmUgZm9jdXMgYW5kIHNob3VsZCBiZSBncmVlbi48L3A+Cis8 aW5wdXQgdHlwZT0idGV4dCIgaWQ9InRlc3QiIGF1dG9mb2N1cz4KKzxkaXYgaWQ9InJlc3VsdCI+ RkFJTDwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK3ZhciB0ZXN0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKTsKK2lmIChkb2N1bWVudC5kZWZhdWx0Vmll dy5nZXRDb21wdXRlZFN0eWxlKHRlc3QsIG51bGwpLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91 bmQtY29sb3InKSA9PSAicmdiKDAsIDEyOCwgMCkiKQorICAgIHJlc3VsdC5pbm5lckhUTUwgPSAi UEFTUyI7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K