240896 2022-05-24 18:44:53 -0700 [Angle] Uniform buffer reuse causes flush, creates invalid state 2022-06-22 17:35:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 240948 241894 1 kpiddington kpiddington dino ews-watchlist gman kbr kkinnunen kondapallykalyan mmaxfield webkit-bug-importer oldest_to_newest 1871630 0 kpiddington 2022-05-24 18:44:53 -0700 [Angle] Uniform buffer reuse causes flush, creates invalid state 1871631 1 459740 kpiddington 2022-05-24 18:46:27 -0700 Created attachment 459740 Patch 1871634 2 ews-watchlist 2022-05-24 18:48:27 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1871694 3 459740 kkinnunen 2022-05-25 03:06:32 -0700 Comment on attachment 459740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459740&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:2224 > { this would need some context in the commit message. If you've not updated your checkout, maybe you need to do pull. The commit messages come now from the commit message instead of ChangeLog files. 1871695 4 kkinnunen 2022-05-25 03:07:09 -0700 Do we have any idea in which specific case this happens? In other words, can we write a test for it? 1871868 5 459740 mmaxfield 2022-05-25 15:40:49 -0700 Comment on attachment 459740 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459740&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:2232 > + ASSERT(mRenderEncoder.valid()); Is this really right? ASSERT()s are supposed to only be for things that are provably true. 1871983 6 459782 kkinnunen 2022-05-26 04:15:11 -0700 Created attachment 459782 For landing 1871984 7 kkinnunen 2022-05-26 04:19:18 -0700 At the time, happened on earth.google.com. Most likely started happening once we increased the max uniforms? Could be tested in WebGL test suite, bug 240948. 1872000 8 ews-feeder 2022-05-26 07:00:43 -0700 Committed r294877 (251007@main): <https://commits.webkit.org/251007@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459782. 1872001 9 webkit-bug-importer 2022-05-26 07:01:14 -0700 <rdar://problem/93967506> 459740 2022-05-24 18:46:27 -0700 2022-05-26 04:15:07 -0700 Patch bug-240896-20220524184626.patch text/plain 1954 kpiddington ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJl ci9tZXRhbC9Db250ZXh0TXRsLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFO R0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0KaW5kZXggMDM0MmFlMjBiZGRlZTAwNWEx NDdlZWRiY2MzODI1MDgwYjMxMjNiNS4uMzkwZGMwZTdjMzVmNTkwNTkzNWU3YmUxZWJmOWZhN2Zm ZTJmNmQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF L3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0KQEAgLTIyMjIsNiAr MjIyMiwyNyBAQCBhbmdsZTo6UmVzdWx0IENvbnRleHRNdGw6OnNldHVwRHJhdyhjb25zdCBnbDo6 Q29udGV4dCAqY29udGV4dCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv bnN0IHZvaWQgKmluZGljZXMsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi b29sIHhmYlBhc3MpCiB7CisgICAgQU5HTEVfVFJZKHNldHVwRHJhd0ltcGwoY29udGV4dCwgbW9k ZSwgZmlyc3RWZXJ0ZXgsIHZlcnRleE9ySW5kZXhDb3VudCwgaW5zdGFuY2VzLCBpbmRleFR5cGVP ck5vbmUsIGluZGljZXMsIHhmYlBhc3MpKTsKKyAgICAvL0ZsdXNoIG9jY3VycmVkIGR1cmluZyBz ZXR1cCwgcHJvYmFibHkgZm9yIHJlc291cmNlCisgICAgLy8gYWxsb2NhdGlvbiBmb3IgdW5pZm9y bXMuIFJlZG8gdGhlIHNldHVwLgorICAgIGlmKCFtUmVuZGVyRW5jb2Rlci52YWxpZCgpKQorICAg IHsKKyAgICAgICAgQU5HTEVfVFJZKHNldHVwRHJhd0ltcGwoY29udGV4dCwgbW9kZSwgZmlyc3RW ZXJ0ZXgsIHZlcnRleE9ySW5kZXhDb3VudCwgaW5zdGFuY2VzLCBpbmRleFR5cGVPck5vbmUsIGlu ZGljZXMsIHhmYlBhc3MpKTsKKyAgICB9CisgICAgQVNTRVJUKG1SZW5kZXJFbmNvZGVyLnZhbGlk KCkpOworICAgIHJldHVybiBhbmdsZTo6UmVzdWx0OjpDb250aW51ZTsKK30KK2FuZ2xlOjpSZXN1 bHQgQ29udGV4dE10bDo6c2V0dXBEcmF3SW1wbChjb25zdCBnbDo6Q29udGV4dCAqY29udGV4dCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsOjpQcmltaXRpdmVNb2RlIG1v ZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHTGludCBmaXJzdFZlcnRl eCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdMc2l6ZWkgdmVydGV4T3JJ bmRleENvdW50LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0xzaXplaSBp bnN0YW5jZXMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbDo6RHJhd0Vs ZW1lbnRzVHlwZSBpbmRleFR5cGVPck5vbmUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb25zdCB2b2lkICppbmRpY2VzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYm9vbCB4ZmJQYXNzKQoreworICAgIAorCiAgICAgQVNTRVJUKG1Qcm9ncmFtKTsK IAogICAgIC8vIGluc3RhbmNlcz0wIG1lYW5zIG5vIGluc3RhbmNlZCBkcmF3LgpAQCAtMjM1NCw3 ICsyMzc1LDYgQEAgYW5nbGU6OlJlc3VsdCBDb250ZXh0TXRsOjpzZXR1cERyYXcoY29uc3QgZ2w6 OkNvbnRleHQgKmNvbnRleHQsCiAKICAgICBBTkdMRV9UUlkobVByb2dyYW0tPnNldHVwRHJhdyhj b250ZXh0LCAmbVJlbmRlckVuY29kZXIsIG1SZW5kZXJQaXBlbGluZURlc2MsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaXNQaXBlbGluZURlc2NDaGFuZ2VkLCB0ZXh0dXJlQ2hh bmdlZCwgdW5pZm9ybUJ1ZmZlcnNEaXJ0eSkpOwotCiAgICAgcmV0dXJuIGFuZ2xlOjpSZXN1bHQ6 OkNvbnRpbnVlOwogfQogCg== 459782 2022-05-26 04:15:11 -0700 2022-05-26 09:38:33 -0700 For landing bug-240896-20220526141510.patch text/plain 3124 kkinnunen RnJvbSBmNjZlZjRlYThmMzc1NTFjZDkzOWVhMDhmM2E2YjcwMGNiOTY0NzNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLaW1tbyBLaW5udW5lbiA8a2tpbm51bmVuQGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAyNiBNYXkgMjAyMiAxMzoyMzoyMyArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFtB bmdsZV0gVW5pZm9ybSBidWZmZXIgcmV1c2UgY2F1c2VzIGZsdXNoLCBjcmVhdGVzIGludmFsaWQK IHN0YXRlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDA4OTYKClBh dGNoIGJ5IEt5bGUgUGlkZGluZ3Rvbi4KClJldmlld2VkIGJ5IEtpbW1vIEtpbm51bmVuLgoKQSBm bHVzaCBkdXJpbmcgZHJhdyBzZXR1cCB3b3VsZCBsZWF2ZSB0aGUgcmVuZGVyIGNvbW1hbmQgZW5j b2Rlcgpub3Qgc3RhcnRlZCBhbmQgcmVuZGVyIHBpcGVsaW5lIHVuc2V0LiBUaGlzIHdvdWxkIGFz c2VydCBpbiBkZWJ1ZwphbmQgbGVhayBtZW1vcnkgd2l0aCBjb3JydXB0ZWQgZHJhd3MgaW4gcmVs ZWFzZS4KClRoaXMgd291bGQgaGFwcGVuIGZvciBleGFtcGxlIHdoZW4gdW5pZm9ybSBidWZmZXIg cG9vbCB3b3VsZCBydW4Kb3V0IG9mIHVuaWZvcm0gbWVtb3J5LiBJZiB0aGUgcG9vbCBpcyBtYXhl ZCBvdXQsIHdlIGZsdXNoIHRoZQpleGlzdGluZyByZW5kZXJpbmcgdG8gb2J0YWluIGZyZWUgYnVm ZmVycy4gQWZ0ZXIgdGhlIGZsdXNoLAp3ZSBuZWVkIHRvIHJlLXJ1biB0aGUgc2V0dXAuCgpUZXN0 IGlzIHRyYWNrZWQgaW4gYnVnIDI0MDk0OC4KCiogU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW06CihyeDo6Q29udGV4dE10bDo6 c2V0dXBEcmF3KToKKHJ4OjpDb250ZXh0TXRsOjpzZXR1cERyYXdJbXBsKToKLS0tCiAuLi4vc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0gfCAyNiArKysrKysrKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9Db250ZXh0 TXRsLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21l dGFsL0NvbnRleHRNdGwubW0KaW5kZXggMDM0MmFlMjBiZGRlLi45YTk1NzUxMzdkYjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRh bC9Db250ZXh0TXRsLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdM RS9yZW5kZXJlci9tZXRhbC9Db250ZXh0TXRsLm1tCkBAIC0yMjIxLDYgKzIyMjEsMzIgQEAgYW5n bGU6OlJlc3VsdCBDb250ZXh0TXRsOjpzZXR1cERyYXcoY29uc3QgZ2w6OkNvbnRleHQgKmNvbnRl eHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbDo6RHJhd0VsZW1lbnRz VHlwZSBpbmRleFR5cGVPck5vbmUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb25zdCB2b2lkICppbmRpY2VzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYm9vbCB4ZmJQYXNzKQoreworICAgIEFOR0xFX1RSWShzZXR1cERyYXdJbXBsKGNvbnRleHQs IG1vZGUsIGZpcnN0VmVydGV4LCB2ZXJ0ZXhPckluZGV4Q291bnQsIGluc3RhbmNlcywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpbmRleFR5cGVPck5vbmUsIGluZGljZXMsIHhmYlBhc3Mp KTsKKyAgICBpZiAoIW1SZW5kZXJFbmNvZGVyLnZhbGlkKCkpCisgICAgeworICAgICAgICAvLyBG bHVzaCBvY2N1cnJlZCBkdXJpbmcgc2V0dXAsIGR1ZSB0byBydW5uaW5nIG91dCBvZiBtZW1vcnkg d2hpbGUgc2V0dGluZyB1cCB0aGUgcmVuZGVyCisgICAgICAgIC8vIHBhc3Mgc3RhdGUuIFRoaXMg d291bGQgaGFwcGVuIGZvciBleGFtcGxlIHdoZW4gdGhlcmUgaXMgbm8gbW9yZSBzcGFjZSBpbiB0 aGUgdW5pZm9ybQorICAgICAgICAvLyBidWZmZXJzIGluIHRoZSB1bmlmb3JtIGJ1ZmZlciBwb29s LiBUaGUgcmVuZGVyaW5nIHdvdWxkIGJlIGZsdXNoZWQgdG8gZnJlZSB0aGUgdW5pZm9ybQorICAg ICAgICAvLyBidWZmZXIgbWVtb3J5IGZvciBuZXcgdXNhZ2UuIEluIHRoaXMgY2FzZSwgcmUtcnVu IHRoZSBzZXR1cC4KKyAgICAgICAgQU5HTEVfVFJZKHNldHVwRHJhd0ltcGwoY29udGV4dCwgbW9k ZSwgZmlyc3RWZXJ0ZXgsIHZlcnRleE9ySW5kZXhDb3VudCwgaW5zdGFuY2VzLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpbmRleFR5cGVPck5vbmUsIGluZGljZXMsIHhmYlBhc3Mp KTsKKyAgICAgICAgLy8gU2V0dXAgd2l0aCBmbHVzaGVkIHN0YXRlIHNob3VsZCBlaXRoZXIgcHJv ZHVjZSBhIHdvcmtpbmcgZW5jb2RlciBvciBmYWlsIHdpdGggYW4gZXJyb3IKKyAgICAgICAgLy8g cmVzdWx0LgorICAgICAgICBBU1NFUlQobVJlbmRlckVuY29kZXIudmFsaWQoKSk7CisgICAgfQor ICAgIHJldHVybiBhbmdsZTo6UmVzdWx0OjpDb250aW51ZTsKK30KKworYW5nbGU6OlJlc3VsdCBD b250ZXh0TXRsOjpzZXR1cERyYXdJbXBsKGNvbnN0IGdsOjpDb250ZXh0ICpjb250ZXh0LAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsOjpQcmltaXRpdmVNb2RlIG1v ZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0xpbnQgZmlyc3RW ZXJ0ZXgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0xzaXplaSB2 ZXJ0ZXhPckluZGV4Q291bnQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgR0xzaXplaSBpbnN0YW5jZXMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZ2w6OkRyYXdFbGVtZW50c1R5cGUgaW5kZXhUeXBlT3JOb25lLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHZvaWQgKmluZGljZXMsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCB4ZmJQYXNzKQogewogICAgIEFT U0VSVChtUHJvZ3JhbSk7CiAKLS0gCjIuMzIuMCAoQXBwbGUgR2l0LTEzMikKCg==