24079 2009-02-22 01:49:25 -0800 REGRESSION(r39549): Page loads cannot be interrupted with Command-. or Escape 2009-03-05 17:43:48 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P2 Minor --- 1 jonasw adele ap zwarich oldest_to_newest 110494 0 jonasw 2009-02-22 01:49:25 -0800 The loading of a page cannot be interrupted with keyboard shortcuts such as the Escape key or Command-period. The "Stop" command in the the View menu and the stop button in the toolbar still work as expected. Note that this does not apply to the very first phases of page loading (probably DNS resolving or similar) but rather when the page data arrives and the window shows some of the page content. Tested with WebKit Nightly r41121, though the issue has been present for many weeks or even months. (Speaking of interrupting loading I'd like to suggest a Stop button per sub-request in the Activity window as well, but that should be a separate ticket.) 110496 1 mrowe 2009-02-22 02:47:54 -0800 <rdar://problem/6611233> 111164 2 mrowe 2009-02-26 05:32:21 -0800 Cameron, you broke this with <http://trac.webkit.org/changeset/39549>. 111177 3 zwarich 2009-02-26 07:35:10 -0800 Damn, I suck. I'll try to fix it. 111386 4 zwarich 2009-02-26 20:56:49 -0800 This problem is caused by a ocmbination of r38629 and r39549. After r38629, all key events pass through the editor machinery. Most key combinations in the browser are promptly ignored. However, escape and command-. give the "cancelOperation" editor command, which causes them to be handled by doCommandBySelector. Strangely, cancelOperation: works fine with [super doCommandBySelector:selector], but if we ignore it like my change in r38549 does, then it doesn't get handled correctly by the responder chain. I know that these events are handled in a weird way by AppKit, but I haven't looked into it much further. As an aside, it might be best to decide whether to handle editor events (even though we are not currently editing) outside of doCommandBySelector. I'll play around with this a bit to see if I can shed more light on the problem, but it is probably best if an Apple person can take this bug. 111387 5 28062 zwarich 2009-02-26 21:07:19 -0800 Created attachment 28062 Backtrace of [WebView stopLoading:] as in r39548 This is a backtrace of [WebView stopLoading:] before my change in r39549 (I just reverted locally). The event gets passed to Safari by [NSWindow doCommandBySelector:]. 112484 6 28339 adele 2009-03-05 17:07:31 -0800 Created attachment 28339 patch I tested this by making sure cmd-. and escape cause loading to be stopped. I tested that ctrl-tab works to switch tabs when focus is in a text field. And I tested that pageup/pagedown and home/end work with Mail. And I ran layout tests. I'm not convinced this solution is perfect, but I am sure it works better than our current code for many cases. 112487 7 28339 darin 2009-03-05 17:15:32 -0800 Comment on attachment 28339 patch r=me Testing is the key. 112493 8 adele 2009-03-05 17:43:48 -0800 Committed revision 41467. 28062 2009-02-26 21:07:19 -0800 2009-02-26 21:07:19 -0800 Backtrace of [WebView stopLoading:] as in r39548 backtrace.txt text/plain 2618 zwarich IzAgIC1bV2ViVmlldyhXZWJJQkFjdGlvbnMpIHN0b3BMb2FkaW5nOl0gKHNlbGY9MHg2OTc2OWQw LCBfY21kPTB4MmY4MmM0LCBzZW5kZXI9MHgwKSBhdCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW06MzQ5MQojMSAgMHgwMDAzYjMwNSBpbiA/PyAoKQoj MiAgMHg5MThiOWMxOCBpbiAtW05TV2luZG93IGRvQ29tbWFuZEJ5U2VsZWN0b3I6XSAoKQojMyAg MHgwMDI3ZTU2MiBpbiAtW1dlYkhUTUxWaWV3KFdlYk5TVGV4dElucHV0U3VwcG9ydCkgZG9Db21t YW5kQnlTZWxlY3RvcjpdIChzZWxmPTB4NjliMmY3MCwgX2NtZD0weDk1MDhmY2E0LCBzZWxlY3Rv cj0weDk1MGU3ZWI4KSBhdCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYkhUTUxWaWV3Lm1tOjUzNTUKIzQgIDB4OTE3NDQyODEgaW4gLVtOU1Jlc3BvbmRlciBkb0Nv bW1hbmRCeVNlbGVjdG9yOl0gKCkKIzUgIDB4OTE4YjljM2YgaW4gLVtOU1dpbmRvdyBkb0NvbW1h bmRCeVNlbGVjdG9yOl0gKCkKIzYgIDB4MDAyN2U1NjIgaW4gLVtXZWJIVE1MVmlldyhXZWJOU1Rl eHRJbnB1dFN1cHBvcnQpIGRvQ29tbWFuZEJ5U2VsZWN0b3I6XSAoc2VsZj0weDY5YjJmNzAsIF9j bWQ9MHg5NTA4ZmNhNCwgc2VsZWN0b3I9MHg5NTBjOGJhMCkgYXQgL1VzZXJzL0NhbWVyb24vV2Vi S2l0L1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbTo1MzU1CiM3ICAweDAwMjdkMzgx IGluIC1bV2ViSFRNTFZpZXcoV2ViSW50ZXJuYWwpIF9pbnRlcmNlcHRFZGl0aW5nS2V5RXZlbnQ6 c2hvdWxkU2F2ZUNvbW1hbmQ6XSAoc2VsZj0weDY5YjJmNzAsIF9jbWQ9MHgzMDUzZGMsIGV2ZW50 PTB4MWNkYTk5ZDAsIHNob3VsZFNhdmU9MCAnXDAwMCcpIGF0IC9Vc2Vycy9DYW1lcm9uL1dlYktp dC9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW06NDk3MgojOCAgMHgwMDI0YzY2NSBp biBXZWJFZGl0b3JDbGllbnQ6OmhhbmRsZUtleWJvYXJkRXZlbnQgKHRoaXM9MHg2OTg2ZDcwLCBl dmVudD0weDFjZGE5OWQwKSBhdCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW06NDQxCiM5ICAweDAzNmZhNzNkIGluIFdlYkNv cmU6OkVkaXRvcjo6aGFuZGxlS2V5Ym9hcmRFdmVudCAodGhpcz0weDcwOWVhZDQsIGV2ZW50PTB4 MWNkYTk5ZDApIGF0IC9Vc2Vycy9DYW1lcm9uL1dlYktpdC9XZWJDb3JlL2VkaXRpbmcvRWRpdG9y LmNwcDoxMDUKIzEwIDB4MDM3MTc3NmYgaW4gV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpkZWZhdWx0 S2V5Ym9hcmRFdmVudEhhbmRsZXIgKHRoaXM9MHg3MDllYjAwLCBldmVudD0weDFjZGE5OWQwKSBh dCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHA6MTkw NwojMTEgMHgwM2E3ZmRiZSBpbiBXZWJDb3JlOjpOb2RlOjpkZWZhdWx0RXZlbnRIYW5kbGVyICh0 aGlzPTB4MWM5ZTJlMzAsIGV2ZW50PTB4MWNkYTk5ZDApIGF0IC9Vc2Vycy9DYW1lcm9uL1dlYktp dC9XZWJDb3JlL2RvbS9Ob2RlLmNwcDoyODQyCiMxMiAweDAzYTc4MTNmIGluIFdlYkNvcmU6Ok5v ZGU6OmRpc3BhdGNoR2VuZXJpY0V2ZW50ICh0aGlzPTB4MWM5ZTJlMzAsIHBycEV2ZW50PUAweGJm ZmZlZjdjKSBhdCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2ViQ29yZS9kb20vTm9kZS5jcHA6MjQ2 OQojMTMgMHgwM2E3ODQyNyBpbiBXZWJDb3JlOjpOb2RlOjpkaXNwYXRjaEV2ZW50ICh0aGlzPTB4 MWM5ZTJlMzAsIGU9QDB4YmZmZmYwMjgsIGVjPUAweGJmZmZmMDBjKSBhdCAvVXNlcnMvQ2FtZXJv bi9XZWJLaXQvV2ViQ29yZS9kb20vTm9kZS5jcHA6MjM2NgojMTQgMHgwMzcxYTc4YSBpbiBXZWJD b3JlOjpFdmVudEhhbmRsZXI6OmtleUV2ZW50ICh0aGlzPTB4NzA5ZWIwMCwgaW5pdGlhbEtleUV2 ZW50PUAweGJmZmZmMDhjKSBhdCAvVXNlcnMvQ2FtZXJvbi9XZWJLaXQvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHA6MTg0OAojMTUgMHgwMzcxZmIwNyBpbiBXZWJDb3JlOjpFdmVudEhhbmRs ZXI6OmtleUV2ZW50ICh0aGlzPTB4NzA5ZWIwMCwgZXZlbnQ9MHgxY2QwMWRiMCkgYXQgL1VzZXJz L0NhbWVyb24vV2ViS2l0L1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tOjE3Mgoj MTYgMHgwMDI3NGMwNiBpbiAtW1dlYkhUTUxWaWV3IGtleURvd246XSAoc2VsZj0weDY5YjJmNzAs IF9jbWQ9MHg5NTEwZDU5MCwgZXZlbnQ9MHgxY2QwMWRiMCkgYXQgL1VzZXJzL0NhbWVyb24vV2Vi S2l0L1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbTozNzQwCiMxNyAweDkxNmE1ZGRk IGluIC1bTlNXaW5kb3cgc2VuZEV2ZW50Ol0gKCkKIzE4IDB4MDAwMmIwZDMgaW4gPz8gKCkKIzE5 IDB4OTE2NzFkNDkgaW4gLVtOU0FwcGxpY2F0aW9uIHNlbmRFdmVudDpdICgpCiMyMCAweDAwMDJh YjU4IGluID8/ICgpCiMyMSAweDkxNWNmNjlmIGluIC1bTlNBcHBsaWNhdGlvbiBydW5dICgpCiMy MiAweDkxNTljOGE0IGluIE5TQXBwbGljYXRpb25NYWluICgpCiMyMyAweDAwMGI5YjE2IGluID8/ ICgpCkN1cnJlbnQgbGFuZ3VhZ2U6ICBhdXRvOyBjdXJyZW50bHkgb2JqZWN0aXZlLWMrKwo= 28339 2009-03-05 17:07:31 -0800 2009-03-05 17:15:32 -0800 patch patch_3-5-09-2.txt text/plain 2845 adele SW5kZXg6IG1hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFjL0NoYW5nZUxvZwkocmV2aXNp b24gNDE0NjQpCisrKyBtYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDktMDMtMDUgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDc5CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS82NjExMjMzPiBSRUdSRVNTSU9OIChyMzk1NDkpOiBQYWdlIGxvYWRzIGNhbm5vdCBi ZSBpbnRlcnJ1cHRlZCB3aXRoIENvbW1hbmQtLiBvciBFc2NhcGUKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzY2MzY1NjM+IEN0cmwtdGFiIHNob3J0Y3V0IGRvZXNuJ3Qgc3dpdGNoIHRhYnMgd2hl biBmb2N1cyBpcyBpbiB0ZXh0IGZpZWxkCisgICAgICAgCisgICAgICAgICogV2ViVmlldy9XZWJI VE1MVmlldy5tbTogKC1bV2ViSFRNTFZpZXcgZG9Db21tYW5kQnlTZWxlY3RvcjpdKToKKyAgICAg ICAgSWYgV2ViS2l0IGRvZXMgbm90IHN1cHBvcnQgdGhlIGNvbW1hbmQsIHdlIG5lZWQgdG8gcGFz cyB0aGUgc2VsZWN0b3IgdG8gc3VwZXIuICBJbiB0aGlzIGNhc2UsCisgICAgICAgIHdlJ2xsIGNv bnNpZGVyIHRoZSBldmVudCBub3QgdG8gYmUgaGFuZGxlZC4gIFRoaXMgaXMgbm90IHBlcmZlY3Qg YmVjYXVzZSBpbiB0aGVvcnksIFtzdXBlciBkb0NvbW1hbmRCeVNlbGVjdG9yOl0gCisgICAgICAg IGNhbiBkbyBzb21lIGFjdGlvbiB0aGF0IHdvdWxkIGNhdXNlIFdlYktpdCB0byBuZWVkIHRvIGNv bnNpZGVyIHRoZSBldmVudCBoYW5kbGVkLiAgQnV0IGluIHByYWN0aWNlLCBJJ3ZlIGZvdW5kIG5v CisgICAgICAgIGV4YW1wbGUgb2YgdGhhdCBoYXBwZW5pbmcgYW5kIGNhdXNpbmcgYnJva2VuIGJl aGF2aW9yLgorCiAyMDA5LTAzLTA0ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IG1hYy9XZWJWaWV3L1dlYkhU TUxWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIG1hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCShyZXZp c2lvbiA0MTQ2NCkKKysrIG1hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC01Mzc1LDE4ICs1Mzc1LDE2IEBAIHN0YXRpYyB2b2lkIGV4dHJhY3RVbmRlcmxpbmVzKE5T QXR0cmlidXQKICAgICAgICAgICAgIEVkaXRvcjo6Q29tbWFuZCBjb21tYW5kID0gW3NlbGYgY29y ZUNvbW1hbmRCeVNlbGVjdG9yOnNlbGVjdG9yXTsKICAgICAgICAgICAgIGlmIChjb21tYW5kLmlz U3VwcG9ydGVkKCkpCiAgICAgICAgICAgICAgICAgZXZlbnRXYXNIYW5kbGVkID0gY29tbWFuZC5l eGVjdXRlKGV2ZW50KTsKLSAgICAgICAgICAgIGVsc2UgaWYgKFtzZWxmIF9jYW5FZGl0XSkgewot ICAgICAgICAgICAgICAgIC8vIElmIHRoZSBjb21tYW5kIGlzIHVuc3VwcG9ydGVkIGFuZCB0aGUg V2ViSFRNTFZpZXcgaXMgZWRpdGFibGUsIHRoZW4gcGFzcyB0aGUKLSAgICAgICAgICAgICAgICAv LyBzZWxlY3RvciB0byBzdXBlciBhbmQgc2F5IHRoYXQgdGhlIGV2ZW50IHdhcyBoYW5kbGVkLiBJ ZiB0aGUgV2ViSFRNTFZpZXcgaXMKLSAgICAgICAgICAgICAgICAvLyBub3QgZWRpdGFibGUsIHRo ZW4gZG8gbm90IHNheSB0aGF0IHRoZSBldmVudCB3YXMgaGFuZGxlZC4gVGhpcyBpcyBpbXBvcnRh bnQKLSAgICAgICAgICAgICAgICAvLyBiZWNhdXNlIG9mIHNlbGVjdG9ycyBsaWtlIHNjcm9sbFBh Z2VEb3duOiwgd2hpY2ggY29tZSBhcyBpbnB1dCBtZXRob2QgZXZlbnRzCi0gICAgICAgICAgICAg ICAgLy8gd2hlbiBlZGl0aW5nIGlzIGVuYWJsZWQgYnV0IGtleWJvYXJkIGV2ZW50cyB3aGVuIGl0 IGlzIG5vdC4gVGhlc2UgZXZlbnRzIGFyZQotICAgICAgICAgICAgICAgIC8vIGhhbmRsZWQgYnkg dGhlIG5leHQgcmVzcG9uZGVyIGluIHRoZSByZXNwb25kZXIgY2hhaW4uCisgICAgICAgICAgICBl bHNlIHsKICAgICAgICAgICAgICAgICBfcHJpdmF0ZS0+c2VsZWN0b3JGb3JEb0NvbW1hbmRCeVNl bGVjdG9yID0gc2VsZWN0b3I7CisgICAgICAgICAgICAgICAgLy8gSWYgV2ViS2l0IGRvZXMgbm90 IHN1cHBvcnQgdGhpcyBjb21tYW5kLCB3ZSBuZWVkIHRvIHBhc3MgdGhlIHNlbGVjdG9yIHRvIHN1 cGVyLgogICAgICAgICAgICAgICAgIFtzdXBlciBkb0NvbW1hbmRCeVNlbGVjdG9yOnNlbGVjdG9y XTsKICAgICAgICAgICAgICAgICBfcHJpdmF0ZS0+c2VsZWN0b3JGb3JEb0NvbW1hbmRCeVNlbGVj dG9yID0gMDsKLSAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIC8vIEluIHRoZW9y eSwgW3N1cGVyIGRvQ29tbWFuZEJ5U2VsZWN0b3I6XSBjYW4gZG8gc29tZSBhY3Rpb24gdGhhdCB3 b3VsZCBjYXVzZSBXZWJLaXQgCisgICAgICAgICAgICAgICAgLy8gdG8gbmVlZCB0byBjb25zaWRl ciB0aGUgZXZlbnQgaGFuZGxlZC4gIEJ1dCBpbiBwcmFjdGljZSwgSSd2ZSBmb3VuZCBubworICAg ICAgICAgICAgICAgIC8vIGV4YW1wbGUgb2YgdGhhdCBoYXBwZW5pbmcgYW5kIGNhdXNpbmcgYnJv a2VuIGJlaGF2aW9yLgogICAgICAgICAgICAgICAgIGV2ZW50V2FzSGFuZGxlZCA9IGZhbHNlOwor ICAgICAgICAgICAgfQogICAgICAgICB9CiAKICAgICAgICAgaWYgKHBhcmFtZXRlcnMpCg==