24076 2009-02-21 14:46:41 -0800 [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing 2009-02-28 22:22:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned oldest_to_newest 110482 0 jmalonzo 2009-02-21 14:46:41 -0800 We need to modify the path to point to libwebkit when detecting 3D transforms and accelerated compositing, just like how we do it when detecting SVG, WML, etc... The attached patch does this. 110483 1 27856 jmalonzo 2009-02-21 14:47:51 -0800 Created attachment 27856 modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing 111174 2 27856 zecke 2009-02-26 06:50:54 -0800 Comment on attachment 27856 modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing Is there a way to remove the code duplication? E.g. changing the path before calling hasFoo..? 111611 3 28114 jmalonzo 2009-02-28 05:09:53 -0800 Created attachment 28114 refactor gtk lib detection and put it in one place Hi zecke. This patch does what you asked for. Thanks for the feedback. 111660 4 28114 zecke 2009-02-28 19:42:07 -0800 Comment on attachment 28114 refactor gtk lib detection and put it in one place Assuming the path is correct. Thanks for the cleanup. 111672 5 jmalonzo 2009-02-28 22:22:06 -0800 Landed in r42326. Thanks! 27856 2009-02-21 14:47:51 -0800 2009-02-28 05:09:53 -0800 modify path to point to libwebkit.so when detecting 3D transforms and accelerated compositing runwebkittests-gtkguard-transformaccelcompositing.patch text/plain 1258 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNmU5NDAwLi5mZWYzMTFjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDIt MjEgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWx0ZXIgdGhlIHBhdGggZm9y IGd0ayB3aGVuIGRldGVjdGluZyAzRCB0cmFuc2Zvcm1zIGFuZAorICAgICAgICBhY2NlbGVyYXRl ZCBjb21wb3NpdGluZy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKwogMjAw OS0wMi0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVy LXN0YW1wZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4gCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KaW5kZXggOTQ3ZGJjYS4uNzEwNjU0MSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpA QCAtNDcyLDYgKzQ3MiwxMCBAQCBzdWIgaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ1N1cHBvcnQK ICAgICAKICAgICBteSAkcGF0aCA9IHNoaWZ0OwogCisgICAgaWYgKGlzR3RrKCkgYW5kICRwYXRo ID1+IC9XZWJDb3JlLykgeworICAgICAgICAkcGF0aCAuPSAiLy4uLy5saWJzL2xpYndlYmtpdC0x LjAuc28iOworICAgIH0KKwogICAgIG15ICR1c2VBY2NlbGVyYXRlZENvbXBvc2l0aW5nID0gMDsK ICAgICBpZiAoLWUgJHBhdGgpIHsKICAgICAgICAgb3BlbiBOTSwgIi18IiwgIm5tIiwgJHBhdGgg b3IgZGllOwpAQCAtNTAxLDYgKzUwNSwxMCBAQCBzdWIgaGFzM0RUcmFuc2Zvcm1zU3VwcG9ydAog ICAgIAogICAgIG15ICRwYXRoID0gc2hpZnQ7CiAKKyAgICBpZiAoaXNHdGsoKSBhbmQgJHBhdGgg PX4gL1dlYkNvcmUvKSB7CisgICAgICAgICRwYXRoIC49ICIvLi4vLmxpYnMvbGlid2Via2l0LTEu MC5zbyI7CisgICAgfQorCiAgICAgbXkgJGhhczNEVHJhbnNmb3Jtc1N1cHBvcnQgPSAwOwogICAg IGlmICgtZSAkcGF0aCkgewogICAgICAgICBvcGVuIE5NLCAiLXwiLCAibm0iLCAkcGF0aCBvciBk aWU7Cg== 28114 2009-02-28 05:09:53 -0800 2009-02-28 19:42:07 -0800 refactor gtk lib detection and put it in one place gtk-webkitdirs-refactor-lib-detection.patch text/plain 1831 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiMjgzY2QwLi40ZWRkMzUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDIt MjggIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gd2Via2l0ZGlycy5w bSBtb2RpZnkgcGF0aCBpbiB3aGVuIGRldGVjdGluZyAzRCB0cmFuc2Zvcm1zIGFuZCBhY2NlbGVy YXRlZCBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjQwNzYKKworICAgICAgICBSZWZhY3RvciBndGsgbGliIGRldGVjdGlvbiBhbmQg cHV0IGl0IGluIGJ1aWx0RHlsaWJQYXRoRm9yTmFtZQorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRkaXJzLnBtOgorCiAyMDA5LTAyLTI3ICBYYW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgogCiAg ICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KaW5kZXggZDEyMmRkOC4uZjk1ODU5YSAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQpAQCAtMzg4LDkgKzM4OCwxMiBAQCBzdWIgYnVpbHREeWxpYlBhdGhGb3JOYW1l CiB7CiAgICAgbXkgJGxpYnJhcnlOYW1lID0gc2hpZnQ7CiAgICAgZGV0ZXJtaW5lQ29uZmlndXJh dGlvblByb2R1Y3REaXIoKTsKLSAgICBpZiAoaXNRdCgpIG9yIGlzR3RrKCkgb3IgaXNDaHJvbWl1 bSgpKSB7CisgICAgaWYgKGlzUXQoKSBvciBpc0Nocm9taXVtKCkpIHsKICAgICAgICAgcmV0dXJu ICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvJGxpYnJhcnlOYW1lIjsKICAgICB9CisgICAgaWYg KGlzR3RrKCkpIHsKKyAgICAgICAgcmV0dXJuICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIvJGxp YnJhcnlOYW1lLy4uLy5saWJzL2xpYndlYmtpdC0xLjAuc28iOworICAgIH0KICAgICBpZiAoaXNB cHBsZU1hY1dlYktpdCgpKSB7CiAgICAgICAgIHJldHVybiAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0 RGlyLyRsaWJyYXJ5TmFtZS5mcmFtZXdvcmsvVmVyc2lvbnMvQS8kbGlicmFyeU5hbWUiOwogICAg IH0KQEAgLTQyNywxMCArNDMwLDYgQEAgc3ViIGhhc1NWR1N1cHBvcnQKICAgICAgICAgcmV0dXJu IDE7CiAgICAgfQogCi0gICAgaWYgKGlzR3RrKCkgYW5kICRwYXRoID1+IC9XZWJDb3JlLykgewot ICAgICAgICAkcGF0aCAuPSAiLy4uLy5saWJzL2xpYndlYmtpdC0xLjAuc28iOwotICAgIH0KLQog ICAgIG15ICRoYXNTVkdTdXBwb3J0ID0gMDsKICAgICBpZiAoLWUgJHBhdGgpIHsKICAgICAgICAg b3BlbiBOTSwgIi18IiwgIm5tIiwgJHBhdGggb3IgZGllOwpAQCAtNTM1LDEwICs1MzQsNiBAQCBz dWIgaGFzV01MU3VwcG9ydAogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBpZiAoaXNH dGsoKSBhbmQgJHBhdGggPX4gL1dlYkNvcmUvKSB7Ci0gICAgICAgICRwYXRoIC49ICIvLi4vLmxp YnMvd2Via2l0LTEuMC5zbyI7Ci0gICAgfQotCiAgICAgbXkgJGhhc1dNTFN1cHBvcnQgPSAwOwog ICAgIGlmICgtZSAkcGF0aCkgewogICAgICAgICBvcGVuIE5NLCAiLXwiLCAibm0iLCAkcGF0aCBv ciBkaWU7Cg==