240715 2022-05-20 07:28:23 -0700 Web Inspector: Assertion Failed: Expect an array of string values CSSCompletions.js:39 2022-05-24 13:55:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman rcaliman inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1870703 0 rcaliman 2022-05-20 07:28:23 -0700 ``` [Error] Assertion Failed: Expect an array of string values – [] (0) CSSCompletions (CSSCompletions.js:39) (anonymous function) (CSSKeywordCompletions.js:233) (anonymous function) (CSSKeywordCompletions.js:129) _valueCompletionDataProvider _updateCompletions (SpreadsheetTextField.js:435) _handleInput (SpreadsheetTextField.js:422) _handleInput ``` **Steps to reproduce** - Open Web Inspector, go to Styles sidebar panel - Type `var(` on any CSS value **Result** No issue in UI or UX, but the assertion above is hit. **Explanation** It happens because the `WI.CSSCompletions` instance created in `WI.CSSKeywordCompletions.forFunction()` is initially given an empty array for "var" functions. The actual values are added immediately after instantiation via `WI.CSSCompletions.addValues()`. They come from the custom completion provider referenced by the `additionalFunctionValueCompletionsProvider` option. There's no reason to have this two step approach. We can provide the result of `additionalFunctionValueCompletionsProvider("var")` at `WI.CSSCompletions` instantiation. 1870704 1 webkit-bug-importer 2022-05-20 07:29:02 -0700 <rdar://problem/93653315> 1870712 2 rcaliman 2022-05-20 07:50:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/831 1871563 3 ews-feeder 2022-05-24 13:55:35 -0700 Committed r294763 (250929@main): <https://commits.webkit.org/250929@main> Reviewed commits have been landed. Closing PR #831 and removing active labels.