24070 2009-02-20 19:47:47 -0800 Changing "scrolling" attribute on iframe element already in DOM doesn't take effect 2024-10-09 21:02:10 -0700 1 1 1 Unclassified WebKit Scrolling 528+ (Nightly build) All All RESOLVED FIXED GoodFirstBug, InRadar P2 Normal --- 1 tom mattwoodrow ahmad.saleem792 ap bfulgham jasneet mattwoodrow rniwa simon.fraser techrazy.yang webkit-bug-importer zwarich oldest_to_newest 110457 0 tom 2009-02-20 19:47:47 -0800 Changing "scrolling" attribute on iframe element already in DOM doesn't take effect. Works as expected in Firefox. 110458 1 27847 tom 2009-02-20 19:48:21 -0800 Created attachment 27847 Reduction 110462 2 techrazy.yang 2009-02-20 20:51:40 -0800 conform on Windows Safari. 111378 3 28060 techrazy.yang 2009-02-26 18:36:05 -0800 Created attachment 28060 First attempt to fix the bug Add a new method in FrameView to change the scrollbar's state and a test case for this bug. 116122 4 zwarich 2009-03-31 18:22:35 -0700 *** Bug 24972 has been marked as a duplicate of this bug. *** 116124 5 28060 zwarich 2009-03-31 18:42:48 -0700 Comment on attachment 28060 First attempt to fix the bug + if (attached()) { Is there any need to check attached() here? Shouldn't checking contentFrame() be enough? + if (contentFrame() && contentFrame()->view()) { + FrameView* view = contentFrame()->view(); + view->changeScrollbarsState(m_scrolling != ScrollbarAlwaysOff); + } + } There is already a method on FrameView for setting the scrollbar state: void setCanHaveScrollbars(bool canScroll); You should use that instead of making your own. I'm r-'ing this patch, but I am glad that you are fixing this bug. 1890460 6 ahmad.saleem792 2022-08-10 17:26:46 -0700 I am able to reproduce this in Safari 15.6 on macOS using modified test case by changing HTTP to HTTPS in test case: Link - https://jsfiddle.net/fcjd6qr8/ Following are results across browsers: *** Firefox Nightly 105 *** Once iframe load, clicking "show scrollbars" load "scrollbar" in iframe *** Chrome Canary 106 *** Nothing loads and "show scrollbars" do nothing. *** Safari 15.6 on macOS 12.5 *** Nothing loads and "show scrollbars" do nothing. ________ I am not sure on web-spec but just wanted to share updated testing results. Thanks! 1892598 7 webkit-bug-importer 2022-08-19 20:43:34 -0700 <rdar://problem/98911472> 1892599 8 461752 simon.fraser 2022-08-19 21:14:58 -0700 Created attachment 461752 Reduction 1892600 9 simon.fraser 2022-08-19 21:22:25 -0700 HTMLFrameElementBase::parseAttribute() needs to respond to "scrolling" attribute changes. 2066381 10 mattwoodrow 2024-10-08 20:17:23 -0700 *** This bug has been marked as a duplicate of bug 281103 *** 2066673 11 mattwoodrow 2024-10-09 15:31:15 -0700 I'll fix this as a separate task. 2066676 12 mattwoodrow 2024-10-09 15:35:22 -0700 Pull request: https://github.com/WebKit/WebKit/pull/34933 2066784 13 ews-feeder 2024-10-09 21:02:07 -0700 Committed 284947@main (d98621968e3c): <https://commits.webkit.org/284947@main> Reviewed commits have been landed. Closing PR #34933 and removing active labels. 27847 2009-02-20 19:48:21 -0800 2022-08-19 21:14:58 -0700 Reduction webkit iframe reduction.html text/html 185 tom PGlucHV0IHR5cGU9ImJ1dHRvbiIgdmFsdWU9IlNob3cgc2Nyb2xsYmFycyIgb25jbGljaz0iZG9j dW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2lmcmFtZScpWzBdLnNldEF0dHJpYnV0ZSgnc2Ny b2xsaW5nJywgJ3llcycpOyIgLz4KPGlmcmFtZSBzcmM9Imh0dHA6Ly93ZWJraXQub3JnLyIgc2Ny b2xsaW5nPSJubyIgLz4= 28060 2009-02-26 18:36:05 -0800 2010-06-10 16:55:51 -0700 First attempt to fix the bug 24070.patch text/plain 5805 techrazy.yang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTI3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDItMjYgIEJvIFlhbmcgIDx0ZWNocmF6eS55YW5nQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQwNzAKKyAgICAgICAgVGVz dDogZmFzdC9mcmFtZXMvaWZyYW1lLWpzLXNjcm9sbGluZy1hdHRyaWJ1dGUuaHRtbAorCisgICAg ICAgIEFkZCBhIG1ldGhvZCBpbiBGcmFtZVZpZXcgdXNlZCB0byBjaGFuZ2UgdGhlIHNjcm9sbGJh cnMgc3RhdGUsIAorICAgICAgICBmaXggdGhlIGlmcmFtZSdzIHNjcm9sbGluZyBhdHRyaWJ1dGUg YmVoYXZpb3IgYWZ0ZXIgdGhlIGlmcmFtZQorICAgICAgICBpcyBhdHRhY2hlZC4KKworICAgICAg ICAqIGh0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TEZyYW1lRWxlbWVudEJhc2U6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToKKyAgICAgICAgKiBwYWdl L0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmNoYW5nZVNjcm9s bGJhcnNTdGF0ZSk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKwogMjAwOS0wMi0yNiAg U3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50 QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNl LmNwcAkocmV2aXNpb24gNDEyNzYpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJh c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQsNyArMTM0LDEzIEBAIHZvaWQgSFRNTEZyYW1l RWxlbWVudEJhc2U6OnBhcnNlTWFwcGVkQXQKICAgICAgICAgICAgIG1fc2Nyb2xsaW5nID0gZG9j dW1lbnQoKS0+ZnJhbWVFbGVtZW50c1Nob3VsZElnbm9yZVNjcm9sbGluZygpID8gU2Nyb2xsYmFy QWx3YXlzT2ZmIDogU2Nyb2xsYmFyQXV0bzsKICAgICAgICAgZWxzZSBpZiAoZXF1YWxJZ25vcmlu Z0Nhc2UoYXR0ci0+dmFsdWUoKSwgIm5vIikpCiAgICAgICAgICAgICBtX3Njcm9sbGluZyA9IFNj cm9sbGJhckFsd2F5c09mZjsKLSAgICAgICAgLy8gRklYTUU6IElmIHdlIGFyZSBhbHJlYWR5IGF0 dGFjaGVkLCB0aGlzIGhhcyBubyBlZmZlY3QuCisKKyAgICAgICAgaWYgKGF0dGFjaGVkKCkpIHsK KyAgICAgICAgICAgIGlmIChjb250ZW50RnJhbWUoKSAmJiBjb250ZW50RnJhbWUoKS0+dmlldygp KSB7CisgICAgICAgICAgICAgICAgRnJhbWVWaWV3KiB2aWV3ID0gY29udGVudEZyYW1lKCktPnZp ZXcoKTsKKyAgICAgICAgICAgICAgICB2aWV3LT5jaGFuZ2VTY3JvbGxiYXJzU3RhdGUobV9zY3Jv bGxpbmcgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQog ICAgIH0gZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IHZpZXdzb3VyY2VBdHRyKSB7CiAgICAgICAg IG1fdmlld1NvdXJjZSA9ICFhdHRyLT5pc051bGwoKTsKICAgICAgICAgaWYgKGNvbnRlbnRGcmFt ZSgpKQpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDQxMjc2KQorKysgV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMjksNCArMTMyOSwxNyBAQCB2b2lk IEZyYW1lVmlldzo6YWRqdXN0UGFnZUhlaWdodChmbG9hdCAqCiAgICAgICAgICpuZXdCb3R0b20g PSBvbGRCb3R0b207CiB9CiAKK3ZvaWQgRnJhbWVWaWV3OjpjaGFuZ2VTY3JvbGxiYXJzU3RhdGUo Ym9vbCBzdGF0ZSkKK3sKKyAgICBpZiAoc3RhdGUpIHsKKyAgICAgICAgbV9obW9kZSA9IFNjcm9s bGJhckF1dG87CisgICAgICAgIG1fdm1vZGUgPSBTY3JvbGxiYXJBdXRvOworICAgIH0gZWxzZSB7 CisgICAgICAgIG1faG1vZGUgPSBTY3JvbGxiYXJBbHdheXNPZmY7CisgICAgICAgIG1fdm1vZGUg PSBTY3JvbGxiYXJBbHdheXNPZmY7CisgICAgfQorICAgIHNldENhbkhhdmVTY3JvbGxiYXJzKHN0 YXRlKTsKKyAgICBzZXROZWVkc0xheW91dCgpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5oCShyZXZpc2lvbiA0MTI3NikKKysrIFdlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuaAkod29ya2luZyBjb3B5KQpAQCAtMTg0LDYgKzE4NCw3IEBAIHB1YmxpYzoKIAogICAgIHZv aWQgYWRqdXN0UGFnZUhlaWdodChmbG9hdCogbmV3Qm90dG9tLCBmbG9hdCBvbGRUb3AsIGZsb2F0 IG9sZEJvdHRvbSwgZmxvYXQgYm90dG9tTGltaXQpOwogCisgICAgdm9pZCBjaGFuZ2VTY3JvbGxi YXJzU3RhdGUoYm9vbCBzdGF0ZSk7CiAKIHByaXZhdGU6CiAgICAgdm9pZCByZXNldCgpOwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gNDEyNzYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMi0yNiAgQm8gWWFuZyAgPHRlY2hyYXp5Lnlh bmdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDA3MAorICAg ICAgICBUZXN0IGNhc2UgZm9yIHRoZSBpZnJhbWUgc2Nyb2xsaW5nIGF0dHJpYnV0ZS4KKworICAg ICAgICAqIGZhc3QvZnJhbWVzL2lmcmFtZS1qcy1zY3JvbGxpbmctYXR0cmlidXRlLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvaWZyYW1lLWpzLXNjcm9sbGluZy1h dHRyaWJ1dGUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2lm cmFtZS1qcy1zY3JvbGxpbmctYXR0cmlidXRlLXN1YmZyYW1lLmh0bWw6IEFkZGVkLgorCiAyMDA5 LTAyLTI2ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBHZW9mZiBHYXJlbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2lmcmFt ZS1qcy1zY3JvbGxpbmctYXR0cmlidXRlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2ZyYW1lcy9pZnJhbWUtanMtc2Nyb2xsaW5nLWF0dHJpYnV0ZS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9pZnJhbWUtanMt c2Nyb2xsaW5nLWF0dHJpYnV0ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MyBAQAorQUxFUlQ6IFNjcm9sbGluZyBhdHRyaWJ1dGUgd29ya3MKKyAKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9mcmFtZXMvaWZyYW1lLWpzLXNjcm9sbGluZy1hdHRyaWJ1dGUuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9pZnJhbWUtanMtc2Nyb2xsaW5nLWF0 dHJpYnV0ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvaWZy YW1lLWpzLXNjcm9sbGluZy1hdHRyaWJ1dGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz OSBAQAorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT4gVGhlIHRlc3QgZmlsZSBmb3IgaWZyYW1lJ3Mg c2Nyb2xsaW5nIGNoYW5nZSAgPC90aXRsZT4KKzxzY3JpcHQ+CisgICAgZnVuY3Rpb24gc2hvdygp IHsKKyAgICAgICAgdmFyIGVsZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsK KyAgICAgICAgZWxlLnNldEF0dHJpYnV0ZSgic2Nyb2xsaW5nIiwgInllcyIpOworICAgIH0KKwor ICAgIGZ1bmN0aW9uIGhpZGUoKSB7CisgICAgICAgIHZhciBlbGUgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgidGFyZ2V0Iik7CisgICAgICAgIGVsZS5zZXRBdHRyaWJ1dGUoInNjcm9sbGluZyIs ICJubyIpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgICAgIHZhciBlbGUg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7CisgICAgICAgIGhpZGUoKTsKKyAg ICAgICAgdmFyIG5vc2Nyb2xsID0gZWxlLmNvbnRlbnRXaW5kb3cuZG9jdW1lbnQuYm9keS5jbGll bnRXaWR0aDsKKyAgICAgICAgc2hvdygpOworICAgICAgICB2YXIgc2Nyb2xsID0gZWxlLmNvbnRl bnRXaW5kb3cuZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aDsKKworICAgICAgICBhbGVydChub3Nj cm9sbCA+IHNjcm9sbCA/ICJTY3JvbGxpbmcgYXR0cmlidXRlIHdvcmtzIiA6ICJTY3JvbGxpbmcg YXR0cmlidXRlIGRvZXMgbm90IHdvcmsiKTsKKyAgICB9CisKKyAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQoKTsKKworICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIHRlc3QpOwor ICAgIH0KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8aW5wdXQgdHlwZT0iYnV0dG9uIiB2 YWx1ZT0iU2hvdyBTY3JvbGxiYXJzIiBvbmNsaWNrPSJzaG93KCk7Ii8+Cis8aW5wdXQgdHlwZT0i YnV0dG9uIiB2YWx1ZT0iSGlkZSBTY3JvbGxiYXJzIiBvbmNsaWNrPSJoaWRlKCk7Ii8+Cis8ZGl2 PgorPGlmcmFtZSBpZD0idGFyZ2V0IiBzcmM9InJlc291cmNlcy9pZnJhbWUtanMtc2Nyb2xsaW5n LWF0dHJpYnV0ZS1zdWJmcmFtZS5odG1sIj48L2lmcmFtZT4KKzwvZGl2PgorPC9ib2R5PgorPC9o dG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2lmcmFtZS1qcy1z Y3JvbGxpbmctYXR0cmlidXRlLXN1YmZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2lmcmFtZS1qcy1zY3JvbGxpbmctYXR0cmlidXRlLXN1 YmZyYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNv dXJjZXMvaWZyYW1lLWpzLXNjcm9sbGluZy1hdHRyaWJ1dGUtc3ViZnJhbWUuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw1IEBACis8aHRtbD4KKzxib2R5IHN0eWxlPSJ3aWR0aDogODAwcHg7 IGhlaWdodDogNjAwcHg7Ij4KK05vdGhpbmcuLi4KKzwvYm9keT4KKzwvaHRtbD4K 461752 2022-08-19 21:14:58 -0700 2022-08-19 21:14:58 -0700 Reduction change-scrolling-attribute.html text/html 297 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KICAgIAo8aW5wdXQgdHlwZT0iYnV0dG9uIiB2 YWx1ZT0iU2hvdyBzY3JvbGxiYXJzIiBvbmNsaWNrPSJkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFn TmFtZSgnaWZyYW1lJylbMF0uc2V0QXR0cmlidXRlKCdzY3JvbGxpbmcnLCAneWVzJyk7IiAvPgoK PGlmcmFtZSBzcmNkb2M9IgogICAgPHN0eWxlPiBib2R5IHsgaGVpZ2h0OiAyMDAwcHg7IH08L3N0 eWxlPgogICAgPGJvZHk+aGkgdGhlcmU8L2JvZHk+CiAgICAiIHNjcm9sbGluZz0ibm8iPgo8L2Jv ZHk+CjwvaHRtbD4K