240677 2022-05-19 11:32:48 -0700 Need to keep the document alive in KeyframeEffect::processKeyframes() 2022-05-19 12:48:45 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts darin dino graouts saam webkit-bug-importer oldest_to_newest 1870479 0 graouts 2022-05-19 11:32:48 -0700 Since we use the provided Document in KeyframeEffect::processKeyframes() and it's just a reference, we should ensure it's kept alive while this method is called. 1870480 1 graouts 2022-05-19 11:33:04 -0700 rdar://93513759 1870485 2 graouts 2022-05-19 11:41:15 -0700 Pull request: https://github.com/WebKit/WebKit/pull/796 1870487 3 graouts 2022-05-19 11:42:53 -0700 Landed https://commits.webkit.org/250756@main (r294497)! 1870506 4 darin 2022-05-19 12:48:45 -0700 We are really going to have to discuss this as a team. Our overall strategy was supposed to be that callers have to ref/deref things, not that functions must protect the things they are passed. So the caller is supposed to ref/deref the document, not the processKeyframes function. But maybe that strategy is impractical, since even a Node's document is not ref'd if the Node is moved to another document? If we do need to "protect" things then we need a discipline for knowing when it’s needed.